A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily for staging.
This reformats code to a more CodingStyle conforming style,
compiles it, verifies that the object code hasn't changed,
and git commits it too.
You must have the necessary develo
x/lnet/api.h has no obvious style problems
> and is ready for submission.
[]
> Is that expected?
No, I haven't seen that.
Can you tell me what git tree you're working on?
Also, can you use the scripts/checkpatch from -next
tag next-20140711
My system has:
$ perl --version
This is
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Friday, July 11, 2014 5:54 AM
> To: h...@infradead.org
> Cc: James Bottomley; KY Srinivasan; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; a...@canonical.com; sta...@vger.kernel.org
> -Original Message-
> From: h...@infradead.org [mailto:h...@infradead.org]
> Sent: Thursday, July 10, 2014 11:32 PM
> To: James Bottomley
> Cc: KY Srinivasan; linux-ker...@vger.kernel.org; m...@mkp.net;
> h...@infradead.org; de...@linuxdriverproject.org; a...@canonical.com;
> sta...@vger
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote:
> On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
> > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > > A simple script to run checkpatch --fix for various types of
> > > of cleanups.
> > >
> > > This script is useful
There's a useless "+" use that needs to be removed as perl 5.20
emits a "Useless use of greediness modifier '+'" message each
time it's hit.
Reported-by: Greg KH
Signed-off-by: Joe Perches
---
On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote:
> Ok, with linux-next I get the same thing:
Thanks G
On Fri, Jul 11, 2014 at 07:09:30PM -0700, Joe Perches wrote:
> There's a useless "+" use that needs to be removed as perl 5.20
> emits a "Useless use of greediness modifier '+'" message each
> time it's hit.
>
> Reported-by: Greg KH
> Signed-off-by: Joe Perches
> ---
> On Fri, 2014-07-11 at 19:0
On Fri, 2014-07-11 at 18:53 -0700, Greg KH wrote:
> On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > A simple script to run checkpatch --fix for various types of
> > of cleanups.
[]
> Anyway, try running this script on
> drivers/staging/lustre/lnet/lnet/acceptor.c to see how this bu
On Fri, Jul 11, 2014 at 06:57:24PM -0700, Joe Perches wrote:
> On Fri, 2014-07-11 at 18:53 -0700, Greg KH wrote:
> > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > > A simple script to run checkpatch --fix for various types of
> > > of cleanups.
> []
> > Anyway, try running this s
On Fri, 2014-07-11 at 18:43 -0700, Greg KH wrote:
> On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > A simple script to run checkpatch --fix for various types of
> > of cleanups.
[]
> If I pick drivers/staging/lustre/include/linux/lnet/types.h, then I get:
>
> staging: lnet:
eady for submission.
> > []
> > > Is that expected?
> >
> > No, I haven't seen that.
> >
> > Can you tell me what git tree you're working on?
>
> My staging-next branch of staging.git on git.kernel.org
>
> > Also, can you u
On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
> On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > A simple script to run checkpatch --fix for various types of
> > of cleanups.
> >
> > This script is useful primarily for staging.
> >
> > This reformats code to a more CodingStyle
what git tree you're working on?
My staging-next branch of staging.git on git.kernel.org
> Also, can you use the scripts/checkpatch from -next
> tag next-20140711
that will take a bit to checkout, I'll do that afterward.
> My system has:
>
> $ perl --version
>
> This i
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> A simple script to run checkpatch --fix for various types of
> of cleanups.
>
> This script is useful primarily for staging.
>
> This reformats code to a more CodingStyle conforming style,
> compiles it, verifies that the object code
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> A simple script to run checkpatch --fix for various types of
> of cleanups.
>
> This script is useful primarily for staging.
>
> This reformats code to a more CodingStyle conforming style,
> compiles it, verifies that the object code
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> A simple script to run checkpatch --fix for various types of
> of cleanups.
>
> This script is useful primarily for staging.
>
> This reformats code to a more CodingStyle conforming style,
> compiles it, verifies that the object code
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> A simple script to run checkpatch --fix for various types of
> of cleanups.
>
> This script is useful primarily for staging.
>
> This reformats code to a more CodingStyle conforming style,
> compiles it, verifies that the object code
On Fri, Jul 11, 2014 at 03:39:48PM +0100, Ian Abbott wrote:
> On 2014-07-11 15:38, Ian Abbott wrote:
> >From: Andrey Utkin
> >
> >From: Andrey Utkin
>
> Dammit! Greg, do you want to sort that out or should I have another go?
Heh, no worries, I can fix it up, thanks.
greg k-h
_
On Fri, Jul 11, 2014 at 07:11:45PM -0400, Erik Arfvidson wrote:
> This patch adds the virtpci debugfs directory and the info entry
> inside of it.
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> v3: Fixed formating and comments. Also added debufs_remove_recursive() and
This patch adds the virtpci debugfs directory and the info entry
inside of it.
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
v3: Fixed formating and comments. Also added debufs_remove_recursive() and
simple simple_read_from_buffer()
v2: fixed comments and applied Dan Carpen
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Thursday, July 10, 2014 3:19 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
On Fri, Jul 11, 2014 at 08:54:01PM +0300, Andrey Utkin wrote:
> 2014-07-11 17:38 GMT+03:00 Ian Abbott :
> > Signed-off-by: Andrey Utkin
>
> I think it's incorrect that you have instantly placed my signoff
> statement on this new patch.
Ian gave you credit but also wrote in the changelog that he
2014-07-11 17:38 GMT+03:00 Ian Abbott :
> Signed-off-by: Andrey Utkin
I think it's incorrect that you have instantly placed my signoff
statement on this new patch.
Anyway, thanks for your work on the issue.
--
Andrey Utkin
___
devel mailing list
de...
On Fri, Jul 11, 2014 at 06:06:36PM +0100, Ian Abbott wrote:
> On 2014-07-11 16:34, Dan Carpenter wrote:
> >On Fri, Jul 11, 2014 at 03:38:30PM +0100, Ian Abbott wrote:
> >>From: Andrey Utkin
> >>
> >>From: Andrey Utkin
> >>
> >>The issue was discovered with static analysis and has two instances in
On 2014-07-11 16:34, Dan Carpenter wrote:
On Fri, Jul 11, 2014 at 03:38:30PM +0100, Ian Abbott wrote:
From: Andrey Utkin
From: Andrey Utkin
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x < 65536000) {
...
} else if (x
> -Original Message-
> From: Sitsofe Wheeler [mailto:sits...@gmail.com]
> Sent: Friday, July 11, 2014 1:53 AM
> To: Haiyang Zhang
> Cc: KY Srinivasan; David S. Miller; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org; net...@vger.kernel.org
> Subject: Re: [BISECTED][REGRESSIO
2014-07-12 0:37 GMT+09:00, Dan Carpenter :
> On Sat, Jul 12, 2014 at 12:23:16AM +0900, DaeSeok Youn wrote:
>> Can I modify the MAINTAINERS file for adding myself?
>
> Yes. Just send a patch to add yourself.
OK. I will.
Thanks.
Regards,
Daeseok Youn.
>
> git log -p MAINTAINERS
>
> regards,
> dan
On Sat, Jul 12, 2014 at 12:23:16AM +0900, DaeSeok Youn wrote:
> Can I modify the MAINTAINERS file for adding myself?
Yes. Just send a patch to add yourself.
git log -p MAINTAINERS
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject
On Fri, Jul 11, 2014 at 03:38:30PM +0100, Ian Abbott wrote:
> From: Andrey Utkin
>
> From: Andrey Utkin
>
> The issue was discovered with static analysis and has two instances in
> this file. The code looks like this
> if (x < 65536000) {
> ...
> } else if (x < 65536) {
> ...
>
Hi, Dan
2014-07-11 22:20 GMT+09:00, Dan Carpenter :
> Looks good to me. You should be CC'ing Mark as well. He's in
> MAINTAINERS now.
I'd added Mark to cc list. All of maintainers including open mailing
lists from get_maintainer.pl were added in my patches. :-)
>
> I wish the two of you would C
On Fri, Jul 11, 2014 at 04:44:32PM +0200, Luca Ellero wrote:
> Il 11/07/2014 16:17, Dan Carpenter ha scritto:
> >You have a lot of patches with the exact same subject. Use different
> >subjects like:
> >
> >[patch] staging: ced1401: ced_ioc.c: change spaces to tabs
> >
> >or whatever.
> >
> >regar
Fix checkpatch warnings "Missing a blank line after declarations" in file
usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index
Fix checkpatch warning "suspect code indent for conditional statements" in file
usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401
Fix checkpatch warnings "Missing a blank line after declarations" in file
ced_ioc.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/ced1401/ced_
Fix checkpatch warnings "quoted string split across lines" in file usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced140
Fix checkpatch warning "please, no space before tabs" in file
ced_ioc.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/ced1401/ced_ioc.c
index 397df43..a4
This patchset renames all camel case and Hungarian notation
names in ced1401. It fixes as well some checkpatch warnings
and errors.
I've not modified any logic in the driver.
Please note that I've tryed to not add any checkpatch warning/error.
If some patches give warnings or errors they were prese
Rename camel case variable dwCount in function ced_writechar_callback
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index
Fix checkpatch warnings "line over 80 characters" in file usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 168 +++--
1 file changed, 105 insertions(+), 63 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging
Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_set_event()
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/
Fix checkpatch errors "code indent should use tabs where possible" in file
usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb140
Fix checkpatch warnings "line over 80 characters" in file ced_ioc.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 66 +++--
1 file changed, 42 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/
Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_wait_event()
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 65 +++--
1 file changed, 33 insertions(+), 32 deletions(-)
diff --git
Fix checkpatch error "foo * bar" should be "foo *bar" in file usb1401.h
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.h
b/drivers/staging/ced1401/usb1401.h
index 8e800c3..da
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, July 11, 2014 2:53 AM
> To: KY Srinivasan; Christoph Hellwig
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canon
Il 11/07/2014 16:17, Dan Carpenter ha scritto:
You have a lot of patches with the exact same subject. Use different
subjects like:
[patch] staging: ced1401: ced_ioc.c: change spaces to tabs
or whatever.
regards,
dan carpeneter
Hi Dan,
OK, I'll resend
regards
Luca Ellero
_
On 2014-07-11 15:38, Ian Abbott wrote:
From: Andrey Utkin
From: Andrey Utkin
Dammit! Greg, do you want to sort that out or should I have another go?
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_
From: Andrey Utkin
From: Andrey Utkin
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x < 65536000) {
...
} else if (x < 65536) {
...
} else if (x <= 0x /* 655360 */) {
...
} else if (x <= 0xf
On 2014-07-11 15:32, Ian Abbott wrote:
From: Andrey Utkin
drivers/staging/comedi/drivers/ni_atmio16d.c: remove pointless condition
Sorry, I messed up the subject line. Let me try that again!
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 7
From: Andrey Utkin
drivers/staging/comedi/drivers/ni_atmio16d.c: remove pointless condition
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x < 65536000) {
...
} else if (x < 65536) {
...
} else if (x <= 0xfff
You have a lot of patches with the exact same subject. Use different
subjects like:
[patch] staging: ced1401: ced_ioc.c: change spaces to tabs
or whatever.
regards,
dan carpeneter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.l
Hi!
On Fre, 2014-07-11 at 15:30 +0300, Andrey Utkin wrote:
[...]
> Could you please substantiate this? I see that convert_arg has type
> "unsigned int" which may be 8 bytes on 64-bit platform. I haven't
At least in the x86_64 world, "unsigned int" has 32bit.
TTBOMK, it is similar on all other 64b
Some of these functions aren't called and can just be deleted.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Jul 11, 2014 at 08:00:57AM -0500, Romer, Benjamin M wrote:
> On Thu, 2014-07-10 at 07:51 -0700, Greg KH wrote:
> > On Thu, Jul 10, 2014 at 10:34:14AM -0400, Erik Arfvidson wrote:
> > > This patch adds the virtpci debugfs directory and the info entry
> > > inside of it.
> > >
> > > Signed-o
Looks good to me. You should be CC'ing Mark as well. He's in
MAINTAINERS now.
I wish the two of you would CC each other and review each other's work.
Daeseok, add yourself to the MAINTAINERS file for this driver as well so
everyone CC's you on their dgap patches. You're doing good work.
regar
On Fri, Jul 11, 2014 at 03:30:15PM +0300, Andrey Utkin wrote:
> 2014-07-11 15:01 GMT+03:00 Ian Abbott :
> > On 2014-07-11 11:13, Andrey Utkin wrote:
> >>
> >> The issue was discovered with static analysis and has two instances in
> >> this file. The code looks like this
> >> if (x < 65536000) {
> >
On Thu, 2014-07-10 at 07:51 -0700, Greg KH wrote:
> On Thu, Jul 10, 2014 at 10:34:14AM -0400, Erik Arfvidson wrote:
> > This patch adds the virtpci debugfs directory and the info entry
> > inside of it.
> >
> > Signed-off-by: Erik Arfvidson
> > Signed-off-by: Benjamin Romer
>
> 2/2? Where is p
> "hch" == hch@infradead org writes:
(Back from vacation: Bear with me while I'm catching up on two weeks of
linux-scsi stuff...)
hch> I think the problem is a differnet one. If we have the logical
hch> provisioning EVPD it configures what method to use, but if we don't
hch> have one we sim
2014-07-11 15:01 GMT+03:00 Ian Abbott :
> On 2014-07-11 11:13, Andrey Utkin wrote:
>>
>> The issue was discovered with static analysis and has two instances in
>> this file. The code looks like this
>> if (x < 65536000) {
>> ...
>> } else if (x < 65536) {
>> ...
>> } else if (x
On 2014-07-11 11:13, Andrey Utkin wrote:
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x < 65536000) {
...
} else if (x < 65536) {
...
} else if (x <= 0x /* 655360 */) {
...
} else if (x <= 0x
Null checks in dgap_tty_digigetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 23 +--
1 files changed, 5 insertions(+), 18 deletions(-)
diff -
Null checks in dgap_tty_digisetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 29 +
1 files changed, 5 insertions(+), 24 deletions
On 2014-07-11 05:00, Chase Southwood wrote:
This is a small patchset containing a handful of fixes to the ADDI-DATA
APCI1564 driver that I would like to get out of the way before I forget
to take care of them. From here, I will move to start fixing the
digital input/timer/counters/watchdog funct
Fix checkpatch error "foo * bar" should be "foo *bar" in file usb1401.h
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.h
b/drivers/staging/ced1401/usb1401.h
index 8e800c3..da
Null checks in dgap_tty_digisetedelay() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 26 +-
1 files changed, 5 insertions(+), 21 deletions(-)
di
Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_set_event()
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/
Fix checkpatch warnings "quoted string split across lines" in file usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced140
Rename camel case variable dwCount in function ced_writechar_callback
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index
Fix checkpatch warnings "Missing a blank line after declarations" in file
usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index
Fix checkpatch warnings "Missing a blank line after declarations" in file
ced_ioc.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/ced1401/ced_
Fix checkpatch errors "code indent should use tabs where possible" in file
usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb140
Fix checkpatch warnings "line over 80 characters" in file usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c | 168 +++--
1 file changed, 105 insertions(+), 63 deletions(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging
Null checks in dgap_set_modem_info() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd" and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 36
1 files changed, 8 insertions(+), 28 deletion
This patchset renames all camel case and Hungarian notation
names in ced1401. It fixes as well some checkpatch warnings
and errors.
I've not modified any logic in the driver.
Please note that I've tryed to not add any checkpatch warning/error.
If some patches give warnings or errors they were prese
Fix checkpatch warnings "line over 80 characters" in file ced_ioc.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 66 +++--
1 file changed, 42 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/
Fix checkpatch warning "please, no space before tabs" in file
ced_ioc.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/ced1401/ced_ioc.c
index 397df43..a4
Null checks in dgap_tty_digigeta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 23 +--
1 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/dr
Fix checkpatch warning "suspect code indent for conditional statements" in file
usb1401.c
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/usb1401.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401
Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_wait_event()
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 65 +++--
1 file changed, 33 insertions(+), 32 deletions(-)
diff --git
Null checks in dgap_tty_digiseta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "bd" which are used in dgap_tty_digiseta().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 28 +---
1 files changed, 5 inse
The "ts" is not used in dgap_param().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 79ea116..ad7b462 100644
--- a/drivers/staging/dgap/dgap.c
+
The dgap_param() has a paramter which is tty_struct and
use variables in that struct. That variables which are "ch", "bd", "bs"
and "un" do not need to check NULL so these statements are removed.
And also change the parameter of this function because
it is possible to let someone know what paramte
The "ch" is already checking in caller.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 9affc5b..79ea116 100644
--- a/drivers/staging/dgap/dgap.c
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x < 65536000) {
...
} else if (x < 65536) {
...
} else if (x <= 0x /* 655360 */) {
...
} else if (x <= 0x /* 6553600 */) {
...
}
On 11/07/2014 00:12, Greg KH wrote:
On Thu, Jul 10, 2014 at 11:04:15AM +0200, Luca Ellero wrote:
Signed-off-by: Luca Ellero
---
drivers/staging/ced1401/ced_ioc.c | 212 +++--
1 file changed, 131 insertions(+), 81 deletions(-)
That's a lot of changes all in
On Fri, Jul 11, 2014 at 11:52:55AM +0200, Hannes Reinecke wrote:
> Something like this should be sufficient:
Right. That plus a detailed comment explaining why it's there..
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriver
On 07/11/2014 12:26 AM, KY Srinivasan wrote:
-Original Message-
From: Christoph Hellwig [mailto:h...@infradead.org]
Sent: Thursday, July 10, 2014 3:13 AM
To: KY Srinivasan
Cc: Christoph Hellwig; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; oher...@suse.com;
jbottom...@pa
On Wed, Jul 09, 2014 at 11:59:14, Greg Kroah-Hartman wrote:
> On Tue, Jul 01, 2014 at 02:33:43PM +0200, Davide Gianforte wrote:
> > + uint32_t ctrl_ext = BPCTL_READ_REG(pbpctl_dev, CTRL_EXT);
> >
> > - ctrl_ext = BPCTL_READ_REG(pbpctl_dev, CTRL_EXT);
>
> How about just removing the " = 0;" p
88 matches
Mail list logo
