From: Anil Belur
- this patch removes IRQF_DISABLED macro, as this is
deprecated/noop.
Signed-off-by: Anil Belur
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/stag
From: Anil Belur
- this patch removes the IRQF_DISABLED macro, as this is
deprecated/noop.
Signed-off-by: Anil Belur
---
drivers/staging/nokia_h4p/nokia_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nokia_h4p/nokia_core.c
b/drivers/staging/nokia_
From: sanjeev sharma
This is a patch to the r819xU_phy.c file that remove unnecessary whitespace
and tabs reported by checkpatch.pl script.
Signed-off-by: Sanjeev Sharma
---
drivers/staging/rtl8192u/r819xU_phy.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
From: sanjeev sharma
This is a patch to the r819xU_phy.c file that will fix too long lines warning
reported by checkpatch.pl .
Signed-off-by: Sanjeev Sharma
---
drivers/staging/rtl8192u/r819xU_phy.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
From: sanjeev sharma
This is a patch to the r819xU_phy.c file that remove unneeded return statements
in code.
Signed-off-by: Sanjeev Sharma
---
Changes in v2:
- Remove useless return statement.
---
drivers/staging/rtl8192u/r819xU_phy.c | 13 -
1 file changed, 13 deletions(-)
di
From: sanjeev sharma
I have come up with seperate patch as per Dan comment.
sanjeev sharma (4):
staging: rtl8192u: Remove useless return statement in r819xU_phy.c
staging: rtl8192u: Removed unnecessary whitespace & tab warning in
r819xU_phy.c
staging: rtl8192u: Fixed switch and case i
From: sanjeev sharma
This is a patch to the r819xU_phy.c file that will fix switch and case
indentation Error reported by checkpatch script.
Signed-off-by: Sanjeev Sharma
---
drivers/staging/rtl8192u/r819xU_phy.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
On Tue, Jul 08, 2014 at 06:48:18PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 16:45 -0700, Greg KH wrote:
> > On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote:
> > > Use print_hex_dump_bytes to have memory properly dumped only when
> > > DEBUG is defined.
> []
> > > diff --git a/
On Tue, 2014-07-08 at 16:45 -0700, Greg KH wrote:
> On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote:
> > Use print_hex_dump_bytes to have memory properly dumped only when
> > DEBUG is defined.
[]
> > diff --git a/drivers/staging/rts5208/trace.h
> > b/drivers/staging/rts5208/trace.h
[]
Added a check of the return value of the kobject_set_name function.
Signed-off-by: Anton Protopopov
---
drivers/staging/comedi/comedi_fops.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
in
On Wed, Jul 09, 2014 at 08:48:53AM +0400, Anton Protopopov wrote:
>
>
> 09.07.2014 08:28, gregkh пишет:
> > On Wed, Jul 09, 2014 at 08:24:06AM +0400, Anton Protopopov wrote:
> >> 2014-06-09 14:01 GMT+04:00 Ian Abbott :
> >>> On 2014-06-07 14:56, Anton Protopopov wrote:
>
> Added a check
09.07.2014 08:28, gregkh пишет:
> On Wed, Jul 09, 2014 at 08:24:06AM +0400, Anton Protopopov wrote:
>> 2014-06-09 14:01 GMT+04:00 Ian Abbott :
>>> On 2014-06-07 14:56, Anton Protopopov wrote:
Added a check of the return value of the kobject_set_name function.
Signed-off-by: An
On Wed, Jul 09, 2014 at 09:57:06AM +0530, Anil Shashikumar Belur wrote:
>
> On Wednesday 09 July 2014 05:21 AM, Greg KH wrote:
> > This change is already in my tree, what branch are you working
> > against? greg k-h
>
> Hi Greg,
>
> I am using staging.git. I try to make sure and rebase any chang
On Wed, Jul 09, 2014 at 08:24:06AM +0400, Anton Protopopov wrote:
> 2014-06-09 14:01 GMT+04:00 Ian Abbott :
> > On 2014-06-07 14:56, Anton Protopopov wrote:
> >>
> >> Added a check of the return value of the kobject_set_name function.
> >>
> >> Signed-off-by: Anton Protopopov
> >> ---
> >> drive
On Wednesday 09 July 2014 05:21 AM, Greg KH wrote:
> This change is already in my tree, what branch are you working
> against? greg k-h
Hi Greg,
I am using staging.git. I try to make sure and rebase any changes in my
branch with staging-next before sending out the patches. Not sure, if I
am miss
On Wednesday 09 July 2014 05:18 AM, Greg KH wrote:
> Someone sent this same patch just before you did, sorry :(
>
Ah - no worries - sorry for the noise.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/l
2014-06-09 14:01 GMT+04:00 Ian Abbott :
> On 2014-06-07 14:56, Anton Protopopov wrote:
>>
>> Added a check of the return value of the kobject_set_name function.
>>
>> Signed-off-by: Anton Protopopov
>> ---
>> drivers/staging/comedi/comedi_fops.c | 9 -
>> 1 file changed, 8 insertions(+)
On Wed, Jul 09, 2014 at 09:41:42AM +0800, 黄钦佳 wrote:
> OK, I will have another try.
> However I have a question. As I'm from China, should I use the name in
> my identity card or I can use my own English name which getting used
> to? Says, Qinjia Huang(ID card) or Kinka Huang?
Your "real" name ple
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM
panic because the notification work is done in a workqueue, and in panic() the
kernel typically ends up in an infinite loop, and a typical kernel config has
CONFIG_PREEMPT_VOLUNTARY=y and CONFIG_PREEMPT is not set, so a
> -Original Message-
> > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > > Sent: Tuesday, July 8, 2014 17:27 PM
> > > To: Dexuan Cui
> > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> driverdev-
> > > de...@linuxdriverproject.org; plagn...@jcrosoft.com;
> > >
OK, I will have another try.
However I have a question. As I'm from China, should I use the name in
my identity card or I can use my own English name which getting used
to? Says, Qinjia Huang(ID card) or Kinka Huang?
Thanks
2014-07-08 8:51 GMT+08:00 Greg Kroah-Hartman :
> Your subject has the info
On Wed, Jul 09, 2014 at 02:34:12AM +0200, Mario wrote:
> linux-next.git-v3.14-drivers-staging rtl8821ae "in conjunction with their"
>
> linux-firmware-4c7327a35767c2133600376380c867dff3cbaa1c-rtlwifi "
>
> It went wonderfully with uname-r (3.14.3-200.fc20.x86_64).
>
>
> Today, however, came upd
On Tue, Jul 01, 2014 at 12:30:22PM +0530, Anil Belur wrote:
> From: Anil Belur
>
> - this patch fixes jiffies comparision with a safer function to prevent
> any overflows
>
> Signed-off-by: Anil Belur
> ---
> drivers/staging/speakup/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR.
Correctly handle this.
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storv
Implement a simple abort handler. The host does not support "Abort"; just
ensure that all inflight I/Os have been accounted for.
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/drivers/s
Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the
Windows host require this.
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/sc
Hyper-V hosts can support multiple targets and multiple channels and larger
number of
LUNs per target. Update the code to reflect this. With this patch we can
correctly
enumerate all the paths in a multi-path storage environment.
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_dr
Going forward it is possible that some of the commands that are not currently
implemented will be implemented on future Windows hosts. Make command filtering
depend on the host version.
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c | 11 ---
1 files changed, 8 ins
SRB status can have additional information. Mask these out before processing
SRB status.
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index
Host does not handle WRITE_SAME_16; filter this command out. This patch
is required to handle large devices (greater than 2 TB disks).
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/storvsc
Based on the negotiated VMBUS protocol version, we adjust the size of the
storage
protocol messages. The two sizes we currently handle or pre-win8 and post-win8.
Win WS2012 R2, we are negotiating higher VMBUS protocol version than the win8
version. Make adjustments to correctly handle this.
Signe
In this patch set I have fixed a few bugs and implemented some enhancements.
K. Y. Srinivasan (8):
Drivers: scsi: storvsc: Change the limits to reflect the values on
the host
Drivers: scsi: storvsc: Filter commands based on the storage protocol
version
Drivers: scsi: storvsc: Fix a
Richard Weinberger :
> Am 09.07.2014 00:47, schrieb Francois Romieu:
[...]
> > What are you taking about ? netconsole does not need to receive.
>
> Isn't netconsole is only one user of netpoll ?
Out of tree users are irrelevant. See netpoll related comments in
cd6362befe4cc7bf589a5236d2a780af2d4
On Wed, Jul 02, 2014 at 04:23:55PM +0530, Anil Belur wrote:
> From: Anil Belur
>
> - this patch replaces sizeof(a)/sizeof(a[0]) with the ARRAY_SIZE macro
> to get the number of nidstrings (and netstrfns)
> - v2: also for netstrfns
>
> Signed-off-by: Anil Belur
Someone sent this same patch ju
On Tue, Jul 08, 2014 at 11:38:29PM +0200, Fabio Falzoi wrote:
> Use pr_debug macro to control tracing verbosity through dynamic debug
> facility.
For almost all of these, you should use dev_dbg() instead, as you have
access to a struct device (well, you should have, you might have to dig
for it..
On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote:
> Use print_hex_dump_bytes to have memory properly dumped only when
> DEBUG is defined.
>
> Signed-off-by: Fabio Falzoi
> ---
> drivers/staging/rts5208/ms.c| 4 ++--
> drivers/staging/rts5208/rtsx_chip.c | 4 ++--
> drivers/
On Fri, Jul 04, 2014 at 09:58:15PM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Greg Kroah-Hartman
> Cc: Daeseok Youn
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Fabian Frederick
> ---
> drivers/stagin
On Mon, Jun 30, 2014 at 03:56:11PM +0900, Daeseok Youn wrote:
> OS_phystov()/OS_vtophys() are replaced with
> phys_to_virt()/virt_to_phys().
>
> Signed-off-by: Daeseok Youn
> ---
> V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va().
>
> drivers/staging/cxt1e1/musycc.c |
On Thu, Jun 26, 2014 at 12:05:07PM -0700, H Hartley Sweeten wrote:
> According to the register programming manual, the filter interval
> register is 32-bit. Fix the writes to this register.
>
> Signed-off-by: H Hartley Sweeten
> Reviewed-by: Ian Abbott
> ---
> drivers/staging/comedi/drivers/ni_
On Fri, Jul 04, 2014 at 10:30:27PM +0200, Pawel Lebioda wrote:
> This patch fixes almost all 'missing blank line after declaration'
> warnings reported by checkpatch.pl for drivers/staging/bcm.
>
> Signed-off-by: Pawel Lebioda
> Reviewed-by: Matthias Beyer
This patch no longer applies due to ot
Am 09.07.2014 00:47, schrieb Francois Romieu:
> Richard Weinberger :
> [...]
>> This won't work as netpoll runs with IRQs disabled.
>> ->ndo_poll_controller() has to make sure that SKBs can be received and
>> transmitted
>> while IRQs are off. I thought calling the channel callback by hand would
On Mon, Jun 30, 2014 at 12:00:46PM +0200, Luca Ellero wrote:
> Signed-off-by: Luca Ellero
> ---
> drivers/staging/ced1401/ced_ioc.c | 21 -
> drivers/staging/ced1401/usb1401.c |9 ++---
> drivers/staging/ced1401/usb1401.h |6 +++---
> 3 files changed, 21 insertio
Richard Weinberger :
[...]
> This won't work as netpoll runs with IRQs disabled.
> ->ndo_poll_controller() has to make sure that SKBs can be received and
> transmitted
> while IRQs are off. I thought calling the channel callback by hand would be
> enough to receive SKBs.
What are you taking abou
Am 09.07.2014 00:47, schrieb Francois Romieu:
> Richard Weinberger :
> [...]
>> This won't work as netpoll runs with IRQs disabled.
>> ->ndo_poll_controller() has to make sure that SKBs can be received and
>> transmitted
>> while IRQs are off. I thought calling the channel callback by hand would
On Tue, Jul 01, 2014 at 12:06:59PM +0200, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Greg,
>
> Here is v2 of patch 08/10 "Sanitize USB read/write functions" it
> should fix the 'do not do DMA on the stack' issue with the original
> version. With this patch 09/10 is valid again.
>
>
On Mon, Jun 02, 2014 at 06:17:59PM +0530, Vinayak Menon wrote:
> An issue was observed when a userspace task exits.
> The page which hits error here is the zero page.
> In binder mmap, the whole of vma is not mapped.
> On a task crash, when debuggerd reads the binder regions,
> the unmapped areas f
On Tue, Jul 08, 2014 at 10:17:48PM +, Dexuan Cui wrote:
> > -Original Message-
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Tuesday, July 8, 2014 17:27 PM
> > To: Dexuan Cui
> > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> > de...@lin
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Tuesday, July 8, 2014 17:27 PM
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; plagn...@jcrosoft.com;
> tomi.valkei...@ti.com; lin
Fix an incorrect use of the %d format specifier in dev_err that caused a
warning.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 4f5f7a3..
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rts5208/
Use standard debug features instead of relying on the custom
configuration option CONFIG_RTS5208_DEBUG and a series of home grown
macros.
Changes in v3:
* defined rtsx_hex_dump as a static inline function to avoid checkpatch errors
Changes in v2:
* defined rtsx_hex_dump macro to produce output on
Use print_hex_dump_bytes to have memory properly dumped only when
DEBUG is defined.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 4 ++--
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
drivers/staging/rts5208/rtsx_scsi.c | 9 -
drivers/staging/rts5208/sd.c
Am 08.07.2014 22:03, schrieb KY Srinivasan:
> The VCPU the channel is bound to is available in the channel state. You could
> use the following code
> Fragment to ensure that the call is made on the "right" cpu:
>
> smp_call_function_single(dev->channel->target_cpu,
>
> -Original Message-
> From: Richard Weinberger [mailto:rich...@nod.at]
> Sent: Tuesday, July 8, 2014 11:39 AM
> To: KY Srinivasan; Haiyang Zhang
> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] hyperv: Add netpoll support
Hi,
Thanks for the comments and suggestions, I'll get them fixed and send it
in the
new patch.
Cheers,
Erik
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> -Original Message-
> From: Richard Weinberger [mailto:rich...@nod.at]
> Sent: Tuesday, July 8, 2014 2:40 PM
> To: Haiyang Zhang; KY Srinivasan
> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] hyperv: Add netpoll support
>
Hi Peter,
On 07/08/2014 09:36 AM, Greg KH wrote:
> On Tue, Jul 08, 2014 at 03:03:58PM +0200, Peter Meerwald wrote:
>> Hello,
>>
Given the total lack of response here, I suggest just deleting the
driver. No one has ever done the "real work" that is going to be
required to get this c
Am 08.07.2014 19:55, schrieb Haiyang Zhang:
>
>
>> -Original Message-
>> From: Richard Weinberger [mailto:rich...@nod.at]
>> Sent: Tuesday, July 8, 2014 5:32 AM
>> To: KY Srinivasan; Haiyang Zhang
>> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux-
>> ker...@vger.kernel.or
Am 08.07.2014 20:01, schrieb KY Srinivasan:
>
>
>> -Original Message-
>> From: Richard Weinberger [mailto:rich...@nod.at]
>> Sent: Tuesday, July 8, 2014 2:32 AM
>> To: KY Srinivasan; Haiyang Zhang
>> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux-
>> ker...@vger.kernel.or
> -Original Message-
> From: Richard Weinberger [mailto:rich...@nod.at]
> Sent: Tuesday, July 8, 2014 2:32 AM
> To: KY Srinivasan; Haiyang Zhang
> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Richard Weinberger
> Subject: [PATCH] hyperv: Add n
On Tue, Jul 08, 2014 at 01:21:31PM -0400, Erik Arfvidson wrote:
> This patch adds the virtpci debugfs directory and the info entry
> inside of it.
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/virtpci/virtpci.c | 122
>
> -Original Message-
> From: Richard Weinberger [mailto:rich...@nod.at]
> Sent: Tuesday, July 8, 2014 5:32 AM
> To: KY Srinivasan; Haiyang Zhang
> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Richard Weinberger
> Subject: [PATCH] hyperv: Add n
This patch adds the virtpci debugfs directory and the info entry
inside of it.
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virtpci/virtpci.c | 122 ++-
1 file changed, 118 insertions(+), 4 deletions(-)
diff --git a/drivers/
On Tue, Jul 08, 2014 at 01:21:31PM -0400, Erik Arfvidson wrote:
> -
> + /*debug_fs file and direcroty removal*/
> + debugfs_remove(info_debugfs_entry);
> + debugfs_remove(virtpci_debugfs_dir);
Odd indentation, comment style, and spelling typos :(
Also, you can just rem
This patch removes all proc entries from virtpci
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virtpci/virtpci.c | 309 +--
1 file changed, 1 insertion(+), 308 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.
On Tue, 2014-07-08 at 11:45 +0300, Dan Carpenter wrote:
> On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote:
> I'm gonna fix it, thanks.
> And leave out the semi-colon as well.
another way to do this is:
static void rtsx_hex_dump(void *buf, size_t len)
{
#if DEBUG
print_hex_dum
On Tue, 2014-07-08 at 11:24 +0300, Andy Shevchenko wrote:
> On Mon, 2014-07-07 at 09:50 -0700, Joe Perches wrote:
> > Perhaps better if -1 was accepted by string_escape_mem
> > as a strlen request or just ignored as a 0 length is
> > above.
>
> Would it be any benefit here?
Dunno, it was just a t
Hi Andrey,
Thanks for the patch!
On Tue, Jul 8, 2014 at 3:58 PM, Andrey Utkin
wrote:
> 2014-07-08 17:32 GMT+03:00 Levente Kurusa :
>> Hmm, while it is true that get_ipipe_mode returns an int, but
>> the consequent call to regw_ip takes an u32 as its second
>> argument. Did it cause a build warni
Previously, it was needed to reopen device to update GOP size and
quantization parameter. Now we update device registers with new values
immediately.
Signed-off-by: Andrey Utkin
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers
solo6*10 boards have configurable quantization parameter which takes
values from 0 to 31, inclusively.
This change enables setting it with ioctl VIDIOC_S_CTRL with id
V4L2_CID_MPEG_VIDEO_H264_MIN_QP.
Signed-off-by: Andrey Utkin
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 5 +
1
On Tue, Jul 08, 2014 at 05:30:33PM +0300, Andrey Utkin wrote:
> solo6*10 boards have configurable quantization parameter which takes
> values from 0 to 31, inclusively.
>
> This change enables setting it with ioctl VIDIOC_S_CTRL with id
> V4L2_CID_MPEG_VIDEO_H264_MIN_QP.
Both of these two need si
On Tue, Jul 08, 2014 at 04:32:57PM +0200, Levente Kurusa wrote:
> 2014-07-08 16:08 GMT+02:00 Andrey Utkin :
> > Use signed type to check correctly for negative error code. The issue
> > was reported with static analyser:
> >
> > [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]:
On Tue, Jul 08, 2014 at 04:54:59PM +0300, Andrey Utkin wrote:
> The issue is discovered by static checker. The proposed change (0x000c0
> -> 0x000c) is likely correct because:
> 1. 16-bit `map` holds value coming from struct
> ieee80211_vht_mcs_info.tx_mcs_map, which is described so: "TX MCS map 2
2014-07-08 17:32 GMT+03:00 Levente Kurusa :
> Hmm, while it is true that get_ipipe_mode returns an int, but
> the consequent call to regw_ip takes an u32 as its second
> argument. Did it cause a build warning for you? (Can't really
> check since I don't have ARM cross compilers close-by)
> If not,
Previously, it was needed to reopen device to update GOP size and
quantization parameter. Now we update device registers with new values
immediately.
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/solo6x10/solo6x
On Tue, Jul 08, 2014 at 03:03:58PM +0200, Peter Meerwald wrote:
> Hello,
>
> > > Given the total lack of response here, I suggest just deleting the
> > > driver. No one has ever done the "real work" that is going to be
> > > required to get this code out of staging. It has had build errors
> > >
solo6*10 boards have configurable quantization parameter which takes
values from 0 to 31, inclusively.
This change enables setting it with ioctl VIDIOC_S_CTRL with id
V4L2_CID_MPEG_VIDEO_H264_MIN_QP.
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 5 +
1 file changed, 5 insertions(+)
2014-07-08 16:08 GMT+02:00 Andrey Utkin :
> Use signed type to check correctly for negative error code. The issue
> was reported with static analyser:
>
> [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]:
> (style) A pointer can not be negative so it is either pointless or an
>
Use signed type to check correctly for negative error code. The issue
was reported with static analyser:
[linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]:
(style) A pointer can not be negative so it is either pointless or an
error to check if it is.
Bugzilla: https://bugzilla.
kmalloc() result check was lacking. Fixing that required also
changing card_send_command() return type from void to int, and
checking its return code everywhere.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78561
Reported-by: Maksymilian Arciemowicz
Signed-off-by: Andrey Utkin
---
driv
The issue is discovered by static checker. The proposed change (0x000c0
-> 0x000c) is likely correct because:
1. 16-bit `map` holds value coming from struct
ieee80211_vht_mcs_info.tx_mcs_map, which is described so: "TX MCS map 2
bits for each stream, total 8 streams". The changed code refers to cas
This patch adds support for the hmc5983 spi interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek
---
drivers/staging/iio/magnetometer/Kconfig
This patch adds support for the hmc5983 i2c interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek
---
drivers/staging/iio/magnetometer/Kconfig
Changed structure of struct hmc5843_chip_info to include length of translation
arrays. Code previously using #defined constant has been changed accordingly.
This allows to integrate devices which do have different amounts of available
rates/scales.
Signed-off-by: Josef Gajdusek
---
drivers/stagi
This patch splits hmc5843.c to multiple files - the interface-agnostic
hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is
another step to add support of SPI-enabled hmc5983.
Signed-off-by: Josef Gajdusek
---
drivers/staging/iio/magnetometer/Kconfig| 16 +-
dri
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek
---
drivers/staging/iio/magnetometer/Kconfig | 1 +
drivers/staging/iio/magnetometer/hmc5843.c | 140
This patch series modifies the hmc5843 driver to support the hmc5983 i2c and
spi interfaces.
Josef Gajdusek (5):
staging:iio:hmc5843: Added regmap support
staging:iio:hmc5843: Split hmc5843.c to multiple files
staging:iio:hmc5843: register <-> value arrays now can have different
lengths
On Tue, Jul 08, 2014 at 11:23:51AM +0300, Dan Carpenter wrote:
> When you compare the old and new versions of hmc5843_read_raw() then it
> appears there is a bug fix or something which hasn't been documentented
> in the changelog.
>
> > -static int hmc5843_read_raw(struct iio_dev *indio_dev,
> > -
Hello,
> > Given the total lack of response here, I suggest just deleting the
> > driver. No one has ever done the "real work" that is going to be
> > required to get this code out of staging. It has had build errors
> > causing it to not even be usable for some kernel versions with no one
> > n
On 29/06/14 19:42, Greg KH wrote:
> On Fri, Jun 20, 2014 at 07:05:17PM +0300, Kristina Martšenko wrote:
>> On 20/06/14 18:43, Kristina Martšenko wrote:
>>> Hi Omar,
>>>
>>> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
>>> nobody seems to have worked towards moving tidspb
On Tue, Jul 8, 2014 at 12:12 PM, Kristina Martšenko
wrote:
> On 06/07/14 21:12, Dmitry Torokhov wrote:
>> I was supposed to uprev the driver to the latest kernel and start
>> merging it, unfortunately last month and a half was quite a mess.
>> Hopefully now I should have more time since I can do
Hi,
Indeed -- I upgraded to sparse 0.5.0, and there's no need for this fix
anymore. I'll start keeping track of sparse's git repo from now on.
Dan -- Thanks for pointing this out.
Greg -- Please don't apply this patch.
Eli
On 08/07/14 14:36, Dan Carpenter wrote:
On Sat, Jul 05, 2014 at 1
On Sat, Jul 05, 2014 at 12:45:10PM +0300, Eli Billauer wrote:
> IS_ERR() expects a non-__iomem pointer.
This should be fixed in the latest versions of Sparse. Don't make the
code worse to work around bugs in the tools.
regards,
dan carpenter
___
devel
We're holding a spinlock here so we can't do sleeping allocations.
The call tree is:
rtw_sta_flush() <-- takes spin_lock_bh(&pstapriv->asoc_list_lock);
--> ap_free_sta()
--> rtw_clearstakey_cmd()
Originally these calls were rtw_zmalloc() and then we switched them to
kzalloc() in fadbe0cd
On Thu, Jun 26, 2014 at 04:42:11PM +0200, Matthias Beyer wrote:
> Hi,
>
> I have a question related to some patches I send in.
>
> (I send them to de...@driverdev.osuosl.org, but they show up in the
> archives of this list... so I'm asking here)
>
> I send 6 patch sets since the beginning of the
On Wed, Jun 25, 2014 at 11:25:33PM +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Quentin Lee
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c |4 +---
> 1 file changed, 1
On Tue, Jun 24, 2014 at 10:52:41PM -0400, James A Shackleford wrote:
> Signed-off-by: James A Shackleford
> ---
> drivers/staging/rtl8712/osdep_service.h |5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/osdep_service.h
> b/drivers/staging/rtl8712/osdep_ser
Hi Guillaume,
On Tue, 8 Jul 2014 00:31:32 +0200
Guillaume Clement wrote:
> This fixes several warnings in the nvec staging driver.
Pawel Lebioda already sent a patch series to fix these issues
a few days ago. From a first look, your patch series looks identical.
Thanks anyway for taking your t
On 06/07/14 21:12, Dmitry Torokhov wrote:
> On Sat, Jul 5, 2014 at 8:39 PM, Greg KH wrote:
>> On Sat, Jul 05, 2014 at 04:37:37PM +0100, Alan Cox wrote:
>>> On Fri, 2014-07-04 at 21:48 +0300, Kristina Martšenko wrote:
Hi,
I'm going over some "older" drivers in the staging tree and wa
On Tue, Jul 08, 2014 at 03:18:40PM +0530, sanjeev sharma wrote:
> Hi Dan,
>
>
> On Tue, Jul 8, 2014 at 1:13 PM, Dan Carpenter
> wrote:
>
> > On Tue, Jul 08, 2014 at 11:34:18AM +0530, sanjeev sharma wrote:
> > > From: sanjeevs1
> > ^
> > No.
> >
> > >
> > > This is a patch to th
1 - 100 of 112 matches
Mail list logo
