[PATCH] staging: gdm72xx: Use net_device_stats from struct net_device

2014-07-07 Thread Tobias Klauser
Instead of using an own copy of struct net_device_stats in struct nic, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev->stats, which is the default in dev_get_stats(). Signed-off-by: Tobias Klauser --- drivers/staging

[PATCH] staging: wlan-ng: Use net_device_stats from struct net_device

2014-07-07 Thread Tobias Klauser
Instead of using an own copy of struct net_device_stats in struct wlandevice, use stats from struct net_device. Also remove the thus unnecessary .ndo_get_stats function, as it would now just return netdev->stats, which is the default in dev_get_stats(). Furthermore, convert prefix increment of sta

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread Fabio Falzoi
> > Hi, > here exist some checkpatch errors. > > Best Regards. > micky. Yes, you'are right, I'm gonna fix it, thanks. On Tue, Jul 8, 2014 at 4:12 AM, micky wrote: > On 07/07/2014 03:10 PM, Fabio Falzoi wrote: >> >> Use print_hex_dump_bytes to have memory properly dumped only when >> DEBUG is def

Re: [PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err

2014-07-07 Thread Fabio Falzoi
Hi Micky, in the latest linux-tree sources, lun field in struct scsi_device from include/scsi/scsi_device.h is a u64: unsigned int id, channel; u64 lun; unsigned int manufacturer; so we get a compiler warning if we keep the %u specifier. Regards, Fabio On Tue, Jul 8, 20

[PATCH] staging: rtl8192u: fix checkpatch error/warning in r819xU_phy.c

2014-07-07 Thread sanjeev sharma
From: sanjeevs1 This is a patch to the r819xU_phy.c file that fixes up all the Error/Warning found by the checkpatch.pl tool Signed-off-by: Sanjeev Sharma --- drivers/staging/rtl8192u/r819xU_phy.c | 76 +-- 1 file changed, 36 insertions(+), 40 deletions(-) dif

Re: [PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err

2014-07-07 Thread micky
On 07/07/2014 03:10 PM, Fabio Falzoi wrote: Fix an incorrect use of the %d format specifier in dev_err that caused a warning. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread micky
On 07/07/2014 03:10 PM, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c |

Re: [GIT PULL] imx-drm update for component changes

2014-07-07 Thread Greg Kroah-Hartman
On Sat, Jul 05, 2014 at 10:55:24AM +0100, Russell King wrote: > Greg, > > Please incorporate the imx-drm update for component changes, which can > be found at: > > git://ftp.arm.linux.org.uk/~rmk/linux-arm.git component-for-staging > > with SHA1 9e5e2ffda320bacb761e4812e3ef7a7decd592a9. > > T

Re: [GIT PULL] component fix

2014-07-07 Thread Greg Kroah-Hartman
On Sat, Jul 05, 2014 at 10:51:02AM +0100, Russell King wrote: > Greg, > > Please incorporate a fix for the component helper, which can be found at: > > git://ftp.arm.linux.org.uk/~rmk/linux-arm.git component-for-driver > > with SHA1 b509cc802239a8b5ba7d1d2cc5adfb9d984b7ed8. > > This fixes a b

Re: [PATCH 1/1] staging: android: logger: fixes not useful "else" warnings This patch fixes WARNING: else is not generally useful after a break or return

2014-07-07 Thread Greg Kroah-Hartman
Your subject has the info that should be here in the body of the changelog entry. On Fri, Jul 04, 2014 at 12:09:23AM +0800, kinka wrote: > Signed-off-by: kinka I need a "real" name for any kernel submission, please read Documentation/SubmittingPatches for the details. also, someone just sent t

[PATCH] staging:nvec: Fix several coding style warnings

2014-07-07 Thread Guillaume Clement
This fixes several warnings in the nvec staging driver. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/5] staging:nvec: Fix "unnecessary else" coding style warning.

2014-07-07 Thread Guillaume Clement
The last else is unnessary as all the if statements end with a return. Signed-off-by: Guillaume Clément --- drivers/staging/nvec/nvec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 90f1c4d..8a3dd47 100644 --

[PATCH 4/5] staging:nvec: Add missing blank line after declarations.

2014-07-07 Thread Guillaume Clement
Signed-off-by: Guillaume Clément --- drivers/staging/nvec/nvec_power.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c index aacfcd6..6446e15 100644 --- a/drivers/staging/nvec/nvec_power.c +++ b/drivers/staging/nvec/nvec_p

[PATCH 5/5] staging:nvec: Add missing blank line after declarations.

2014-07-07 Thread Guillaume Clement
Signed-off-by: Guillaume Clément --- drivers/staging/nvec/nvec_ps2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c index 45b2f13..f56f1db 100644 --- a/drivers/staging/nvec/nvec_ps2.c +++ b/drivers/staging/nvec/nvec_ps2.c @@

[PATCH 2/5] staging:nvec: Remove unnessary out of memory message.

2014-07-07 Thread Guillaume Clement
Logging messages that show some type of "out of memory" error are generally unnecessary as there is a generic message and a stack dump done by the memory subsystem. Signed-off-by: Guillaume Clément --- drivers/staging/nvec/nvec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff -

[PATCH 3/5] staging:nvec: Add missing blank line after declarations.

2014-07-07 Thread Guillaume Clement
Signed-off-by: Guillaume Clément --- drivers/staging/nvec/nvec_paz00.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c index 934b796..e2e675a 100644 --- a/drivers/staging/nvec/nvec_paz00.c +++ b/drivers/staging/nvec/nvec_p

[PATCH 2/2] Drivers: hv: util: Fix a bug in the KVP code

2014-07-07 Thread K. Y. Srinivasan
Add code to poll the channel since we process only one message at a time and the host may not interrupt us. Also increase the receive buffer size since some KVP messages are close to 8K bytes in size. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/hv/hv_kvp.c | 17 ++--- drivers

[PATCH 1/2] Drivers: hv: vmbus: Fix a bug in the channel callback dispatch code

2014-07-07 Thread K. Y. Srinivasan
Starting with Win8, we have implemented several optimizations to improve the scalability and performance of the VMBUS transport between the Host and the Guest. Some of the non-performance critical services cannot leverage these optimization since they only read and process one message at a time. Ma

[PATCH 0/2] Drivers: hv

2014-07-07 Thread K. Y. Srinivasan
This patch set fixes a bug in the VMBUS driver that dispatches driver specific callback as well as a bug in the KVP code. K. Y. Srinivasan (2): Drivers: hv: vmbus: Fix a bug in the channel callback dispatch code Drivers: hv: util: Fix a bug in the KVP code drivers/hv/connection.c |8

[PATCH v2 5/5] staging:iio:hmc5843: Add support for spi hmc5983

2014-07-07 Thread Josef Gajdusek
This patch adds support for the hmc5983 spi interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig

[PATCH v2 4/5] staging:iio:hmc5843: Add support for i2c hmc5983

2014-07-07 Thread Josef Gajdusek
This patch adds support for the hmc5983 i2c interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig

[PATCH v2 3/5] staging:iio:hmc5843: register <-> value arrays now can have different lengths

2014-07-07 Thread Josef Gajdusek
Changed structure of struct hmc5843_chip_info to include length of translation arrays. Code previously using #defined constant has been changed accordingly. This allows to integrate devices which do have different amounts of available rates/scales. Signed-off-by: Josef Gajdusek --- drivers/stagi

[PATCH v2 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

2014-07-07 Thread Josef Gajdusek
This patch splits hmc5843.c to multiple files - the interface-agnostic hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is another step to add support of SPI-enabled hmc5983. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig| 16 +- dri

[PATCH v2 1/5] staging:iio:hmc5843: Added regmap support

2014-07-07 Thread Josef Gajdusek
This patch changes hmc5843.c to use regmap. This provides transparent caching to the code as well as abstraction necessary to add support for SPI-based hmc5983. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig | 1 + drivers/staging/iio/magnetometer/hmc5843.c | 139

[PATCH v2 0/5] staging:iio:hmc5843: Few adjustments and support for hmc5983

2014-07-07 Thread Josef Gajdusek
This patch series modifies the hmc5843 driver to support the hmc5983 i2c and spi interfaces. Josef Gajdusek (5): staging:iio:hmc5843: Added regmap support staging:iio:hmc5843: Split hmc5843.c to multiple files staging:iio:hmc5843: register <-> value arrays now can have different lengths

Re: [PATCH 1/5] staging:iio:hmc5843: Added regmap support

2014-07-07 Thread Peter Meerwald
> >> > This patch changes hmc5843.c to use regmap. This provides > >transparent caching > >> > to the code as well as abstraction necessary to add support for > >SPI-based > >> > hmc5983. > >> > > >> > Signed-off-by: Josef Gajdusek > >> Hi Josef, > >> > >> A few little bits and pieces inline. >

Re: [PATCH 1/5] staging:iio:hmc5843: Added regmap support

2014-07-07 Thread Josef Gajdusek
On Mon, Jul 07, 2014 at 06:00:29PM +0100, Jonathan Cameron wrote: > On 02/07/14 14:50, Josef Gajdusek wrote: > > This patch changes hmc5843.c to use regmap. This provides transparent > > caching > > to the code as well as abstraction necessary to add support for SPI-based > > hmc5983. > > > > Sign

[PATCH 12/13] staging: rtl8188eu: Remove unused functions rtw_cbuf_[full, empty, push, pop]()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |6 -- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 65 - 2 files changed, 71 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188

[PATCH 11/13] staging: rtl8188eu: Remove unused function rtw_cbuf_alloc()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |1 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 21 - 2 files changed, 22 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188e

[PATCH 10/13] staging: rtl8188eu: Use msecs_to_jiffies() instead of rtw_ms_to_systime()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 10 +- drivers/staging/rtl8188eu/include/osdep_service.h |1 - drivers/staging/rtl8188eu/os_dep/osdep_service.c |5 - 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH 13/13] staging: rtl8188eu: osdep_service.h: Remove unused struct rtw_cbuf

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index 3a620f8..fed9c86 100644 --- a/drivers/stagin

[PATCH 08/13] staging: rtl8188eu: rtw_efuse.c: Remove unused functions

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 60 - drivers/staging/rtl8188eu/include/rtw_efuse.h |2 - 2 files changed, 62 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_

[PATCH 07/13] staging: rtl8188eu: Remove unused function HalDetectPwrDownMode88E()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 19 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h |2 -- 2 files changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu

[PATCH 09/13] staging: rtl8188eu: use jiffies_to_msecs() instead of rtw_systime_to_ms()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |1 - drivers/staging/rtl8188eu/os_dep/osdep_service.c |7 +-- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188

[PATCH 05/13] staging: rtl8188eu: rtw_efuse.c : Remove unused functions

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 49 - drivers/staging/rtl8188eu/include/rtw_efuse.h |2 - 2 files changed, 51 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_

[PATCH 04/13] staging: rtl8188eu: Remove unused function efuse_GetMaxSize()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_efuse.c|7 --- drivers/staging/rtl8188eu/include/rtw_efuse.h |1 - 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c index 0e20d

[PATCH 06/13] staging: rtl8188eu: Remove unused functions rtw_efuse_map_[read, write]()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 113 - drivers/staging/rtl8188eu/include/rtw_efuse.h |2 - 2 files changed, 115 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw

[PATCH 02/13] staging: rtl8188eu: Remove function rtw_alloc_etherdev()

2014-07-07 Thread navin patidar
rtw_alloc_etherdev() is used in rtw_init_netdev() but never gets called because old_padapter is never NULL. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |1 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 +--- drivers/staging/rtl8188eu/os_dep

[PATCH 01/13] staging: rtl8188eu: Remove unused function rtw_change_ifname()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_ioctl_set.h |1 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 55 - 2 files changed, 56 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_ioctl_set.h b/drivers/staging/rtl8188e

[PATCH 03/13] staging: rtl8188eu: Remove unused function efuse_GetCurrentSize()

2014-07-07 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_efuse.c|9 - drivers/staging/rtl8188eu/include/rtw_efuse.h |1 - 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c index 82

Re: [BISECTED][REGRESSION] Loading Hyper-V network drivers is racy in 3.14+ on Hyper-V 2012 R2

2014-07-07 Thread Sitsofe Wheeler
On Mon, Jul 07, 2014 at 04:54:20PM +, Haiyang Zhang wrote: > > > -Original Message- > > From: Sitsofe Wheeler [mailto:sits...@gmail.com] > > Sent: Sunday, July 6, 2014 4:18 PM > > To: Haiyang Zhang > > Cc: KY Srinivasan; David S. Miller; de...@linuxdriverproject.org; linux- > > ker...@

Re: staging: rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()

2014-07-07 Thread navin patidar
On Mon, Jul 7, 2014 at 6:16 PM, Dan Carpenter wrote: > Hello navin patidar, > > The patch fadbe0cd5292: "staging: rtl8188eu:Remove rtw_zmalloc(), > wrapper for kzalloc()" from Jun 22, 2014, leads to the following > static checker warning: > > drivers/staging/rtl8188eu/core/rtw_cmd.c:1234 r

Re: [PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-07 Thread Joe Perches
On Mon, 2014-07-07 at 18:21 +0300, Andy Shevchenko wrote: > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > static noinline_for_stack > +char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec, > + const char *fmt) [] > + if (spec.field_width == 0) > +

RE: [BISECTED][REGRESSION] Loading Hyper-V network drivers is racy in 3.14+ on Hyper-V 2012 R2

2014-07-07 Thread Haiyang Zhang
> -Original Message- > From: Sitsofe Wheeler [mailto:sits...@gmail.com] > Sent: Sunday, July 6, 2014 4:18 PM > To: Haiyang Zhang > Cc: KY Srinivasan; David S. Miller; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org > Subject: [BISECTED][REGRESSION] Lo

Re: [PATCH 5/5] staging:iio:hmc5843: Add support for spi hmc5983

2014-07-07 Thread Jonathan Cameron
On 02/07/14 14:54, Josef Gajdusek wrote: This patch adds support for the hmc5983 spi interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek Someti

Re: [PATCH 4/5] staging:iio:hmc5843: Add support for i2c hmc5983

2014-07-07 Thread Jonathan Cameron
On 02/07/14 14:53, Josef Gajdusek wrote: This patch adds support for the hmc5983 i2c interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek Very n

Re: [PATCH 3/5] staging:iio:hmc5843: register <-> value arrays now can have different lengths

2014-07-07 Thread Jonathan Cameron
On 02/07/14 14:52, Josef Gajdusek wrote: Changed structure of struct hmc5843_chip_info to include length of translation arrays. Code previously using #defined constant has been changed accordingly. This allows to integrate devices which do have different amounts of available rates/scales. Signed

Re: [PATCH 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

2014-07-07 Thread Jonathan Cameron
On 02/07/14 14:51, Josef Gajdusek wrote: This patch splits hmc5843.c to multiple files - the interface-agnostic hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is another step to add support of SPI-enabled hmc5983. Signed-off-by: Josef Gajdusek Looks good to me from

Re: [PATCH 1/5] staging:iio:hmc5843: Added regmap support

2014-07-07 Thread Jonathan Cameron
On 02/07/14 14:50, Josef Gajdusek wrote: This patch changes hmc5843.c to use regmap. This provides transparent caching to the code as well as abstraction necessary to add support for SPI-based hmc5983. Signed-off-by: Josef Gajdusek Hi Josef, A few little bits and pieces inline. Peter, could y

Re: Anybody working on gdm72xx?

2014-07-07 Thread Michalis Pappas
On 07/01/2014 09:17 PM, Michalis Pappas wrote: > The wimax.h interface specifies communication through "message pipes", a > means of free-form communication between user-space and the driver. So > my understanding is that the library only needs to replace the lowest > layer (ie ioctl/netlink) with

Re: [PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-07 Thread Joe Perches
[trivial notes] On Mon, 2014-07-07 at 18:21 +0300, Andy Shevchenko wrote: > This allows user to print a given buffer as esaped string. The rules applied as an escaped > accordingly to the mix of the flags provided by additional format letters. rules are applied according to an optional mix of f

Re: [PATCH v2] iio:trigger: Introduce the use of devm_kzalloc

2014-07-07 Thread Jonathan Cameron
On 07/07/14 13:37, Lars-Peter Clausen wrote: On 07/07/2014 02:34 PM, Jonathan Cameron wrote: On 01/07/14 22:19, Himangi Saraogi wrote: This patch introduces the use of the managed version of kzalloc and removes the kfrees in the probe and remove functions. More return paths are added and the la

Re: [PATCH] staging: iio: Introduce the use of devm_ioremap_resource

2014-07-07 Thread Jonathan Cameron
On 07/07/14 13:36, Lars-Peter Clausen wrote: On 07/07/2014 02:36 PM, Jonathan Cameron wrote: On 01/07/14 19:44, Himangi Saraogi wrote: This patch introduces the use of devm_ioremap_resource. It does away with call to request_mem_region and the error checking on platform_get_resource. Also, the

Re: [PATCH] staging: iio: remove duplicate case labels

2014-07-07 Thread Jonathan Cameron
On 07/07/14 15:12, Daniel Baluta wrote: Otherwise, compiling iio_event_monitor program fails: io_event_monitor.c: In function ‘event_is_known’: iio_event_monitor.c:125:2: error: duplicate case value case IIO_MOD_LIGHT_BOTH: ^ iio_event_monitor.c:121:2: error: previously used here case I

[PATCH] staging: nvec: add missing blank line after declarations

2014-07-07 Thread Pawel Lebioda
Fix 'missing blank line after declaration' warnings reported by checkpatch.pl. Signed-off-by: Pawel Lebioda --- drivers/staging/nvec/nvec_paz00.c | 1 + drivers/staging/nvec/nvec_power.c | 1 + drivers/staging/nvec/nvec_ps2.c | 2 ++ 3 files changed, 4 insertions(+) diff --git a/drivers/stagin

[PATCH v2 10/10] staging: rtl8192u: use %*pEn to escape buffer

2014-07-07 Thread Andy Shevchenko
Let's use kernel's native specifier to escape a buffer. Signed-off-by: Andy Shevchenko --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/

[PATCH v2 06/10] wireless: ipw2x00: print SSID via %*pE

2014-07-07 Thread Andy Shevchenko
Instead of custom approach this allows to print escaped strings via recently added kernel extension: %*pE. Signed-off-by: Andy Shevchenko --- drivers/net/wireless/ipw2x00/ipw2100.c | 22 +-- drivers/net/wireless/ipw2x00/ipw2200.c | 270 ++- drivers/net/wireless/i

[PATCH v2 01/10] lib / string_helpers: move documentation to c-file

2014-07-07 Thread Andy Shevchenko
The documentation of API belongs to c-file. This patch moves it accordingly. There is no functional change. Signed-off-by: Andy Shevchenko --- include/linux/string_helpers.h | 34 -- lib/string_helpers.c | 38 ++ 2 fi

[PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-07 Thread Andy Shevchenko
This allows user to print a given buffer as esaped string. The rules applied accordingly to the mix of the flags provided by additional format letters. For example, if the given buffer: 1b 62 20 5c 43 07 22 90 0d 5d The result strings could be: %*pE"\eb \C\a"\220\r]"

[PATCH v2 05/10] wireless: libertas: print esaped string via %*pE

2014-07-07 Thread Andy Shevchenko
Instead of custom approach this allows to print escaped strings via recently added kernel extension: %*pE. Signed-off-by: Andy Shevchenko --- drivers/net/wireless/libertas/cfg.c | 8 ++-- drivers/net/wireless/libertas/mesh.c | 7 +++ 2 files changed, 5 insertions(+), 10 deletions(-) di

[PATCH v2 08/10] staging: wlan-ng: use %*pEhp to print SN

2014-07-07 Thread Andy Shevchenko
This is a generic specifier to print an escaped buffer by given criteria. Let's use it instead of custom approach. Signed-off-by: Andy Shevchenko --- drivers/staging/wlan-ng/prism2sta.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/stag

[PATCH v2 02/10] lib / string_helpers: refactoring the test suite

2014-07-07 Thread Andy Shevchenko
This patch prepares test suite for a following update. It introduces test_string_check_buf() helper which checks the result and dumps an error. Signed-off-by: Andy Shevchenko --- lib/test-string_helpers.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletion

[PATCH v2 07/10] lib80211: remove unused print_ssid()

2014-07-07 Thread Andy Shevchenko
In kernel we have %*pE specifier to print an escaped buffer. All users now switched to that approach. This fixes a bug as well. The current implementation wrongly prints octal numbers: only two first digits are used in case when 3 are required and the rest of the string ends up cut off. Additiona

[PATCH v2 09/10] staging: rtl8192e: use %*pEn to escape buffer

2014-07-07 Thread Andy Shevchenko
Let's use kernel's native specifier to escape a buffer. Signed-off-by: Andy Shevchenko --- drivers/staging/rtl8192e/rtllib.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 83f5f57..98

[PATCH v2 03/10] lib / string_helpers: introduce string_escape_mem()

2014-07-07 Thread Andy Shevchenko
This is almost the opposite function to string_unescape(). Nevertheless it handles \0 and could be used for any byte buffer. The documentation is supplied together with the function prototype. The test cases covers most of the scenarios and would be expanded later on. Signed-off-by: Andy Shevche

[PATCH v2 00/10] lib: introduce string_escape_mem an %*pE specifier

2014-07-07 Thread Andy Shevchenko
The introduced function is a kind of opposite to string_unescape. We have several users of such functionality each of them created custom implementation. The series contains clean up of test suite, adding new call, and switching few users to use it via %*pE specifier. Test suite covers all of exis

[PATCH] staging: iio: remove duplicate case labels

2014-07-07 Thread Daniel Baluta
Otherwise, compiling iio_event_monitor program fails: io_event_monitor.c: In function ‘event_is_known’: iio_event_monitor.c:125:2: error: duplicate case value case IIO_MOD_LIGHT_BOTH: ^ iio_event_monitor.c:121:2: error: previously used here case IIO_MOD_LIGHT_BOTH: Fixes: da4db94 (iio stagi

Re: [PATCH v2] iio:trigger: Introduce the use of devm_kzalloc

2014-07-07 Thread Lars-Peter Clausen
On 07/07/2014 02:52 PM, Julia Lawall wrote: On Mon, 7 Jul 2014, Jonathan Cameron wrote: On 01/07/14 22:19, Himangi Saraogi wrote: This patch introduces the use of the managed version of kzalloc and removes the kfrees in the probe and remove functions. More return paths are added and the labels

Re: [PATCH v2] iio:trigger: Introduce the use of devm_kzalloc

2014-07-07 Thread Julia Lawall
On Mon, 7 Jul 2014, Jonathan Cameron wrote: > On 01/07/14 22:19, Himangi Saraogi wrote: > > This patch introduces the use of the managed version of kzalloc and > > removes the kfrees in the probe and remove functions. More return > > paths are added and the labels are renamed to order them. > > >

re: staging: rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()

2014-07-07 Thread Dan Carpenter
Hello navin patidar, The patch fadbe0cd5292: "staging: rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()" from Jun 22, 2014, leads to the following static checker warning: drivers/staging/rtl8188eu/core/rtw_cmd.c:1234 rtw_setassocsta_cmd() warn: struct type mismatch 'set_stake

Re: [PATCH v2] iio:trigger: Introduce the use of devm_kzalloc

2014-07-07 Thread Lars-Peter Clausen
On 07/07/2014 02:34 PM, Jonathan Cameron wrote: On 01/07/14 22:19, Himangi Saraogi wrote: This patch introduces the use of the managed version of kzalloc and removes the kfrees in the probe and remove functions. More return paths are added and the labels are renamed to order them. Signed-off-by

Re: [PATCH] staging: iio: Introduce the use of devm_ioremap_resource

2014-07-07 Thread Lars-Peter Clausen
On 07/07/2014 02:36 PM, Jonathan Cameron wrote: On 01/07/14 19:44, Himangi Saraogi wrote: This patch introduces the use of devm_ioremap_resource. It does away with call to request_mem_region and the error checking on platform_get_resource. Also, the calls to free the allocated resources like rel

Re: [PATCH] staging: iio: Introduce the use of devm_ioremap_resource

2014-07-07 Thread Jonathan Cameron
On 01/07/14 19:44, Himangi Saraogi wrote: This patch introduces the use of devm_ioremap_resource. It does away with call to request_mem_region and the error checking on platform_get_resource. Also, the calls to free the allocated resources like release_mem_region and iounmap are done away with. T

Re: [PATCH v2] iio:trigger: Introduce the use of devm_kzalloc

2014-07-07 Thread Jonathan Cameron
On 01/07/14 22:19, Himangi Saraogi wrote: This patch introduces the use of the managed version of kzalloc and removes the kfrees in the probe and remove functions. More return paths are added and the labels are renamed to order them. Signed-off-by: Himangi Saraogi Looks sane, but I'd like an a

[PATCH] drivers: staging: android: ion: Kconfig: Let it also depend on HAS_DMA

2014-07-07 Thread Chen Gang
ION need HAS_DMA (e.g. need DMA_SHARED_BUFFER), so it has to depend on HAS_DMA, or can not pass compiling with allmodconfig under score which NO_DMA. And the related error: CC drivers/staging/android/ion/ion_cma_heap.o drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_mm

Re: staging: dgap:

2014-07-07 Thread Dan Carpenter
On Tue, Jul 01, 2014 at 10:15:34AM -0400, Mark Hounschell wrote: > Hi Dan, > > I've been away for a while but should be able to find some time to work > on the dgap driver some more. Do you have a TODO list? > Really there is just a lot of misc clean up work to do. Get rid of forward declaratio

[PATCH v2 4/4] Staging: rts5208: Fix a format specifier for dev_err

2014-07-07 Thread Fabio Falzoi
Fix an incorrect use of the %d format specifier in dev_err that caused a warning. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index 4f5f7a3..

[PATCH v2 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

2014-07-07 Thread Fabio Falzoi
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208/

[PATCH v2 0/4] Staging: rts5208: Use standard debug features

2014-07-07 Thread Fabio Falzoi
Use standard debug features instead of relying on the custom configuration option CONFIG_RTS5208_DEBUG and a series of home grown macros. Changes in v2: * defined rtsx_hex_dump macro to produce output only if DEBUG is defined Fabio Falzoi (4): Staging: rts5208: Replace custom macro with pr_debu

[PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread Fabio Falzoi
Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 9 - drivers/staging/rts5208/sd.c