OS_phystov()/OS_vtophys() are replaced with
phys_to_virt()/virt_to_phys().
Signed-off-by: Daeseok Youn
---
V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va().
drivers/staging/cxt1e1/musycc.c | 16
drivers/staging/cxt1e1/pmcc4_drv.c | 12 ++
From: Sami Laine
Sparse warning correction:
CHECK drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c
drivers/staging/media/solo6x10/solo6x10-jpeg.h:113:21: warning: symbol 'jpeg_dqt
' was not declared. Should it be static?
The symbol jpeg_dqt is used just in solo6x10-v4l2-enc.c, so I think i
All its callers depends on the return value of -ENOBUFS to reallocate a
bigger buffer and retry the receiving. So there's no need to call
pr_err() here since it was not a real issue, otherwise syslog will be
flooded by this false warning.
Cc: K. Y. Srinivasan
Cc: Haiyang Zhang
Signed-off-by: Jas
From: Sami Laine
Sparse warning corrections for incorrect printk format characters.
Signed-off-by: Sami Laine
---
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index c0a0e60..e0e8693 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
2014-06-30 6:22 GMT+09:00 Greg KH :
> On Fri, Jun 27, 2014 at 06:56:08PM +0900, Daeseok Youn wrote:
>> OS_mem_token_tlen() is same return value as OS_mem_token_len().
>> That means packet count is always 1. So OS_mem_token_tlen()
>> must be total length of packet and OS_mem_token_len() has a
>> len
Hi, Greg.
2014-06-30 6:21 GMT+09:00 Greg KH :
> On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote:
>> OS_phystov()/OS_vtophys() are replaced with __va()/__pa().
>
> No, you should use virt_to_phys() and phys_to_virt() instead of these
> internal macros which might not be correct for all
On Sat, Jun 28, 2014 at 2:49 AM, Michalis Pappas wrote:
>
> Hi Ben,
>
> would you be interested to work on this driver together? My reviewing
> process is a bit slow as this is the first driver I'm going through and
> I would like to understand how everything works in detail. I was
> planning to s
On Monday 30 June 2014 12:47 AM, Antti Palosaari wrote:
> Moikka!
> That is already fixed by someone else and patch is somewhere Mauro or
> Hans queue.
>
> regards
> Antti
>
Moikka :)
Ah no worries - I could not find the changes with the latest updates.
Thanks
___
On Fri, Jun 27, 2014 at 04:53:32PM +0300, Andy Shevchenko wrote:
> The helper mac_pton() validates and converts MAC address from string format to
> a number. Originally code uses simple code to do that. With mac_pton() the
> driver now validates input as well.
>
> MEanwhile hex2bin() converts hexd
On Fri, Jun 27, 2014 at 06:56:08PM +0900, Daeseok Youn wrote:
> OS_mem_token_tlen() is same return value as OS_mem_token_len().
> That means packet count is always 1. So OS_mem_token_tlen()
> must be total length of packet and OS_mem_token_len() has a
> length of fragmented packet. And then it can
On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote:
> OS_phystov()/OS_vtophys() are replaced with __va()/__pa().
No, you should use virt_to_phys() and phys_to_virt() instead of these
internal macros which might not be correct for all architectures.
thanks,
greg k-h
wHubCharacteristics gets wrong value on big-endian CPUs.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index a65b708..
Return transferred bytes only when transfer was successful.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/octeon-hcd.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 5
On data toggle error, we don't know if and how many bytes were
successfully transferred by DMA. We should just fail the transaction
instead of trying a retry.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/octeon-hcd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
Cancel requests synchronously instead of using the dequeue tasklet.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/octeon-hcd.c | 38 +
1 file changed, 1 insertion(+), 37 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/st
The driver did not use link_urb_to_ep() / unlink_urb_from_ep(). This
caused odd behaviour in some error recovery situations, all requests
would start to fail after the first failure.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/octeon-hcd.c | 18 +-
1 file changed,
Moikka!
That is already fixed by someone else and patch is somewhere Mauro or
Hans queue.
regards
Antti
On 06/29/2014 08:20 AM, Anil Belur wrote:
From: Anil Belur
- this fix replaces jiffies interval comparision with safer function to
avoid any overflow and wrap around ?
Signed-off-by:
On Fri, Jun 20, 2014 at 07:05:17PM +0300, Kristina Martšenko wrote:
> On 20/06/14 18:43, Kristina Martšenko wrote:
> > Hi Omar,
> >
> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> > nobody seems to have worked towards moving tidspbridge out of staging in
> > over a y
On 29/06/14 10:41, Federico Di Pierro wrote:
Fix some little style issues in drivers/staging/iio/frequency/ad9832.c .
This is my latest task of the eudyptula challenge (third attempt!)
Signed-off-by: Federico Di Pierro
I'd have preferred more meaty work on this driver, but I guess every
little
On 27/06/14 21:48, Belisko Marek wrote:
PIng? Jonathan do you have any objections to this approach? Can you
please pick it? Thx.
Sorry, this one dropped through the cracks.
Applied to the togreg branch of iio.git along with the documentation patch that
goes with it.
Jonathan
On Tue, Feb 18,
Fix some little style issues in drivers/staging/iio/frequency/ad9832.c .
This is my latest task of the eudyptula challenge (third attempt!)
Signed-off-by: Federico Di Pierro
---
drivers/staging/iio/frequency/ad9832.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --gi
21 matches
Mail list logo
