On Wed, Jun 25, 2014 at 5:11 AM, Michalis Pappas wrote:
>
>
> Hi everyone,
>
> I've been working on a driver review for gdm72xx and I think there are some
> more issues to be fixed except from stuff reported by checkpatch.pl. Here's
> what I've come up with so far:
>
> First of all, during a pat
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_qos.c | 10 +-
drivers/staging/gdm72xx/gdm_qos.h | 4 +---
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index df6f000..732f009 100644
--- a/dri
This patch changes gdm_usb_send() and gdm_sdio_send() to return -EINVAL instead
of calling BUG_ON if an invalid data length is passed to the functions.
Reported-by: Dan Carpenter
Reported-by: Michalis Pappas
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_sdio.c | 3 ++-
drivers/stagin
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_qos.c | 38 +++---
drivers/staging/gdm72xx/gdm_qos.h | 2 +-
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index a2efc
This patch addresses the following issues:
- Use int instead of u32 whenever makes sense
- Turn extract_qos_list() in gdm_qos.c, which previously always returned
0, into a void function.
Reported-by: Dan Carpenter
Reported-by: Michalis Pappas
Signed-off-by: Ben Chan
---
drivers/staging/gdm72
The code in apci1564_interrupt() for handling counter interrupts is currently
repeated four times; once for each counter. This code is identical save for the
registers it is using, so just handle all four counters with a for loop.
Also, the interrupt function was doing a useless set-and-check of
apci1564_cos_insn_config() is currently using apci1564_reset() to disable
digital input interrupts when the configuration operation is
COMEDI_DIGITAL_TRIG_DISABLE. However, this is incorrect as the device reset
function also resets the registers for the digital outputs, timer, watchdog, and
counte
Commit aed3f9d (staging: comedi: addi_apci_1564: absorb apci1564_reset()) moved
the only use of addi_watchdog.h from hwdrv_apci1564.c to addi_apci_1564.c, but
left the include statement itself in the former file. Move this include to the
file which actually uses it.
Signed-off-by: Chase Southwood
From: Guillaume Morin
Simple code style fixes
Signed-off-by: Guillaume Morin
---
drivers/staging/dgnc/dgnc_driver.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index d52a9e8..68460af
This patchset moves a misplaced include to the proper file, swaps out an overly
aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().
Chase Southwood (3):
staging: comedi: addi_apci_1564: move addi_watchdog.h include to
addi_apci_1564.c
staging: comedi: addi_apci_15
From: Yue Zhang
hv_fcopy_daemon fails to overwrite a file if the target file already
exits.
Add O_TRUNC flag on opening.
Signed-off-by: Yue Zhang
---
tools/hv/hv_fcopy_daemon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> > From: Yue Zhang
> >
> > hv_fcopy_daemon fails to overwrite a file if the target file already
> > exits.
> >
> > Add O_TRUNC flag on opening.
> >
> > MS-TFS: 341345
>
> It's as if the people on your team don't talk to each
On Fri, Jun 27, 2014 at 05:16:48PM -0700, Yue Zhang wrote:
> From: Yue Zhang
>
> hv_fcopy_daemon fails to overwrite a file if the target file already
> exits.
>
> Add O_TRUNC flag on opening.
>
> MS-TFS: 341345
It's as if the people on your team don't talk to each other about what
they should,
From: Yue Zhang
hv_fcopy_daemon fails to overwrite a file if the target file already
exits.
Add O_TRUNC flag on opening.
Signed-off-by: Yue Zhang
---
tools/hv/hv_fcopy_daemon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy
> -Original Message-
> From: Yue Zhang [mailto:yue...@microsoft.com]
> Sent: Friday, June 27, 2014 5:17 PM
> To: KY Srinivasan; Haiyang Zhang; driverdev-devel@linuxdriverproject.org;
> linux-ker...@vger.kernel.org; o...@aepfle.de; jasow...@redhat.com;
> a...@canonical.com
> Cc: Dexuan Cui
From: Yue Zhang
hv_fcopy_daemon fails to overwrite a file if the target file already
exits.
Add O_TRUNC flag on opening.
MS-TFS: 341345
Signed-off-by: Yue Zhang
---
tools/hv/hv_fcopy_daemon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/t
Am 24.06.2014 16:12, schrieb Stefan Hajnoczi:
On Tue, Jun 24, 2014 at 9:52 PM, Greg KH wrote:
On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote:
On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko
wrote:
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
n
PIng? Jonathan do you have any objections to this approach? Can you
please pick it? Thx.
On Tue, Feb 18, 2014 at 9:35 PM, Belisko Marek wrote:
> Hi Jonathan,
>
> On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron wrote:
>> On 14/02/14 14:25, Marek Belisko wrote:
>>>
>>> Signed-off-by: Marek Beli
Hi Greg,
On 27/06/2014 16:55, Greg KH wrote:
On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote:
Il 26/06/2014 21:23, Greg KH ha scritto:
On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote:
On 2014-06-18 13:33, Kristina Martšenko wrote:
Hi Alois,
I'm helping Greg do a b
On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote:
> Il 26/06/2014 21:23, Greg KH ha scritto:
> >On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote:
> >>On 2014-06-18 13:33, Kristina Martšenko wrote:
> >>>Hi Alois,
> >>>
> >>>I'm helping Greg do a bit of cleanup in the staging
Signed-off-by: Denis Carikli
---
drivers/gpu/ipu-v3/ipu-di.c |4 ++--
drivers/staging/imx-drm/ipuv3-crtc.c |4 ++--
include/video/imx-ipu-v3.h |8 +++-
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-
The helper mac_pton() validates and converts MAC address from string format to
a number. Originally code uses simple code to do that. With mac_pton() the
driver now validates input as well.
MEanwhile hex2bin() converts hexdecimal strings to its binary representation.
As the other helper it validat
From: Sami Laine
Sparse warning corrections: NULL-pointers as NULL instead of static 0's.
Signed-off-by: Sami Laine
---
diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c
b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index 77ee9e5..d9c874c 100644
--- a/drivers/staging/lustre/
Il 26/06/2014 21:23, Greg KH ha scritto:
On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote:
On 2014-06-18 13:33, Kristina Martšenko wrote:
Hi Alois,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving ced1401 out of s
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/stagi
The patch looks mostly OK, though I see there is also a
CONFIG_PPC_256K_PAGES
define that should probably be handled.
Cheers, Andreas
On 2014/06/20, 6:23 AM, "Arnd Bergmann" wrote:
>The lustre virtual block device cannot handle 64K pages and fails at
>compile
>time. To avoid running into this e
This patch moves the doubled if block inside the retval-checking one
level up.
As the if-else-block it was in is now a one-statement if-else block,
I removed the braces from it.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/DDRInit.c | 16 +---
1 file changed, 5 insertions(+
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/DDRInit.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 423bfd9..4564f40 100644
--- a/drivers/staging/bcm/DDRInit.c
+++
Hi,
I fixed the suggested stuff:
* Moved the whitespace fixes which appeared to be in the indentation-fix
patch to the appropriate patch
* Moved the commits with line-shortenings to the _end_ of the patchset, so
greg k-h is free to apply them or not without messing around wit
This patch fixes some indentation errors, where multi-line statements
where not indented.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/DDRInit.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/s
The inner if-statement was aligned just like the outer one. Why?
This indention was introduced by
f34c488c3894968e8cdbdc3b1ed617d78315cace
which is a indention-fix patch itself. That's why I'm curious about it.
I did not merge these nested if-statements, as I don't know if I'm
destroying lo
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/DDRInit.c | 176 --
1 file changed, 134 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index d2646d9..423bfd9 100644
--- a/drivers/staging/bcm/
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/DDRInit.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index f1d7cb8..cdd1029 100644
--- a/drivers/staging/bcm/DDRInit.
OS_mem_token_ interfaces are useless, so just replaced with
sk_buff related fuctions.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/musycc.c | 45 +-
drivers/staging/cxt1e1/pmcc4_drv.c | 11 ++--
drivers/staging/cxt1e1/pmcc4_private.h
OS_mem_token_tlen() is same return value as OS_mem_token_len().
That means packet count is always 1. So OS_mem_token_tlen()
must be total length of packet and OS_mem_token_len() has a
length of fragmented packet. And then it can count total
count of fragmented packets properly.
And OS_mem_token_ne
OS_phystov()/OS_vtophys() are replaced with __va()/__pa().
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/musycc.c | 16
drivers/staging/cxt1e1/pmcc4_drv.c | 12 ++--
drivers/staging/cxt1e1/sbecom_inline_linux.h | 19 -
36 matches
Mail list logo
