Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-17 Thread micky
On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky wrote: On 06/16/2014 04:42 PM, Ulf Hansson wrote: @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { struct rtsx_pcr *pcr;

Re: [PATCH v3 0/2] Fix subject line

2014-06-17 Thread Davidlohr Bueso
On Mon, 2014-06-16 at 00:28 +0400, Wahib wrote: > Hi Davidlohr! > > Don't worry. I am not discouraged. :) > > I understand your concern that the patch feels superficial. It's what the task > asked us to do. I suspect the author(s) of the Eudyptula Challenge designed > this task to get us involved

Re: [PATCH v3 0/2] Staging: unisys: uislib: address sparse noderef warnings

2014-06-17 Thread Greg KH
On Thu, Jun 05, 2014 at 01:56:14PM -0500, Ken Cox wrote: > > This series gets rid of some sparse noderef warnings by adding I/O versions > of the functions that are producing the warnings and also removing __iomem > declarations where they are not needed. But you forgot to delete the now unused

Re: [PATCH] staging: unisys: Remove trailing semicolon from macro

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 11:59:20PM +0900, Masanari Iida wrote: > This patch removed trailing semicolon from macro in guestlinuxdebug.h > > Signed-off-by: Masanari Iida > --- > drivers/staging/unisys/include/guestlinuxdebug.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-17 Thread Greg KH
On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote: > Added I/O version for the function ultra_vbus_init_channel() to get rid > of noderef sparse warnings when accessing I/O space. > > Signed-off-by: Ken Cox > --- > .../common-spar/include/channels/vbuschannel.h | 40 >

Re: [PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-17 Thread Greg KH
On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote: > The unisys drivers now properly check to make sure they are running > on the s-Par platform before they will initialize. This was fixed in > commit fcd0157ece so it is safe to allow the unisys drivers to be built. > > This has been tested

Re: [PATCH 07/76] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info

2014-06-17 Thread Greg KH
On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > drivers/staging/rtl8723au/core/rtw_ieee80211.c | 29 > +- > 1 file changed, 14 insertions(+), 15 deletions(-) > > diff --git a/drivers/

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-17 Thread Greg KH
On Mon, Jun 09, 2014 at 09:05:33AM -0700, Greg KH wrote: > On Mon, Jun 09, 2014 at 10:54:46AM -0500, Larry Finger wrote: > > On 06/09/2014 10:39 AM, Jes Sorensen wrote: > > >Greg KH writes: > > >>On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: > > >>>From: Jes Sorensen >

Re: [PATCHv2] Fixes function fw_download_code to check for Null return from dev_skb_alloc

2014-06-17 Thread Greg KH
Lots of things wrong here, please step back, and slow down. Your subject, this really isn't "v2", is it? On Tue, Jun 17, 2014 at 05:18:01PM -0400, Nicholas Krause wrote: > Signed-off-by: Nicholas Krause You aren't saying what you are doing here in the body of the patch, why not? > --- > drive

[PATCHv2] Fixes function fw_download_code to check for Null return from dev_skb_alloc

2014-06-17 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..e4c8224 100644 --

Re: [PATCHv2] Check if skb_alloc returns Null in function fw_download_code

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 12:07:12PM -0400, Nicholas Krause wrote: > Signed-off-by: Nicholas Krause > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > b/drivers/staging/rtl819

Re: [PATCHv2] Check if skb_alloc returns Null in function fw_download_code

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 12:04:59PM -0400, Nick Krause wrote: > I created it using  git-format patch and check my condition is > wrong should be !skb to check for Nulls . That's not the real problem here. The real issue is you can not apply your patch to any tree. Please remove all patches from y

Re: does drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c have an uncommon character set ?

2014-06-17 Thread Greg KH
On Sat, Jun 14, 2014 at 07:36:31PM +0200, Toralf Förster wrote: > The html formatter of the static checker Cppcheck stumbles over that file. In > fact, even this small python snippet : > > #!/usr/bin/env python > > import io > > source_filename = "./drivers/staging/rtl8821ae/btcoexist/HalBtc881

[PATCHv2] Check if skb_alloc returns Null in function fw_download_code

2014-06-17 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..11e915e 100644 --- a/drivers/stagi

Re: [PATCHv2] Check if skb_alloc returns Null in function fw_download_code

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 11:05:16AM -0400, Nicholas Krause wrote: > Signed-off-by: Nicholas Krause > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > b/drivers/staging/rtl819

[PATCH] staging: unisys: Remove trailing semicolon from macro

2014-06-17 Thread Masanari Iida
This patch removed trailing semicolon from macro in guestlinuxdebug.h Signed-off-by: Masanari Iida --- drivers/staging/unisys/include/guestlinuxdebug.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/include/guestlinuxdebug.h b/drivers/staging/un

[PATCHv2] Check if skb_alloc returns Null in function fw_download_code

2014-06-17 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..11e915e 100644 --- a/drivers/stagi

[PATCH] staging: bcm: Remove unnecessary parentheses

2014-06-17 Thread Masanari Iida
This patch remove unnecessary parentheses in PHSModule.c Signed-off-by: Masanari Iida --- drivers/staging/bcm/PHSModule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 07c5a0b..bd68c6f 100644 --- a/driv

Re: [PATCH v14 09/10] ARM: dts: mbimx51sd: Add display support.

2014-06-17 Thread Denis Carikli
On 06/16/2014 02:29 PM, Denis Carikli wrote: [...] Which result at the lcd regulator being physically powered on at boot. I didn't see that because powering it on at boot is what I want. I fixed that in imx-drm's parallel-display with another patch I just sent separately. Denis. __

[PATCH] imx-drm: parallel-display: Fix DPMS default state.

2014-06-17 Thread Denis Carikli
If connector->dpms is left untouched, it defaults to DRM_MODE_DPMS_ON (0). As a result, drm_helper_connector_dpms will exit when it will be asked to set the state to DRM_MODE_DPMS_ON, because it is already set. That issue prevented displays from turning on at boot. Signed-off-by: Denis Carikli

[PATCH v3] staging: vt6655: preserve address space in ethtool_ioctl()

2014-06-17 Thread Martin Kepplinger
Fix the sparse error: cast removes address space of expression and add __user annotation to the driver's ethtool_ioctl(). Signed-off-by: Martin Kepplinger --- I think I forgot to change the declaration on top. drivers/staging/vt6655/device_main.c |6 +++--- 1 file changed, 3 insertions(+),

[PATCH v2] staging: vt6655: preserve address space in ethtool_ioctl()

2014-06-17 Thread Martin Kepplinger
Fix the sparse error: cast removes address space of expression and add __user annotation to the driver's ethtool_ioctl(). Signed-off-by: Martin Kepplinger --- Beyond that, how would you include socket.c's ethtool_ioctl() here? thanks for looking at these tiny changes. drivers/staging/vt6655/de

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-17 Thread Ulf Hansson
On 17 June 2014 03:04, micky wrote: > On 06/16/2014 08:40 PM, Ulf Hansson wrote: >> >> On 16 June 2014 11:09, micky wrote: >>> >>> On 06/16/2014 04:42 PM, Ulf Hansson wrote: > > @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc { >> >> struct rtsx_pcr *pcr; >>