[PATCH] staging: iio: fix coding style

This patch fixes coding style reported by checkpatch.pl that missing a blank line after declarations. Signed-off-by: Jimmy Picard --- drivers/staging/iio/iio_simple_dummy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_sim

Re: [PATCH v13 06/10] drm: drm_display_mode: add signal polarity flags

Hi Denis, Thank you for the patch. On Tuesday 10 June 2014 12:25:47 Denis Carikli wrote: > We need a way to pass signal polarity informations > between DRM panels, and the display drivers. > > To do that, a pol_flags field was added to drm_display_mode. > > Signed-off-by: Denis Carikli > ---

[PATCH] drivers/staging/speakup/main: fixed jiffie comparison

speakup_key() used manual comparison of jiffies to determine the time since the last keypress, replaced it with time_after() Resend with kernel mailing list cc'ed (duh...) Signed-off-by: Robin Schroer --- drivers/staging/speakup/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] drivers/staging/speakup/main: fixed jiffie comparison

speakup_key() used manual comparison of jiffies to determine the time since the last keypress, replaced it with time_after() Signed-off-by: Robin Schroer --- drivers/staging/speakup/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c b/driver

Patch[Fixes marco definition for if statements that use marco CA91CX42_LM_CTL_AS_A16 in header file, vme_ca91cx42.h]

Signed-off-by: Nicholas Krause --- drivers/vme/bridges/vme_ca91cx42.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vme/bridges/vme_ca91cx42.h b/drivers/vme/bridges/vme_ca91cx42.h index 02a7c79..57e942f 100644 --- a/drivers/vme/bridges/vme_ca91cx42.h +++ b/drivers/

Re: [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call

On Thu, Jun 12, 2014 at 11:09:20PM +0200, Rickard Strandqvist wrote: > I agree that you should not do patches just to silence a static control > program. > > Concerning (len >= BUSID_SIZE) I agree! But I usually try to change as > little as possible in the patches I do. But perhaps I should not t

Re: [PATCH v3 0/2] Fix subject line

On Thu, Jun 12, 2014 at 01:48:38PM -0700, Davidlohr Bueso wrote: > On Thu, 2014-06-12 at 13:35 -0700, Greg Kroah-Hartman wrote: > > On Thu, Jun 12, 2014 at 01:25:34PM -0700, Davidlohr Bueso wrote: > > > On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote: > > > > Fix coding style issues detected b

Re: [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call

2014-06-11 7:45 GMT+02:00 Dan Carpenter : > On Tue, Jun 10, 2014 at 10:48:35PM +0200, Rickard Strandqvist wrote: >> Hi >> >> True! >> Sorry :-( >> >> But then one would either operate strcpy outright. >> >> Or use strlcpy then the code would be: >> >> /* strlcpy() handles not include \0 */ >>

[PATCH] staging: lustre: removed spaces at the start of a line

Hello, This is a patch in order to remove 2 lines with spaces at the start of the line. Best Regards. Signed-off-by: Marc Fite --- drivers/staging/lustre/lustre/obdecho/lproc_echo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdecho/lp

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

Martyn, Nick Krause emailed me privately that he's not able to get git to work. Normally for bug fixes, we would patch this up ourselves. The offending code was introduced in: commit 2b82beb8c1bc81b3dde69d16cacbc22546681acf Author: Martyn Welch Date: Thu Feb 18 15:13:19 2010 + Stagin

Re: [PATCH v3 0/2] Fix subject line

On Thu, 2014-06-12 at 13:35 -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 12, 2014 at 01:25:34PM -0700, Davidlohr Bueso wrote: > > On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote: > > > Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. > > > > Sorry but unless bundled

Re: [PATCH v3 0/2] Fix subject line

On Thu, Jun 12, 2014 at 01:25:34PM -0700, Davidlohr Bueso wrote: > On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote: > > Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. > > Sorry but unless bundled with something more meaningful, I really don't > see the value in thes

Re: [PATCH v3 0/2] Fix subject line

On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote: > Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. Sorry but unless bundled with something more meaningful, I really don't see the value in these changes. I certainly don't want to discourage folks or anything, but just

[PATCH v3 2/2] staging: usbip: usbip_host_driver.c: fix line over 80 characters

Fix coding style issue "line over 80 characters" detected by checkpatch.pl in usbip_host_driver.c. Signed-off-by: Wahib Faizi --- .../usbip/userspace/libsrc/usbip_host_driver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/userspace/libsrc/u

[PATCH v3 1/2] staging: usbip: usbip_host_driver.c: avoid assignment in if

Fix coding style issue "do not use assignment in if condition" detected by checkpatch.pl in usbip_host_driver.c. Signed-off-by: Wahib Faizi --- .../usbip/userspace/libsrc/usbip_host_driver.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/usbip/usersp

[PATCH v3 0/2] Fix subject line

Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. v3: Shorten subject line, as suggested by Greg Kroah-Hartman , Joe Perches v2: Split patch into logical chunks, as suggested by Greg Kroah-Hartman ___ devel mailing list de.

[PATCH 1/2] staging: usbip: usbip_host_driver.c: avoid assignment in if

Fix coding style issue "do not use assignment in if condition" detected by checkpatch.pl in usbip_host_driver.c. Signed-off-by: Wahib Faizi --- .../usbip/userspace/libsrc/usbip_host_driver.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/usbip/usersp

[PATCH 2/2] staging: usbip: usbip_host_driver.c: fix line over 80 characters

Fix coding style issue "line over 80 characters" detected by checkpatch.pl in usbip_host_driver.c. Signed-off-by: Wahib Faizi --- .../usbip/userspace/libsrc/usbip_host_driver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/userspace/libsrc/u

Fix subject line

Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. v3: Shorten subject line, as suggested by Greg Kroah-Hartman , Joe Perches v2: Split patch into logical chunks, as suggested by Greg Kroah-Hartman ___ devel maili

[PATCHv3] staging: keucr: usb.c: add blank lines after declarations

From: Mathias Engan Add blank line after declarations in eucr_suspend and eucr_resume as reported by checkpatch. Signed-off-by: Mathias Engan --- drivers/staging/keucr/usb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/keucr/usb.c b/drivers/staging/k

Re: [PATCH v2 1/2] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style

On Thu, 2014-06-12 at 10:54 -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 12, 2014 at 09:32:19PM +0400, Wahib Faizi wrote: > > Fix coding style issue "do not use assignment in if condition" > > detected by checkpatch.pl in usbip_host_driver.c. > > > > Signed-off-by: Wahib Faizi > > Both of thes

Re: [PATCH v2 1/2] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style

On Thu, Jun 12, 2014 at 09:32:19PM +0400, Wahib Faizi wrote: > Fix coding style issue "do not use assignment in if condition" > detected by checkpatch.pl in usbip_host_driver.c. > > Signed-off-by: Wahib Faizi Both of these patches have the same Subject: line, which isn't good as it doesn't make

[PATCH] staging: rtl8172u: Make ieee80211_crypto_init static

Fix sparse warning. Signed-off-by: L. Alberto Giménez --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c index 55

[PATCH v2 1/2] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style

Fix coding style issue "do not use assignment in if condition" detected by checkpatch.pl in usbip_host_driver.c. Signed-off-by: Wahib Faizi --- .../usbip/userspace/libsrc/usbip_host_driver.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/usbip/usersp

Split patch into 2 logical chunks

Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. v2: Split patch into logical chunks, as suggested by Greg Kroah-Hartman [PATCH v2 1/2] Fix coding style issue "do not use assignment in if condition" detected by checkpatch.pl in usbip_host_driver.c. [PATCH v2 2/2]

[PATCH v2 2/2] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style

Fix coding style issue "line over 80 characters" detected by checkpatch.pl in usbip_host_driver.c. Signed-off-by: Wahib Faizi --- .../usbip/userspace/libsrc/usbip_host_driver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/userspace/libsrc/u

Re: [PATCH] staging: iio: fix coding style

On Thu, Jun 12, 2014 at 05:42:43PM +0800, Jimmy P wrote: > This patch fixes coding style errors reported by checkpatch.pl for > lines that was over 80 chars long. The macro value shoud be put in () as > well. > > Signed-off-by: Jimmy P We need a "real" or "full" name here for the signed-off-by:

Re: [PATCHv2] staging: keucr: usb.c: add blank lines after declarations

On Thu, Jun 12, 2014 at 09:28:56AM +0200, mathias.en...@gmail.com wrote: > From: Mathias Engan > > Add blank line after declarations in eucr_suspend and eucr_resume > as reported by checkpatch. > > Signed-off-by: Mathias Engan > --- > drivers/staging/keucr/usb.c |2 ++ > 1 file changed, 2

Re: [PATCH v3 0/8] Cleanup patches for bcm staging driver

Good enough. Thanks. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

On Thu, Jun 12, 2014 at 10:33:09AM -0400, nick wrote: > Here is the fixed patch. Having issues with using Thunderbird > so just used Evolution for now. > Nick Please read the first paragraph of: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

Here is the fixed patch. Having issues with using Thunderbird so just used Evolution for now. Nick --- drivers/vme/bridges/vme_ca91cx42.h.orig 2014-06-11 22:50:29.339671939 -0400 +++ drivers/vme/bridges/vme_ca91cx42.h 2014-06-11 23:15:36.027685173 -0400 Fixes bug issues with wrong bus width

Re: [PATCH] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style

On Thu, Jun 12, 2014 at 02:35:38PM +0400, Wahib Faizi wrote: > Fix coding style issues detected by checkpatch.pl: > 1. do not use assignment in if condition > 2. line over 80 characters You are doing two different things here, so please break it up into two different patches. Can you please do th

Re: [PATCH 06/22] staging: rtl8188eu: Instead of intf_hdl pass adapter in read & write functions

On Thu, Jun 12, 2014 at 03:52:33PM +0530, navin patidar wrote: > On Thu, Jun 12, 2014 at 1:13 PM, Dan Carpenter > wrote: > > On Wed, Jun 11, 2014 at 10:51:25PM +0530, navin patidar wrote: > >> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c > >> b/drivers/staging/rtl8188eu/core/rtw_io.c > >

[PATCH v3 4/8] Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index e1a3e6d..2f540d6 100644 --- a/drivers/

[PATCH v3 0/8] Cleanup patches for bcm staging driver

Hi, hopefully, this is the last version of the patchset. I fixed up my `sed` error and test compiled the module. Please notice: I cannot test the patches as I do not have the appropriate hardware. Kind regards, Matthias Beyer Matthias Beyer (8): Staging: bcm: Shortened some lines Staging:

[PATCH v3 5/8] Staging: bcm: Merged some lines which got shorter by the latest patch

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 2f540d6..bda33c8 100644 --- a/drivers/

[PATCH v3 8/8] Staging: bcm: Line length cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 276825f..bef13a6 100644 --- a/drivers/staging/bcm/I

[PATCH v3 3/8] Staging: bcm: Replaced member accessing with variable in device_run()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index dd7b4a5..e1a3e6d 100644 --- a/drivers/staging/bcm/Interf

[PATCH v3 7/8] Staging: bcm: Shortened some lines in select_alternate_setting_for_highspeed_modem()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 9f9045d..276825f 100644 --- a/drivers/

[PATCH v3 2/8] Staging: bcm: replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index d61a688..dd7b4a5 100644 --- a/drivers/staging/bcm/Interface

[PATCH v3 1/8] Staging: bcm: Shortened some lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 7c04c73..d61a688 100644 --- a/drivers/staging/bcm/InterfaceInit.c +++ b/

[PATCH v3 6/8] Staging: bcm: Outsourced selecting of alternate setting

This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 207 +++- 1 file changed, 112 insertions(+), 95 deletions(-) diff --

[PATCH] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue

Signed-off-by: Andrey Skvortsov --- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.

Eudyptula Challenge (Task 10)

Greetings Linux Kernel Developers! This is Task 10 of the Eudyptula Challenge. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c: fix coding style

Fix coding style issues detected by checkpatch.pl: 1. do not use assignment in if condition 2. line over 80 characters Signed-off-by: Wahib Faizi --- .../usbip/userspace/libsrc/usbip_host_driver.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/u

Re: [PATCH 06/22] staging: rtl8188eu: Instead of intf_hdl pass adapter in read & write functions

On Thu, Jun 12, 2014 at 1:13 PM, Dan Carpenter wrote: > On Wed, Jun 11, 2014 at 10:51:25PM +0530, navin patidar wrote: >> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c >> b/drivers/staging/rtl8188eu/core/rtw_io.c >> index a0a31e6..85306bf 100644 >> --- a/drivers/staging/rtl8188eu/core/rtw_

[PATCH] staging: iio: fix coding style

This patch fixes coding style errors reported by checkpatch.pl for lines that was over 80 chars long. The macro value shoud be put in () as well. Signed-off-by: Jimmy P --- drivers/staging/iio/frequency/ad5930.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/driv

Re: [PATCH 06/22] staging: rtl8188eu: Instead of intf_hdl pass adapter in read & write functions

On Wed, Jun 11, 2014 at 10:51:25PM +0530, navin patidar wrote: > diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c > b/drivers/staging/rtl8188eu/core/rtw_io.c > index a0a31e6..85306bf 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_io.c > +++ b/drivers/staging/rtl8188eu/core/rtw_io.c > @@ -57

[PATCHv2] staging: keucr: usb.c: add blank lines after declarations

From: Mathias Engan Add blank line after declarations in eucr_suspend and eucr_resume as reported by checkpatch. Signed-off-by: Mathias Engan --- drivers/staging/keucr/usb.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/keucr/usb.c b/drivers/staging/keucr/usb.c index

[PATCH 1/2] lustre/osc/osc_dev.c remove space between sizeof and open parenthesis

Signed-off-by: Honggang Li --- drivers/staging/lustre/lustre/osc/osc_dev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_dev.c b/drivers/staging/lustre/lustre/osc/osc_dev.c index a7c1ec0..5249e66 100644 --- a/drivers/stagin

[PATCH 0/2 linux-next] coding style clean up for lustre/osc/osc_dev.c

Patches clean up coding style issue of the file: linux-next/drivers/staging/lustre/lustre/osc/osc_dev.c Honggang Li (2): lustre/osc/osc_dev.c remove space between sizeof and open parenthesis lustre/osc/osc_dev.c add a blank line after declarations drivers/staging/lustre/lustre/osc/osc_dev.c

[PATCH 2/2] lustre/osc/osc_dev.c add a blank line after declarations

Signed-off-by: Honggang Li --- drivers/staging/lustre/lustre/osc/osc_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/lustre/lustre/osc/osc_dev.c b/drivers/staging/lustre/lustre/osc/osc_dev.c index 5249e66..048a5a5 100644 --- a/drivers/staging/lustre/lustre/osc/osc_dev