Re: [PATCH v3 00/05] staging: Emma Mobile USB driver and KZM9D board code V3

2014-06-08 Thread Magnus Damm
On Sat, Jun 7, 2014 at 12:39 AM, Greg KH wrote: > On Fri, Jun 06, 2014 at 07:44:08PM +0900, Magnus Damm wrote: >> staging: Emma Mobile USB driver and KZM9D board code V3 >> >> [PATCH v3 01/05] staging: emxx_udc: Add Emma Mobile USB Gadget driver >> [PATCH v3 02/05] staging: emxx_udc: I/O memory an

[PATCH] checkpatch: fix complex macro false positive for escaped constant char

2014-06-08 Thread Joe Perches
A single escaped constant char is not a complex macro. Signed-off-by: Joe Perches --- On Sun, 2014-06-08 at 23:12 +0900, Choi Gi-yong wrote: > diff --git a/drivers/staging/speakup/speakup_acntpc.c > b/drivers/staging/speakup/speakup_acntpc.c [] > @@ -35,7 +35,7 @@ [] > -#define PROCSPEECH '\r' >

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-08 Thread Ben Dooks
On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: > On 05/30/2014 07:33 PM, David Daney wrote: > >On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: > >>On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe > >>wrote: > >>>--- a/drivers/gpio/gpiolib.c > >>>+++ b/drivers/gpio/gpiolib.c

[PATCH] staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

2014-06-08 Thread Rickard Strandqvist
Array 'SigBuff' is filled incompletely. Someone forget to multiply for the sizeof type. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/bcm/nvm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

2014-06-08 Thread Rickard Strandqvist
Hi I think someone missed the count sizeof type in memcpy. I'm no expert on this code. But I wonder if also the the next for loop wrong? It will fill with 0XFF00 but it is not a complete 0X you're looking for? So something like: memset(&Buff[sigOffset], 0xFF, MAX_RW_S

Re: [PATCH 2/2] Staging: speakup: ERROR: Fix macro parenthesis.

2014-06-08 Thread Dan Carpenter
It looks like this patch is adding blank lines not parenthesis like the subject says. regards, dan carpenter On Sun, Jun 08, 2014 at 11:12:57PM +0900, Choi Gi-yong wrote: > Signed-off-by: Choi Gi-yong > --- > drivers/staging/speakup/speakup_acntpc.c | 5 - > 1 file changed, 4 insertions(+),

[PATCH 2/2] Staging: speakup: ERROR: Fix macro parenthesis.

2014-06-08 Thread Choi Gi-yong
Signed-off-by: Choi Gi-yong --- drivers/staging/speakup/speakup_acntpc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_acntpc.c b/drivers/staging/speakup/speakup_acntpc.c index 31f952b..f70b698 100644 --- a/drivers/staging/speakup/speakup

[PATCH v2 25/26] staging: rtl8188eu: Remove unused function nat25_handle_frame()

2014-06-08 Thread navin patidar
Signed-off-by: navin patidar --- V2: Restore sequence of source code compilation, sequence was changed by v1 of this patch. drivers/staging/rtl8188eu/core/rtw_br_ext.c| 61 drivers/staging/rtl8188eu/include/recv_osdep.h |1 - 2 files changed, 62 deletions(-)

[PATCH V2] Staging:tidspbridge Fix minor checkpatch.pl warning.

2014-06-08 Thread Adithya Krishnamurthy
From: Adithya Krishnamurthy Fixed checkpatch "WARNING: Missing a blank line after declarations" Signed-off-by: Adithya Krishnamurthy --- drivers/staging/tidspbridge/core/chnl_sm.c |1 + drivers/staging/tidspbridge/core/io_sm.c |1 + drivers/staging/tidspbridge/core/tioma

Re: [linux-nics] [PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-08 Thread Jeff Kirsher
On Sat, 2014-06-07 at 18:40 +0200, Ken Helias wrote: > From: Ken Helias > > All other add functions for lists have the new item as first argument > and the > position where it is added as second argument. This was changed for no > good > reason in this function and makes using it unnecessary conf