- dgap_tty_uninit() doesn't match dgap_tty_init() at all.
so rename it. It is just used for cleanup when this module is
exited or failed to initialize by dgap_init_module.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 7a07a9b..b331108 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@
Pass "brd" to dgap_after_config_loaded() instead of passing
"dgap_numboards" and looking up brd again.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dg
- Pass "dgap_numboards" to dgap_found_board() instead of
using a global variable.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index c78c
Remove some unnecessary parenthesis as recommended by checkpatch.pl.
Signed-off-by: Sam Bobroff
---
drivers/staging/rts5139/rts51x_scsi.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x_scsi.c
b/drivers/staging/rts5139/rts51x_scsi.c
On Mon, Jun 02, 2014 at 05:38:06PM -0700, Ovidiu Toader wrote:
> This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c
>
> The new version of the file pleases checkpatch.pl when run with "--ignore
> LONG_LINE".
>
Looks good. Thanks.
regards,
dan carpenter
___
Hello!
On Jun 2, 2014, at 11:57 PM, David Rientjes wrote:
> I'm pretty sure we want to allow users to restore the kernel default
> behavior if they've already written to this file and now want to change it
> back.
>
> What do you think about doing it like this instead?
> ---
> Documentation/sys
Hello!
On Jun 2, 2014, at 9:40 PM, David Rientjes wrote:
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 5dba293..91d0265 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -5854,7 +5854,7 @@ int percpu_pagelist_fraction_sysctl_handler(ctl_table
>> *table, int write,
>>
This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c
The new version of the file pleases checkpatch.pl when run with "--ignore
LONG_LINE".
Signed-off-by: Ovidiu Toader
---
Changes since v1:
* made commit brief description clearer
drivers/staging/media/rtl2832u_sdr/rtl28
On Mon, Jun 02, 2014 at 04:00:28PM -0700, Mitchel Humpherys wrote:
> What's the protocol for UAPI headers in staging drivers? Specifically,
> I'm wondering how people usually install those headers. For example,
> there are a bunch of Android UAPI headers under
> drivers/staging/android/uapi which c
What's the protocol for UAPI headers in staging drivers? Specifically,
I'm wondering how people usually install those headers. For example,
there are a bunch of Android UAPI headers under
drivers/staging/android/uapi which currently end up at
/drivers with a call to `make headers_install'. All
othe
2014-06-02 19:13 GMT+09:00 Dan Carpenter :
> On Mon, Jun 02, 2014 at 06:35:15PM +0900, DaeSeok Youn wrote:
>> Hi, Dan.
>>
>> 2014-06-02 16:30 GMT+09:00 Dan Carpenter :
>> > On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote:
>> >> The dgap_probe1() function is just calling dgap_found_boar
Hi
Okay, this code has been changed in linux-next, before the allocation
before the switch statement.
Yes, I repeat it to myself.. I'll check everything against linux-next
in the future!
Best regards
Rickard Strandqvist
2014-06-02 10:41 GMT+02:00 Dan Carpenter :
> On Sun, Jun 01, 2014 at 01:
The following changes since commit 4b660a7f5c8099d88d1a43d8ae138965112592c7:
Linux 3.15-rc6 (2014-05-22 06:42:02 +0900)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.15-rc8
for you to fetch changes up to 9326c5ca098
On Mon, Jun 02, 2014 at 12:50:35PM -0700, Ovidiu Toader wrote:
> On 06/02/14 03:21, Dan Carpenter wrote:
> > Send the patch inline, not as an attachment.
> >
> > Read the first paragraph.
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
> >
Fix a style issue reported by checkpatch.pl for the Eudyptula challenge
Signed-off-by: Wolfgang Ocker
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
inde
Hi
I mail about this for the first time in early May, but ther were many
other faults in the design of my patch then, had several different
types of errors in the same path etc.
So good that someone was inspired to make a real patch of it even then :)
And i'm getting the linux-next to check bef
Hi Dan!
Now this is a bad example because there is nothing really wrong, and I
could not find the original error log :-(
But i get for the testing variable:
drivers/staging/rtl8192u/r8192U_core.c : 4747] : (style) Variable
'testing' is assigned a value that is never used.
And for the this fi
On 06/02/14 03:21, Dan Carpenter wrote:
> Send the patch inline, not as an attachment.
>
> Read the first paragraph.
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
>
> The subject should say something about adding blank lines.
Thanks for th
On 06/02/2014 03:30 AM, Dan Carpenter wrote:
> On Sun, Jun 01, 2014 at 07:26:18PM -0700, Thomas Wood wrote:
>> Don't use spaces as tabs, and fix other style errors and warnings.
>>
>> Signed-off-by: Thomas Wood
>
> Too much in one patch. Break it up into one type of fix per patch and
> send a
On Mon, Jun 02, 2014 at 07:05:01PM +0200, Federico Di Pierro wrote:
> - else {
> + } else {
> ret = -EINVAL;
> break;
> }
>
>
> Signed-off-by: Federico Di Pierro
This goes after the changelog and before the diff.
James,
On Sun, Jun 01, 2014 at 08:07:35PM -0400, James A Shackleford wrote:
> This patch fixes the following sparse warnings:
>
> skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should
> it be static?
> skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared.
On 02/06/14 18:05, Federico Di Pierro wrote:
Hi!
This is my latest task of the eudyptula challenge.
Just a very small patch! It fixes 3 little coding style problems.
I'm using linux-next.
Fair enough, but you need to spend a little time working
on the 'how' of your patch submission.
See Document
On Mon, 2014-06-02 at 19:05 +0200, Federico Di Pierro wrote:
> Hi!
Hello Federico.
> This is my latest task of the eudyptula challenge.
Your patch subject should be something like:
[PATCH] staging: iio: kernel style neatening
> Just a very small patch! It fixes 3 little coding style problems.
On Tue, Jun 3, 2014 at 1:05 AM, Federico Di Pierro wrote:
> Hi!
> This is my latest task of the eudyptula challenge.
> Just a very small patch! It fixes 3 little coding style problems.
> I'm using linux-next.
Hi, Federico,
It's awesome you taking part in eudyptula challenge program. That is a
go
Hi!
This is my latest task of the eudyptula challenge.
Just a very small patch! It fixes 3 little coding style problems.
I'm using linux-next.
--- linux/drivers/staging/iio/frequency/ad9832.c.orig 2014-06-02
17:26:12.929978122 +0200
+++ linux/drivers/staging/iio/frequency/ad9832.c2014-0
On Mon, Jun 02, 2014 at 06:36:22PM +0200, Philipp Zabel wrote:
> Am Mittwoch, den 28.05.2014, 14:13 -0700 schrieb Greg Kroah-Hartman:
> > On Mon, May 26, 2014 at 04:19:39PM +0200, Philipp Zabel wrote:
> > > The i.MX Image Processing Unit (IPU) contains a number of image processing
> > > blocks that
Am Mittwoch, den 28.05.2014, 14:13 -0700 schrieb Greg Kroah-Hartman:
> On Mon, May 26, 2014 at 04:19:39PM +0200, Philipp Zabel wrote:
> > The i.MX Image Processing Unit (IPU) contains a number of image processing
> > blocks that sit right in the middle between DRM and V4L2. Some of the
> > modules
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..ceb06d8 10
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
This patch fixes line lengths in the
drivers/staging/bcm/InterfaceMisc.c
file.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceMisc.c | 98 +
1 file changed, 67 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc
On Mon, Jun 02, 2014 at 11:08:00AM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer
The information you put in the 0/1 message should be here in the
changelog entry.
And for a single patch, you don't need a 0/1 message, just send the
patch itself.
Care to fix this up and resend?
th
On Sat, 2014-05-24 at 18:19 +1000, Vitaly Osipov wrote:
> This patch removes all usage of _malloc() and the function itself. Most
> uses are straightforward replacements by kmalloc(..., GFP_ATOMIC),
> because this was the definition of _malloc(). In a few places it
> was possible to use kzalloc() o
This patch fixes the following sparse warnings for
drivers/staging/lustre/lnet/lnet/router.c:
router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared.
Should it be static?
router.c:277:1: warning: symbol 'lnet_add_route_to_rnet' was not declared.
Should it be static?
Signed-of
On Mon, Jun 02, 2014 at 03:19:18PM +0300, Dan Carpenter wrote:
>
> Why not just make them static? They don't seem to be used outside of
> that file. What am I missing?
>
Given a 50/50 choice I based my decision on the surrounding functions which
were mostly defined in the header file.
I shou
An issue was observed when a userspace task exits.
The page which hits error here is the zero page.
In binder mmap, the whole of vma is not mapped.
On a task crash, when debuggerd reads the binder regions,
the unmapped areas fall to do_anonymous_page in handle_pte_fault,
due to the absence of a vm_
On Mon, Jun 02, 2014 at 01:03:48PM +0100, John Church wrote:
> This patch fixes the following sparse warnings for
> drivers/staging/lustre/lnet/lnet/router.c:
>
> router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared.
> Should it be static?
> router.c:277:1: warning: symbol 'l
This patch fixes the following sparse warnings for
drivers/staging/lustre/lnet/lnet/router.c:
router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared.
Should it be static?
router.c:277:1: warning: symbol 'lnet_add_route_to_rnet' was not declared.
Should it be static?
Signed-of
On Sun, Jun 01, 2014 at 07:26:18PM -0700, Thomas Wood wrote:
> Don't use spaces as tabs, and fix other style errors and warnings.
>
> Signed-off-by: Thomas Wood
Too much in one patch. Break it up into one type of fix per patch and
send a series of patches.
[patch 1] use tabs
[patch 2] fix brace
On Sun, Jun 01, 2014 at 01:00:17PM -0700, Ovidiu Toader wrote:
> motivation: eudyptula challenge
>
> This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c
>
> The new version of the file pleases checkpatch.pl when run with
> "--ignore LONG_LINE".
>
> Signed-off-by: Ovidiu T
On Mon, Jun 02, 2014 at 06:35:15PM +0900, DaeSeok Youn wrote:
> Hi, Dan.
>
> 2014-06-02 16:30 GMT+09:00 Dan Carpenter :
> > On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote:
> >> The dgap_probe1() function is just calling dgap_found_board().
> >> So it is removed and dgap_found_board()
[ I am writing this at the end after writing the rest of this email.
After looking at the CP_TO_USR() macro more carefully, I realize that
the uninitialized variable bugs you are fixing are false positives.
The information leaks where the max size is not capped are real
security bugs.
T
Mark Einon writes:
> On Mon, Jun 02, 2014 at 10:26:42AM +0200, Bjørn Mork wrote:
>> Removing a build generated file.
>>
>> Cc: Mark Einon
>> Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock")
>> Signed-off-by: Bjørn Mork
>
> Hi Bjørn,
>
> Unfortunately this issue has
On Mon, Jun 02, 2014 at 10:26:42AM +0200, Bjørn Mork wrote:
> Removing a build generated file.
>
> Cc: Mark Einon
> Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock")
> Signed-off-by: Bjørn Mork
Hi Bjørn,
Unfortunately this issue has already been fixed by someone els
2014-06-02 17:00 GMT+09:00 Dan Carpenter :
> On Mon, Jun 02, 2014 at 02:14:47PM +0900, Daeseok Youn wrote:
>> Adds a label for "kfree(brd)". And also remove
>> a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
>> Because "brd" will free after failure.
>>
>> Signed-off-by: Daeseok
Hi, Dan.
2014-06-02 16:30 GMT+09:00 Dan Carpenter :
> On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote:
>> The dgap_probe1() function is just calling dgap_found_board().
>> So it is removed and dgap_found_board() is called directly.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> RESEND :
On Sun, Jun 01, 2014 at 03:23:40PM +0200, Rickard Strandqvist wrote:
> There is a risk that the variable will be used without being initialized.
>
> This was largely found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
Someone already sent thi
Hi,
this is a patch which fixes the line length in the
drivers/staging/bcm/InterfaceMisc.c
file.
Regards,
Matthias Beyer
Matthias Beyer (1):
Staging: bcm: Shortened lines
drivers/staging/bcm/InterfaceMisc.c | 98 +
1 file changed, 67 insertions(+), 3
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceMisc.c | 98 +
1 file changed, 67 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.c
b/drivers/staging/bcm/InterfaceMisc.c
index 4173fd7..e001f2a 100644
--- a/drivers/
These all look great. Thanks. :)
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Removing a build generated file.
Cc: Mark Einon
Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock")
Signed-off-by: Bjørn Mork
---
drivers/staging/et131x/Module.symvers | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 drivers/staging/et131x/Modul
On Sun, Jun 01, 2014 at 01:30:43PM +0200, Rickard Strandqvist wrote:
> There is a risk for memory leak in when something unexpected happens
> and the function returns.
>
> This was largely found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
>
On Mon, Jun 02, 2014 at 02:14:47PM +0900, Daeseok Youn wrote:
> Adds a label for "kfree(brd)". And also remove
> a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
> Because "brd" will free after failure.
>
> Signed-off-by: Daeseok Youn
> Reviewed-by: Dan Carpenter
> ---
> RESE
On Mon, Jun 02, 2014 at 02:08:24PM +0900, Daeseok Youn wrote:
> @@ -4177,12 +4183,46 @@ static int dgap_tty_register_ports(struct board_t
> *brd)
> brd->print_driver,
> brd->firstminor + i, NULL);
Btw, the "brd->firstmino
On Sun, Jun 01, 2014 at 11:05:39PM +0200, Rickard Strandqvist wrote:
> Hi Dan
>
> I agree, this looks strange.
> Have been looking for a while in history with, to see if the code has
> been removed. I start my search using cppcheck for over three months
> ago.
> But could not find anything. Sorry
On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote:
> The dgap_probe1() function is just calling dgap_found_board().
> So it is removed and dgap_found_board() is called directly.
>
> Signed-off-by: Daeseok Youn
> ---
> RESEND : this patch is included into newly serise of patches
> so re
58 matches
Mail list logo
