Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit :
> Setting a 'silent' parameter without a synth would crash the kernel.
>
> Signed-off-by: Sasha Levin
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/synth.c |3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/dri
ION system heap keeps pages in its pool for better performance. When the
system is under memory pressure, slab shrinker calls the callback
registered and then the pages pooled get freed.
When the shrinker is called, it checks gfp_mask and determines whether
the pages from highmem need to be freed
ION system heap uses an internal data structure, struct page_info, for
tracking down the meta information of the pages allocated from the pool.
Now that the pool returns compound pages, we don't need to store page
order in struct page_info.
Signed-off-by: Heesub Shin
---
drivers/staging/android/
struct ion_system_heap has an array for storing pointers to page pools
and it is allocated separately from the containing structure. There is
no point in allocating those two small objects individually, bothering
slab allocator. Using a variable length array simplifies code lines and
reduces overhe
ION system heap creates a temporary list of pages to build
scatter/gather table, introducing an internal data type, page_info. Now
that the order field has been removed from it, we do not need to depend
on such data type anymore.
Signed-off-by: Heesub Shin
---
drivers/staging/android/ion/ion_sys
Now that the pages returned from the pool are compound pages, we do not
need to pass the order information to free_buffer_page().
Signed-off-by: Heesub Shin
---
drivers/staging/android/ion/ion_system_heap.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/stag
The page pool uses an internal data structure, ion_page_pool_item, for
wrapping pooled pages and constructing a list. As the struct page
already provides ways for doing exactly the same thing, we do not need
to reinvent the wheel. This commit removes the data structure and slab
allocations for it.
Hi,
Here is my patchset with some modification, hoping reviews or comments
from you guys.
v2:
o No changes in the code, just reworded changelog
o Reorder patch
Heesub Shin (9):
staging: ion: tidy up a bit
staging: ion: simplify ion_page_pool_total()
staging: ion: remove struct ion_page_
For aesthetics and readability, rename goto labels, remove
useless code lines, and clarify function return type.
Signed-off-by: Heesub Shin
---
drivers/staging/android/ion/ion_page_pool.c | 2 +-
drivers/staging/android/ion/ion_priv.h| 2 +-
drivers/staging/android/ion/ion_system_hea
Using compound pages relieves burden on tracking the meta information
which are currently stored in page_info.
Signed-off-by: Heesub Shin
---
drivers/staging/android/ion/ion_page_pool.c | 4 +++-
drivers/staging/android/ion/ion_system_heap.c | 2 +-
2 files changed, 4 insertions(+), 2 deletion
ion_page_pool_total() returns the total number of pages in the pool.
Depending on the argument passed, it counts highmem pages in or not.
This commit simplifies the code lines for better readability.
Signed-off-by: Heesub Shin
---
drivers/staging/android/ion/ion_page_pool.c | 10 +-
1 fi
On 05/28/2014 01:16 AM, Radim Krčmář wrote:
> We try to free two pages when only one has been allocated.
> Cleanup path is unlikely, so I haven't found any trace that would fit,
> but I hope that free_pages_prepare() does catch it.
>
> Cc: sta...@vger.kernel.org
> Signed-off-by: Radim Krčmář
> ---
On Tue, May 27, 2014 at 11:34 AM, Ian Abbott wrote:
> On 2014-05-24 23:24, Chase Southwood wrote:
>>
>> This board supports an interrupt that can be generated by an AND/OR
>> combination of 16 of the input channels.
>>
>> Create a separate subdevice to handle this interrupt.
>>
>> In doing this, t
On Tue, May 27, 2014 at 07:16:20PM +0200, Radim Krčmář wrote:
> We try to free two pages when only one has been allocated.
> Cleanup path is unlikely, so I haven't found any trace that would fit,
> but I hope that free_pages_prepare() does catch it.
>
> Cc: sta...@vger.kernel.org
> Signed-off-by:
Hi,
2014-05-28 5:28 GMT+09:00 Chaitanya Hazarey :
> Hey DaeSeok,
>
> I fixed all of them except -
>
> this "if" condition like below:
> if (5 == wrqu->encoding.length || 13 == wrqu->encoding.length)
> mask = 0x00;
> and this should be outside "for" loop
>
> Can you please elaborate on this?
Hi, Dan.
2014-05-27 19:20 GMT+09:00 Dan Carpenter :
> The "brd->nasync = 0;" was wrong, yes, but my main complaint was that
> you are writing complicated error handling. This v2 patch makes the
> error handling even more complicated. If dgap_tty_init() fails it
> should free the things it alloca
Setting a 'silent' parameter without a synth would crash the kernel.
Signed-off-by: Sasha Levin
---
drivers/staging/speakup/synth.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index 0b3549b..172cf62 100644
--- a/driv
Great. Thanks.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Added spaces needed in the proper places to address:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ';' (ctx:VxV)
ERROR: space required after that close brace '}'
ERROR: space required before the open brace '{'
ERROR: space required before the open parenthesis '('
Signed-off-by: Marcin Kostrzewa
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
index 20e89
The subject should be:
[PATCH] Staging: comedi: addi-data:
On Tue, May 27, 2014 at 02:17:35PM +, Marcin Kostrzewa wrote:
> Signed-off-by: Marcin Kostrzewa
> ---
> drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> dif
Signed-off-by: Marcin Kostrzewa
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
index 20e89b0
Well, it is what it is, will send the patch the right way.
Best,
Chaitanya
On Tue, May 27, 2014 at 1:39 PM, Dan Carpenter wrote:
> On Tue, May 27, 2014 at 01:09:45PM -0700, Chaitanya Hazarey wrote:
>> Fixed the following:
>>
>> ERROR: do not use C99 // comments
>> ERROR: space required after th
On Tue, May 27, 2014 at 11:36:07AM -0700, Mitchel Humpherys wrote:
> On Mon, May 26 2014 at 03:04:58 AM, Heesub Shin
> wrote:
> > -static struct page_info *alloc_largest_available(struct ion_system_heap
> > *heap,
> > -struct ion_buffer *buffer,
> > -
This one as well would have been easier to review if you folded patches
7-10 together.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
These would have been easier to review if this patch were folded in with
the previous two patches. What I look for in these patches is, "Will
the compile break if you get it wrong?"
For "[PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to
padapter->chip_type directly", you could get it wrong and
On Tue, May 27, 2014 at 01:09:45PM -0700, Chaitanya Hazarey wrote:
> Fixed the following:
>
> ERROR: do not use C99 // comments
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ';' (ctx:VxV)
> ERROR: space required before the open brace '{'
> ERROR: spaces requir
Hey DaeSeok,
I fixed all of them except -
this "if" condition like below:
if (5 == wrqu->encoding.length || 13 == wrqu->encoding.length)
mask = 0x00;
and this should be outside "for" loop
Can you please elaborate on this?
Thanks,
Chaitanya
On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn
Thanks. :)
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Cleaned up dead code, added curly {} braces where needed
and fixed the following:
ERROR: do not use C99 // comments
ERROR: else should follow close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: spaces required around that '=
Cleaned up dead code, added curly {} braces where needed
and fixed the following:
ERROR: do not use C99 // comments
ERROR: else should follow close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: spaces required around that '=
Cleaned up dead code, added curly {} braces where needed
and fixed the following:
ERROR: do not use C99 // comments
ERROR: else should follow close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: spaces required around that '=
Cleaned up dead code, added curly {} braces where needed
and fixed the following:
ERROR: do not use C99 // comments
ERROR: else should follow close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: spaces required around that '=
Fixed the following:
ERROR: do not use C99 // comments
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ';' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERR
Cleaned up dead code, added curly {} braces where needed
and fixed the following:
ERROR: do not use C99 // comments
ERROR: else should follow close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open brace '{'
ERROR: spaces required around that '=
On Tue, May 27, 2014 at 11:52 AM, Greg Kroah-Hartman
wrote:
> On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
>> For aesthetics and readability, rename goto labels, remove
>> useless code lines, and clarify function return type.
>>
>> Signed-off-by: Heesub Shin
>> ---
>> drivers/sta
On Tue, May 27, 2014 at 09:05:43PM +0530, navin patidar wrote:
> Signed-off-by: navin patidar
> ---
> drivers/staging/rtl8712/osdep_service.h |6 --
> 1 file changed, 6 deletions(-)
This is the rtl8712 driver, not the rtl8188eu driver.
And this patch causes a build error.
Please ALWAYS
On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
> For aesthetics and readability, rename goto labels, remove
> useless code lines, and clarify function return type.
>
> Signed-off-by: Heesub Shin
> ---
> drivers/staging/android/ion/ion_page_pool.c | 2 +-
> drivers/staging/androi
On Mon, May 26 2014 at 03:04:59 AM, Heesub Shin wrote:
> Not that the pages returned from the pool are compound pages, we do not
> need to pass the order information to free_buffer_page().
s/Not/Now/
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Li
On Mon, May 26 2014 at 03:04:58 AM, Heesub Shin wrote:
> ION system heap uses a temporary list holding meta data on pages
> allocated to build scatter/gather table. Now that the pages are compound
> pages, we do not need to introduce a new data type redundantly.
>
> Signed-off-by: Heesub Shin
> -
On 05/27/2014 12:27 PM, Jim Davis wrote:
Building with the attached random configuration file,
A problem with the build when PCI is not selected was reported yesterday. I
think this build error is caused by MAC80211 not being selected. The fix for
both problems was merged as commit 42e4c20f11
Hey there,
Thanks for looking into this,
Will be sending out the modified version soon.
Thanks,
Chaitanya
On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn wrote:
> Hi,
>
> 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey :
>> Fixed the following:
>>
>> ERROR: do not use C99 // comments
>> ERROR: el
This member of the private data is just a copy of the channels from
the cmd->chanlist. Remove the member and just use the cmd->chanlist
directly.
Remove the unneeded 'len' local variable in usbduxsigma_ao_urb_complete().
This is just the cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ia
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Remove the unnecessary local variables used for the cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/
This member of the private data can be determined from the cmd->stop_src.
Do that instead and remove the member.
Refactor pcmmio_handle_dio_intr() to remove an indent level.
For aesthetics, change the switch in pcmmio_cmd() to an if/else.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Gre
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/driver
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das16.c
b/driver
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 17 +
1 file changed, 9 insertions(+), 8 d
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/st
The caller already has the comedi_subdevice and comedi_cmd pointers. Pass
those variables to the helper function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 10 ++
1 file changed, 6 insertions(+), 4 deletion
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl816.c
b/driver
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_isadma.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(
Tidy up the local variables so that the comedi_cmd is accessed as a pointer
instead of getting to it from the comedi_subdevice pointer.
Remove the local variable 'len' and use the cmd->chanlist_len directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/st
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_fc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Factor the fifo half-full handling out of the interrupt function to reduce
the indent level of the code.
Tidy up the factored out code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 128 +--
1
Use the local variable to access the comedi_cmd as a pointer in
pci224_ao_munge() instead of getting to it from the comedi_async
pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 4 ++--
1 file changed, 2 inserti
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
The (*do_cmdtest) validates that the 'stop_arg' is >= 1 for a 'stop_src'
of TRIG_COUNT and the 'scan_end_arg' is validated to be the 'chanlist_len'
which will always be >= 1. Remove the unreachable error code for an
'ai_sample_count < 1'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
THe comedi core ensures that the chanlist will be valid for any async operation
other than Step 1 of the (*do_cmdtest) to get the trigger source masks.
Remove the unnecessary checks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ampl
This member of the private data can be determined from the
cmd->stop_src. Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das800.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
This series continues the cleanup of the comedi driver async command support.
H Hartley Sweeten (38):
staging: comedi: usbdux: remove 'ai_continuous' from private data
staging: comedi: usbdux: remove 'ao_continuous' from private data
staging: comedi: usbduxfast: remove 'ai_continuous' from p
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/s
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 10 ++
1 file changed, 6 insertions(+), 4 deletio
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/s
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl711.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
The calculation for the total number of bytes in the DMA transfer
is incorrect. Fix it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/come
Use the comedi_fc helper function to get the 'bytes_per_scan'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pc
Use the 'cmd' pointer to access the chanlist instead of getting to it
using the comedi_subdevice pointer.
Remove the unneeded 'n' local variable, this is just the cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdu
This function does not use the comedi_cmd. Remove the commented out
local variable.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_65xx.c
b
The cmd->chanlist_len will always be >= 1 in this function. Remove the
unnecessary checks.
Use the comedi_fc helper function to get the 'bytes_per_scan'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 11 ++-
Tidy up the local variables so that the comedi_cmd is accessed as a pointer
instead of getting to it from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 14 ++
1 file changed, 6 insertions
This member of the private data is just a copy of the channels from
the cmd->chanlist. Remove the member and just use the cmd->chanlist
directly.
Remove the unneeded 'len' local variable in usbdux_ao_isoc_irq().
This is just the cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
For aesthetics, use a local variable to access the comedi_cmd as a
pointer in das800_ai_do_cmd() instead of getting to it from the
comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das800.c | 15 ---
1 fi
Use the local variable to access the comedi_cmd as a pointer in
pci230_handle_ai() instead of getting to it from the comedi_async
pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 6 +++---
1 file changed, 3 inse
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
Use the local variable to access the comedi_cmd as a pointer
in dio200_read_scan_intr() instead of getting to it from the
comedi_subdevice pointer.
Remove the unnecessary local variable 'len', this is just the
cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Har
Use the comedi_fc helpers to validate the timer arguments.
This is a repost of a series that Ian Abbott has already reviewed. I have
udated his sign off on all the patches.
H Hartley Sweeten (23):
staging: comedi: adl_pci9111: use comedi_fc helpers to validate timer args
staging: comedi: adv_
We try to free two pages when only one has been allocated.
Cleanup path is unlikely, so I haven't found any trace that would fit,
but I hope that free_pages_prepare() does catch it.
Cc: sta...@vger.kernel.org
Signed-off-by: Radim Krčmář
---
Cc'd stable because the worst-case looks hard to debug.
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
For aesthetics, rename the local variable 'tmp' to 'arg'.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
cmd->scan_begin_arg for the scan_begin_src TRIG_TIMER. Pass the local
variable to dt2k_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer w
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate
the cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local
variable to i8253_cascade_ns_to_timer() instead of the cmd argument.
This value is modified by that function to return the actual time
(in nanoseconds) that the time
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
arguments for the TRIG_TIMER command sources. Pass the local variable to
i8253_cascade_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer w
1 - 100 of 154 matches
Mail list logo
