Remove a prohibited space before a closed parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/
From: "Son P. Nguyen"
Fixed reporting_keystroke type to int instead of bool to quiet sparse
complaints of error cannot size expression.
This is a part of eudyptula-challenge.
Signed-off-by: Son P. Nguyen
---
drivers/staging/speakup/fakekey.c | 6 +++---
1 file changed, 3 insertions(+), 3 dele
Add a required space before an open parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_t
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
> - alloc_tty_driver() is deprecated so it is changed to
> tty_alloc_driver()
> - Pointers which are allocated by alloc_tty_driver() and kzalloc()
> can be NULL so it need to check NULL for them.
> - If one of those is failed, it need to
Renamed convert_frame_to_ether() to p80211_convert_to_ether().
Signed-off-by: Denis Pithon
---
drivers/staging/wlan-ng/p80211netdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
b/drivers/staging/wlan-ng/p80211netdev.c
index 6
Wherever possible, replaced printk() and pr_xxx() calls with
netdev_xxx() / dev_xxx() calls; used pr_xxx() otherwise.
Signed-off-by: Denis Pithon
---
drivers/staging/wlan-ng/p80211netdev.c | 45 +-
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/dr
Gathered together comments in front of multicast filtering block.
Signed-off-by: Denis Pithon
---
drivers/staging/wlan-ng/p80211netdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
b/drivers/staging/wlan-ng/p80211netdev.c
inde
Replaced generic memcmp() with dedicated ether_addr_equal_unaligned()
call. I did not find any clue of u16 alignment for both addresses.
Signed-off-by: Denis Pithon
---
drivers/staging/wlan-ng/p80211netdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wl
Used is_multicast_ether_addr() to perform the checking.
Signed-off-by: Denis Pithon
---
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
b/drivers/staging/wlan-ng/p80211netdev.c
index 13fe068..63edc
On Fri, May 16, 2014 at 11:26:37AM +0300, Eli Billauer wrote:
>
> Signed-off-by: Eli Billauer
> ---
> Documentation/driver-model/devres.txt |2 ++
> include/asm-generic/pci-dma-compat.h | 17 +
> 2 files changed, 19 insertions(+), 0 deletions(-)
The patch looks fine to me
Hello,
On Fri, May 16, 2014 at 11:26:36AM +0300, Eli Billauer wrote:
> +dma_addr_t dmam_map_single(struct device *dev, void *ptr, size_t size,
> +enum dma_data_direction direction)
> +
> +{
> + struct dma_devres *dr;
> + dma_addr_t dma_handle;
> +
> + dr = devre
On Fri, May 16, 2014 at 11:26:35AM +0300, Eli Billauer wrote:
> devm_get_free_pages() and devm_free_pages() are the managed counterparts
> for __get_free_pages() and free_pages().
>
> Signed-off-by: Eli Billauer
Acked-by: Tejun Heo
Thanks.
--
tejun
___
> -Original Message-
> From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev-
> devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan
> Sent: Friday, May 16, 2014 12:29 PM
> To: James Bottomley; Ian Abbott
> Cc: Andy Whitcroft; de...@linuxdriverproject.org; Hai
On Fri, 16 May 2014 15:06:46 +0300, Dan Carpenter
wrote:
> On Fri, May 16, 2014 at 07:57:08AM -0400, Mark Hounschell wrote:
> > On 05/16/2014 07:52 AM, Mark Hounschell wrote:
> > > On 05/15/2014 06:49 PM, Dan Carpenter wrote:
> > >> On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer w
> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Friday, May 16, 2014 11:25 AM
> To: Ian Abbott
> Cc: linux-s...@vger.kernel.org; de...@linuxdriverproject.org; Andy
> Whitcroft; KY Srinivasan; Haiyang Zhang; Tim Gardner
> Subject: Re: [PA
On Mon, Apr 28, 2014 at 01:50:11PM -0500, Junsu Shin wrote:
> Fixed following coding style issues.
> - No space is necessary after a cast
> - Alignment should match open parenthesis
> - Braces {} should be used on all arms of this statement
You are doing 3 things, so this should be 3 patches at
On Fri, May 16, 2014 at 10:08:07AM -0500, Larry Finger wrote:
> Greg,
>
> This E-mail is to prepare you for a new Realtek RTL8192EE driver that I
> intend to submit early next week. I hope it will be in time for kernel 3.16.
Sounds good, feel free to send it anytime, a new stand-alone staging
dri
On Fri, 2014-05-16 at 19:18 +0100, Ian Abbott wrote:
> On 2014-05-16 18:58, James Bottomley wrote:
> > On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote:
> >> On 2014-05-16 18:14, James Bottomley wrote:
> >>> On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
> From: Andy Whitcroft
>
On 2014-05-16 18:58, James Bottomley wrote:
On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote:
On 2014-05-16 18:14, James Bottomley wrote:
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
From: Andy Whitcroft
Suggested-by: James Bottomley
That is my patch, isn't it, just with a slig
On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote:
> On 2014-05-16 18:14, James Bottomley wrote:
> > On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
> >> From: Andy Whitcroft
> >>
> >> Suggested-by: James Bottomley
> >
> > That is my patch, isn't it, just with a slightly modified comment:
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
> From: Andy Whitcroft
>
> BugLink: http://bugs.launchpad.net/bugs/1234417
This is a pretty low quality bug report; where's the analysis that
should be in your patch?
The problem is, is it not, that when you turn on trim we now also probe
for
On 2014-05-16 18:14, James Bottomley wrote:
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
From: Andy Whitcroft
Suggested-by: James Bottomley
That is my patch, isn't it, just with a slightly modified comment:
http://marc.info/?l=linux-scsi&m=137908428211951
I believe so, yes. Look
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
> From: Andy Whitcroft
>
> Suggested-by: James Bottomley
That is my patch, isn't it, just with a slightly modified comment:
http://marc.info/?l=linux-scsi&m=137908428211951
Andy promised to go off and test it and that's where the thread end
On Fri, May 16, 2014 at 04:39:07PM +0100, Ian Abbott wrote:
> From: Andy Whitcroft
>
> Suggested-by: James Bottomley
> Signed-off-by: Andy Whitcroft
You should be signing these as well.
regards,
dan carpenter
___
devel mailing list
de...@linuxdrive
These changes to the Microsoft Hyper-V storage driver in Ubuntu Saucy's
3.13 kernel look useful for the mainline kernel, especially as they
enable 'TRIM' support.
Andy Whitcroft (2):
scsi: hyper-v storvsc switch up to SPC-3
scsi: hyper-v storvsc -- host takes MAINTENANCE_IN commands badly --
From: Andy Whitcroft
Suggested-by: James Bottomley
Signed-off-by: Andy Whitcroft
---
Original patch title changed slightly by Ian Abbott
due to typo.
---
drivers/scsi/storvsc_drv.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_dr
From: Andy Whitcroft
BugLink: http://bugs.launchpad.net/bugs/1234417
Signed-off-by: Andy Whitcroft
Signed-off-by: Tim Gardner
---
Original patch title was "UBUNTU: SAUCE: storvsc -- host takes
MAINTENANCE_IN commands badly elide them". Changed by Ian Abbott
---
drivers/scsi/storvsc_drv.c | 2
Greg,
This E-mail is to prepare you for a new Realtek RTL8192EE driver that I intend
to submit early next week. I hope it will be in time for kernel 3.16.
This device is incorporated in the recently introduced Lenovo T440s tablet, and
from the correspondence that I have received, there have b
On Fri, May 16, 2014 at 12:52:47PM +0300, Dan Carpenter wrote:
> On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote:
> > Hi,
> >
> > This patch haven't been updated over the past 3 weeks.
> > Will you check for me?
>
> Greg was trying to travel around the world in one month like Jackie
Jim Davis writes:
> Building with the attached random configuration file,
>
> drivers/staging/rtl8723au/core/rtw_cmd.c: In function ‘c2h_evt_hdl’:
> drivers/staging/rtl8723au/core/rtw_cmd.c:1315:4: error: implicit declaration
> of
> function ‘c2h_handler_8723a’ [-Werror=implicit-function-declarat
Export of symbols statement must be placed right after the definition to meet
kernel coding style guidelines. This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
//
@ r @ identifier f; @@
- EXPORT_S
Add Mark Hounschell to the MAINTAINERs list for the dgap driver
Signed-off-by: Mark Hounschell
Suggested-by: Dan Carpenter
Cc: Greg Kroah-Hartman
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index da68679..c9be346 100644
--- a/MAINTAINERS
+++ b/
On Fri, May 16, 2014 at 07:57:08AM -0400, Mark Hounschell wrote:
> On 05/16/2014 07:52 AM, Mark Hounschell wrote:
> > On 05/15/2014 06:49 PM, Dan Carpenter wrote:
> >> On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
> >>> Hi,
> >>>
> >>> As I got a bit queued up for dgap, I ju
On 05/16/2014 07:52 AM, Mark Hounschell wrote:
> On 05/15/2014 06:49 PM, Dan Carpenter wrote:
>> On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
>>> Hi,
>>>
>>> As I got a bit queued up for dgap, I just noticed that commit 542f3d5a
>>> states
>>> to add Mark to the maintainer
On Fri, May 16, 2014 at 07:52:53AM -0400, Mark Hounschell wrote:
> On 05/15/2014 06:49 PM, Dan Carpenter wrote:
> > On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
> >> Hi,
> >>
> >> As I got a bit queued up for dgap, I just noticed that commit 542f3d5a
> >> states
> >> to ad
On 05/15/2014 06:49 PM, Dan Carpenter wrote:
> On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
>> Hi,
>>
>> As I got a bit queued up for dgap, I just noticed that commit 542f3d5a states
>> to add Mark to the maintainers list for dgap, while the patch addresses the
>> dgnc entr
2014-05-16 18:52 GMT+09:00 Dan Carpenter :
> On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> This patch haven't been updated over the past 3 weeks.
>> Will you check for me?
>
> Greg was trying to travel around the world in one month like Jackie
> Chan. http://www.imdb.
On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote:
> Hi,
>
> This patch haven't been updated over the past 3 weeks.
> Will you check for me?
Greg was trying to travel around the world in one month like Jackie
Chan. http://www.imdb.com/title/tt0327437/ He is back to work since
yester
Hi,
This patch haven't been updated over the past 3 weeks.
Will you check for me?
Regards,
Daeseok Youn.
2014-04-28 8:21 GMT+09:00 DaeSeok Youn :
> OK. I'll make my patch based on Mark's patch.
> Thanks.
>
> Daeseok Youn.
>
> 2014-04-27 3:48 GMT+09:00 Dan Carpenter :
>> On Sat, Apr 26, 2014 at
The "devs" is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as empty string.
So "devs" cannot be NULL, removes NULL check for "devs".
Signed-off-by: Daeseok Youn
---
V2: remove unneeded lines for sending a patch.
drivers/staging/ozwpan/ozproto.c |2 +-
1 files changed, 1
Hi, Dan
2014-05-16 18:03 GMT+09:00 Dan Carpenter :
> On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
>> >From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn
>> Date: Fri, 16 May 2014 17:02:04 +0900
>> Subject: [PATCH] staging: ozwpan: remove
On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
> >From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn
> Date: Fri, 16 May 2014 17:02:04 +0900
> Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
>
Your patches before were
This patchset consists of new functions to the managed device resource
API, followed by patches for the Xillybus driver that now relies on these.
Rationale: While migrating the staging/xillybus driver to rely completely on
managed resources, some functionalities were missing, and hence added:
* d
Managed device resource API replaces code that reinvents it for memory
allocation, page allocation and DMA mapping.
Suggested-by: Baruch Siach
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus.h | 31 +--
drivers/staging/xillybus/xillybus_core.c | 160 ---
devm_get_free_pages() and devm_free_pages() are the managed counterparts
for __get_free_pages() and free_pages().
Signed-off-by: Eli Billauer
---
Documentation/driver-model/devres.txt |2 +
drivers/base/devres.c | 76 +
include/linux/device.h
dmam_map_single() and dmam_unmap_single() are the managed counterparts
for the respective dma_* functions.
Note that dmam_map_single() returns zero on failure, and not a value to
be handled by dma_mapping_error(): The error check is done by
dmam_map_single() to avoid the registration of a mapping
Suggested-by: Baruch Siach
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus.h |1 -
drivers/staging/xillybus/xillybus_core.c |2 +-
drivers/staging/xillybus/xillybus_of.c | 47 -
drivers/staging/xillybus/xillybus_pcie.c | 65 ---
Signed-off-by: Eli Billauer
---
Documentation/driver-model/devres.txt |2 ++
include/asm-generic/pci-dma-compat.h | 17 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/Documentation/driver-model/devres.txt
b/Documentation/driver-model/devres.txt
index 13
>From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
The "devs" is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as empty string.
On 2014-05-12 at 17:22:46 +0200, Denis Pithon wrote:
> Extract new static function from p80211netdev_rx_bh() to fix coding
> style issue (too many leading tabs).
>
> Signed-off-by: Denis Pithon
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 74
> --
> 1 file c
50 matches
Mail list logo
