This patch converts printk to dev_err in ft1000_cs.c
Signed-off-by: Masanari Iida
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
b/drivers/staging/ft1000/ft1000-pcmci
On Fri, May 16, 2014 at 12:27:01AM +0200, Christian Engelmayer wrote:
> Hi,
>
> As I got a bit queued up for dgap, I just noticed that commit 542f3d5a states
> to add Mark to the maintainers list for dgap, while the patch addresses the
> dgnc entry. Was that the intention?
No, it wasn't at all.
On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
None of the callers pass in a NULL hnode so there isn't actually a NULL
dereference here. You could just remove the check.
regards,
dan carpenter
_
Hi,
As I got a bit queued up for dgap, I just noticed that commit 542f3d5a states
to add Mark to the maintainers list for dgap, while the patch addresses the
dgnc entry. Was that the intention?
https://lkml.org/lkml/2014/4/25/275
Regards,
Christian
---
commit 542f3d5af89c15d0b4e80bbf927d252efa
Hi all, and Greg!
Good idea!
I will do it in all the other mail.
Best regards
Rickard Strandqvist
2014-05-16 0:08 GMT+02:00 Greg Kroah-Hartman :
> On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was
On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/tidspbridge/rmgr
On Tue, May 06, 2014 at 07:54:41PM +0200, Clément Calmels wrote:
> This is a patch to fix coding style issue found by
> scripts/checkpatch.pl utility.
>
> Signed-off-by: Clément Calmels
> ---
> drivers/staging/sep/sep_dev.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/sta
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/tidspbridge/rmgr/node.c |4 ++--
1 fil ändrad, 2 tillägg(+), 2 borttagningar(-)
diff --git a/d
On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
> Fix some coding style issues concerning printk() usage.
>
> Signed-off-by: Denis Pithon
> ---
> drivers/staging/wlan-ng/p80211netdev.c | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drive
On Sun, Apr 13, 2014 at 10:09:49PM +0530, c...@slynux.com wrote:
> From: Sarath Lakshman
This doesn't match your From: line, why?
>
> Fixed missed declarations for few non-static functions.
>
> Signed-off-by: Sarath Lakshman
> ---
> drivers/staging/wlan-ng/cfg80211.c | 1 +
> drivers/stagi
On Sun, Apr 13, 2014 at 09:22:16PM +1000, Vitaly Osipov wrote:
> All files in drivers/staging/wlan-ng updated to use pr_err
>
> Signed-off-by: Vitaly Osipov
> ---
> drivers/staging/wlan-ng/p80211conv.c | 24 +--
> drivers/staging/wlan-ng/p80211netdev.c |7 ++-
> drivers/staging/w
On 05/15/2014 02:33 AM, Dan Carpenter wrote:
> These days most people use git to send patches so I have added a section
> about that.
>
> Signed-off-by: Dan Carpenter
Applied. Thanks.
> ---
> v2: fix typo in commit message
> v3: update git am and log commands. Mention the man pages.
> v4: s/l
On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote:
> This commit fixes the following sparse warning:
>
> drivers/staging/rtl8723au/os_dep/os_intfs.c:
> - 322:14: warning: restricted __be16 degrades to integer
>
> Signed-off-by: Konrad Zapalowicz
> ---
> drivers/staging/rtl87
On Wed, May 14, 2014 at 10:12:46AM +0200, Tobias Klauser wrote:
> On 2014-05-13 at 16:43:57 +0200, Masanari Iida wrote:
> > This patch replaced printk with pr_info.
>
> It would be even better to use dev_err(), since these are error messages
> and you can use the struct dev from link->dev. You ca
This commit fixes the following sparse warning:
drivers/staging/rtl8723au/os_dep/os_intfs.c:
- 322:14: warning: restricted __be16 degrades to integer
Signed-off-by: Konrad Zapalowicz
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Wed, May 07, 2014 at 02:41:48PM +0300, Ebru Akagunduz wrote:
> Fix smatch warning "dgnc_cleanup_board() info:
> redundant null check on brd->flipbuf calling kfree()"
> in dgnc_driver.c
>
> Signed-off-by: Ebru Akagunduz
> ---
> drivers/staging/dgnc/dgnc_driver.c | 3 +--
> 1 file changed, 1 in
On Wed, Apr 09, 2014 at 05:30:04PM +0100, Paul McQuade wrote:
> ERROR: that open brace { should be on the previous line
> ERROR: else should follow close brace '}
> ERROR: space required before the open parenthesis '(
> ERROR: trailing whitespace
> ERROR: open brace '{' following function declarati
Remove unnecessary brackets from return statements in socklnd.c,
socklnd.h, socklnd_cb.c and socklnd_lib-linux.c to meet
kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +-
.../staging/lustre/lnet/klnds/socklnd/socklnd.h|4 +
Remove unnecessary line continuation '\' in socklnd.c to meet
kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/sock
These days most people use git to send patches so I have added a section
about that.
Signed-off-by: Dan Carpenter
---
v2: fix typo in commit message
v3: update git am and log commands. Mention the man pages.
v4: s/list/appropriate mailing list(s)/
diff --git a/Documentation/email-clients.txt b/
20 matches
Mail list logo
