Don't require FIRMWAREbDownload() to, first off, unlock a held lock.
Thus do all locking in main_usb.c and hold it for a insignificantly
shorter period of time. This makes the affected area significantly more
readable though.
Signed-off-by: Martin Kepplinger
---
I resend https://lkml.org/lkml/201
On Mon, 05 May 2014 15:35:43 -0700 Joe Perches wrote:
> > @@ -67,6 +68,7 @@ long vfs_truncate(struct path *path, lof
> > {
> > struct inode *inode;
> > long error;
> > + wobble();
> >
> > inode = path->dentry->d_inode;
>
> Patch content can be a bit odd when lines are
> both add
On Mon, 2014-05-05 at 15:15 -0700, Andrew Morton wrote:
> On Mon, 05 May 2014 13:12:16 -0700 Joe Perches wrote:
>
> > A couple more modifications to the declarations tests.
> >
> > o Declarations can also be bitfields so exclude things with a colon
> > o Make sure the current and previous lines
Read some of these links.
https://www.google.com/search?q=how+to+send+a+v2+patch
Send the email to yourself. Save it as raw text including headers and
everything. `cat raw_email.txt | git am`. Review the log with
`git log`. When that works then resend it to the list.
The subject of the email
On Mon, 05 May 2014 13:12:16 -0700 Joe Perches wrote:
> A couple more modifications to the declarations tests.
>
> o Declarations can also be bitfields so exclude things with a colon
> o Make sure the current and previous lines are indented the same
> to avoid matching some macro where a struc
On Mon, May 05, 2014 at 10:38:37AM -0700, Greg KH wrote:
> On Mon, May 05, 2014 at 07:10:37PM +0200, Fernando Apesteguia wrote:
> > On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote:
> > > On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
> > > > Small fix to driver. If the
> A sparse error fixup removed a htons() which is required for the driver
> to function. This patch puts the htons() back and fixes the sparse
> warning correctly by changing the left side cast.
>
> Signed-off-by: Sean MacLennan
I found that this patch is necessary and sufficient on my Samsung N5
The following changes since commit d1db0eea852497762cab43b905b879dfcd3b8987:
Linux 3.15-rc3 (2014-04-27 19:29:27 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.15-rc4
for you to fetch changes up to 86281966c73
On Mon, May 05, 2014 at 09:16:03PM +0200, Clément Calmels wrote:
> On Sun, 4 May 2014 17:26:58 -0400
> Greg KH wrote:
>
> > On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote:
> > > Remove C99 comment and rewrite lines over 80 characters.
> > > Warnings and error found by checkpatch.
A couple more modifications to the declarations tests.
o Declarations can also be bitfields so exclude things with a colon
o Make sure the current and previous lines are indented the same
to avoid matching some macro where a struct type is passed on
the previous line like:
nex
On Sun, May 04, 2014 at 07:26:51PM +0200, Maarten de Jonge wrote:
> Signed-off-by: Maarten de Jonge
Acked-by: Mark Einon
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, 3 May 2014 20:27:35 -0400, Greg KH wrote:
> On Thu, May 01, 2014 at 11:54:02PM +0200, Christian Engelmayer wrote:
> > Fix potential leaks in the error paths of r8712_set_key(). In case the
> > algorithm specific checks fail, the function returns without enqueuing
> > or freeing the already
On Mon, 2014-05-05 at 12:59 +0300, Dan Carpenter wrote:
> On Sat, May 03, 2014 at 07:43:26PM -0400, Greg KH wrote:
> > On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote:
> > > On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
> > > > This patch fixes "Missing a blank line af
Hello Oleg Drokin,
The patch 76133e66b141: "staging/lustre: Replace jobid acquiring with
per node setting" from Apr 27, 2014, leads to the following static
checker warning:
drivers/staging/lustre/lustre/obdclass/class_obd.c:131
lustre_get_jobid()
error: strcpy() 'obd_jobid_node'
On Sun, 4 May 2014 17:26:58 -0400
Greg KH wrote:
> On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote:
> > Remove C99 comment and rewrite lines over 80 characters.
> > Warnings and error found by checkpatch.pl script.
> >
> > Signed-off-by: Clément Calmels
> > ---
> > drivers/stag
On Mon, May 05, 2014 at 07:10:37PM +0200, Fernando Apesteguia wrote:
> On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote:
> > On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
> > > Small fix to driver. If these patches are welcomed, more could come in the
> > > future.
> >
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
For aesthetics, rename the local variable 'tmp' to 'arg'.
Also, change the 'err' variable to the correct type.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Har
On Mon, May 05, 2014 at 09:57:48AM -0700, Greg KH wrote:
> On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
> > Small fix to driver. If these patches are welcomed, more could come in the
> > future.
> >
> > Regards
>
> > >From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 1
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
cmd->scan_begin_arg for the scan_begin_src TRIG_TIMER. Pass the local
variable to dt2k_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer w
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
For aesthetics, rename the local variable 'tmp' to 'arg'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3xx
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate
the cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local
variable to i8253_cascade_ns_to_timer() instead of the cmd argument.
This value is modified by that function to return the actual time
(in nanoseconds) that the time
Use the comedi_fc helpers to validate the timer arguments.
H Hartley Sweeten (24):
staging: comedi: adl_pci9111: use comedi_fc helpers to validate timer args
staging: comedi: adv_pci1710: use comedi_fc helpers to validate timer args
staging: comedi: dt3000: use comedi_fc helpers to validate
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
scan_begin_arg when the scan_begin_src is TRIG_TIMER.
For aesthetics reasons, rename the local variable 'tmp' to 'arg'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
arguments for the TRIG_TIMER command sources. Pass the local variable to
i8253_cascade_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer w
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Tidy up the local varaibles in the function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 32
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local variable
to i8253_cascade_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the time
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
On Mon, May 05, 2014 at 06:40:13PM +0200, Fernando Apesteguia wrote:
> Small fix to driver. If these patches are welcomed, more could come in the
> future.
>
> Regards
> >From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00 2001
> From: Fernando Apesteguia
> Date: Mon, 5 May 2014 18
The comedi_cmd pointer is typically just called 'cmd'. Rename the local
variable in pci9111_ai_do_cmd().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 30
1 file changed, 13 insertions(+),
This member of the subdevice private data can be determined from the
cmd->stop_src. Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_dio200_common.c | 18 +-
1 file changed, 5 insertions(+), 13 dele
This member of the private data can be determined by checking the
cmd->stop_src. Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
d
This member of the private data is a copy of the cmd->chanlist_len. Use
that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/
Remove the unused or unnecessary members from the private data.
H Hartley Sweeten (4):
staging: comedi: adl_pc19111: remove 'stop_is_none' from private data
staging: comedi: adl_pc19111: rename 'async_cmd' variable in (*do_cmd)
staging: comedi: adl_pc19111: remove 'chanlist_len' from private
On Saturday, May 03, 2014 12:54 AM, Chase Southwood wrote:
> Latest patchset in a continuing cleanup of addi_apci_1564.c. Main focus
> is on the auto_attach() function, but also cleaning up some of the old addi
> common code wrappers.
>
> To be applied on top of my prior patchset to this file (the
This member of the private data is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/driver
For aesthetics, rename this function so it has namespace associated
with the driver.
The divisors used to load the counters are stored in the private data.
Get them from there and remove the parameters.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging
This member of the private data is just a copy of the cmd->scan_end_arg.
Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-
Small fix to driver. If these patches are welcomed, more could come in the
future.
Regards
>From d8369cba0552c5ea5f4eadc750434e39785e042a Mon Sep 17 00:00:00 2001
From: Fernando Apesteguia
Date: Mon, 5 May 2014 18:16:53 +0200
Subject: [PATCH] [staging/silicom] Fixing missing blank line after
dec
This member of the private data is set to 0 but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b
For aesthetics, rename this function so it has namespace associated
with the driver.
Refactor the function to reduce the indent level and tidy up the code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 107 +++
This member of the private data is just a copy of the cmd->stop_arg.
Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --gi
This member of the private data is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/drive
This member of the private data is only set when the cmd->convert_src
is TRIG_NOW. Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 25 ++---
1 file changed, 10 insertions(+), 15 dele
The devpriv->usedma flag can be checked to determine which handler
function should be used to transfer the analog input data. Do that
instead and remove the member from the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/a
This member of the private data is just a copy of the s->async->prealloc_bufsz.
Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 27 +++
1 file changed, 11 insertions(+), 16 delet
This member of the private data is just a copy of the cmd->chanlist_len.
Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git
This member of the private data is always set to I8254_OSC_BASE_4MHZ.
Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git
This member of the private data is just a copy of the cmd->chanlist.
Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
This member of the private data is always set to 0. Remove it and the
affected code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 32 +++-
1 file changed, 3 insertions(+), 29 deletions(-)
diff
This member of the private data is set to 0 but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/d
This member of the private data is not used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/drivers/staging/com
This member of the private data is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/driver
This member of the private data is only set when the analog input
subdevice maxdata is 0x. Just check the s->maxdata and remove
the private data member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 16 +++-
Remove the unused or unnecessary members from the private data.
H Hartley Sweeten (20):
staging: comedi: adl_pci9118: remove 'ai_n_chan' from private data
staging: comedi: adl_pci9118: remove 'ai_chanlist' from private data
staging: comedi: adl_pci9118: remove 'ai_data_len' from private data
The (*do_cmdtest) only allows TRIG_COUNT, TRIG_NONE, or TRIG_EXT as the
cmd->stop_src. Remove the disabled code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/driv
This member of the private data is set only used during the (*detach)
to check if the board can be reset. The pci9118_reset() function just
needs a valid dev->iobase. Use that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl
Looks fine to me, ACK.--b.
On Mon, Apr 28, 2014 at 01:50:13PM -0400, Jeff Layton wrote:
> Currently, the fl_owner isn't set for flock locks. Some filesystems use
> byte-range locks to simulate flock locks and there is a common idiom in
> those that does:
>
> fl->fl_owner = (fl_owner_t)filp;
>
Am 2014-05-05 14:36, schrieb Dan Carpenter:
> On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
>> Am 2014-05-05 13:35, schrieb Dan Carpenter:
>>> On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
Use dev_err() instead of printk() and remove "dgnc:" from the m
On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
> Am 2014-05-05 13:35, schrieb Dan Carpenter:
> > On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
> >> Use dev_err() instead of printk() and remove "dgnc:" from the message.
> >> This should provide userspace with
Am 2014-05-05 13:35, schrieb Dan Carpenter:
> On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
>> Use dev_err() instead of printk() and remove "dgnc:" from the message.
>> This should provide userspace with more useful information and use
>> the common kernel coding style.
>>
>
>
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
> Use dev_err() instead of printk() and remove "dgnc:" from the message.
> This should provide userspace with more useful information and use
> the common kernel coding style.
>
Whenever I see a "RESEND" in a subject and no explan
Use dev_err() instead of printk() and remove "dgnc:" from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On Sat, May 03, 2014 at 07:43:26PM -0400, Greg KH wrote:
> On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote:
> > On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
> > > This patch fixes "Missing a blank line after declarations" warnings.
> > >
> > > Signed-off-by: Seunghun
On 29 April 2014 09:36, Ulf Hansson wrote:
> On 29 April 2014 03:54, wrote:
>> From: Micky Ching
>>
>> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
>>
>> commit did use
>> mutex_unlock() in tasklet, but mutex_unlock() can't used in
>> tasklet(atomic context). The driver need u
79 matches
Mail list logo
