[PATCH] staging: bcm: fix lines over 80 characters

2014-05-02 Thread Greg DeAngelis
Signed-off-by: Greg DeAngelis --- drivers/staging/bcm/Transmit.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c index 2ed4836..4976746 100644 --- a/drivers/staging/bcm/Transmit.c +++ b/driv

Re: [PATCH 00/22] staging: comedi: pass subdevice around instead of async

2014-05-02 Thread Ian Abbott
On 02/05/14 18:40, Hartley Sweeten wrote: On Friday, May 02, 2014 5:50 AM, Ian Abbott wrote: For comedi subdevices that support asynchronous commands, the `async` member of `struct comedi_subdevice` points to a `struct comedi_async` allocated to manage asynchronous commands on that subdevice. T

RE: randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

2014-05-02 Thread Haiyang Zhang
riverproject.org; net...@vger.kernel.org > Subject: Re: randconfig build error with next-20140502, in > drivers/net/hyperv/netvsc_drv.c > > From: Haiyang Zhang > Date: Fri, 2 May 2014 14:42:06 + > > > real_num_rx_queues is defined in "include/linux/netdevice.h&quo

Re: randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

2014-05-02 Thread David Miller
From: Haiyang Zhang Date: Fri, 2 May 2014 14:42:06 + > real_num_rx_queues is defined in "include/linux/netdevice.h": > It requires CONFIG_SYSFS flag, which is enabled by default, but not set in > your config file. > > Could you use default config and add hyperv drivers, then try again? You

RE: [PATCH 00/22] staging: comedi: pass subdevice around instead of async

2014-05-02 Thread Hartley Sweeten
On Friday, May 02, 2014 5:50 AM, Ian Abbott wrote: > For comedi subdevices that support asynchronous commands, the `async` > member of `struct comedi_subdevice` points to a `struct comedi_async` > allocated to manage asynchronous commands on that subdevice. The > pointer to this "async" structure

[PATCH 1/3] staging/lustre/libcfs: Fix build errors for !CONFIG_SMP

2014-05-02 Thread Geert Uytterhoeven
When CONFIG_SMP=n: drivers/staging/lustre/include/linux/libcfs/linux/linux-mem.h:58:31: fatal error: libcfs/libcfs_cpu.h: No such file or directory drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c:78:1: error: redefinition of 'cfs_cpt_table_print' drivers/staging/lustre/include/linux/libcfs/li

[PATCH 2/3] staging: lustre: Use %zd to format ssize_t

2014-05-02 Thread Geert Uytterhoeven
drivers/staging/lustre/lustre/llite/rw26.c: In function 'll_direct_IO_26': drivers/staging/lustre/lustre/llite/rw26.c:383:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'ssize_t' [-Wformat] drivers/staging/lustre/lustre/llite/rw26.c:383:2: warning:

[PATCH 3/3] staging/lustre/llite: Fix unused variable warning if !CONFIG_FS_POSIX_ACL

2014-05-02 Thread Geert Uytterhoeven
If CONFIG_FS_POSIX_ACL=n: drivers/staging/lustre/lustre/llite/xattr.c: In function 'll_setxattr_common': drivers/staging/lustre/lustre/llite/xattr.c:115:27: warning: unused variable 'rce' [-Wunused-variable] Signed-off-by: Geert Uytterhoeven --- drivers/staging/lustre/lustre/llite/xattr.c |

RE: randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

2014-05-02 Thread Haiyang Zhang
> -Original Message- > From: KY Srinivasan > Sent: Friday, May 2, 2014 11:00 AM > To: Haiyang Zhang; Jim Davis; Stephen Rothwell; linux-next; linux-kernel; > de...@linuxdriverproject.org; netdev > Subject: RE: randconfig build error with next-20140502, in &g

[PATCH] staging: vt6656: fix potential leak in vt6656_hostap_ioctl()

2014-05-02 Thread Christian Engelmayer
Commit fb841d67 (staging: vt6656: don't leak 'param' in vt6656_hostap_ioctl() when returning -EOPNOTSUPP) cleaned up direct returns in the ioctl switch statement that leaked already allocated memory. Fix the same issue for VIAWGET_HOSTAPD_SCAN_REQ and VIAWGET_HOSTAPD_MLME that are also not supporte

RE: randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

2014-05-02 Thread Haiyang Zhang
> -Original Message- > From: Jim Davis [mailto:jim.ep...@gmail.com] > Sent: Friday, May 2, 2014 9:56 AM > To: Stephen Rothwell; linux-next; linux-kernel; KY Srinivasan; Haiyang > Zhang; de...@linuxdriverproject.org; netdev > Subject: randconfig build error with

RE: randconfig build error with next-20140502, in drivers/net/hyperv/netvsc_drv.c

2014-05-02 Thread KY Srinivasan
> -Original Message- > From: Haiyang Zhang > Sent: Friday, May 2, 2014 7:42 AM > To: Jim Davis; Stephen Rothwell; linux-next; linux-kernel; KY Srinivasan; > de...@linuxdriverproject.org; netdev > Subject: RE: randconfig build error with next-20140502, in > drivers/ne

[PATCH 18/22] staging: comedi: pass subdevice to comedi_buf_write_n_available()

2014-05-02 Thread Ian Abbott
Local function `comedi_buf_write_n_available()` currently takes a pointer to a `struct comedi_async`. Change it to take a pointer to a `struct comedi_subdevice` and use the `async` member for consistency with the other comedi buffer handling functions. Signed-off-by: Ian Abbott --- drivers/stag

[PATCH 11/22] staging: comedi: pass subdevice to comedi_buf_read_alloc()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_read_alloc()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in

[PATCH 15/22] staging: comedi: pass subdevice to comedi_buf_is_mmapped()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_is_mmapped()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in

[PATCH 20/22] staging: comedi: mite: pass subdevice to mite_sync_input_dma()

2014-05-02 Thread Ian Abbott
`mite_sync_input_dma()` in the "mite" module currently takes a pointer to a `struct comedi_async` and gets a pointer to the owning `struct comedi_subdevice` from the `subdevice` member. Change it to take a pointer to a `struct comedi_subdevice` and use the `async` member. The motivation for this

[PATCH 19/22] staging: comedi: mite: pass subdevice to mite_buf_change()

2014-05-02 Thread Ian Abbott
`mite_buf_change()` in the "mite" module currently takes a pointer to a `struct comedi_async` and gets a pointer to the owning `struct comedi_subdevice` from the `subdevice` member. Change it to take a pointer to a `struct comedi_subdevice` and use the `async` member. The motivation for this is t

[PATCH 22/22] staging: comedi: remove subdevice member of struct comedi_async

2014-05-02 Thread Ian Abbott
The `async` member of `struct comedi_subdevice` may point to a `struct comedi_async` or may be NULL. The `subdevice` member of `struct comedi_async` points back to the `struct comedi_subdevice` associated with it in a one-to-one relationship. All uses of the `subdevice` member of `struct comedi_a

[PATCH 21/22] staging: comedi: mite: pass subdevice to mite_sync_output_dma()

2014-05-02 Thread Ian Abbott
`mite_sync_output_dma()` in the "mite" module currently takes a pointer to a `struct comedi_async` and gets a pointer to the owning `struct comedi_subdevice` from the `subdevice` member. Change it to take a pointer to a `struct comedi_subdevice` and use the `async` member. The motivation for this

[PATCH 07/22] staging: comedi: ni_tiocmd: pass subdevice to command setup functions

2014-05-02 Thread Ian Abbott
The `ni_tio_input_cmd()`, `ni_tio_output_cmd()` and `ni_tio_cmd_setup()` functions are called from `ni_tio_cmd()` to set up a comedi command. They currently get passed two parameters, a pointer to a `struct ni_gpct` and a pointer to a `struct comedi_async`, but both of those come from members of a

[PATCH 09/22] staging: comedi: pass subdevice to comedi_buf_write_free()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_write_free()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in

[PATCH 16/22] staging: comedi: pass subdevice to comedi_buf_munge()

2014-05-02 Thread Ian Abbott
Local function `comedi_buf_munge()` is called by `comedi_buf_write_free()` to modify (or "munge") the data copied from a device into the buffer. Currently, the function takes a pointer to a `struct comedi_async` and gets a pointer to the comedi subdevice from the `subdevice` member. Change it to t

[PATCH 10/22] staging: comedi: pass subdevice to comedi_buf_write_n_allocated()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_write_n_allocated()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` paramet

[PATCH 14/22] staging: comedi: pass subdevice to comedi_buf_reset()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_reset()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in the c

[PATCH 12/22] staging: comedi: pass subdevice to comedi_buf_read_free()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_read_free()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in t

[PATCH 13/22] staging: comedi: pass subdevice to comedi_buf_read_n_available()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_read_n_available()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` paramete

[PATCH 08/22] staging: comedi: pass subdevice to comedi_buf_write_alloc()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_write_alloc()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in

[PATCH 17/22] staging: comedi: pass subdevice to __comedi_buf_write_alloc()

2014-05-02 Thread Ian Abbott
Local function `__comedi_buf_write_alloc()` is called by `comedi_buf_write_alloc()` and `comedi_buf_put()`. It currently takes a pointer to a `struct comedi_async`. Change it to take a pointer to a `struct comedi_subdevice` and use the `async` member for consistency with other comedi buffer handl

[PATCH 06/22] staging: comedi: pass subdevice to comedi_buf_memcpy_from()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_memcpy_from()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in

[PATCH 05/22] staging: comedi: pass subdevice to comedi_buf_memcpy_to()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_memcpy_to()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The main aim at the moment is to replace all the `struct comedi_async *` parameters with `struct comedi_subdevice *` parameters in t

[PATCH 03/22] staging: comedi: pass subdevice to comedi_buf_put()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_put()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The function puts a sample value in the comedi buffer, but currently only deals with 16-bit sample types. A future version could deal wit

[PATCH 02/22] staging: comedi: remove async parameter from resize_async_buffer()

2014-05-02 Thread Ian Abbott
The `struct comedi_async *async` parameter of `resize_async_buffer()` is redundant as its value can be easily derived from the `struct comedi_subdevice *s` parameter as `s->async`. Remove the parameter. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_fops.c | 10 +- 1 file c

[PATCH 01/22] staging: comedi: remove redundant pointer dereference in comedi_poll()

2014-05-02 Thread Ian Abbott
`s->async->subdevice` in `comedi_poll()` points to the same `struct comedi_subdevice` as `s`, so the double pointer reference is redundant. Just use `s`. (`s->async->subdevice` is initialized by `__comedi_device_postconfig_async()` in "drivers/staging/comedi/drivers.c" and doesn't change.) Signed

[PATCH 00/22] staging: comedi: pass subdevice around instead of async

2014-05-02 Thread Ian Abbott
For comedi subdevices that support asynchronous commands, the `async` member of `struct comedi_subdevice` points to a `struct comedi_async` allocated to manage asynchronous commands on that subdevice. The pointer to this "async" structure is passed around by various functions and some of those fun

[PATCH 04/22] staging: comedi: pass subdevice to comedi_buf_get()

2014-05-02 Thread Ian Abbott
Change the parameters of `comedi_buf_get()` to pass a pointer to the comedi subdevice instead of a pointer to the "async" structure belonging to the subdevice. The function gets a sample value from the comedi buffer, but currently only deals with 16-bit sample types. A future version could deal w

Re: [PATCH] Fixing coding style issues in android alarm-dev.c

2014-05-02 Thread Dan Carpenter
On Wed, Apr 30, 2014 at 10:05:53PM +0100, Karim Raslan wrote: > fixing "Missing a blank line after declarations" found by checkpatch.pl script > Use a subject prefix. Also the subject is too vague. [PATCH] staging: android: alarm-dev: add a blank line regards, dan carpenter __

Re: [PATCH v2] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

2014-05-02 Thread Jes Sorensen
Christian Engelmayer writes: > Fix a potential leak in the error path of function update_bcn_wps_ie(). > Move the affected input verification to the beginning of the function so > that it may return directly without leaking already allocated memory. > Detected by Coverity - CID 1077718. > > Signed