Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Chase Southwood
Hartley, Yes, you raise very good points. In any case, I have added cover letters to my submitting checklist so hopefully everything will be a lot easier for everyone next go round. Thanks, Chase On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten wrote: > On Wednesday, April 30, 2014 12:52 AM,

30.May.14 Update info

2014-04-30 Thread AMY
Hi, I would like to share personal classified information about my experience and role which I played in the pursuit of my career this will benefit us greatly,interested reply through my private email: ( sgt.rho...@aim.com ) please view website below to know more Rgds, Rhodes

[PATCH] Fixing coding style issues in android alarm-dev.c

2014-04-30 Thread Karim Raslan
fixing "Missing a blank line after declarations" found by checkpatch.pl script Signed-off-by: Karim Raslan --- drivers/staging/android/alarm-dev.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c index 2fc7cdd..f200

Re: [PATCH] staging: iio: Fix format string mismatch in ad7280a.c

2014-04-30 Thread Jonathan Cameron
On 28/04/14 17:00, Masanari Iida wrote: Fix two format string mismatch in ad7280a.c Signed-off-by: Masanari Iida Applied to the togreg branch of iio.git Note this will initially get pushed out as testing for the autobuilders to play. Thanks, Jonathan --- drivers/staging/iio/adc/ad7280a.c

Re: [PATCH V2 net 1/1] hyperv: Properly handle checksum offload

2014-04-30 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 30 Apr 2014 11:58:25 -0700 > Do checksum offload only if the client of the driver wants checksum to be > offloaded. > > In V1 version of this patch, I addressed comments from > Stephen Hemminger and > Eric Dumazet . > > In this version of the patch I have a

Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

2014-04-30 Thread Dan Carpenter
On Wed, Apr 30, 2014 at 11:04:49PM +0530, Raghavendra Ganiga wrote: > This is a patch to fix coding style > warnings found by the checkpatch.pl tool > Someone fixed this already. You should be working against linux-next for this kind of thing. regards, dan carpenter ___

Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-30 Thread Dan Carpenter
On Wed, Apr 30, 2014 at 10:14:31AM -0700, K. Y. Srinivasan wrote: > + /* Setup state for managing the send buffer. */ > + net_device->map_words = DIV_ROUND_UP(net_device->send_section_cnt, > + BITS_PER_LONG); > + > + net_device->send_section_map

[PATCH V2 net 1/1] hyperv: Properly handle checksum offload

2014-04-30 Thread K. Y. Srinivasan
Do checksum offload only if the client of the driver wants checksum to be offloaded. In V1 version of this patch, I addressed comments from Stephen Hemminger and Eric Dumazet . In this version of the patch I have addressed comments from David Miller. This patch fixes a bug that is exposed in g

Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-30 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 30 Apr 2014 10:14:31 -0700 > We send packets using a copy-free mechanism (this is the Guest to Host > transport > via VMBUS). While this is obviously optimal for large packets, > it may not be optimal for small packets. Hyper-V host supports > a second mechani

[PATCH] staging: comedi: fix coding style issues in comedi_fops.c

2014-04-30 Thread Raghavendra Ganiga
This is a patch to fix coding style warnings found by the checkpatch.pl tool Signed-off-by: Raghavendra Chandra Ganiga --- drivers/staging/comedi/comedi_fops.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/com

Re: [PATCH V2 net-next 1/1] hyperv: Properly handle checksum offload

2014-04-30 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 30 Apr 2014 09:05:21 -0700 > Do checksum offload only if the client of the driver wants checksum to be > offloaded. > > In V1 version of this patch, I addressed comments from > Stephen Hemminger and > Eric Dumazet . > > In this version of the patch I have a

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Hartley Sweeten
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: > Thanks so much, I greatly appreciate the review. I'll fix the > changelog for patch 4 and send once more (as I assume that's easier > for Greg). Also, I should know better about the cover letter as > well...I was once told not to sen

RE: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-04-30 Thread Hartley Sweeten
On Wednesday, April 30, 2014 2:13 AM, Ian Abbott wrote: > On 2014-04-29 20:59, H Hartley Sweeten wrote: >> Remove some unnecessary pacer divisor calculations. The divisors are >> calculated >> as part of the (*do_cmdtest) and don't need done in the (*do_cmd). >> >> Remomove the older, unused, divi

[RESEND] [PATCH] staging: android: fix missing a blank line after declarations

2014-04-30 Thread Seunghun Lee
This patch fixes "Missing a blank line after declarations" warnings. Signed-off-by: Seunghun Lee --- drivers/staging/android/alarm-dev.c |1 + drivers/staging/android/binder.c | 34 + drivers/staging/android/ion/ion.c | 10 ++

[PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-30 Thread K. Y. Srinivasan
We send packets using a copy-free mechanism (this is the Guest to Host transport via VMBUS). While this is obviously optimal for large packets, it may not be optimal for small packets. Hyper-V host supports a second mechanism for sending packets that is "copy based". We implement that mechanism in

Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-30 Thread David Miller
From: KY Srinivasan Date: Wed, 30 Apr 2014 14:17:04 + > Please let me know if there is some other issue you want addressed in this > patch. If the patch isn't in patchwork, I'm not going to apply it and you need to simply resubmit it. ___ devel ma

[PATCH V2 net-next 1/1] hyperv: Properly handle checksum offload

2014-04-30 Thread K. Y. Srinivasan
Do checksum offload only if the client of the driver wants checksum to be offloaded. In V1 version of this patch, I addressed comments from Stephen Hemminger and Eric Dumazet . In this version of the patch I have addressed comments from David Miller. This patch fixes a bug that is exposed in g

RE: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-30 Thread KY Srinivasan
> -Original Message- > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > Sent: Wednesday, April 23, 2014 2:25 PM > To: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com >

Drivers/hv

2014-04-30 Thread K. Y. Srinivasan
Greg, Some time back I had sent a buch of patches for Hyper-V drivers. Are they still in the queue or should I resend them. Regards, K. Y ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/dri

[PATCH v2] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
by cleaning up BT_AUTO_REPORT_ONLY_8192E_2ANT (always set to 0, never used as constant) halbtc8192e2ant_iswifi_status_changed was called only from the unused code Signed-off-by: Jan Moskyto Matejka --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 43 -- .../staging/r

Re: [PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
> > > static void halbtc8192e2ant_update_btlink_info(struct btc_coexist > > *btcoexist) > > { > > The output of > git grep BT_AUTO_REPORT_ONLY_8192E_2ANT next-20140430 > > is > next-20140430:drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:#if &

Re: [PATCH] staging: media: parport: Fix format string mismatch in bw-qcam.c

2014-04-30 Thread Masanari Iida
-next.git/tree/drivers/staging?id=refs/tags/next-20140430 But as I see the patch itself carefully, the path "staging" does NOT included. So it seemed something going wrong with linux-next merger. I will resend the patch with correct title and correct mailing list later on. Thanks. Mas

Re: [PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Paul Bolle
busy; > @@ -534,6 +535,7 @@ static bool halbtc8192e2ant_iswifi_status_changed(struct > btc_coexist *btcoexist) > > return false; > } > +#endif > > static void halbtc8192e2ant_update_btlink_info(struct btc_coexist *btcoexist) > { The output of git grep BT_AUTO_REPORT_ONLY_8192E_

[PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
The function halbtc8192e2ant_iswifi_status_changed is called only at line 4158 which is #if'd in the same way as I'm now #if-ing the function. Signed-off-by: Jan Moskyto Matejka --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driv

Re: [PATCH] staging: media: parport: Fix format string mismatch in bw-qcam.c

2014-04-30 Thread Greg KH
On Wed, Apr 30, 2014 at 07:51:13PM +0900, Masanari Iida wrote: > Fix format string mismatch in bw-qcam.c > > Signed-off-by: Masanari Iida > --- > drivers/media/parport/bw-qcam.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/parport/bw-qcam.c b/drivers/me

[PATCH] staging: media: parport: Fix format string mismatch in bw-qcam.c

2014-04-30 Thread Masanari Iida
Fix format string mismatch in bw-qcam.c Signed-off-by: Masanari Iida --- drivers/media/parport/bw-qcam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/parport/bw-qcam.c b/drivers/media/parport/bw-qcam.c index 8a0e84c..416507a 100644 --- a/drivers/media/parport

[patch] staging: rtl8192u: cleanup a switch statement

2014-04-30 Thread Dan Carpenter
The white space was all wrong here. The case statements were indented too far. The if else blocks weren't indented at all. There was a break statement aligned with the else block and it confused my static checker because "were curly braces intended" so that the break statement was only on the el

Re: [PATCH 00/32] staging: comedi: continue async command cleanup

2014-04-30 Thread Ian Abbott
On 2014-04-29 20:59, H Hartley Sweeten wrote: Remove some unnecessary pacer divisor calculations. The divisors are calculated as part of the (*do_cmdtest) and don't need done in the (*do_cmd). Remomove the older, unused, divisor calc functions in 8253.h to avoid any confusion. Remove some unnec

Re: [PATCH 4/6 v3] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-30 Thread Ian Abbott
On 2014-04-30 08:57, Chase Southwood wrote: This driver only uses PCI bar 0 (devpriv->i_IobaseAmcc), and PCI bar 1 (dev->iobase), don't bother reading the unused PCI bars. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- 2: Bad PCI bar numbers corrected. 3: Fixed silly

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-04-30 Thread Ulf Hansson
On 30 April 2014 05:34, Roger wrote: > > On 04/29/2014 08:46 PM, Arnd Bergmann wrote: >> >> On Tuesday 29 April 2014 13:05:15 Ulf Hansson wrote: >>> >>> On 29 April 2014 11:45, Arnd Bergmann wrote: drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove': :(.text+0x806480): unde

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-30 Thread Dan Carpenter
On Tue, Apr 29, 2014 at 11:21:48PM -0400, Oleg Drokin wrote: > I can rediff this patch with this particular part dropped if there are > any concerns and it's possible to reintegrate it in a changed form. No no. I knew that Greg had already merged this stuff by the time I got around to reviewing i

[PATCH 4/6 v3] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-30 Thread Chase Southwood
This driver only uses PCI bar 0 (devpriv->i_IobaseAmcc), and PCI bar 1 (dev->iobase), don't bother reading the unused PCI bars. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- 2: Bad PCI bar numbers corrected. 3: Fixed silly typos in the changelog drivers/staging/come

Re: [PATCH v7 4/4] memstick: Add realtek USB memstick host driver

2014-04-30 Thread Roger
On 04/28/2014 06:10 PM, Lee Jones wrote: From: Roger Tseng Realtek USB memstick host driver provides memstick host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng --- drivers/memstick/host/Kconfig | 10 + drivers/memstick/host/Makefile | 1

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Chase Southwood
Ian and Hartley, Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them for strictly cleanup patchsets (as Greg can't

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-04-30 Thread Arnd Bergmann
On Wednesday 30 April 2014 11:34:33 Roger wrote: > I think Ulf's idea is to fix the bug by modifying the .c files. > I really found the problem of my ifdef hackery and it should do > something similar in sdhci.c as: > > From: Roger Tseng > Date: Wed, 30 Apr 2014 11:11:25 +0800 > Subject: [PATCH]