Re: staging: add Lustre file system client support

Hello! On Apr 23, 2014, at 11:14 PM, Peng Tao wrote: >> Btw, what's the trick to navigating the lustre source? I normally do >> a make cscope but that doesn't work and I am having a very hard time >> with this code. >> > I use cscope + ctags to navigate the lustre source. I guess you hit > some

Re: staging: add Lustre file system client support

Hi Dan, Thanks for reporting this. On Wed, Apr 23, 2014 at 10:13 PM, Dan Carpenter wrote: > Btw, what's the trick to navigating the lustre source? I normally do > a make cscope but that doesn't work and I am having a very hard time > with this code. > I use cscope + ctags to navigate the lustre

[PATCH 17/22] staging: comedi: adv_pci1710: only calc the pacer divisors once

When the cmd->convert_src == TRIG_TIMER the divisors needed to generate the pacer time are calculated in the (*do_cmdtest) to validate the cmd->convert_arg. The core always does the (*do_cmdtest) before the (*do_cmd) so there is no reason to recalc the divisors. Signed-off-by: H Hartley Sweeten C

[PATCH 12/22] staging: comedi: adv_pci1710: tidy up pci171x_ai_check_chanlist()

Tidy up this function to clarify what the chanlist is being checked for. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 81 ++-- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/dr

[PATCH 05/22] staging: comedi: adv_pci1710: remove 'ai_n_chan' from private data

This member of the private data is just a copy of the cmd->chanlist_len. Use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/

[PATCH 13/22] staging: comedi: adv_pci1710: don't check the chanlist twice

The chanlist is checked in Step 5 of the (*do_cmdtest) there is no reason to check it again in the (*do_cmd). The only reasonm its done is to get the actual 'seglen', the non-repeating length of the chanlist. Save the 'seglen' found by pci171x_ai_check_chanlist() in the private data and use that i

[PATCH 18/22] staging: comedi: adv_pci1710: remove local var in pci171x_ai_cmd()

The local variable 'mode' is not necessary. We can determine the mode by checking the cmd->convert_src and cmd->start_src. Do this instead to clarify the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 27 +++--

[PATCH 08/22] staging: comedi: adv_pci1710: cmd->scan_begin_src can only be TRIG_FOLLOW

In Step 1 of the (*do_cmdtest), the cmd->scan_begin_src is checked to only allow TRIG_FOLLOW. The (*do_cmd) does not need to recheck this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 16 +++- 1 file chang

[PATCH 14/22] staging: comedi: adv_pci1710: remove 'neverending_ai' from private data

This member of the private data is not necessary. We can determine if the analog input command is neverending by checking the cmd->stop_src: TRIG_COUNT -> !neverending_ai TRIG_NONE -> neverending_ai Do that instead and remove the unnecessary member. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 10/22] staging: comedi: adv_pci1710: remove 'ai_do' from private data

This member of the private data is set to the "mode" that the ai command is operating in but nothing uses it. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 4 1 file changed, 4 deletions(-) diff -

[PATCH 16/22] staging: comedi: adv_pci1710: remove 'ai_eos' from private data

This member of the private data is is not necessary. We can just check the cmd->flags for TRIG_WAKE_EOS when needed. Remvoe the member. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 21 +++-- 1 file cha

[PATCH 11/22] staging: comedi: adv_pci1710: rename check_channel_list()

For aesthetics, rename this function so it has namespace associated with the driver. Also, change it's parameters. The cmd->chanlist and cmd->chanlist_len are always passed, just pass the comedi_cmd pointer instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- dr

[PATCH 19/22] staging: comedi: adv_pci1710: tidy up start_pacer()

For aesthetics, rename this function so it has namespace associated with the driver. Change the parameters to the function. The 'mode' is really a flag to load the counters and the divisors can be found in the private data. To clarify the code and remove the magic numbers, use the 8253.h helpers

[PATCH 21/22] staging: comedi: adv_pci1710: handle events and clear interrupt in common code

The helper functions that handle reading the analog input samples for the interrupt function both call cfc_handle_events() and clear the interrupt request at various times. Move this to the main interrupt handler to make sure the events are posted and the interrupt request is cleared. Signed-off-

[PATCH 22/22] staging: comedi: adv_pci1710: always enable PCI171x_PARANOIDCHECK code

This define enables code that checks for analog input channel dropout when reading sampled. The define is enabled so we might as well always enable the code and remove the define. Factor out the common channel dropout detect code as a helper function. And cleanup the code. Signed-off-by: H Hartle

[PATCH 07/22] staging: comedi: adv_pci1710: remove 'ai_data_len' from private data

This member of the private data is just a copy of the s->async->prealloc_bufsz. Use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/

[PATCH 20/22] staging: comedi: adv_pci1710: rename interrupt helper functions

For aesthetics, rename the helper functions that are called by the interrupt function to handle reading the analog input samples. Also, change the parameters to the helpers to the comedi_device and comedi_subdevice pointers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 15/22] staging: comedi: adv_pci1710: remove 'ai_buf_ptr' from private data

This member of the private data is set to 0 but never used. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c

[PATCH 04/22] staging: comedi: adv_pci1710: remove 'ai_chanlist' from private data

This member of the private data is just a copy of the cmd->chanlist. Use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/stagi

[PATCH 02/22] staging: comedi: adv_pci1710: remove 'ai_timer1' from private data

This member of the private data is just a copy of the cmd->convert_arg. Use that instead and remove the unnecessary sanity checking since it was already validated in the (*do_cmdtest). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv

[PATCH 06/22] staging: comedi: adv_pci1710: remove 'ai_scans' from private data

This member of the private data is just a copy of the cmd->stop_arg. Use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/d

[PATCH 00/22] staging: comedi: adv_pci1710: cleanup async command support

Remove the unnecessary members from the private data and cleanup the async command support code. H Hartley Sweeten (22): staging: comedi: adv_pci1710: remove 'ai_timer2' from private data staging: comedi: adv_pci1710: remove 'ai_timer1' from private data staging: comedi: adv_pci1710: remove

[PATCH 03/22] staging: comedi: adv_pci1710: remove 'ai_flags' from private data

This member of the private data is just a copy of the cmd->flags. Use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/

[PATCH 09/22] staging: comedi: adv_pci1710: absorb pci171x_ai_docmd_and_mode()

This helper function is called by the ai (*do_cmd) to setup and start the async command based on the "mode" of operation. This "mode" is determined by the cmd convert_src and start_src. Move this "mode" determination and combine the functions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc:

[PATCH 01/22] staging: comedi: adv_pci1710: remove 'ai_timer2' from private data

This member of the private data is set to 0 but it is never used. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1

[PATCH 3/4] staging: comedi: amplc_pci224: always cascade the 8254 timers

The 8254 timers are only used in this driver to generate the analog output pacer. To simplify the driver, always cascade the timers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci224.c | 123 ++ 1 file

[PATCH 1/4] staging: comedi: amplc_pci224: remove pci224_cascade_ns_to_timer()

This function is just a wrapper around i8253_cascade_ns_to_timer(). Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci224.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/

[PATCH 2/4] staging: comedi: amplc_pci224: factor out the 'start pacer' code

To clarify the analog output (*do_cmd) function, factor out the code that starts the pacer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci224.c | 142 +- 1 file changed, 73 insertions(+), 69 deletions(

[PATCH 4/4] staging: comedi: amplc_pci224: only calc the pacer divisors once

When the cmd->scan_begin_src == TRIG_TIMER the divisors needed to generate the pacer time are calculated in the (*do_cmdtest) to validate the cmd->scan_begin_arg. The core always does the (*do_cmdtest) before the (*do_cmd) so there is no reason to recalc the divisors. Signed-off-by: H Hartley Swee

[PATCH 0/4] staging: comedi: amplc_pci224: cleanup timer code

Tidy up the timer/pacer code in this driver. H Hartley Sweeten (4): staging: comedi: amplc_pci224: remove pci224_cascade_ns_to_timer() staging: comedi: amplc_pci224: factor out the 'start pacer' code staging: comedi: amplc_pci224: always cascade the 8254 timers staging: comedi: amplc_pci22

[PATCH 0/3] staging: comedi: drivers: cleanup (*do_cmdtest) step 2b

Clarify step 2b of the adl_pci9111 driver. Remove the unnecessary step 2b tests in the cb_pcidas64 and me4000 drivers. H Hartley Sweeten (3): staging: comedi: adl_pci9111: clarify Step 2b of the (*do_cmdtest) staging: comedi: cb_pcidas64: remove unnecessary Step 2b test in (*do_cmdtest) stag

[PATCH 1/3] staging: comedi: adl_pci9111: clarify Step 2b of the (*do_cmdtest)

This step of the (*do_cmdtest) verifies that the selected trigger sources are mutually compatible. For this driver the scan_begin_src must be TRIG_FOLLOW or the same source as the convert_src. Simplify the logic to clarify this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Ha

[PATCH 2/3] staging: comedi: cb_pcidas64: remove unnecessary Step 2b test in (*do_cmdtest)

This test is unnecessary. The cfc_check_trigger_src() in Step 1 ensures that the trigger source is one of these values and Step 2 makes sure it's only one of these values. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c |

[PATCH 3/3] staging: comedi: me4000: remove unnecessary Step 2b test in (*do_cmdtest)

This test is unnecessary. It covers all the possible combinations of the scan_end_src and stop_src triggers so the final else can never be reached. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me4000.c | 11 --- 1 file change

Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

TLDR; Style nits and we should return -ENOMEM on error instead of success. On Wed, Apr 23, 2014 at 02:24:45PM -0700, K. Y. Srinivasan wrote: > We send packets using a copy-free mechanism (this is the Guest to Host > transport > via VMBUS). While this is obviously optimal for large packets, > it

Re: [PATCH] staging: iio: Fix typo in iio

On 22/04/14 22:41, Randy Dunlap wrote: On 04/22/14 04:23, Masanari Iida wrote: Correct spelling typo in comment within staging/iio Signed-off-by: Masanari Iida Acked-by: Randy Dunlap Oh good, a cut and paste typo ;) Anyhow, applied to the togreg branch of iio.git Might not be pushed out f

[PATCH] staging: dgap: fix sparse warnings for the entire cm_t structure

This patch fixes sparse warnings for the entire cm_t structure This entire structure defines a hardware segment Signed-off-by: Mark Hounschell Tested-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 8 drivers/staging/dgap/dgap.h | 2 +- 2 files changed, 5

[PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

We send packets using a copy-free mechanism (this is the Guest to Host transport via VMBUS). While this is obviously optimal for large packets, it may not be optimal for small packets. Hyper-V host supports a second mechanism for sending packets that is "copy based". We implement that mechanism in

[PATCH] staging: dgap: fix sparse warnings for the entire bs_t structure

This patch fixes sparse warnings for the entire bs_t structure This entire structure defines a hardware segment Signed-off-by: Mark Hounschell Tested-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 22 +++--- drivers/staging/dgap/dgap.h | 4 ++-- 2

[PATCH 1/1] Drivers: hv: balloon: Ensure pressure reports are posted regularly

The current code posts periodic memory pressure status from a dedicated thread. Under some conditions, especially when we are releasing a lot of memory into the guest, we may not send timely pressure reports back to the host. Fix this issue by reporting pressure in all contexts that can be active i

[PATCH] staging: dgap: fix sparse warnings for re_map_membase and re_map_port

This patch fixes sparse warnings for the re_map_membase and re_map_port variables. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 24 drivers/staging/dgap/dgap.h | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote: > On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: > The aim of my patch was basically to add __user annotation. I tried to > keep the change minimal to lessen the risk of regression Yes. That's the right approach. The

Re: [PATCH net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

From: "K. Y. Srinivasan" Date: Tue, 22 Apr 2014 11:03:32 -0700 > + skb = (struct sk_buff *) > + packet->send_completion_tid; As in netvsc_xmit_completion() this must be coded as: skb = (struct sk_buff *) (unsigned long)packet->send_completio

[PATCH] staging: unisys: fix copyright notices

This patch changes all of the various representations of the copyright symbol to (C). Signed-off-by: Benjamin Romer --- drivers/staging/unisys/channels/channel.c | 2 +- drivers/staging/unisys/channels/chanstub.c | 2 +- drivers/staging/

Re: [PATCH net-next,v2,1/2] hyperv: Remove recv_pkt_list and lock

From: Haiyang Zhang Date: Mon, 21 Apr 2014 14:54:43 -0700 > Removed recv_pkt_list and lock, and updated related code, so that > the locking overhead is reduced especially when multiple channels > are in use. > > The recv_pkt_list isn't actually necessary because the packets are > processed seque

Re: [PATCH net-next,v2,2/2] hyperv: Simplify the send_completion variables

From: Haiyang Zhang Date: Mon, 21 Apr 2014 14:54:44 -0700 > The union contains only one member now, so we use the variables in it > directly. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Also applied, thanks. ___ devel mailing l

RE: [PATCH 0/2] Eliminate spin locks in the vmbus channel callback path

> -Original Message- > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > Sent: Tuesday, April 8, 2014 6:45 PM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com > Cc: KY Srinivasan >

[PATCH] staging: panel: fix regression in lcd_write

This patch fix a regression in lcd_write caused by commit 70a8c3eb8546cefe40fb0bc7991e8899b7b91075 Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c in

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: > Out of curiosity, have you tested this patch? > > On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: > > This patch fixes two sparse warnings related to lcd_write : > > warning: incorrect type in argument 1 (different ad

Re: [PATCH] staging/android: Remove ram_console.h

On Tue, Apr 22, 2014 at 2:22 AM, Bintian Wang wrote: > ram_console is replaced by pstore and pstore_ram drivers, > and there is no code to use this head file, so remove it. > > Signed-off-by: Bintian Wang > --- > drivers/staging/android/ram_console.h | 22 -- > 1 file chang

RE: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

On Wednesday, April 23, 2014 12:09 AM, Chase Southwood wrote: >>On Thursday, April 17, 2014 1:33 AM, Chase Southwood >> wrote: > >> The reset function for this driver is a bit of a mess; clean it up to >> ensure that it is functioning properly. >> >> Signed-off-by: Chase Southwood >> --- >> 2: *C

[PATCH 00/02] staging: dgap: Digi International dgap driver

This patch series fixes 2 different BUGS that didn't reveal themselves until the 3.15 series started. patch 1 fixes how we insure the config data is a string. The original code is clearly just wrong. After many loads/unloads of the driver, various OOPs would occure. None of which indicated this

[PATCH 02/02] staging: dgap: Fix BUG in processing config file

This patch fixes an OOPS caused by a pointer being changed between the malloc and free. Signed-off-by: Mark Hounschell Tested-by: Mark Hounschell Reported-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-)

[PATCH 01/02] staging: dgap: Fix how we insure config data is a string

This patch changes the way we insure the config data is a string. Clearly this was just wrong. After a certain number of loads/unloads various OOPs were generated indicating something other than this driver had a problem. It was this driver. Signed-off-by: Mark Hounschell Tested-by: Mark Hounsche

Re: staging: add Lustre file system client support

Btw, what's the trick to navigating the lustre source? I normally do a make cscope but that doesn't work and I am having a very hard time with this code. regards, dan carpenter On Wed, Apr 23, 2014 at 04:54:26PM +0300, Dan Carpenter wrote: > Hello Peng Tao, > > The patch d7e09d0397e8: "staging:

re: staging: add Lustre file system client support

Hello Peng Tao, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/include//linux/libcfs/libcfs_ioctl.h:200 libcfs_ioctl_is_invalid() error: buffer overflow 'data->ioc_bu

Re: [PATCH linux-next v2] staging/rtl8821ae: fix sparse address space warning

On Wed, Apr 23, 2014 at 02:59:46PM +0200, Anders Darander wrote: > Change the definition of pci_mem_start|end from correct from pci_io(un)map's > point of view. > Terrific. Thanks! If you really wanted to then you could just delete pci_mem_end and also you could remove all the casting of pci_mem

[PATCH linux-next v3] staging/rtl8821ae: fix sparse address space warning

Change the definition of pci_mem_start|end from correct from pci_io(un)map's point of view. Signed-off-by: Anders Darander --- Changes v2 - v3 * Fix a style error v1 -> v2: * Change the struct definition instead of casting all pci_iomap and pci_iounmap calls. drivers

[PATCH linux-next v2] staging/rtl8821ae: fix sparse address space warning

Change the definition of pci_mem_start|end from correct from pci_io(un)map's point of view. Signed-off-by: Anders Darander --- Changes v1 -> v2: * Change the struct definition instead of casting all pci_iomap and pci_iounmap calls. drivers/staging/rtl8821ae/pci.c | 14 ++

Re: [PATCH][linux-next] staging/rtl8821ae: fix sparse address space warning

On Wed, Apr 23, 2014 at 02:06:25PM +0200, Anders Darander wrote: > When unmapping the pci memory, the pointer was explicitly casted to void*, > thus omitting the __iomem designation. It looks like the struct definition should be updated instead of every single reference being casted. regards, dan

[PATCH][linux-next] staging/rtl8821ae: fix sparse address space warning

When unmapping the pci memory, the pointer was explicitly casted to void*, thus omitting the __iomem designation. Signed-off-by: Anders Darander --- drivers/staging/rtl8821ae/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/s

Re: [PATCH] staging: silicom: remove redundant pci_get_drvdata() call

2014-04-23 17:35 GMT+09:00, Dan Carpenter : > On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote: >> The pci_get_drvdata() and checking NULL for dev are >> called twice in while loop in is_bypass_dev(). >> >> Signed-off-by: Daeseok Youn >> --- >> This patch has an warning from checkpatch

Re: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

On 2014-04-17 07:33, Chase Southwood wrote: The reset function for this driver is a bit of a mess; clean it up to ensure that it is functioning properly. Signed-off-by: Chase Southwood --- 2: *Changed order of register accesses for digital input registers back to original ordering. *Removed rea

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

On Wed, Apr 23, 2014 at 12:05:57PM +0300, Dan Carpenter wrote: > On Wed, Apr 23, 2014 at 04:49:26PM +0800, Michalis Pappas wrote: > > Hi Dan, thanks for looking at this. From the above snippet I realize > > that I wasn't aware of the strict flag, so significantly less errors > > were produced. > >

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

On Wed, Apr 23, 2014 at 04:49:26PM +0800, Michalis Pappas wrote: > Hi Dan, thanks for looking at this. From the above snippet I realize > that I wasn't aware of the strict flag, so significantly less errors > were produced. > > The issues I was referring to as pedantic are: > > WARNING: unchecked

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

On 04/23/2014 04:04 PM, Dan Carpenter wrote: > On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote: >> After all patches have been applied, the only remaining issue on the >> TODO list is to conform to the coding standards. The remaining issues >> reported by checkpatch.pl are probably

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

On Wed, Apr 23, 2014 at 09:01:24AM +0530, navin patidar wrote: > dan, It is ok to rearrange and remove members of enum LED_STATE_871x > and enum LED_CTL_MODE. > these enum are not related to firmware . Ok. Cool. regards, dan carpenter ___ devel mail

Re: [PATCH] staging: silicom: remove redundant pci_get_drvdata() call

On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote: > The pci_get_drvdata() and checking NULL for dev are > called twice in while loop in is_bypass_dev(). > > Signed-off-by: Daeseok Youn > --- > This patch has an warning from checkpatch.pl. > checkpatch.pl warning: > WARNING: Too many l

[PATCH] staging: silicom: remove redundant pci_get_drvdata() call

The pci_get_drvdata() and checking NULL for dev are called twice in while loop in is_bypass_dev(). Signed-off-by: Daeseok Youn --- This patch has an warning from checkpatch.pl. checkpatch.pl warning: WARNING: Too many leading tabs - consider code refactoring drivers/staging/silicom/bypasslib/by

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote: > After all patches have been applied, the only remaining issue on the > TODO list is to conform to the coding standards. The remaining issues > reported by checkpatch.pl are probably pedantic, so if agreed, that > task can be remove

Re: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

>On Thursday, April 17, 2014 1:33 AM, Chase Southwood > wrote: >The reset function for this driver is a bit of a mess; clean it up to >ensure that it is functioning properly. > >Signed-off-by: Chase Southwood >--- >2: *Changed order of register accesses for digital input registers back to >origi