Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

On Tue, Apr 22, 2014 at 7:58 PM, Larry Finger wrote: > > To me, the opposite case is true. If you have not tested, then you need to > explicitly state "compile tested only" in the commit message. Without saying > that, your signed-off-by is implying that you have tested, as well as > declaring tha

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

dan, It is ok to rearrange and remove members of enum LED_STATE_871x and enum LED_CTL_MODE. these enum are not related to firmware . regards, --navin-patidar On Tue, Apr 22, 2014 at 4:05 PM, Dan Carpenter wrote: > It's ok to renumber all of these? It's not something the firmware will > care a

RE: [PATCH] ion: remove duplicated clearing of sg_table initialization

Thank you for your advice. I sent the patch again. > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, April 22, 2014 7:47 PM > To: Gioh Kim > Cc: 'Greg Kroah-Hartman'; 'John Stultz'; 'Rebecca Schultz Zavin'; > de...@driverdev.osuosl.org; �̰�ȣ > S

[PATCH] Staging: android: ion: duplicated clearing of sg_table

From: "gioh.kim" Because sg_table is cleared in sg_alloc_table via memset we don't need to use kzalloc to allocate sg_table. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_carveout_heap.c |2 +- drivers/staging/android/ion/ion_chunk_heap.c|2 +- drivers/staging/android

[PATCH v3 3/3] staging: gdm72xx: Removed direct comparisons on jiffies

Replaced comparisons on jiffies values with wrap-safe functions. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/staging/gdm72xx/sdio_boot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drive

[PATCH v3 2/3] staging: gdm72xx: Removed completed task from TODO list

Removed line related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function kernel_thread') Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers

Re: [PATCH v3 1/3] staging: gdm72xx: Coding style fixes

Minor white-space fixes as suggested by checkpatch.pl. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_wimax.c | 2 ++ drivers/staging/gdm72xx/usb_boot.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/stag

[PATCH v3 0/3] staging: gdm72xx: Minor cleanup

The following patches perform various cleanups on the gdm72xx driver. PATCH 1/3 fixes some small coding style issues PATCH 2/3 removes an already completed item from the TODO list PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions After all patches have been applied, the only re

Re: [PATCH] staging: iio: Fix typo in iio

On 04/22/14 04:23, Masanari Iida wrote: > Correct spelling typo in comment within staging/iio > > Signed-off-by: Masanari Iida Acked-by: Randy Dunlap Thanks. > --- > drivers/staging/iio/adc/ad7606.h| 4 ++-- > drivers/staging/iio/adc/ad7816.c| 2 +- > drivers/staging/iio/adc/ad799x.h

Re: [PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing

On Wed, Apr 23, 2014 at 01:07:57AM +0300, Dan Carpenter wrote: > On Tue, Apr 22, 2014 at 11:23:02PM +0200, Fabio Falzoi wrote: > > Define pr_fmt macro to prefix every pr_ function in standard way. > > > > In the end we will want to remove all these debugging messages. Ah. I see that you do remo

Re: [PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing

On Tue, Apr 22, 2014 at 11:23:02PM +0200, Fabio Falzoi wrote: > Define pr_fmt macro to prefix every pr_ function in standard way. > In the end we will want to remove all these debugging messages. The error conditions probably already have a print, the function tracing is done better with ftrace,

Re: [PATCH v3 1/6] Staging: rts5139: Camel case labels replaced

On Tue, Apr 22, 2014 at 11:22:59PM +0200, Fabio Falzoi wrote: > @@ -316,7 +316,7 @@ static int rts51x_control_thread(void *__chip) > if (chip->srb->result != DID_ABORT << 16) > chip->srb->scsi_done(chip->srb); > else > -SkipForAbort : > +abort : Ju

[PATCH v3 6/6] Staging: rts5139: More appropriate use of sizeof operand

Use the pointer rts51x to get the size of the struct. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 6120410..8529cba 100644 --- a/drive

[PATCH v3 3/6] Staging: rts5139: Splitted one-line multiple assignment

Splitted a multiple assignment on two separate lines. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 28f4631..2be6210 100644 --- a/dri

[PATCH v3 5/6] Staging: rts5139: Removed OOM messages

All allocation Out Of Memory messages removed. We rely on the generic OOM message in dump_stack(). Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/st

[PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing

Define pr_fmt macro to prefix every pr_ function in standard way. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 100 +++ 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts

[PATCH v3 0/6] Staging: rts5139: Fix coding style

Fix some coding style issues in rts51x.c (from rts5139 module). Changes in v3: * removed all the Out Of Memory messages * redefined pr_fmt to add a prefix to each pr_. Changes in v2: * patch splitted to have just one specific coding style issue fixed at a time Fabio Falzoi (6): Staging: rts5139

[PATCH v3 2/6] Staging: rts5139: Fixed multi-line code alignment

Multi-line code aligned with open parenthesis. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index 9d9c706..28f4631 1

[PATCH v3 1/6] Staging: rts5139: Camel case labels replaced

Replace camel case labels with linux coding style compliant names. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5139/rts51x.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c index c8d

[PATCH net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

We send packets using a copy-free mechanism (this is the Guest to Host transport via VMBUS). While this is obviously optimal for large packets, it may not be optimal for small packets. Hyper-V host supports a second mechanism for sending packets that is "copy based". We implement that mechanism in

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

I sometimes mark my patches as untested and there are a couple other people who do as well. For the staging tree probably 80% of the patches are not tested. I kind of know who regular developers are and who tests their patches. But one thing I really want to stress is that if I ask something abo

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

On 04/22/2014 09:14 AM, Dan Carpenter wrote: On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote: Hi dan it's just a cleanup patch and i also tested all patches of this patch series on the hardware (TP-LINK TL-WN723N). my mistake i should have added "Tested-by" tag for all patches.

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote: > Hi dan > > it's just a cleanup patch and i also tested all patches of this patch > series on the hardware (TP-LINK TL-WN723N). > my mistake i should have added "Tested-by" tag for all patches. > > Tested-by: navin patidar No no.

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

Hi dan it's just a cleanup patch and i also tested all patches of this patch series on the hardware (TP-LINK TL-WN723N). my mistake i should have added "Tested-by" tag for all patches. Tested-by: navin patidar regards, --navin-patidar On Tue, Apr 22, 2014 at 3:41 PM, Dan Carpenter wrote: > O

[PATCH] staging:lustre: use gfp_t instead of int

Fixed several sparse "warning: incorrect type" by replacing int declarations with gfp_t Signed-off-by: Vitaly Osipov --- .../staging/lustre/include/linux/libcfs/libcfs.h |1 + drivers/staging/lustre/lustre/libcfs/module.c |3 ++- drivers/staging/lustre/lustre/libcfs/tracefile.c

[PATCH] staging: iio: Fix typo in iio

Correct spelling typo in comment within staging/iio Signed-off-by: Masanari Iida --- drivers/staging/iio/adc/ad7606.h| 4 ++-- drivers/staging/iio/adc/ad7816.c| 2 +- drivers/staging/iio/adc/ad799x.h| 2 +- drivers/staging/iio/addac/adt7316.c | 4 ++-- drivers/staging/iio/cdc/ad7152.

Re: [PATCH] ion: remove duplicated clearing of sg_table initialization

Patch is corrupt and doesn't apply. Read Documentation/email-clients.txt or use git send-email. Send it to yourself. Save the raw email, including headers and everything, and `cat raw_email.txt | git am`. Review the changelog. When it works then resend it to the list. On Tue, Apr 22, 2014 at 0

Re: [PATCH 1/1] staging: android: Fix warning cast removes address space of expression

On Sun, Apr 20, 2014 at 11:10:57AM +0200, Camille Bordignon wrote: > Fix sparse warning "cast removes address space of expression" > Add lost flag "__user" due to cast > > Signed-off-by: Camille Bordignon This one is the most perfect version of this patch yet. Unfortunately a couple other peopl

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

It's ok to renumber all of these? It's not something the firmware will care about? Have you tested this? Same for patch 10/10. (These questions are just questions. I don't ask rhetorical questions on email. I don't know the answers). regards, dan carpenter __

Re: [PATCH 05/10] staging: rtl8188eu: Simplify led blinking strategy code.

Minor white space complaints. On Sun, Apr 20, 2014 at 02:17:13PM +0530, navin patidar wrote: > @@ -1334,7 +316,7 @@ static void SwLedControlMode4(struct adapter *padapter, > enum LED_CTL_MODE LedAct > else > pLed->BlinkingLedState = RTW_LED_ON;

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote: > _ReadLEDSetting() doesn't read led settings this function actually > initialize member variables of struct led_priv, we should do that > inside rtl8188eu_InitSwLeds(). > This seems like a bugfix or is it just a cleanup? It's not c

Re: [PATCH] ced1401 coding style fixes

The subject is in the wrong format. It should be: [PATCH 1/3] Staging: ced1401: fix long lines [PATCH 2/3] Staging: ced1401: add blank lines after declarations [PATCH 3/3] Staging: ced1401: remove unused typedefs Btw, break it up into 3 patches. regards, dan carpenter _

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

Out of curiosity, have you tested this patch? On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: > This patch fixes two sparse warnings related to lcd_write : > warning: incorrect type in argument 1 (different address spaces) > warning: incorrect type in initializer (incompatible argu

Re: [PATCH] Staging:dgap:dgap_tty.c: Upgraded driver to use Mutex instead of semaphore

On Thu, Apr 17, 2014 at 09:25:32PM +0530, Kumar Gaurav wrote: > dgap driver uses semaphore for obtaining lock. I upgraded it to use MUTEX. > You are patching ancient code that doesn't exist. Work against linux-next. regards, dan carpenter ___ devel m

Re: [PATCH 00/26] staging: comedi: round 2 of async command support cleanup

On 2014-04-17 18:07, H Hartley Sweeten wrote: This series continues the cleanup of the comedi async command support. H Hartley Sweeten (26): staging: comedi: drivers: core validates chanlist_len max staging: comedi: drivers: properly validate cmd->scan_end_arg staging: comedi: addi_apci

Re: [PATCH v2 3/3] staging: gdm72xx: Minor cleanup

These patches are all good but the subjects for all three are the same and quite bad. Please fix this and resend. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driver

Re: [PATCH v2 2/3] staging: gdm72xx: Minor cleanup

On Sun, Apr 20, 2014 at 11:36:54AM +0800, Michalis Pappas wrote: > > Removed line related to replacement of kernel_thread with kthread, > as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8. > In the future, the way to specify a commit is: ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix

[PATCH] staging/android: Remove ram_console.h

ram_console is replaced by pstore and pstore_ram drivers, and there is no code to use this head file, so remove it. Signed-off-by: Bintian Wang --- drivers/staging/android/ram_console.h | 22 -- 1 file changed, 22 deletions(-) delete mode 100644 drivers/staging/android/ram

Re: [PATCH v2 1/2] Staging: dgnc: dgnc_driver: fixed dgnc_pci_tbl definition

I like the idea of this patch but the v2 version still doesn't compile. I don't understand how you can write such a nice patch and not even test that it compiles. Twice. That's not ok. On Sun, Apr 20, 2014 at 06:05:38PM +, Son P. Nguyen wrote: > From: "Son P. Nguyen" Don't include this whe

[PATCH] ion: remove duplicated clearing of sg_table initialization

Hi, I found a duplicated zeroing at sg_table initialization in ION of linux- 3.15.0-rc2 version. Here is my patch. Subject: [PATCH] ion: remove duplicated clearing of sg_table initialization Because sg_table is cleared in sg_alloc_table via memset we don't need to use kzalloc to allocate sg_tabl