Re: [report] staging: r8723au: rtw_report_sec_ie23a() is buggy

Dan Carpenter writes: > Hello Larry, Jes, > > The rtw_report_sec_ie23a() is very buggy. > > 1) It uses GFP_KERNEL but the callers are holding a spinlock. > > rtw_select_and_join_from_scanned_queue23a() <- takes lock > -> rtw_joinbss_cmd23a() >-> rtw_restruct_sec_ie23a() >

[PATCH] staging: vt6656: fix sparse warning

This patch fixes the following warning: drivers/staging/vt6656/aes_ccmp.c:221:6: warning: symbol 'AESbGenCCMP' was not declared. Should it be static? Signed-off-by: Angus Gibson --- drivers/staging/vt6656/aes_ccmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vt6656/aes_

Re: [PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c

On Mon, Apr 14, 2014 at 12:13:03AM +0200, Paul Bolle wrote: > On Mon, 2014-04-14 at 01:07 +0300, Dan Carpenter wrote: > > The long description was fine. It included a copy of the error message > > and everything. > > This is what I saw in the body of the message above the "---" line: > From:

[PATCH v2] bcm: Fixing a few checkpatch issues in InterfaceMisc.h

Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h. I converted some spaces to tabs, and removed unnecessary whitespace. The kernel version I am using linux-next-20140411. Signed-off-by: Julian Gindi --- drivers/staging/bcm/InterfaceMisc.h | 12 ++-- 1 file changed,

Re: [PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c

On Mon, 2014-04-14 at 01:07 +0300, Dan Carpenter wrote: > The long description was fine. It included a copy of the error message > and everything. This is what I saw in the body of the message above the "---" line: From: Pascal COMBES Fix alignement problems in drivers/staging/crystalhd

Re: [PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c

On Sun, Apr 13, 2014 at 11:26:15PM +0200, Paul Bolle wrote: > On Mon, 2014-04-14 at 00:02 +0300, Dan Carpenter wrote: > > The subeject should be: > > > > [PATCH v2 1/3] Staging: crystalhd: Fix alignement in crystalhd_lnx.c > > > > Please resend it. Also you should use shorter subject lines. > >

Re: [PATCH v2 2/3] Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c

On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote: > From: Pascal COMBES > > Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c: > No space needed before a cast. > > Signed-off-by: Pascal COMBES > --- > diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c > b/drivers/

Re: [PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c

On Mon, 2014-04-14 at 00:02 +0300, Dan Carpenter wrote: > The subeject should be: > > [PATCH v2 1/3] Staging: crystalhd: Fix alignement in crystalhd_lnx.c > > Please resend it. Also you should use shorter subject lines. > > "Fix coding style problem (cast with space) in > drivers/staging/cryst

Re: [PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c

The subeject should be: [PATCH v2 1/3] Staging: crystalhd: Fix alignement in crystalhd_lnx.c Please resend it. Also you should use shorter subject lines. "Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c" This is too long. Say: "Remove a stray space ch

Re: [PATCH] bcm: Fixing a few checkpatch issues in InterfaceMisc.h

On Sun, Apr 13, 2014 at 02:56:57PM -0400, JulianGindi wrote: > Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h. I > converted some spaces to tabs, and removed unnecessary whitespace. The kernel > version I am using linux-next-20140411. That's a very long line, please wrap

[PATCH v2 3/3] Fix coding style problem (sizeof with type) in drivers/staging/crystalhd/crystalhd_lnx.c

From: Pascal COMBES Replace sizeof(type) by sizeof(variable) in drivers/staging/crystalhd/crystalhd_lnx.c. Signed-off-by: Pascal COMBES --- diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c index 15e8f02..7b14b28 100644 --- a/drivers/staging/crys

[PATCH v2 2/3] Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c

From: Pascal COMBES Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c: No space needed before a cast. Signed-off-by: Pascal COMBES --- diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c index fd7f08a..15e8f02 100644 --- a/driv

[PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c

From: Pascal COMBES Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c. Signed-off-by: Pascal COMBES --- As asked I split the patch in three (because I'm addressing 3 types of problems). I also took into account your last comment: What I did seemmed better to me, but as I'm n

[PATCH] bcm: Fixing a few checkpatch issues in InterfaceMisc.h

Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h. I converted some spaces to tabs, and removed unnecessary whitespace. The kernel version I am using linux-next-20140411. Signed-off-by: JulianGindi --- drivers/staging/bcm/InterfaceMisc.h | 12 ++-- 1 file changed,

[PATCH] staging/rtl8187se fix sparse complaints

Fix the following sparse complaints: drivers/staging/rtl8187se//r8180_wx.c:1399:24: warning: symbol 'r8180_wx_handlers_def' was not declared. Should it be static? drivers/staging/rtl8187se//ieee80211/ieee80211_crypt.c:201:5: warning: symbol 'ieee80211_crypto_init' was not declared. Should it be

[PATCH] staging: wlan-ng: Fix sparse warnings

From: Sarath Lakshman Fixed missed declarations for few non-static functions. Signed-off-by: Sarath Lakshman --- drivers/staging/wlan-ng/cfg80211.c | 1 + drivers/staging/wlan-ng/prism2mgmt.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/dri

Re: [PATCH] Fix coding style in drivers/staging/crystalhd/crystalhd_lnx.c

On Sun, Apr 13, 2014 at 05:35:46PM +0200, Pascal COMBES wrote: > From: Pascal COMBES > > Fix alignement issues and two or three other coding style problems in > drivers/staging/crystalhd/crystalhd_lnx.c. Patches need to do one thing, as you are addressing a number of different things all in one

[PATCH] Fix coding style in drivers/staging/crystalhd/crystalhd_lnx.c

From: Pascal COMBES Fix alignement issues and two or three other coding style problems in drivers/staging/crystalhd/crystalhd_lnx.c. NB: -I did this for task 10 of Eudyptula challenge -I did not address camel case related problem because it would h

Re: [PATCH 3/4] staging: imx-hdmi: clear all hotplug IRQs on bind

On Fri, Apr 11, 2014 at 04:13:34PM +0200, Lucas Stach wrote: > Makes sure we don't receive a stray IRQ on startup. > > Signed-off-by: Lucas Stach > --- > drivers/staging/imx-drm/imx-hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/imx-drm/imx-hdmi.

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

On Fri, Apr 11, 2014 at 04:13:33PM +0200, Lucas Stach wrote: > Make sure that we probe for a display on detect regardless > of previous hotplug events. Don't handle connector > hotplug state ourselves, but let DRM do the right thing > for us. This brings our hotplug handling in line with > what oth

Re: [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices

Hi, On 04/11/2014 09:15 AM, Jean Delvare wrote: > The sn9c102 driver is deprecated. It was moved to staging in > anticipation of its removal in a future kernel version. However, USB > devices 0C45:6024 and 0C45:6025 are still handled by sn9c102 when > both sn9c102 and gspca_sonixb are enabled. >

[PATCH] staging: wlan-ng: use pr_err() instead of KERN_ERR

All files in drivers/staging/wlan-ng updated to use pr_err Signed-off-by: Vitaly Osipov --- drivers/staging/wlan-ng/p80211conv.c | 24 +-- drivers/staging/wlan-ng/p80211netdev.c |7 ++- drivers/staging/wlan-ng/p80211req.c|3 +- drivers/staging/wlan-ng/prism2fw.c | 6