From: Roger Tseng
Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
USB card reader MFD driver.
Signed-off-by: Roger Tseng
Acked-by: Ulf Hansson
---
drivers/mmc/host/Kconfig |7 +
drivers/mmc/host/Makefile |1 +
drivers/mmc/host/rtsx_usb_sd
From: Roger Tseng
This patchset adds modules to support Realtek USB vendor specific class flash
card reader: one base module in MFD subsystem and two host modules in both mmc
and memstick subsystems. The architecture is similar to rtsx_pci.
This work is done primarily to replace the staging driv
From: Roger Tseng
Realtek USB memstick host driver provides memstick host support based on the
Realtek USB card reader MFD driver.
Signed-off-by: Roger Tseng
---
drivers/memstick/host/Kconfig | 10 +
drivers/memstick/host/Makefile | 1 +
drivers/memstick/host/rtsx_usb_ms.c | 839
From: Roger Tseng
Fix two possible race condition generated by misuse of del_timer in
rtsx_usb_bulk_transfer_sglist() and uninitialized timers before mfd_add_devices
in rtsx_usb_probe().
Signed-off-by: Roger Tseng
---
drivers/mfd/rtsx_usb.c | 8
1 file changed, 4 insertions(+), 4 dele
From: Roger Tseng
Explain why there is no need to have a symmetric LED turn-on in resume handler
while calling rtsx_usb_turn_off_led() in suspend handler.
Signed-off-by: Roger Tseng
---
drivers/mfd/rtsx_usb.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/mfd/rtsx_usb.c b/dr
On 04/10/2014 07:27 PM, Greg KH wrote:
> On Thu, Apr 10, 2014 at 06:56:01PM -0400, Marcos A. Di Pietro wrote:
>> On 04/10/2014 04:55 PM, Greg KH wrote:
>>> On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote:
On 04/10/2014 04:14 PM, Greg KH wrote:
> On Tue, Mar 25, 2014 at
On 04/10/2014 07:56 PM, Greg KH wrote:
> On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote:
>>> That's pretty obviously not going to apply properly, you have line-wrapp
>>> on. You can't cut-and-paste patches into gmail, see
>>> Documentation/email_clients.txt for details.
>>>
>>
On Fri, Mar 21, 2014 at 11:38:26AM -0500, Romer, Benjamin M wrote:
> This patch removes the GUID type from the s-Par modules and replaces it
> with the standard uuid_le type.
>
> guidutils.h was removed entirely, and references to it were replaced
> with linux/uuid.h. In some cases, includes were
On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote:
> > That's pretty obviously not going to apply properly, you have line-wrapp
> > on. You can't cut-and-paste patches into gmail, see
> > Documentation/email_clients.txt for details.
> >
> > thanks,
> >
> > greg k-h
> >
> I'm s
On 04/10/2014 07:27 PM, Greg KH wrote:
> On Thu, Apr 10, 2014 at 06:56:01PM -0400, Marcos A. Di Pietro wrote:
>> On 04/10/2014 04:55 PM, Greg KH wrote:
>>> On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote:
On 04/10/2014 04:14 PM, Greg KH wrote:
> On Tue, Mar 25, 2014 at
On Thu, Apr 10, 2014 at 06:56:01PM -0400, Marcos A. Di Pietro wrote:
> On 04/10/2014 04:55 PM, Greg KH wrote:
> > On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote:
> >> On 04/10/2014 04:14 PM, Greg KH wrote:
> >>> On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrot
On 04/10/2014 04:55 PM, Greg KH wrote:
> On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote:
>> On 04/10/2014 04:14 PM, Greg KH wrote:
>>> On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote:
Fixes code style errors in drivers/staging/bcm/Qos.c
Patch
On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote:
> On 04/10/2014 04:14 PM, Greg KH wrote:
> > On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote:
> >> Fixes code style errors in drivers/staging/bcm/Qos.c
> >>
> >> Patch submitted as part of the Eudyptula Challen
On Thu, Apr 10, 2014 at 10:08:52AM -0500, Romer, Benjamin M wrote:
> This patch replaces the inconsistent copyright symbols in each source
> file with (C).
>
> Signed-off-by: Benjamin Romer
> ---
This patch is in base64, which ok, I can handle, as git can deal with
that. But then it totally fai
On 04/10/2014 04:14 PM, Greg KH wrote:
> On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote:
>> Fixes code style errors in drivers/staging/bcm/Qos.c
>>
>> Patch submitted as part of the Eudyptula Challenge.
>>
>> Signed-off-by: Marcos A. Di Pietro
>> ---
>> drivers/staging/bcm/Qo
On Sat, Apr 05, 2014 at 12:32:07AM +0200, Silvio Fricke wrote:
> Hi Dan,
>
> thanks for your review.
> Attached second version of this series.
I don't understand what the [WIP] marking is. Please just resend these
as "real" patches if you feel they are ready to be merged. If we have
issues with
On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote:
> Fixes code style errors in drivers/staging/bcm/Qos.c
>
> Patch submitted as part of the Eudyptula Challenge.
>
> Signed-off-by: Marcos A. Di Pietro
> ---
> drivers/staging/bcm/Qos.c | 13 -
> 1 file changed, 8 in
On Fri, Apr 04, 2014 at 11:10:51PM +0200, Camille Begue wrote:
> Wrap lines > 80 columns.
>
> Signed-off-by: Camille Begue
Unfortunatly someone sent this same patch a few days before you, so I
had to accept that one, not this one, sorry.
Feel free to send other cleanup patches, we need all the
Mmapping a comedi data buffer with lockdep checking enabled produced the
following kernel debug messages:
==
[ INFO: possible circular locking dependency detected ]
3.5.0-rc3-ija1+ #9 Tainted: G C
-
Hi Larry,
On Thu, Apr 10, 2014 at 8:01 PM, Larry Finger wrote:
> On 04/10/2014 12:46 PM, Geert Uytterhoeven wrote:
>>
>> drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function
>> ‘WMMOnAssocRsp23a’:
>> drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx’
>> may be used u
On 04/10/2014 12:46 PM, Geert Uytterhoeven wrote:
drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp23a’:
drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx’ may
be used uninitialized in this function
Depending on the uninitialized data on the stack
drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp23a’:
drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx’ may
be used uninitialized in this function
Depending on the uninitialized data on the stack, the array may not be
sorted correctly.
Signed-off
On Thu, Apr 10, 2014 at 07:59:38AM +, Narasimharao Bolisetti wrote:
>
> Hi,
>
> I have checked the same in the recent kernel versions also. Issue is still
> remain.
What versions have you tried, and what are the logs from those versions?
> ::DISCLAIMER::
> -
On Thu, Apr 10, 2014 at 06:21:36PM +0300, Dan Carpenter wrote:
> The thing about keeping e100 in parallel with the other driver is that
> some devices didn't work on the other driver and also it wasn't staging
> code.
>
> I don't have strong opinions either way, but if we decide to keep the
> old
The thing about keeping e100 in parallel with the other driver is that
some devices didn't work on the other driver and also it wasn't staging
code.
I don't have strong opinions either way, but if we decide to keep the
old driver around for another kernel release "just in case" then we
should make
This patch replaces the inconsistent copyright symbols in each source
file with (C).
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/channels/channel.c | 2 +-
drivers/staging/unisys/channels/chanstub.c | 2 +-
drivers/staging/u
On Wed, 2014-04-09 at 12:25 -0700, Greg Kroah-Hartman wrote:
> Patches need to do only one thing, so can you please split this up in to
> multiple patches, each one only doing one thing.
Sorry about that! I'll send another patch that fixes all of the
copyright statements at once then. :)
> You fo
Dan Carpenter writes:
> Hello Larry, Jes,
>
> The rtw_report_sec_ie23a() is very buggy.
>
> 1) It uses GFP_KERNEL but the callers are holding a spinlock.
>
> rtw_select_and_join_from_scanned_queue23a() <- takes lock
> -> rtw_joinbss_cmd23a()
>-> rtw_restruct_sec_ie23a()
>
On 2014-04-10 15:38, Michele Curti wrote:
das6402_boards array is used in das6402.c only, so declare it as static.
Signed-off-by: Michele Curti
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
__
On Thu, Apr 10, 2014 at 04:38:00PM +0200, Michele Curti wrote:
>
> das6402_boards array is used in das6402.c only, so declare it as static.
>
> Signed-off-by: Michele Curti
Looks good.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverp
das6402_boards array is used in das6402.c only, so declare it as static.
Signed-off-by: Michele Curti
---
drivers/staging/comedi/drivers/das6402.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das6402.c
b/drivers/staging/comedi/drivers/das64
Hello Larry, Jes,
The rtw_report_sec_ie23a() is very buggy.
1) It uses GFP_KERNEL but the callers are holding a spinlock.
rtw_select_and_join_from_scanned_queue23a() <- takes lock
-> rtw_joinbss_cmd23a()
-> rtw_restruct_sec_ie23a()
-> rtw_report_sec_ie23a
On Thu, Apr 10, 2014 at 03:54:47PM +0200, Michele Curti wrote:
> Hi,
> das6402_boards array seems to be used in das6402.c only, so declare it
> as static.
>
> This patch applies to linux-next next-20140410.
>
> Regards,
> Michele
>
The patch is fine, but you
Hi,
das6402_boards array seems to be used in das6402.c only, so declare it
as static.
This patch applies to linux-next next-20140410.
Regards,
Michele
Signed-off-by: Michele Curti
---
drivers/staging/comedi/drivers/das6402.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Fix all occurences of the checkpatch error:
ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: Mark Einon
---
drivers/staging/rtl8821ae/rtl8821ae/hw.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.h
b/drivers/staging/rt
Fix checkpatch warnings, lines over 80 chars using tabs where possible.
Signed-off-by: Mark Einon
---
drivers/staging/rtl8821ae/rtl8821ae/hw.h | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.h
b/drivers/s
Fix checkpatch check:
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.
Signed-off-by: Mark Einon
---
drivers/s
On Thu, Apr 10, 2014 at 09:57:23PM +1000, Vitaly Osipov wrote:
> Thanks, that's helpful - I for some reason thought that multi-part
> patch had to have more or less uniform subject. We the checkpatch.pl
> people come from http://www.eudyptula-challenge.org/, where at some
> stage we are told to sub
Thanks, that's helpful - I for some reason thought that multi-part
patch had to have more or less uniform subject. We the checkpatch.pl
people come from http://www.eudyptula-challenge.org/, where at some
stage we are told to submit a patch for a single style issue in the
staging tree. All newbies..
The two subjects are really close to being the same. You should choose
better subjects. Like:
[PATCH 2/2] staging: media: omap24xx: use pr_info() instead of KERN_INFO
(All the checkpatch.pl people use the exact same subject for everything
though, so you're not alone in this).
regards,
dan car
These should be using the _safe version of list_for_each() because we
free the current element and it leads to a use after free bug.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/drivers/staging/unisys/visorchipset/visorchipset.h
index d4bf203..d
We dereference "bus" when we report the error so we have to move the
kfree() down a couple lines.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib/uislib.c
index 8ea9c46..3152a21 100644
--- a/drivers/staging/unisys/uislib/uislib.c
From: Dan Carpenter
...
> > - if (auth_alg == 2) {
> > + if (auth_alg == dot11AuthAlgrthm_8021X) {
> > + /* get ether_type */
> > + ptr = ptr + pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;
> > + memcpy(ðer_type, ptr, 2);
> > + ether_type = ntohs((unsigned shor
tcm825x.c:
changed printk to pr_info
Signed-off-by: Vitaly Osipov
---
drivers/staging/media/omap24xx/tcm825x.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/omap24xx/tcm825x.c
b/drivers/staging/media/omap24xx/tcm825x.c
index 2326481..3367ccd 1
tcm825x.c and tcm825x.h:
fixing ERROR: Macros with complex values should be enclosed in parenthesis
Signed-off-by: Vitaly Osipov
---
drivers/staging/media/omap24xx/tcm825x.c |8
drivers/staging/media/omap24xx/tcm825x.h |4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
Hi,
I have checked the same in the recent kernel versions also. Issue is still
remain.
Regards,
Narasimharao B
-Original Message-
From: Willy Tarreau [mailto:w...@1wt.eu]
Sent: 10 April 2014 13:26
To: narasimharo bolisetti
Cc: linux-ker...@vger.kernel.org; kernelnewb...@nl.linux.org;
On Thu, Apr 10, 2014 at 12:05:52AM -0700, narasimharo bolisetti wrote:
> My kernel version is:
> 2.6.35.6-45.fc14.i686
Maintenance for this kernel has been dropped years ago, so it very
likely contains many bugs that were fixed in more recent ones. You
should definitely upgrade.
Hoping this he
Hi Greg/All,
This is Narasimharao working for a s/wcompany HCLT..
I am working a issue and
the description is below:
system stops booting and
needs a series of console inputs (space bar or return) to
continue booting. Each input advances the process a little
bit.
Actuall
48 matches
Mail list logo
