[PATCH] staging rtl8188eu: add a blank line after declarations

fix a coding style issue: Missing a blank line after declarations Signed-off-by: huanqi chi --- drivers/staging/rtl8188eu/core/rtw_br_ext.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_br_ext.c b/drivers/staging/rtl8188eu/core/rtw_b

Re: [PATCH] staging rtl8188eu: add a blank line after declarations

On Sat, Apr 05, 2014 at 12:56:43PM +0800, chihuanqi wrote: > fix a coding style issue: Missing a blank line after declarations > > Signed-off-by: chihuanqi I need a "real" name here. Appologies if you only have one word for a name, but most countries that is not the norm. thanks, greg k-h ___

[PATCH] staging rtl8188eu: add a blank line after declarations

fix a coding style issue: Missing a blank line after declarations Signed-off-by: chihuanqi --- drivers/staging/rtl8188eu/core/rtw_br_ext.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_br_ext.c b/drivers/staging/rtl8188eu/core/rtw_br

[WIP] [PATCH v2 2/3] staging: vt6655: removed incorrect casting in ioctl.c

This patch fixes the following type of sparse warnings: drivers/staging/vt6655/ioctl.c:308:104: warning: cast from restricted gfp_t drivers/staging/vt6655/ioctl.c:579:109: warning: cast from restricted gfp_t Signed-off-by: Silvio Fricke --- drivers/staging/vt6655/ioctl.c | 6 -- 1 file chan

[WIP] [PATCH v2 0/3] remove wrong cast of gfp_t flags

Hi Dan, thanks for your review. Attached second version of this series. Cheers, Silvio Silvio Fricke (3): staging: vt6655: removed incorrect casting in wpactl.c staging: vt6655: removed incorrect casting in ioctl.c staging: vt6655: removed incorrect casting in iwctl.c drivers/st

[WIP] [PATCH v2 3/3] staging: vt6655: removed incorrect casting in iwctl.c

This patch fixes the following type of sparse warning: drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted gfp_t Signed-off-by: Silvio Fricke --- drivers/staging/vt6655/iwctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/iwctl.c b

[WIP] [PATCH v2 1/3] staging: vt6655: removed incorrect casting in wpactl.c

This patch fixes the following type of sparse warnings: drivers/staging/vt6655/wpactl.c:596:47: warning: cast from restricted gfp_t drivers/staging/vt6655/wpactl.c:638:68: warning: cast from restricted gfp_t drivers/staging/vt6655/wpactl.c:860:42: warning: cast from restricted gfp_t Signed-off-by

[PATCH v3] Staging: lustre: mark a variable static in workitem.c

This fixes a sparse warning: warning: symbol 'cfs_wi_data' was not declared. Should it be static? Signed-off-by: Mike Sampson --- v3: updated the changelog drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre

Re: [PATCH v3 1/1] staging: comedi: Fix checkpatch warning

On Fri, 2014-04-04 at 22:57 +0200, Camille Begue wrote: > Wrap lines > 80 columns. > This patch is part of eudyptula challenge No one cares about the eudyptula challenge (whatever that is) as part of a changelog. ___ devel mailing list de...@linuxdrive

Re: [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch

On Fri, Apr 04, 2014 at 06:44:44PM +0300, Kumar Amit Mehta wrote: > Kernel style is that if one side of the if else statement gets has curly > braces then both side should have them. > > Signed-off-by: Kumar Amit Mehta Looks good, thanks. regards, dan carpenter

Re: [PATCH v4 1/1] staging: comedi: Fix checkpatch warning

On Fri, Apr 04, 2014 at 11:10:51PM +0200, Camille Begue wrote: > Wrap lines > 80 columns. > > Signed-off-by: Camille Begue Looks good now. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.

Re: [PATCH 1/1] staging: comedi: Fix checkpatch warning

On Fri, Apr 04, 2014 at 09:15:39PM +0200, Camille Begue wrote: > This patch is part of eudyptula challenge > The changelog should mention something about lines over 80 characte long. > Signed-off-by: Camille Begue > --- > drivers/staging/comedi/comedi_fops.c | 7 +-- > 1 file changed, 5 in

[patch] staging: r8188eu: cleanup by using "len" consistently

"*(p + 1)" and "len" are the same thing. For reviewers who don't know that, then this code is worrying because we cap "len", but pass "*(p + 1)" to memcpy(). I have changed the code to use "len" throughout. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c

[PATCH v4 1/1] staging: comedi: Fix checkpatch warning

Wrap lines > 80 columns. Signed-off-by: Camille Begue --- drivers/staging/comedi/comedi_fops.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index ea6dc36..252505b 100644 --- a/drivers/stagi

[PATCH v3 1/1] staging: comedi: Fix checkpatch warning

Wrap lines > 80 columns. This patch is part of eudyptula challenge Signed-off-by: Camille Begue --- drivers/staging/comedi/comedi_fops.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index e

[PATCH v2 1/1] staging: comedi: Fix checkpatch warning

Wrap lines > 80 columns. This patch is part of eudyptula challenge Signed-off-by: Camille Begue --- drivers/staging/comedi/comedi_fops.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index e

Re: [PATCH] Staging: unisys: verify that a control channel exists

On Fri, Apr 04, 2014 at 02:38:24PM -0400, Sasha Levin wrote: > The code didn't verify that a control channel exists before trying to > use it. It caused NULL ptr derefs which were easy to trigger by an > unpriviliged user simply by reading the proc file, causing: Ugh, what a mess... Thanks for th

Re: [PATCH 1/1] staging: comedi: Fix checkpatch warning

On Fri, 2014-04-04 at 21:15 +0200, Camille Begue wrote: > This patch is part of eudyptula challenge Hello Camille. Please do not write commit log messages like this. Say what's wrong with the code, not why you did it. Write something like: Wrap lines > 80 columns. > diff --git a/drivers/stagin

[PATCH v2] staging: panel: add blank lines after declarations

This patch fixes "Missing a blank line after declarations" checkpatch warnings in panel.c. Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index 0

[PATCH 1/1] staging: comedi: Fix checkpatch warning

This patch is part of eudyptula challenge Signed-off-by: Camille Begue --- drivers/staging/comedi/comedi_fops.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index ea6dc36..0f05e87 100644 --

[PATCH] Staging: unisys: verify that a control channel exists

The code didn't verify that a control channel exists before trying to use it. It caused NULL ptr derefs which were easy to trigger by an unpriviliged user simply by reading the proc file, causing: [ 68.161404] BUG: unable to handle kernel NULL pointer dereference at (null) [ 68.1624

[PATCHv3 1/1] staging/bcm fix hostmibs.c checkpatch problems

Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Signed-off-by: Jake Edge --- Against next-20140403 v3: fixes suggested by Dan Carpenter v2: fixes suggested by Joe Perches There are still some > 80 length lines that require more substantive rework to fix. drivers/staging/bcm/hostmib

[PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch

Kernel style is that if one side of the if else statement gets has curly braces then both side should have them. Signed-off-by: Kumar Amit Mehta --- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl812

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

On Fri, 2014-04-04 at 18:17 +0300, Kumar Amit Mehta wrote: > What Walter mentioned also makes sense, So shouldn't it be something > like this: I'm not Dan, but: > [amit@localhost linux-next]$ git diff > diff --git a/drivers/staging/comedi/drivers/pcl812.c > b/drivers/staging/comedi/drivers/pcl812

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

On Fri, Apr 04, 2014 at 06:17:56PM +0300, Kumar Amit Mehta wrote: > On Fri, Apr 04, 2014 at 04:26:51PM +0300, Dan Carpenter wrote: > > On Fri, Apr 04, 2014 at 02:48:52PM +0300, Kumar Amit Mehta wrote: > > > On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > > > > On Fri, Apr 04, 2014

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

On Fri, Apr 04, 2014 at 04:26:51PM +0300, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 02:48:52PM +0300, Kumar Amit Mehta wrote: > > On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > > > On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > > > > Fixed a coding style

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

On Fri, Apr 04, 2014 at 02:46:14PM +0300, Kristina Martšenko wrote: > Yes, I didn't find any interrupt handlers either, which is partially why > I thought it was (probably) safe. What's the other part of why it was safe? Put that stuff in the changelog. When we're reviewing patches we're always

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

On Fri, Apr 04, 2014 at 02:48:52PM +0300, Kumar Amit Mehta wrote: > On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > > On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > > > Fixed a coding style issue. Reported by checkpatch.pl > > > > > > > It's better if the com

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

Am 04.04.2014 12:05, schrieb Kumar Amit Mehta: > Fixed a coding style issue. Reported by checkpatch.pl > > Signed-off-by: Kumar Amit Mehta > --- > drivers/staging/comedi/drivers/pcl812.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > > Fixed a coding style issue. Reported by checkpatch.pl > > > > It's better if the commit messages are more specific than this. So, should I resend the patch with

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

On 04/04/14 14:04, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 12:26:27PM +0300, Kristina Martšenko wrote: >> On 03/04/14 13:13, Dan Carpenter wrote: >>> On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote: On 03/04/14 11:32, Dan Carpenter wrote: > On Tue, Mar 25, 2014 at

Re: [PATCH] Staging: lustre: mark a variable static in workitem.c

On Fri, Apr 04, 2014 at 07:22:25PM +1100, Mike Sampson wrote: > next-20140403: This fixes a sparse warning: ^ Just leave this out. Either it applies when Greg gets around to it, or you'll have to redo it. If you want to add this information then put it directly after the --- cut of

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > Fixed a coding style issue. Reported by checkpatch.pl > It's better if the commit messages are more specific than this. regards, dan carpenter ___ devel mailing list de...@linuxdriver

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

On Fri, Apr 04, 2014 at 12:26:27PM +0300, Kristina Martšenko wrote: > On 03/04/14 13:13, Dan Carpenter wrote: > > On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote: > >> On 03/04/14 11:32, Dan Carpenter wrote: > >>> On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote

[PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

Fixed a coding style issue. Reported by checkpatch.pl Signed-off-by: Kumar Amit Mehta --- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c index 160eac8

Re: [PATCH v3] staging: comedi: s626: use comedi_timeout() on remaining loops

On 2014-04-04 00:43, Chase Southwood wrote: There were just a handful of more while loops in this file that needed timeouts, and this patch takes care of them. One new callback is introduced, and all of the proper comedi_timeout() calls are then used. The return type of s626_i2c_handshake() has

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

On 03/04/14 13:13, Dan Carpenter wrote: > On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote: >> On 03/04/14 11:32, Dan Carpenter wrote: >>> On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote: Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by

[PATCH] Staging: lustre: mark a variable static in workitem.c

next-20140403: This fixes a sparse warning: warning: symbol 'cfs_wi_data' was not declared. Should it be static? Signed-off-by: Mike Sampson --- drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/libc

Re: [PATCH] staging: vme: Simplfy string usage in vme_user_probe()

looks good to me reviewed-by: wharms @Bojan Prtvar: please note that i am not the maintainer Am 03.04.2014 18:56, schrieb Bojan Prtvar: > We can avoid usage of sprintf() and magic-sized array with simple pointer > assignment. > > Signed-off-by: Bojan Prtvar > --- > This parch should be appl