[PATCH] staging: netlogic: fix missing a blank line after declarations

2014-04-01 Thread Toby Smith
Fix checkpatch.pl issues with missing blank line after declarations. Signed-off-by: Toby Smith --- drivers/staging/netlogic/xlr_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index c83e337..75d7c63 100644 --- a/d

Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver

2014-04-01 Thread Andrew Morton
On Tue, 1 Apr 2014 11:20:32 +0800 Roger wrote: > On 03/25/2014 06:44 PM, rogera...@realtek.com wrote: > > From: Roger Tseng > > > > Realtek USB memstick host driver provides memstick host support based on the > > Realtek USB card reader MFD driver. > > > > Signed-off-by: Roger Tseng > > --- > >

Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 01:56:02PM -0300, Guido Martínez wrote: > On Tue, Apr 01, 2014 at 09:33:00AM -0700, Greg KH wrote: > > On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote: > > > Parenthesize both macros so they will not break program logic if used > > > within another 'if'. Also

Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-01 Thread Guido Martínez
On Tue, Apr 01, 2014 at 09:33:00AM -0700, Greg KH wrote: > On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote: > > Parenthesize both macros so they will not break program logic if used > > within another 'if'. Also fix a usage of DBG_PRT with a missing > > semicolon. > > > > Signed-off

[PATCH v4 2/3] staging: serqt_usb2: Add blank line after declaration

2014-04-01 Thread Thomas Vegas
Use a more common kernel coding style. Signed-off-by: Thomas Vegas --- drivers/staging/serqt_usb2/serqt_usb2.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c index 90cf2bd..f329cb4 1

[PATCH v4 3/3] staging: serqt_usb2: Clean up initializations of variables

2014-04-01 Thread Thomas Vegas
Use a more common kernel coding style. Signed-off-by: Thomas Vegas --- drivers/staging/serqt_usb2/serqt_usb2.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c index f329cb4..

[PATCH v4 1/3] staging: serqt_usb2: Remove useless variable

2014-04-01 Thread Thomas Vegas
Use a more common kernel coding style. Signed-off-by: Thomas Vegas --- drivers/staging/serqt_usb2/serqt_usb2.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c index 0267dd8..90cf2bd 10

[PATCH v4 0/3] Various cleanups in drivers/staging/serqt_usb2

2014-04-01 Thread Thomas Vegas
Various cleanups in drivers/staging/serqt_usb2. Thomas Vegas (3): staging: serqt_usb2: Remove useless variable staging: serqt_usb2: Add blank line after declaration staging: serqt_usb2: Clean up initializations of variables drivers/staging/serqt_usb2/serqt_usb2.c | 25 ---

[PATCHv3 3/3] staging/wlan-ng: fix small coding style issues

2014-04-01 Thread Denis Pithon
Delete some unneeded blank lines and add few ones to make checkpatch.pl happy. Signed-off-by: Denis Pithon --- drivers/staging/wlan-ng/prism2usb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c

[PATCHv3 2/3] staging/wlan-ng: remove obsolete comments

2014-04-01 Thread Denis Pithon
prism2sta_probe_usb() and prism2sta_disconnect_usb() header comments are erroneous and useless. Removed. Signed-off-by: Denis Pithon --- drivers/staging/wlan-ng/prism2usb.c | 40 - 1 file changed, 40 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2usb

[PATCHv3 1/3] staging/wlan-ng: improve readability of usb_prism_tbl[]

2014-04-01 Thread Denis Pithon
Minor changes to nicely line up device entries. Signed-off-by: Denis Pithon --- drivers/staging/wlan-ng/prism2usb.c | 118 ++-- 1 file changed, 47 insertions(+), 71 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb

Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote: > Parenthesize both macros so they will not break program logic if used > within another 'if'. Also fix a usage of DBG_PRT with a missing > semicolon. > > Signed-off-by: Guido Martínez > --- > drivers/staging/vt6655/device.h | 4 ++-

Re: [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues

2014-04-01 Thread Guido Martínez
On Tue, Apr 01, 2014 at 05:13:02PM +0300, Dan Carpenter wrote: > On Tue, Apr 01, 2014 at 09:52:13AM -0300, Guido Martínez wrote: > > @@ -4285,14 +4252,9 @@ vMgrRxManagePacket( > > > > case WLAN_FSTYPE_BEACON: > > // Frame Clase = 0 > > -<<< HEAD > > - //DBG_PRT(MSG_L

Re: [PATCH 2/3] staging: vt6655: remove dead code

2014-04-01 Thread Dan Carpenter
On Tue, Apr 01, 2014 at 09:52:12AM -0300, Guido Martínez wrote: > @@ -2205,11 +2203,8 @@ bool BBbVT3253Init(PSDevice pDevice) > //}} > bResult &= BBbWriteEmbedded(dwIoBase, 0xb0, 0x58); > > - for (ii = 0; ii < CB_VT3253B0_AGC; ii++) { > + for (i

Re: [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues

2014-04-01 Thread Dan Carpenter
On Tue, Apr 01, 2014 at 09:52:13AM -0300, Guido Martínez wrote: > @@ -624,13 +622,10 @@ device_receive_frame( > > // Data frame Handle > > - if (pDevice->bEnablePSMode) { > - if (!IS_FC_MOREDATA((skb->data+4))) { > + if (pDevice->bEnablePSMode) > + if (!IS_FC_MO

Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-01 Thread Dan Carpenter
On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote: > Parenthesize both macros so they will not break program logic if used > within another 'if'. Also fix a usage of DBG_PRT with a missing > semicolon. > > Signed-off-by: Guido Martínez > --- > drivers/staging/vt6655/device.h | 4 ++-

[PATCH] Staging: silicom: fix dangerous if condition in bpctl_mod.c

2014-04-01 Thread Neil Armstrong
checkpatch script returns the following warning: ERROR: do not use assignment in if condition + if (((dev_num = get_dev_idx(dev->ifindex)) == -1) | This patch fixes the if condition by splitting it. Signed-off-by: Neil Armstrong --- drivers/staging/silicom/bpct

[PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-01 Thread Guido Martínez
Parenthesize both macros so they will not break program logic if used within another 'if'. Also fix a usage of DBG_PRT with a missing semicolon. Signed-off-by: Guido Martínez --- drivers/staging/vt6655/device.h | 4 ++-- drivers/staging/vt6655/wpactl.c | 2 +- 2 files changed, 3 insertions(+), 3

[PATCH 0/3] staging: vt6655: style fixes

2014-04-01 Thread Guido Martínez
Miscellaneous style fixes for the vt6655 driver. Should not affect functionality at all. Also remove dead code, shrink driver size by 1203 lines. Guido Martínez (3): staging: vt6655: fix DBG_PRT and PRINT_K macros staging: vt6655: remove dead code staging: vt6655: fix checkpatch bracing issu