[PATCH v2 0/2] mmc: rtsx: add new cmd type handle and modify error handle

2014-03-26 Thread micky_ching
From: Micky Ching v2: fix checkpatch warning. WARNING: Missing a blank line after declarations v1: Add new command type(R1 without CRC) handle, without this patch mmc card initialize will be failed. Using a more careful handle in request timeout, this would improve error recover capability. Deb

[PATCH v2 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

2014-03-26 Thread micky_ching
From: Micky Ching commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a produced a cmd.flags unhandled in realtek pci host driver. This will make MMC card failed initialize, this patch is used to handle the new cmd.flags condition and MMC card can be used. Signed-off-by: Micky Ching --- drivers/mmc

[PATCH v2 2/2] mmc: rtsx: modify error handle and remove smatch warnings

2014-03-26 Thread micky_ching
From: Micky Ching Using non-DMA dump-regs, which would be more exactly for DMA transfer failed. More careful handle when cmd/data timeout, add stop(CMD12) cmd before go to finish request when multi-rw timeout. Remove some static checher warings. on commit: drivers/mmc/host/rtsx_pci_sdmmc.c:194

Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

2014-03-26 Thread DaeSeok Youn
2014-03-27 3:51 GMT+09:00 Aaron Sierra : > - Original Message - >> From: "Daeseok Youn" >> Sent: Tuesday, March 25, 2014 10:01:48 PM >> Subject: [PATCH] staging: vme: fix memory leak in vme_user_probe() >> >> >> If vme_master_request() returns NULL when it failed, >> it need to free buffer

[PATCH 3/7] staging: panel: replace del_timer by del_timer_sync

2014-03-26 Thread Julia Lawall
From: Julia Lawall Use del_timer_sync to ensure that the timer is stopped on all CPUs before the driver exists. This change was suggested by Thomas Gleixner. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ declarer name module_exit; identifier ex;

[PATCH 0/7] replace del_timer by del_timer_sync

2014-03-26 Thread Julia Lawall
These patches replace del_timer by del_timer_sync in module_exit functions. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: keucr: Fix warning about missing blank lines after declarations

2014-03-26 Thread Jonas Hahnfeld
This patches fixes two warnings of checkpatch.pl, both of the type WARNING: Missing a blank line after declarations Signed-off-by: Jonas Hahnfeld --- drivers/staging/keucr/smilsub.c | 1 + drivers/staging/keucr/transport.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/staging/k

Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

2014-03-26 Thread Aaron Sierra
- Original Message - > From: "Daeseok Youn" > Sent: Tuesday, March 25, 2014 10:01:48 PM > Subject: [PATCH] staging: vme: fix memory leak in vme_user_probe() > > > If vme_master_request() returns NULL when it failed, > it need to free buffers for master. > > And also removes unreachable

[PATCH] staging: vt6655,vt6656: fix sparse error "unexpected unlock"

2014-03-26 Thread Cédric Cabessa
Signed-off-by: Cédric Cabessa --- drivers/staging/vt6655/wpactl.c | 3 ++- drivers/staging/vt6656/firmware.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) This patch is part of the eudyptula challenge. diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-03-26 Thread Oleg Drokin
Hello! On Mar 26, 2014, at 4:44 AM, Geert Uytterhoeven wrote: >>> and http://kisskb.ellerman.id.au/kisskb/buildresult/10508264/ >>> will turn green again? >> I certainly hope so. > Ping? > We got a new "fix" for this in due to https://lkml.org/lkml/2014/2/13/479 Well, I certainly hoped for some b

Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-26 Thread Joe Perches
On Wed, 2014-03-26 at 00:42 -0700, Jimmy Li wrote: > fix a sparse warning. [] > diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c [] > @@ -1843,7 +1843,7 @@ int iwctl_siwencodeext(struct net_device *dev, [] > blen = sizeof(*param); > - buf = kmalloc((int)blen, (

[PATCH] Staging: media: Fix sparse warnings for incorrect types in lirc_bt829.c

2014-03-26 Thread Ebru Akagunduz
This patch fixes following sparse warnings in lirc_bt829.c drivers/staging/media/lirc/lirc_bt829.c:182:22: warning: incorrect type in assignment (different address spaces) drivers/staging/media/lirc/lirc_bt829.c:182:22:expected unsigned char *static [toplevel] pci_addr_lin drivers/staging/me

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-26 Thread Oliver Neukum
On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: > From: Roger Tseng > +static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr, > + unsigned int pipe, struct scatterlist *sg, int num_sg, > + unsigned int length, unsigned int *act_len, int timeout) > +

[PATCH v2] staging: silicom: remove BP_PROC_SUPPORT dependant code

2014-03-26 Thread SeongJae Park
Some code is hide inside #ifdef BP_PROC_SUPPORT and it never defined anywhere. And, it made defined but not used function which calling code was hide inside #ifdef BP_PROC_SUPPORT and caused following build warning: drivers/staging/silicom/bpctl_mod.c:6786:12: warning: ‘bp_proc_create’ defined but

Re: [PATCH] staging: silicom: hide conditionally used function in condition

2014-03-26 Thread SeongJae Park
On Wed, Mar 26, 2014 at 9:27 PM, Greg KH wrote: > On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote: >> bp_proc_create() be called only when BP_PROC_SUPPORT defined but its >> definition live outside of #ifdef BP_PROC_SUPPORT and cause following >> trivial build warning: >> drivers/sta

RE: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-26 Thread Haiyang Zhang
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, March 25, 2014 11:50 PM > To: Haiyang Zhang > Cc: David Miller; o...@aepfle.de; net...@vger.kernel.org; > jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- > ker...@vger.kernel.org

Re: [PATCH] staging: silicom: hide conditionally used function in condition

2014-03-26 Thread Greg KH
On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote: > bp_proc_create() be called only when BP_PROC_SUPPORT defined but its > definition live outside of #ifdef BP_PROC_SUPPORT and cause following > trivial build warning: > drivers/staging/silicom/bpctl_mod.c:6786:12: warning: > ‘bp_proc_c

Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-26 Thread Greg Kroah-Hartman
On Wed, Mar 26, 2014 at 12:42:43AM -0700, Jimmy Li wrote: > fix a sparse warning. > drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted > gfp_t > drivers/staging/vt6655/iwctl.c:1846:35: warning: incorrect type in > argument 2 (different base types) > drivers/staging/vt6655/iwctl.c

[staging:staging-next 122/153] drivers/staging/slicoss/slicoss.c:1429 slic_cmdq_addcmdpage() error: we previously assumed 'pslic_handle' could be null (see line 1425)

2014-03-26 Thread Dan Carpenter
Hi Monam, FYI, there are new smatch warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: 7b99b5efaab0f8c8c637cb68840e990fbca16878 commit: b0a0fb1e292e1472db7aea8ddce2fc5ceae5ab48 [122/153] Staging: slicoss: Replace macro with inline d

Re: [PATCH v2] staging: comedi: s626: use comedi_timeout() on remaining loops

2014-03-26 Thread Ian Abbott
On 2014/03/26 03:43 AM, Chase Southwood wrote: > There were just a handful of more while loops in this file that needed > timeouts, and this patch takes care of them. One new callback is > introduced, and all of the proper comedi_timeout() calls are then used. > > Signed-off-by: Chase Southwood

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-03-26 Thread Christoph Hellwig
On Wed, Mar 26, 2014 at 09:44:08AM +0100, Geert Uytterhoeven wrote: > Ping? > > We got a new "fix" for this in due to https://lkml.org/lkml/2014/2/13/479 Given that lustre maintainers aren't willing to fix even the worst crap like this we really should drop it from the staging tree.

Re: [PATCH] [staging][r8188eu]: memory leak in rtw_free_cmd_obj if command is (_Set_Drv_Extra)

2014-03-26 Thread Dan Carpenter
On Tue, Mar 18, 2014 at 10:25:27AM -0400, Wang, Xiaoming wrote: > pcmd->parmbuf->pbuf has been allocated if command is > GEN_CMD_CODE(_Set_Drv_Extra), > and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by > rtw_dequeue_cmd. > The memory leak happened on this branch "if( _FAIL == >

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-03-26 Thread Geert Uytterhoeven
On Sat, Jan 25, 2014 at 4:23 AM, Oleg Drokin wrote: > On Jan 24, 2014, at 3:55 AM, Geert Uytterhoeven wrote: >> On Fri, Jan 24, 2014 at 6:51 AM, Oleg Drokin wrote: +STAGING - LUSTRE +M: Andreas Dilger +M: Oleg Drokin +M: Peng Tao . +L: hpdd-discuss +S: O

Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle

2014-03-26 Thread Ulf Hansson
On 26 March 2014 02:29, micky wrote: > Hi Ulf, > > On 03/25/2014 06:44 PM, Ulf Hansson wrote: >> >> On 25 March 2014 10:47, wrote: >>> >>> From: Micky Ching >>> >>> Add new command type(R1 without CRC) handle, without this >>> patch mmc card initialize will be failed. >>> >>> Using a more caref

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-26 Thread Dan Carpenter
On Mon, Mar 17, 2014 at 09:23:54AM -0400, Mark Hounschell wrote: > >. > > > > Hi Dan, what is going on with this patch? Are you going to submit > it? I want to get rid of the remaining LOCKing macros but think it > may mess you up with this? > Sorry, I went on vacation and I just returned. Than

[PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-26 Thread Jimmy Li
fix a sparse warning. drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted gfp_t drivers/staging/vt6655/iwctl.c:1846:35: warning: incorrect type in argument 2 (different base types) drivers/staging/vt6655/iwctl.c:1846:35:expected restricted gfp_t [usertype] flags drivers/stagin