[PATCH] staging: comedi: s626: use comedi_timeout() on remaining loops

2014-03-24 Thread Chase Southwood
There were just a handful of more while loops in this file that need timeouts, and this patch takes care of them, using comedi_timeout(). A couple of new callbacks are introduced, but there was one case where the appropriate callback function was already defined; in this case I have just used that

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Shuah Khan
On 03/24/2014 06:38 PM, Greg KH wrote: On Mon, Mar 24, 2014 at 05:12:09PM -0600, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 What do you mean by this line? Nothing really. Sloppiness on my part. I was keeping notes as I was chasing the problem and those ended up

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Greg KH
On Mon, Mar 24, 2014 at 05:12:09PM -0600, Shuah Khan wrote: > Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 What do you mean by this line? > This commit added return value check for sscanf() that parses the > input buffer for four input items. However, the return value check > is incorrec

[PATCH] staging: goldfish: switch from spinlock to mutex

2014-03-24 Thread Kristina Martšenko
Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by the TODO list. Signed-off-by: Kristina Martšenko --- drivers/staging/goldfish/README | 1 - drivers/staging/goldfish/goldfish_nand.c | 15 +++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Shuah Khan
Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 This commit added return value check for sscanf() that parses the input buffer for four input items. However, the return value check is incorrect, as it checks for one input item instead of four which is what it is expecting in the input buffer.

Re: [PATCH] staging: line6: Fix missing blanks after declarations

2014-03-24 Thread Joe Perches
On Mon, 2014-03-24 at 21:51 +0100, Fabian Mewes wrote: > This patch is part of eudyptula challenge task 10 > > Signed-off-by: Fabian Mewes Hi Fabian. The patch seems fine, but please do not use something like the above as a commit message. It would be better to describe _why_ the change should

[PATCH v2] staging: line6: Add blank lines after declarations

2014-03-24 Thread Fabian Mewes
Use the more common kernel coding style. Signed-off-by: Fabian Mewes --- applies to next-20140324 v1..v2: improve commit message as suggested by Joe drivers/staging/line6/driver.c | 1 + drivers/staging/line6/playback.c | 5 + drivers/staging/line6/toneport.c | 1 + 3 files changed, 7

[PATCH] drivers:staging:lustre Fixed sparse warning: plain integer as NULL pointer

2014-03-24 Thread John de la Garza
Fixes these sparse warnings: drivers/staging/lustre/lustre/lmv/lproc_lmv.c:202:51: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/lmv/lproc_lmv.c:203:51: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/lmv/lproc_lmv.c:204:51: warning: Using p

[PATCH] staging: line6: Fix missing blanks after declarations

2014-03-24 Thread Fabian Mewes
This patch is part of eudyptula challenge task 10 Signed-off-by: Fabian Mewes --- applies to next-20140324 drivers/staging/line6/driver.c | 1 + drivers/staging/line6/playback.c | 5 + drivers/staging/line6/toneport.c | 1 + 3 files changed, 7 insertions(+) diff --git a/drivers/staging

[PATCH] staging/usbip: userspace - fix usbipd SIGSEGV from refresh_exported_devices()

2014-03-24 Thread Shuah Khan
refresh_exported_devices() doesn't check udev_device_new_from_syspath() return value and passed in null dev to udev_device_get_driver() resulting in a segmentation fault. Change it to check for null return value from both udev_device_new_from_syspath() and udev_device_get_driver(). Signed-off-by:

[PATCH] staging: vt6655: fix sparse warning

2014-03-24 Thread ioana . ileana
From: Ioana Ileana Added missing static qualifier Signed-off-by: Ioana Ileana --- drivers/staging/vt6655/datarate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/datarate.c b/drivers/staging/vt6655/datarate.c index c9a89cd..2d760da 100644 --- a/

[PATCH] next-20140324 drivers/staging/media/sn9c102/sn9c102_hv7131r.c fix style warnings flagged by checkpatch.pl.

2014-03-24 Thread Mike Sampson
Signed-off-by: Mike Sampson --- drivers/staging/media/sn9c102/sn9c102_hv7131r.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/sn9c102/sn9c102_hv7131r.c b/drivers/staging/media/sn9c102/sn9c102_hv7131r.c index 26a9111..51b24e