Re: [PATCH v4 3/3] memstick: Add realtek USB memstick host driver

2014-03-20 Thread Roger
On 03/21/2014 07:18 AM, Andrew Morton wrote: On Wed, 12 Feb 2014 18:00:38 +0800 wrote: From: Roger Tseng Realtek USB memstick host driver provides memstick host support based on the Realtek USB card reader MFD driver. ... +static int rtsx_usb_ms_drv_probe(struct platform_device *pdev) +{

[PATCH] fix some coding style in drivers/staging/iio

2014-03-20 Thread Jimmy Li
fix some coding style in drivers/staging/iio. Signed-off-by: Jimmy Li --- drivers/staging/iio/accel/adis16220_core.c |3 ++- drivers/staging/iio/accel/sca3000_core.c |3 ++- drivers/staging/iio/adc/ad7192.c |3 ++- drivers/staging/iio/adc/ad7606_core.c |2 +- driv

Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

2014-03-20 Thread DaeSeok Youn
2014-03-21 13:27 GMT+09:00 Greg KH : > On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote: >> >> Replace OS_kmalloc/OS_kfree with kmalloc/kfree. > > You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed > out the allocated data: I think some case does not need to get ze

Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

2014-03-20 Thread Greg KH
On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote: > > Replace OS_kmalloc/OS_kfree with kmalloc/kfree. You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed out the allocated data: > -static inline void * > -OS_kmalloc (size_t size) > -{ > -char *ptr = kma

[PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

2014-03-20 Thread Daeseok Youn
Replace OS_kmalloc/OS_kfree with kmalloc/kfree. And also some allocation doesn't need to use GFP_DMA so just use GFP_KERNEL. c4_new() function is never called, remove it. Signed-off-by: Daeseok Youn --- v2: fix subject and comment correctly. I'm not sure what GFP_DMA use correctly for km{,z}al

[PATCH] Staging: bcm: CmHost: remove temp bracing from switch/cases.

2014-03-20 Thread Gary Rookard
Remove the temp bracing afixed to case labels. Properly indent switch/case breaks. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/CmHost.c | 50 +++- 1 file changed, 7 insertions(+), 43 deletions(-) diff --git a/drivers/

Re: [PATCH] staging: cxt1e1: replace kmalloc/kfree with OS_kmalloc/OS_kfree

2014-03-20 Thread DaeSeok Youn
Yes. It was already noticed by Joe Perches. I will send it again. Thanks. Daeseok Youn. 2014-03-21 11:35 GMT+09:00, Greg KH : > On Fri, Mar 21, 2014 at 10:41:39AM +0900, Daeseok Youn wrote: >> >> Replace kmalloc/kfree with OS_kmalloc/OS_kfree. > > I think you mean this the other way around, right

Re: [PATCH] staging: cxt1e1: replace kmalloc/kfree with OS_kmalloc/OS_kfree

2014-03-20 Thread Greg KH
On Fri, Mar 21, 2014 at 10:41:39AM +0900, Daeseok Youn wrote: > > Replace kmalloc/kfree with OS_kmalloc/OS_kfree. I think you mean this the other way around, right? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject

[PATCH] staging: cxt1e1: replace kmalloc/kfree with OS_kmalloc/OS_kfree

2014-03-20 Thread Daeseok Youn
Replace kmalloc/kfree with OS_kmalloc/OS_kfree. And also some allocation doesn't need to use GFP_DMA so just use GFP_KERNEL. c4_new() function is never called, remove it. Signed-off-by: Daeseok Youn --- I'm not sure what GFP_DMA use correctly for km{,z}alloc(). Please review this. And this pat

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
On 03/21/2014 12:34 AM, Sergei Shtylyov wrote: Signed-off-by: Cédric Cabessa --- drivers/staging/usbip/vhci_hcd.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c inde

[PATCH] Staging: vt6655: Fix sparse-indicated type mismatch to kmalloc

2014-03-20 Thread Conrad Meyer
Signed-off-by: Conrad Meyer --- Patch is against next-20140320. Fixes a minor sparse warning in the staging driver vt6655. p->length is u16; implicit cast to size_t is fine. No reason to cast GFP_KERNEL... --- drivers/staging/vt6655/wpactl.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] staging/rtl8821ae: Fix OOM handling in _rtl_init_deferred_work()

2014-03-20 Thread Richard Weinberger
alloc_workqueue() can fail, handle this case. Signed-off-by: Richard Weinberger --- drivers/staging/rtl8821ae/base.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c index fce9c3f..8dbe13c 100644 --

Re: [PATCH v4 3/3] memstick: Add realtek USB memstick host driver

2014-03-20 Thread Andrew Morton
On Thu, 20 Mar 2014 16:38:03 +0800 Roger wrote: > On 02/12/2014 06:00 PM, rogera...@realtek.com wrote: > > From: Roger Tseng > > > > Realtek USB memstick host driver provides memstick host support based on the > > Realtek USB card reader MFD driver. > > > > Signed-off-by: Roger Tseng > Andrew,

Re: [PATCH v4 3/3] memstick: Add realtek USB memstick host driver

2014-03-20 Thread Andrew Morton
On Wed, 12 Feb 2014 18:00:38 +0800 wrote: > From: Roger Tseng > > Realtek USB memstick host driver provides memstick host support based on the > Realtek USB card reader MFD driver. > > ... > > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include

[PATCH net-next, v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-20 Thread Haiyang Zhang
This feature allows multiple channels to be used by each virtual NIC. It is available on Hyper-V host 2012 R2. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h | 110 +- drivers/net/hyperv/netvsc.c | 136 +++

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
On 03/20/2014 11:45 PM, Joe Perches wrote: diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c [] @@ -271,12 +271,14 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, } break;

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Joe Perches
On Fri, 2014-03-21 at 00:34 +0300, Sergei Shtylyov wrote: > On 03/20/2014 01:04 AM, Cédric Cabessa wrote: > > diff --git a/drivers/staging/usbip/vhci_hcd.c > > b/drivers/staging/usbip/vhci_hcd.c [] > > @@ -271,12 +271,14 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 > > typeReq, u16 wVa

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
Hello. On 03/20/2014 01:04 AM, Cédric Cabessa wrote: Signed-off-by: Cédric Cabessa --- drivers/staging/usbip/vhci_hcd.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd

Re: [PATCH 2/2] coding style: fix line over 80 characters

2014-03-20 Thread Sergei Shtylyov
On 03/21/2014 12:34 AM, Sergei Shtylyov wrote: Signed-off-by: Cédric Cabessa --- drivers/staging/usbip/vhci_hcd.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c inde

Re: [RFC PATCH] staging: imx-drm: add suspend / resume

2014-03-20 Thread Martin Fuzzey
Hi Fabio, On 20/03/14 16:31, Fabio Estevam wrote: Does this patch still cause the visual artifacts you mentioned earlier? Regards, Fabio Estevam No. Since I switched from poking the registers to using the existing wrappers I have not observed any artifcats. Regards, Martin __

[RFC PATCH] staging: imx-drm: add suspend / resume

2014-03-20 Thread Martin Fuzzey
Currently i.MX53 boards with the imx-drm display driver active fail an intensive suspend to ram / resume test. After around 5 - 50 cycles it is no longer possible to resume the board. The culprit is the imx-drm driver which does not stop DMA before suspending. Removing the driver "fixes" the prob

Re: [RFC PATCH] staging: imx-drm: add suspend / resume

2014-03-20 Thread Fabio Estevam
Hi Martin, On Thu, Mar 20, 2014 at 12:17 PM, Martin Fuzzey wrote: > Currently i.MX53 boards with the imx-drm display driver active > fail an intensive suspend to ram / resume test. > > After around 5 - 50 cycles it is no longer possible to resume > the board. > > The culprit is the imx-drm driver

Financial Assistane / Loan Offer

2014-03-20 Thread finance01
We offer all purpose loan at 3% interest rate. Contact Us for more details by Email:santanderfinancegr...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] staging: octeon-usb: prevent memory corruption

2014-03-20 Thread Alan Stern
On Thu, 20 Mar 2014, David Laight wrote: > From: Aaro Koskinen > > octeon-hcd will crash the kernel when SLOB is used. This usually happens > > after the 18-byte control transfer when a device descriptor is read. > > The DMA engine is always transfering full 32-bit words and if the > > transfer is

Re: [PATCH 1/2] coding style: fix quoted string split across lines

2014-03-20 Thread Joe Perches
On Wed, 2014-03-19 at 23:04 +0100, Cédric Cabessa wrote: [] > diff --git a/drivers/staging/usbip/usbip_common.c > b/drivers/staging/usbip/usbip_common.c [] > @@ -178,8 +178,8 @@ static void usbip_dump_usb_ctrlrequest(struct > usb_ctrlrequest *cmd) > } > > pr_debug(" "); > -

RE: [PATCH] staging: octeon-usb: prevent memory corruption

2014-03-20 Thread David Laight
From: Aaro Koskinen > octeon-hcd will crash the kernel when SLOB is used. This usually happens > after the 18-byte control transfer when a device descriptor is read. > The DMA engine is always transfering full 32-bit words and if the > transfer is shorter, some random garbage appears after the buff

Re: [PATCH v4 3/3] memstick: Add realtek USB memstick host driver

2014-03-20 Thread Roger
On 02/12/2014 06:00 PM, rogera...@realtek.com wrote: From: Roger Tseng Realtek USB memstick host driver provides memstick host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng Andrew, Would you please Ack or comment this patch(3/3) to let the 3 patches be