Re: [PATCH] Staging: bcm: CmHost: unline split quoted strings.

On Sun, 16 Mar 2014, Gary Rookard wrote: On Sun, 16 Mar 2014, Mark Einon wrote: On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote: I unline split some quoted strings. Hi, Why? What issue does it fix? -- Hi, It fixes a checkpatch error/warning "quoted string split across l

Re: [PATCH] Staging: bcm: CmHost: unline split quoted strings.

On Sun, 16 Mar 2014, Mark Einon wrote: On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote: I unline split some quoted strings. Hi, Why? What issue does it fix? -- Hi, It fixes a checkpatch error/warning "quoted string split across lines" or something phrased very simular. Is

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

Hi Mark, Yes, in fact it does if not for the shear fact that a declaration is not a statement. This file as well as the rest of bcm is in working draft state a real wart hog so to speak, and contained w/in it are developer tricks to mask over would be compiler errors that would crop up during th

Re: [PATCH] Staging: bcm: CmHost: unline split quoted strings.

On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote: > I unline split some quoted strings. Hi, Why? What issue does it fix? > > Signed-off-by: Gary Alan Rookard > > --- > On branch staging-next > drivers/staging/bcm/CmHost.c | 12 > 1 file changed, 4 insertions(+), 8 de

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote: > I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; > from out of a switch/case statement. And also, removed useless duplicate > UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;. Hi, This looks l

Re: [PATCH 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

On 13/03/14 20:39, Ken Cox wrote: Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/procobjecttree.c | 2 +- drivers/staging/unisys/visorutil/visorkmodutils.c | 6 ++ 2 files

[PATCH] staging: r8188eu: fix coccinelle warnings

From: Fengguang Wu drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8030:3-9: Replace memcpy with struct assignment Generated by: coccinelle/misc/memcpy-assign.cocci Signed-off-by: Fengguang Wu Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed

[PATCH] Staging: bcm: CmHost: removed extra parenthesis.

I removed some useless extra parenthesis. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/CmHost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 9252ef1..41cb3de 100644 --

Re: [PATCH] Staging: gdm724x: gdm_lte.c: fixed coding style

On Mon, 2014-03-17 at 08:20 +1300, Daniel Ngu wrote: > Line over 80 characters > Unchecked sscanf return value [] > diff --git a/drivers/staging/gdm724x/gdm_lte.c > b/drivers/staging/gdm724x/gdm_lte.c [] > @@ -536,7 +567,8 @@ static u8 find_dev_index(u32 nic_type) > return index; > } > >

[PATCH] Staging: bcm:CmHost: removed extra parenthesis.

I removed some useless extra parenthesis. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/CmHost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 9252ef1..41cb3de 100644 --

Re: [PATCH] Staging: gdm724x: gdm_lte.c: fixed coding style

On Sun, 2014-03-16 at 12:24 -0700, Joe Perches wrote: > > @@ -551,28 +583,41 @@ static void gdm_lte_netif_rx(struct net_device *dev, > > char *buf, int len, int fla > [] > > struct dhcp_packet { > > This one would be better fixed by moving the struct definition > out of this

[PATCH] Staging: bcm: CmHost: added breaks and /* FALLTHROUGH */ to switch/case.

I added a couple of breaks, and a /* FALLTHROUGH */ comment to switch/case assuming that is the actual desired effect needed by the case label. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/CmHost.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) di

[PATCH] Staging: gdm724x: gdm_lte.c: fixed coding style

Line over 80 characters Unchecked sscanf return value Signed-off-by: Daniel Ngu --- drivers/staging/gdm724x/gdm_lte.c | 182 + 1 file changed, 125 insertions(+), 57 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lt

[PATCH] Staging: gdm724x: gdm_lte.h: fixed coding style

Missing space after return type Signed-off-by: Daniel Ngu --- drivers/staging/gdm724x/gdm_lte.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h index 9287d31..88414e5 100644 --- a/drivers/staging/gdm724

[PATCH] Staging: gdm724x: gdm_mux.c: fixed coding style

Line over 80 characters Signed-off-by: Daniel Ngu --- drivers/staging/gdm724x/gdm_mux.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index 2fa3a5a..10ce2c1 100644 --- a/dr

[PATCH] Staging: gdm724x: gdm_usb.c: fixed coding style

Line over 80 characters Signed-off-by: Daniel Ngu --- drivers/staging/gdm724x/gdm_usb.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c index 03b4305..3d6774b 100644

[PATCH] Staging: gdm724x: netlink_k.c: fixed coding style

Line over 80 characters Signed-off-by: Daniel Ngu --- drivers/staging/gdm724x/netlink_k.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/netlink_k.c b/drivers/staging/gdm724x/netlink_k.c index 77fc64e..5ddd369 100644 --- a/drivers/staging/gdm724

[PATCH] Staging: bcm: CmHost: unline split quoted strings.

I unline split some quoted strings. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/CmHost.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index 2d1f94d..4cb59d7 100644