Re: [PATCH] staging: comedi: fix memory leak

2014-03-14 Thread Levente Kurusa
On 03/15/2014 04:30 AM, Chase Southwood wrote: >> On Friday, March 14, 2014 11:47 AM, Levente Kurusa wrote: > >> Call kfree() on bdev. The variable is otherwise leaked. >> >> Signed-off-by: Levente Kurusa >> [...] >> > > > Levente, > > This change has already been made in staging-next (by me,

Re: git not pulling origin staging-next cleanly.

2014-03-14 Thread Gary Rookard
On Sat, 15 Mar 2014, Greg KH wrote: On Fri, Mar 14, 2014 at 09:51:30PM -0400, Gary Rookard wrote: On Sat, 15 Mar 2014, Greg KH wrote: On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote: Hi, Could this problem be local machine (git-1.9.0-1) or dare I say it, a tmp server-side me

Re: git not pulling origin staging-next cleanly.

2014-03-14 Thread Greg KH
On Fri, Mar 14, 2014 at 09:51:30PM -0400, Gary Rookard wrote: > > > On Sat, 15 Mar 2014, Greg KH wrote: > > > On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote: > >> Hi, > >> Could this problem be local machine (git-1.9.0-1) or dare I say it, > >> a tmp server-side melt-down of sorts?

Re: [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in s626.c

2014-03-14 Thread gre...@linuxfoundation.org
On Fri, Mar 14, 2014 at 06:43:37PM -0700, Chase Southwood wrote: > >On Tuesday, March 11, 2014 9:26 AM, Ian Abbott wrote: > > >>On 2014-03-09 04:00, Chase Southwood wrote: > >> This patch changes a handful of while loops to timeouts to prevent > >> infinite looping on hardware failure. A couple s

Re: [PATCH] staging: comedi: fix memory leak

2014-03-14 Thread Chase Southwood
>On Friday, March 14, 2014 11:47 AM, Levente Kurusa wrote: >Call kfree() on bdev. The variable is otherwise leaked. > >Signed-off-by: Levente Kurusa >--- >drivers/staging/comedi/drivers/comedi_bond.c | 1 + >1 file changed, 1 insertion(+) > >diff --git a/drivers/staging/comedi/drivers/comedi_bond

Re: git not pulling origin staging-next cleanly.

2014-03-14 Thread Gary Rookard
On Sat, 15 Mar 2014, Greg KH wrote: On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote: Hi, Could this problem be local machine (git-1.9.0-1) or dare I say it, a tmp server-side melt-down of sorts? I've tried everything nothing seams to work. What have you typed, exactly, and what

Re: [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in s626.c

2014-03-14 Thread Chase Southwood
>On Tuesday, March 11, 2014 9:26 AM, Ian Abbott wrote: >>On 2014-03-09 04:00, Chase Southwood wrote: >> This patch changes a handful of while loops to timeouts to prevent >> infinite looping on hardware failure. A couple such loops are in a >> function (s626_debi_transfer()) which is called from

Re: git not pulling origin staging-next cleanly.

2014-03-14 Thread Greg KH
On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote: > Hi, > Could this problem be local machine (git-1.9.0-1) or dare I say it, > a tmp server-side melt-down of sorts? > I've tried everything nothing seams to work. What have you typed, exactly, and what has git responded with? __

Re: [PATCH] staging: android: fix coding style

2014-03-14 Thread Greg KH
On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote: > From: mourn > > Signed-off-by: mourn As said in the thread for your other thread, this patch can't be accepted unless you use your real name, sorry. greg k-h ___ devel mailing list d

Re: [PATCH] staging: android: fix coding style

2014-03-14 Thread Greg KH
On Thu, Mar 13, 2014 at 03:13:04PM +0100, mourn wrote: > > > The changes look good, however you should be a bit more specific about > > what the > > fixes are, and that you used checkpatch.pl to find them (I assume). > > > > Yes, you are right. I can edit the commit log. > > > Also, Signed-off-b

[PATCH] staging: comedi: das6402: rewrite broken driver

2014-03-14 Thread H Hartley Sweeten
This driver is _really_ broken. It initializes an analog input subdevice that only has a (*cancel) function. It also does a request_irq() to hookup an interrupt handler using it->options[0] as the IRQ. This option is actually the base address of the I/O region used by the board. If the interrupt h

Re: [PATCH 00/26] staging: comedi: gsc_hpdi: clean up driver

2014-03-14 Thread Ian Abbott
On 2014-03-13 21:16, H Hartley Sweeten wrote: This is the big clean up series for the coemdi gsc_hpdi driver. H Hartley Sweeten (26): staging: comedi: gsc_hpdi: move the (*auto_attach) and (*detach) functions staging: comedi: gsc_hpdi: absorb setup_subdevices() staging: comedi: gsc_hpdi

[PATCH] staging: comedi: fix memory leak

2014-03-14 Thread Levente Kurusa
Call kfree() on bdev. The variable is otherwise leaked. Signed-off-by: Levente Kurusa --- drivers/staging/comedi/drivers/comedi_bond.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c index 51a59e5..4

Re: [PATCH 0/7] staging: comedi: rti802: clean up driver

2014-03-14 Thread Ian Abbott
On 2014-03-13 22:48, H Hartley Sweeten wrote: Clean up this comedi driver. H Hartley Sweeten (7): staging: comedi: rti802: remove RTI802_SIZE define staging: comedi: rti802: tidy up rti802_ao_insn_read() staging: comedi: rti802: tidy up rti802_ao_insn_write() staging: comedi: rti802:

[PATCH] staging: cxt1e1: remove redundant memset() call

2014-03-14 Thread Daeseok Youn
The banner array doens't need to set to 0. sprintf() adds a terminating '\0'. And the sn array can be declared and initialized to zero. So remove redundant memset() with zero. Remove unnecessary cast for memcpy(). Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/hwprobe.c | 12 +++