How many warnings does this generate does this generate when you run it
across the whole tree?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Increase the number of PFNs we can handle in a single vmbus packet.
Some network packets may have more PFNs than the current limit we have.
This is not a bug and this patch can be applied to the *next tree.
Signed-off-by: K. Y. Srinivasan
---
include/linux/hyperv.h |2 +-
1 files changed, 1
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, March 7, 2014 12:19 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com
> Subject: Re: [PATCH 1/1] Driver
On Thu, Mar 06, 2014 at 11:15:08PM -0800, K. Y. Srinivasan wrote:
> Increase the maximum number of pfns we can handle is a single vmbus packet.
Is that a correct sentance?
>
> Signed-off-by: K. Y. Srinivasan
> ---
> include/linux/hyperv.h |2 +-
> 1 files changed, 1 insertions(+), 1 delet
Increase the maximum number of pfns we can handle is a single vmbus packet.
Signed-off-by: K. Y. Srinivasan
---
include/linux/hyperv.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 330ec44..ab7359f 100644
--- a/inc
pcmd->parmbuf->pbuf has been allocated if command is
GEN_CMD_CODE(_Set_Drv_Extra),
and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by
rtw_dequeue_cmd.
The memory leak happened on this branch "if( _FAIL == rtw_cmd_filter(pcmdpriv,
pcmd) )"
which goto post_process directly against
Enable segmentation offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 40 +++
drivers/net/hyperv/netvsc_drv.c | 38 +---
2 files changed, 74 insertions(+), 4 deletions
In preparation for enabling offloads, cleanup the send path.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |7 +---
drivers/net/hyperv/netvsc_drv.c | 88 +
drivers/net/hyperv/rndis_filter.c | 66 ---
Cleanup the code and enable scatter gather I/O.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/netvsc_drv.c | 153 +--
1 files changed, 114 insertions(+), 39 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/driv
Enable send side checksum offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 10 ++
drivers/net/hyperv/netvsc_drv.c | 69 +-
2 files changed, 77 insertions(+), 2 deletions(-)
diff --git a/drivers
Enable receive side checksum offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 33 -
drivers/net/hyperv/netvsc_drv.c | 19 +++
drivers/net/hyperv/rndis_filter.c |4 +++-
3 files c
Prior to enabling guest side offloads, enable the offloads on the host.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 55 +
drivers/net/hyperv/rndis_filter.c | 80 +
2 files chan
This patch set enables both checksum as well as segmentation offload.
As part of this effort I have enabled scatter gather I/O a well.
In this version of the patches, I have addressed comments from David Miller and
Dan Carpenter.
K. Y. Srinivasan (6):
Drivers: net: hyperv: Enable scatter gather
On Thu, 2014-03-06 at 15:35 -0800, Andrew Morton wrote:
> On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> > Networking prefers this style, so warn when it's not used.
> > void foo(int bar)
> > {
> > int baz;
> >
> > code...
> > }
> >
> > not
> >
> > void foo(int bar)
> > {
> >
Added code to check return value of sscanf.
Signed-off-by: John de la Garza
---
drivers/staging/usbip/usbip_common.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/usbip_common.c
b/drivers/staging/usbip/usbip_common.c
index 4a2aab1..2a11233 100644
On Thu, 2014-03-06 at 15:51 -0800, John de la Garza wrote:
> Added code to check return value of sscanf.
[]
> diff --git a/drivers/staging/usbip/usbip_common.c
> b/drivers/staging/usbip/usbip_common.c
[]
> @@ -55,7 +55,8 @@ static ssize_t usbip_debug_store(struct device *dev,
>
Make the test system wide, modify the message too.
Signed-off-by: Joe Perches
---
> OK, let's do this for now. Could you please cook up a followon patch
> which makes this kernel-wide? I'll play with that for a while then I'll
> decide how much I feel like irritating people.
scripts/checkpatc
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 72 +---
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/cxt1e
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/
On Thu, 06 Mar 2014 15:42:30 -0800 Joe Perches wrote:
> On Thu, 2014-03-06 at 15:35 -0800, Andrew Morton wrote:
> > On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> > > Networking prefers this style, so warn when it's not used.
> > > void foo(int bar)
> > > {
> > > int baz;
> > >
> > >
Networking prefers this style, so warn when it's not used.
Networking uses:
void foo(int bar)
{
int baz;
code...
}
not
void foo(int bar)
{
int baz;
code...
}
There are a limited number of false positives when using
macros to declare variables like:
WARNING: ne
On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> Networking prefers this style, so warn when it's not used.
>
> Networking uses:
>
> void foo(int bar)
> {
> int baz;
>
> code...
> }
>
> not
>
> void foo(int bar)
> {
> int baz;
> code...
> }
>
> There are a lim
On Thursday 27 February 2014 16:10:41 Tomi Valkeinen wrote:
> On 27/02/14 15:43, Russell King - ARM Linux wrote:
> > That may be - but the problem with CDF solving this problem is that it's
> > wrong. It's fixing what is in actual fact a *generic* problem in a much
> > too specific way. To put it
Hi Russell,
Time for me to jump in. The more, the merrier I suppose.
On Wednesday 26 February 2014 22:19:39 Russell King - ARM Linux wrote:
> On Wed, Feb 26, 2014 at 10:00:25PM +0100, Guennadi Liakhovetski wrote:
> > Hi Russell
> >
> > (I suspect this my email will be rejected by ALKML too like
Ok.
I will fix it and send again.
Thanks.
Daeseok Youn
2014-03-07 4:58 GMT+09:00 Greg KH :
> On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
>>
>> It doesn't need to assign name array address to np pointer.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> v2: replace sprintf() with snpr
Sorry for confusing you.
Actually 1-3 patches already merged to staging-next branch.
And then I had a request resending the rest of the series.
So I just sent 4-7 again. Sorry, I should rebase these patches and
make a series newly.
I will send patches again properly.
I think this patches need to
On Mon, Mar 03, 2014 at 01:08:06AM +0400, Alexey Khoroshilov wrote:
> dgap_driver_start and dgap_Major_Control_Registered are used
> to keep status of initialization of the driver as a whole and its "Major
> Control".
> But the code that checks them is executed once on module init/unload.
> That m
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch migrates vhci_driver to libudev.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/usbip_common.h | 1 -
.../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++---
.../staging/usbip/userspa
On 03/04/2014 12:10 PM, Valentina Manea wrote:
The class device lists were used only when being initialized,
being populated and being destroyed. They had no real meaning
and thus the code was useless.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/vhci_driver.c | 178
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch modifies usbip_host_driver to use libudev.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/usbip_common.c | 74 ++
.../staging/usbip/userspace/libsrc/usbip_common.h | 5 +-
.../usbip/userspace/libsrc/us
Hi,
On Thu, Mar 6, 2014 at 8:51 PM, Greg KH wrote:
> On Wed, Mar 05, 2014 at 09:53:06PM +0300, Dan Carpenter wrote:
>> On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote:
>> > From: "Maxin B. John"
>> >
>> > cppcheck reported possible null pointer dereference in mdc_lib.c
>> >
>> > [l
Hello Ken Cox,
The patch bac8a4d5d29b: "staging: visoruislib driver used to handle
requests from virtpci" from Mar 4, 2014, leads to the following
Smatch warning (but you need to run with --spammy to see it):
drivers/staging/unisys/uislib/uislib.c:1688 info_proc_read_helper()
warn
On Fri, Mar 07, 2014 at 12:11:10AM +0300, Dan Carpenter wrote:
> Hello Ken Cox,
>
> The patch dc95086172db: "staging: virthba driver to access shared
> SCSI hba" from Mar 4, 2014, leads to the following Sparse warning:
>
> drivers/staging/unisys/virthba/virthba.c:1442:24: warning:
> V
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This was deleted in the driver conversion patch. It didn't need
to be deleted; showing more information is ok.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_list.c | 20 +++-
drivers/staging/usbip/u
Hello Ken Cox,
The patch dc95086172db: "staging: virthba driver to access shared
SCSI hba" from Mar 4, 2014, leads to the following Sparse warning:
drivers/staging/unisys/virthba/virthba.c:1442:24: warning:
Variable length array is used.
drivers/staging/unisys/virthba/virthba.c
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Friday, March 7, 2014 2:19 AM
> To: KY Srinivasan
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Subject:
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch modifies usbip_list to use libudev.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_list.c | 137 +--
1 file changed, 51 insertions(+), 86 deletions(-)
diff --git a/drivers/staging/usb
From: KY Srinivasan
Date: Thu, 6 Mar 2014 20:29:13 +
>
>
>> -Original Message-
>> From: David Miller [mailto:da...@davemloft.net]
>> Sent: Friday, March 7, 2014 1:04 AM
>> To: KY Srinivasan
>> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
>> de...@linuxdriverproject.org;
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Friday, March 7, 2014 1:04 AM
> To: KY Srinivasan
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Subject:
This patch simplifies and cleans up the dgap_init_module function. It also fixes
a possible double free condition as a result pci_unregister_driver possibly
being called twice.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 38 +--
On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote:
> This patch updates the MAINTAINERS file to add the maintainer for the
> Unisys s-Par driver set.
>
> Signed-off-by: Ken Cox
> signed-off-by: Ben Romer
Please capitalize things properly.
And your From: address does not match y
On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
>
> It doesn't need to assign name array address to np pointer.
>
> Signed-off-by: Daeseok Youn
> ---
> v2: replace sprintf() with snprintf() and remove memset() call
> because snprintf() adds a terminating '\0'
Your Subject: does no
On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote:
>
> checkpatch.pl error in linux.c:
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Daeseok Youn
> ---
> drivers/staging/cxt1e1/linux.c | 31 +++
> 1 files changed, 19 insertions(+), 1
On Thu, Mar 06, 2014 at 07:45:27AM +0200, Valentina Manea wrote:
>
>
>
> On Wed, Mar 5, 2014 at 12:16 PM, Dan Carpenter
> wrote:
>
> On Tue, Mar 04, 2014 at 10:35:39PM -0800, Greg KH wrote:
> > On Tue, Mar 04, 2014 at 09:10:46PM +0200, Valentina Manea wrote:
> > > Add a new list AP
On Thu, Mar 06, 2014 at 02:48:13PM -0500, Mark Hounschell wrote:
>
> want me to do this is in a separate patch or redo this one?
>
Separate patch is fine.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.lin
On Wed, Mar 05, 2014 at 02:04:36PM +0100, Maxin B. John wrote:
> From: "Maxin B. John"
>
> osc_obd can be NULL. cppcheck reported this:
> [lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference:
> osc_obd - otherwise it is redundant to check if osc_obd is null at line 295
Sa
On Wed, Mar 05, 2014 at 09:53:06PM +0300, Dan Carpenter wrote:
> On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote:
> > From: "Maxin B. John"
> >
> > cppcheck reported possible null pointer dereference in mdc_lib.c
> >
> > [lustre/lustre/mdc/mdc_lib.c:233]: (error) Possible null poin
On 03/06/2014 02:29 PM, Dan Carpenter wrote:
On Thu, Mar 06, 2014 at 01:57:55PM -0500, Mark Hounschell wrote:
This patch removes printks associated with sysfile creation
and changes the dgap_create_driver_sysfiles function to return
an int so we can check for errors in the sysfile creation
proce
If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with
undefined symbols.
Reported-by: kbuild test robot
Signed-off-by: Ken Cox
---
drivers/staging/unisys/virthba/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/virthba/Kcon
On Thu, Mar 06, 2014 at 03:13:07AM -0800, K. Y. Srinivasan wrote:
> + offload_params = (struct ndis_offload_params *)((ulong)set +
> + set->info_buf_offset);
It's a bit simpler to do pointer math like this:
offload_params = (void *)set + set->info_buf_offse
From: "K. Y. Srinivasan"
Date: Thu, 6 Mar 2014 03:13:10 -0800
> + ppi = init_ppi_data(rndis_msg, NDIS_LSO_PPI_SIZE,
> + TCP_LARGESEND_PKTINFO);
This is not indented properly, "TCP_LARGESEND_PKTINFO);" should start at the
first column after the openning parenthesi
From: "K. Y. Srinivasan"
Date: Thu, 6 Mar 2014 03:13:09 -0800
> +bool get_net_transport_info(struct sk_buff *skb, bool *is_v4,
> + bool *is_tcp, bool *is_udp, u32 *trans_off)
> +{
Returning so many values like this is awkward, at best.
Why not return a well defined
On Thu, Mar 06, 2014 at 02:26:17PM -0500, Mark Hounschell wrote:
> On 03/05/2014 04:47 PM, Dan Carpenter wrote:
> >On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
> >>@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty,
> >>const unsigned char *buf, int
> >>
From: "K. Y. Srinivasan"
Date: Thu, 6 Mar 2014 03:13:08 -0800
> + /*
> + * We only look at the IP checksum here.
> + * Should we be dropping the packet if checksum
> + * failed? How do we deal with other checksums - TCP/UDP?
> + */
From: "K. Y. Srinivasan"
Date: Thu, 6 Mar 2014 03:13:07 -0800
> + /*
> + * can't put_rndis_request, since we may still receive a
> + * send-completion.
> + */
Please fix the formatting of this comment.
> + /*
> + * Turn on the offload
From: "K. Y. Srinivasan"
Date: Thu, 6 Mar 2014 03:13:06 -0800
> In preparation for enabling offloads, cleanup the send path.
>
> Signed-off-by: K. Y. Srinivasan
> Reviewed-by: Haiyang Zhang
> ---
> drivers/net/hyperv/hyperv_net.h |7 +---
> drivers/net/hyperv/netvsc_drv.c | 87
On Thu, Mar 06, 2014 at 01:57:55PM -0500, Mark Hounschell wrote:
> This patch removes printks associated with sysfile creation
> and changes the dgap_create_driver_sysfiles function to return
> an int so we can check for errors in the sysfile creation
> process.
>
> The printk's were flagged by
From: "K. Y. Srinivasan"
Date: Thu, 6 Mar 2014 03:13:05 -0800
> @@ -140,21 +140,125 @@ static void netvsc_xmit_completion(void *context)
> dev_kfree_skb_any(skb);
> }
>
> +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len,
> + struct hv_page_buffe
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const
unsigned char *buf, int
if (down_interruptible(&dgap_TmpWriteSem))
On Thu, Mar 06, 2014 at 12:57:00PM -0600, Ken Cox wrote:
> If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with
> undefined symbols.
>
> Signed-off-by: Ken Cox
> ---
You forgot a "Reported-by:" line saying how you found out about this
issue...
_
The COMEDI_CMD and COMEDI_CMDTEST ioctl functions both copy the
comedi_cmd passed by the user from __user memory space to kernel
memory space. They then do some basic sanity checking of the cmd
before the subdevice (*do_cmdtest) and (*do_cmd) operations are
called.
Introduce a helper function to h
The COMEDI_CMD and COMEDI_CMDTEST ioctl functions both copy the chanlist
passed by the user from __user memory space to kernel memory space. They
then do some sanity checking of the chanlist with comedi_check_chanlist()
before the subdevice (*do_cmdtest) and (*do_cmd) operations are called.
Introd
Introduce some helper functions to handle the user space to kernel space
copying of the comedi_cmd and chanlist data for the COMEDI_CMD and
COMEDI_CMDTEST ioctls.
This gets all the dev_dbg() into one place and clarifies the functions a
bit.
H Hartley Sweeten (2):
staging: comedi: comedi_fops: i
This patch removes printks associated with sysfile creation
and changes the dgap_create_driver_sysfiles function to return
an int so we can check for errors in the sysfile creation
process.
The printk's were flagged by checkpatch but then
driver_create_file was flagged by checkpatch for
not chec
If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with
undefined symbols.
Signed-off-by: Ken Cox
---
drivers/staging/unisys/virthba/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/virthba/Kconfig
b/drivers/staging/unisys/vi
On Thu, Mar 06, 2014 at 09:15:01AM -0700, Shuah Khan wrote:
> >--- a/drivers/staging/usbip/userspace/libsrc/usbip_common.h
> >+++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.h
> >@@ -29,6 +29,15 @@
> > #define USBIP_HOST_DRV_NAME"usbip-host"
> > #define USBIP_VHCI_DRV_NAME
This patch removes more dead code and code associated
with that dead code. The from_user variable in the
dgap_tty_write function was never true. The code under
its test was never being executed. So variables and
functions supporting only that code are also dead.
Signed-off-by: Mark Hounschell
C
This patch fixes a few 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 52 +
1 file changed, 34 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> digital input registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
>
> Signed-off-b
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> watchdog registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
> Additionally, the d
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> timer registers such that they are all the real offsets to each register,
> rather than a mix of real offsets and adders to those offsets.
> Additionally, the defi
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> digital output registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
> Additionally,
On Thursday, March 06, 2014 12:25 AM, Chase Southwood wrote:
> This patch for hwdrv_apci1564.c fixes the register map defines for the
> digital input registers such that they are all the real offsets to each
> register, rather than a mix of real offsets and adders to those offsets.
> Additionally,
On Thu, 2014-03-06 at 11:55 +0100, Laurent Pinchart wrote:
> We thus need the #define DEBUG it appear before the first time device.h is
> included, either directly or indirectly. Adding #define DEBUG to iss.h won't
> work now as iss.h is included after all system includes (which is the usual
> p
On Wednesday, March 05, 2014 11:57 PM, Fred Akers wrote:
> This check is unnecessary because range_table will always be
> initialized to range_unknown by comedi_device_postconfig() for
> drivers that do not initialize range_table or range_table_list
>
> Signed-off-by: Fred Akers
Reviewed-by: H Ha
On Wednesday, March 05, 2014 11:57 PM, Fred Akers wrote:
>
> Refactor this function to remove an extra indent level
>
> Signed-off-by: Fred Akers
Reviewed-by: H Hartley Sweeten
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
Четверг, 6 марта 2014, 17:29 +01:00 от Philipp Zabel :
> Hi Denis,
>
> Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli:
> > diff --git
> > a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> > b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
Hi Denis,
Am Donnerstag, den 06.03.2014, 17:01 +0100 schrieb Denis Carikli:
> The current BGR666 is not consistent with the other color mapings like BGR24.
> BGR666 should be in the same byte order than BGR24.
>
> Signed-off-by: Denis Carikli
patches 1 to 3
Acked-by: Philipp Zabel
You should a
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch modifies usbip_unbind to use libudev.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_unbind.c | 92 +++---
1 file changed, 29 insertions(+), 63 deletions(-)
diff --git a/drivers/staging/u
Hi Denis,
Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli:
> diff --git
> a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> index 2d24425..4dd7ce5 100644
> --- a/Documentation/devicetree/bi
Hi Denis,
Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli:
[...]
> +&display {
> + status = "okay";
> + display-timings {
> + model = "DVI-SVGA";
Does this board really have a DVI connector and no I2C bus routed to the
DDC pins?
> + bits-per-pixel
On Wed, Mar 05, 2014 at 11:30:06PM -0800, Andrew Grover wrote:
> On Wed, Mar 5, 2014 at 10:14 PM, Valentina Manea
> wrote:
> > On Tue, Mar 4, 2014 at 9:20 PM, Greg KH wrote:
> >> On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote:
> >>> -AC_INIT([usbip-utils], [1.1.1], [linux-...@vge
On 03/04/2014 12:10 PM, Valentina Manea wrote:
This patch adds autoconf check for libudev and migrates
usbip_bind to the new library.
libsysfs will still be used until all userspace is modified.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 6 +
.
Signed-off-by: Denis Carikli
---
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- Rebased.
ChangeLog v7->v8:
- Shrinked even more the Cc list.
- Rebased.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
- Rebased the patch and included video/of_display_timing
According to the datasheet, setting the di0_polarity_disp_clk
field in the GENERAL di register sets the output clock polarity
to active high.
Signed-off-by: Denis Carikli
---
ChangeLog v8->v9:
- New patch that is now needed by the
"staging: imx-drm: Use de-active and pixelclk-active" patch.
---
If de-active and/or pixelclk-active properties were set in the
display-timings DT node, they were not used.
Instead the data-enable and the pixel data clock polarity
were hardcoded.
The dts were updated to keep the former behaviour.
Signed-off-by: Denis Carikli
---
ChangeLog v8->v9:
- Removed t
Signed-off-by: Denis Carikli
---
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- The backlight is now on at boot.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Reordered the Cc list.
ChangeLog v3->v5:
- Updated to the new GPIO defines
The CMO-QVGA, DVI-SVGA and DVI-VGA are added.
Signed-off-by: Denis Carikli
---
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- updated pixelclk-active after the following patch:
"imx-drm: Match ipu_di_signal_cfg's clk_pol with its description."
ChangeLog v7->
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Signed-off-by: Denis Carikli
---
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
ChangeLog v7->v8:
- Shrinked even more the Cc list.
Signed-off-by: Denis Carikli
---
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- Rebased.
ChangeLog v7->v8:
- Shrinked even more the Cc list.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Remove people not concerned by this patch from
That new macro is needed by the imx_drm staging driver
for supporting the QVGA display of the eukrea-cpuimx51 board.
Signed-off-by: Denis Carikli
Acked-by: Mauro Carvalho Chehab
Acked-by: Laurent Pinchart
---
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
Ch
On Thu, 2014-03-06 at 08:47 -0600, Ken Cox wrote:
> On 03/05/2014 10:40 PM, Greg KH wrote:
> > On Wed, Mar 05, 2014 at 02:52:26PM -0600, Ken Cox wrote:
> >> Add the Unisys s-Par maintainer entry to the MAINTAINERS file.
> >> Add Greg Kroah-Hartman to the list of patch recipients in the TODO file
>
This patch updates the MAINTAINERS file to add the maintainer for the
Unisys s-Par driver set.
Signed-off-by: Ken Cox
signed-off-by: Ben Romer
diff --git a/MAINTAINERS b/MAINTAINERS
index c3ff623..06dc169 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9031,6 +9031,11 @@
F: include/linux/cd
On 03/06/2014 10:11 AM, Dan Carpenter wrote:
On Thu, Mar 06, 2014 at 09:56:29AM -0500, Mark Hounschell wrote:
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, co
On Thu, 6 Mar 2014, Valentina Manea wrote:
> A device should not be able to be used concurrently both by
> the server and the client. Claiming the port used by the
> shared device ensures no interface drivers bind to it and
> that it is not usable from the server.
>
> Signed-off-by: Valentina Man
Removed the unneeded pmcc4_OSSI_release version string, as well as the now
unused 'release' element of the sbe_card_info struct. This also resolves a
sparse "should it be static" warning.
Signed-off-by: Shaun Laing
---
V2: changed to remove the version string entirely.
Compiles, but I can't test
On Thu, Mar 06, 2014 at 09:56:29AM -0500, Mark Hounschell wrote:
> On 03/05/2014 04:47 PM, Dan Carpenter wrote:
> >On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
> >>@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty,
> >>const unsigned char *buf, int
> >>
On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const
unsigned char *buf, int
if (down_interruptible(&dgap_TmpWriteSem))
1 - 100 of 127 matches
Mail list logo
