Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

I think line break is a solution about long line warning. And replacing with hex_dump() is better than managing with another patch. So I said this improvement is separated with another patch. Just my opinion. If I'm wrong, I try to change as Krzysztof's comment in same patch. Thanks. Daeseok Youn

Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote: > 2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa : > > why not use some existing *hex_dump*() instead? > OK. but this patch is only for fix line length over 80 characters, > right? If it can be improved as your comment, > it must be in another pat

Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa : > Daeseok Youn writes: > >> clean up checkpatch.pl warnings: >> WARNING: Line length over 80 characters > > This warning should be long gone IMHO. It does more harm than good. > >> unsigned char *ucp = (unsigned char *) &hi->mfg_info.dat

Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

Daeseok Youn writes: > clean up checkpatch.pl warnings: > WARNING: Line length over 80 characters This warning should be long gone IMHO. It does more harm than good. > unsigned char *ucp = (unsigned char *) &hi->mfg_info.data; > > pr_info("eeprom[00]: %02x %02x %

[PATCH v2 1/2] Staging: comedi: introduce {outl, inl}_amcc() and {outl, inl}_iobase() helper functions in hwdrv_apci1564.c

This patch introduces a few simple outl and inl helper functions to allow several lines which violate the character limit to be shortened appropriately. It also changes a few macro values which represented offset values from a single unique base value to instead represent the value of that base pl

[PATCH v2 2/2] Staging: comedi: use inl() and outl() helper functions

Use the newly created helper functions to improve code readability and shorten several lines to under the character limit. Cc: Dan Carpenter Signed-off-by: Chase Southwood --- I've reviewed this as best as I can, but I know it's a bear to review. If there is some logical way that you'd like me

[PATCH 5/5 v2] staging: cxt1e1: fix checkpatch errors with open brace '{'

clean up checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/hwprobe.c | 62 +++--- 1 file changed, 25 insertions(+), 37 deletions(-) diff --git a/drivers/staging/cxt1e1/hwprobe.c

[PATCH 4/5 v2] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/hwprobe.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c index

[PATCH 3/5 v3] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/hwprobe.c | 45 -- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/st

Re: [PATCH 3/5] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

sorry for late reply. I will resend patches which couldn't be applied to stating-next branch. Thanks. Daeseok Youn. 2014-03-01 7:19 GMT+09:00 Greg KH : > On Fri, Feb 28, 2014 at 04:33:49PM +0900, DaeSeok Youn wrote: >> OK. sorry. >> I will send again. > > Please resend all 3 of these, I've appl

[GIT PULL] Staging driver fixes for 3.14-rc5

The following changes since commit cfbf8d4857c26a8a307fb7cd258074c9dcd8c691: Linux 3.14-rc4 (2014-02-23 17:40:03 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.14-rc5 for you to fetch changes up to 9f4a9b83f13

[PATCH 1/3] staging: dgap: remove unneeded status variables

dgap_driver_start and dgap_Major_Control_Registered are used to keep status of initialization of the driver as a whole and its "Major Control". But the code that checks them is executed once on module init/unload. That makes no sense in these variables as far as their values are predictable at any

[PATCH 3/3] staging: dgap: fix error handling in dgap_init_module()

No need to call pci_unregister_driver() if pci_register_driver() failed. Signed-off-by: Alexey Khoroshilov --- drivers/staging/dgap/dgap.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index b4157d7..51

[PATCH 2/3] staging: dgap: implement proper error handling in dgap_start()

dgap_start() ignored errors in class_create() and device_create(). The patch implements proper error handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/staging/dgap/dgap.c | 22 -- 1 file changed, 20 inserti

[PATCH 2/2] staging :keucr:scsiglue.c : fixed a macros should not be colon terminated issue

fixed a coding style issue. Signed-off-by: Keerthimai Janarthanan --- drivers/staging/keucr/scsiglue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c index ac3d34d..fce19a4 100644 --- a/drivers/staging/keucr