On Fri, Feb 28, 2014 at 10:52:32AM +0300, Dan Carpenter wrote:
> On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote:
> > hwdrv_apci1564.c had numerous lines over the column limit. This patch
> > splits all such lines to bring them in compliance with coding style.
> >
> > Signed-off-b
On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote:
> hwdrv_apci1564.c had numerous lines over the column limit. This patch
> splits all such lines to bring them in compliance with coding style.
>
> Signed-off-by: Chase Southwood
> ---
> .../comedi/drivers/addi-data/hwdrv_apci1564.
On 27/02/14 18:54, Philipp Zabel wrote:
>> - One IPU enabled, one disabled: nothing special here, just set the
>> other IPU to status="disabled" in the DT data. The driver for the
>> enabled IPU would register the required DRM entities.
>
> that should work. Let the enabled IPU create the imx-drm
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/st
Smatch located a handful of while loops testing readl calls in s626.c.
Since these while loops depend on readl succeeding, it's safer to make
sure they time out eventually.
Signed-off-by: Chase Southwood
---
Ian and/or Hartley, I'd love your comments on this. It seems to me that
we want these ki
OK. sorry.
I will send again.
Thanks.
Daeseok Youn
2014-02-28 16:28 GMT+09:00 Dan Carpenter :
> On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>>
>
> Patch is white space dammaged and doesn't apply.
A handful of variables here were being initialized to 0 upon declaration,
however they are always then set to another value before their first use,
so initialization here is useless and we can remove it.
Signed-off-by: Chase Southwood
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
hwdrv_apci1564.c had numerous lines over the column limit. This patch
splits all such lines to bring them in compliance with coding style.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 50 --
1 file changed, 36 insertions(+), 14 dele
Nearly every variable in hwdrv_apci035.c is initialized to 0 when it is
declared, and then set to some other value before ever being used. As
such, we can remove all of these initializations. They are accomplishing
nothing.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data/hwdrv_
On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote:
>
> clean up checkpatch.pl warnings:
> WARNING: Line length over 80 characters
>
Patch is white space dammaged and doesn't apply.
regards,
dan carpenter
___
devel mailing list
de...@linux
clean up checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 62 +++---
1 file changed, 25 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45
--
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c
b/drivers/
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 585 +++---
1 file changed, 293 insertions(+), 292 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c
clean up checkpatch.pl warnings:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 120 +++---
1 file changed, 60 insertions(+), 60 deletions(-)
diff --git a/drivers/sta
On Thu, Feb 27, 2014 at 11:54:23PM +, Russell King - ARM Linux wrote:
> On Thu, Feb 27, 2014 at 02:52:34PM -0800, Greg KH wrote:
> >
> > How can dmfc ever be NULL? You control what values you pass to it, why
> > check it again?
>
> Indeed. This is actually a case where the static checker wa
On Thu, Feb 27, 2014 at 11:44:38PM +, Russell King - ARM Linux wrote:
> On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote:
> > On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote:
> > > diff --git a/drivers/staging/imx-drm/imx-ldb.c
> > > b/drivers/staging/imx-drm/imx-ldb.c
> >
On Thu, Feb 27, 2014 at 11:44:38PM +, Russell King - ARM Linux wrote:
> On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote:
> > On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote:
> > > diff --git a/drivers/staging/imx-drm/imx-ldb.c
> > > b/drivers/staging/imx-drm/imx-ldb.c
> >
This patch bypass the timer_irq_works() check for hyperv guest since:
- It was guaranteed to work.
- timer_irq_works() may fail sometime due to the lpj calibration were inaccurate
in a hyperv guest or a buggy host.
In the future, we should get the tsc frequency from hypervisor and use preset
lp
> -Original Message-
> From: Thomas Gleixner [mailto:t...@linutronix.de]
> Sent: Tuesday, February 25, 2014 11:10 AM
> To: KY Srinivasan
> Cc: LKML; Ingo Molnar; Peter Zijlstra; x86; Greg Kroah-Hartman; linuxdrivers
> Subject: RE: [patch 25/26] x86: hyperv: Cleanup the irq mess
>
> On Tu
'struct tty_struct’ has no member named ‘low_latency’
Signed-off-by: Kumar Amit Mehta
---
drivers/staging/sb105x/sb_pci_mp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sb105x/sb_pci_mp.c
b/drivers/staging/sb105x/sb_pci_mp.c
index c9d6ee3..5687d6c 100
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 02b4f8f..07de83f 100644
--- a/drivers/staging/cxt1e1/hwprobe.c
+++ b/drivers/staging
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. Adding an usbip uapi header file will
define the kernel - userspace interface for this device status.
Signed-off-by: Shuah Khan
---
include/uapi/linux/Kbuild |1 +
include/uapi/linux/usbip
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. A new uapi usbip.h now defines the
usbip device status for kernel and userspace to use. Change usbip
kernel space to include uapi usbip.h for usbip device status.
Signed-off-by: Shuah Khan
---
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. Adding an usbip uapi header file will
define the kernel - userspace interface for this device status.
Shuah Khan (3):
staging/usbip: add uapi header to export usbip kernel interfaces
staging/
usbip userspace has duplicated enum definition to report usbip device
status maintained by the kernel. A new uapi usbip.h now defines the
usbip device status for kernel and userspace to use. Change usbip
userspace to include uapi usbip.h for usbip device status.
Signed-off-by: Shuah Khan
---
...
On Thu, Feb 27, 2014 at 02:52:34PM -0800, Greg KH wrote:
> On Wed, Feb 26, 2014 at 08:53:39PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam
> >
> > Fix the following static checker warning:
> >
> > drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel()
> > warn: variable d
On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote:
> On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote:
> > diff --git a/drivers/staging/imx-drm/imx-ldb.c
> > b/drivers/staging/imx-drm/imx-ldb.c
> > index abf8517..daa54df 100644
> > --- a/drivers/staging/imx-drm/imx-ldb.c
> > +++
On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Use snprintf() in order to fix the following static checker warning:
>
> drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
> overflow. buf_size: 16 length: 18
> probably 18 is the
On Wed, Feb 26, 2014 at 08:53:39PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following static checker warning:
>
> drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
> variable dereferenced before check 'dmfc' (see line 157)
>
> Reported-by: Dan Ca
This isn't a real patch, and it deliberately doesn't compile, but it's
sort of what the patch should look like.
The first thing to do is to get rid of the stupid DGAP_UNLOCK() macro.
Disabling IRQs more than once doesn't help anything and it doesn't make
sense to have lock_flags and lock_flags2.
On Thu, Feb 27, 2014 at 03:39:08PM -0500, Mark Hounschell wrote:
> On 02/26/2014 10:30 AM, Dan Carpenter wrote:
> > On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote:
> >> This patch addresses the follow error message followed
> >> by a kernel oops:
> >>
> >> dgap: driver does not set
On Thu, Feb 27, 2014 at 03:39:08PM -0500, Mark Hounschell wrote:
> On 02/26/2014 10:30 AM, Dan Carpenter wrote:
> > On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote:
> >> This patch addresses the follow error message followed
> >> by a kernel oops:
> >>
> >> dgap: driver does not set
On Thu, Feb 27, 2014 at 12:41:36PM -0800, Greg Kroah-Hartman wrote:
> On Tue, Feb 25, 2014 at 01:09:57PM +0100, Philipp Zabel wrote:
> > Am Dienstag, den 25.02.2014, 12:43 +0100 schrieb Philipp Zabel:
> > > The i.MX Image Processing Unit (IPU) contains a number of image processing
> > > blocks that
On Tue, Feb 25, 2014 at 12:43:40PM +0100, Philipp Zabel wrote:
> Hi,
>
> this series has two small cleanups for the IPUv3 core driver and then moves
> it from drivers/staging/imx-drm/ipu-v3 to drivers/gpu. In this directory there
> is already the host1x driver, which serves a similar purpose.
I'v
On Tue, Feb 25, 2014 at 01:09:57PM +0100, Philipp Zabel wrote:
> Am Dienstag, den 25.02.2014, 12:43 +0100 schrieb Philipp Zabel:
> > The i.MX Image Processing Unit (IPU) contains a number of image processing
> > blocks that sit right in the middle between DRM and V4L2. Some of the
> > modules,
> >
On 02/26/2014 10:30 AM, Dan Carpenter wrote:
> On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote:
>> This patch addresses the follow error message followed
>> by a kernel oops:
>>
>> dgap: driver does not set tty->port. This will crash the kernel later. Fix
>> the driver
>>
>> It als
On Thu, Feb 27, 2014 at 06:12:48PM +, r...@mage.me.uk wrote:
> When checking buffers.c with checkpatch.pl it throws the following error:
> drivers/staging/speakup/buffers.c:58: ERROR: return is not a function,
> parentheses are not required
Remember, checkpatch.pl is a "guide", not the "law".
When checking buffers.c with checkpatch.pl it throws the following
error: drivers/staging/speakup/buffers.c:58: ERROR: return is not a
function, parentheses are not required
I watched one of your talks, it's very informative and concise:
http://www.youtube.com/watch?v=LLBrBBImJt4&feature=youtu
On Thu, Feb 27, 2014 at 04:26:42PM +, Reza Snowdon wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Reza Snowdon
> ---
> drivers/staging/speakup/buffers.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/buffers.c
> b/drivers/stag
On Thu, Feb 27, 2014 at 04:26:42PM +, Reza Snowdon wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Reza Snowdon
> ---
> drivers/staging/speakup/buffers.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/buffers.c
> b/drivers/stag
Hi Tomi,
Am Donnerstag, den 27.02.2014, 15:55 +0200 schrieb Tomi Valkeinen:
> On 27/02/14 15:00, Russell King - ARM Linux wrote:
> > On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote:
> >> For the i.MX6 display subsystem there is no clear single master device,
> >> and the physical con
Fixed a coding style issue.
Signed-off-by: Reza Snowdon
---
drivers/staging/speakup/buffers.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/buffers.c
b/drivers/staging/speakup/buffers.c
index 382973e..8d7caa7 100644
--- a/drivers/staging/speaku
On 27/02/14 15:43, Russell King - ARM Linux wrote:
> That may be - but the problem with CDF solving this problem is that it's
> wrong. It's fixing what is in actual fact a *generic* problem in a much
> too specific way. To put it another way, it's forcing everyone to fix
> the same problem in th
On 27/02/14 15:00, Russell King - ARM Linux wrote:
> On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote:
>> For the i.MX6 display subsystem there is no clear single master device,
>> and the physical configuration changes across the SoC family. The
>> i.MX6Q/i.MX6D SoCs have two separate
On Thu, Feb 27, 2014 at 03:16:03PM +0200, Tomi Valkeinen wrote:
> On 27/02/14 13:56, Russell King - ARM Linux wrote:
>
> >> Is there even need for such a master device? You can find all the
> >> connected display devices from any single display device, by just
> >> following the endpoint links.
>
On 27/02/14 13:56, Russell King - ARM Linux wrote:
>> Is there even need for such a master device? You can find all the
>> connected display devices from any single display device, by just
>> following the endpoint links.
>
> Please read up on what has been discussed over previous years:
>
> htt
From: Heinrich Schuchardt
Memory was leaked and a device not closed.
Signed-off-by: Heinrich Schuchardt
---
drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c
b/drivers
On Thu, Feb 27, 2014 at 8:00 AM, Russell King - ARM Linux
wrote:
> On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote:
>> For the i.MX6 display subsystem there is no clear single master device,
>> and the physical configuration changes across the SoC family. The
>> i.MX6Q/i.MX6D SoCs ha
On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote:
> For the i.MX6 display subsystem there is no clear single master device,
> and the physical configuration changes across the SoC family. The
> i.MX6Q/i.MX6D SoCs have two separate display controller devices IPU1 and
> IPU2, with two ou
Am Donnerstag, den 27.02.2014, 13:06 +0200 schrieb Tomi Valkeinen:
> On 25/02/14 16:23, Philipp Zabel wrote:
>
> > +Freescale i.MX DRM master device
> > +
> > +
> > +The freescale i.MX DRM master device is a virtual device needed to list all
> > +IPU or other displa
On Thu, Feb 27, 2014 at 01:06:52PM +0200, Tomi Valkeinen wrote:
> On 25/02/14 16:23, Philipp Zabel wrote:
>
> > +Freescale i.MX DRM master device
> > +
> > +
> > +The freescale i.MX DRM master device is a virtual device needed to list all
> > +IPU or other display i
Argument type of sockfd is set as int, but format string
is set as unsigned int. Fix the mismatch.
Signed-off-by: Masanari Iida
---
drivers/staging/usbip/userspace/libsrc/vhci_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/libsrc/vhci
Fix spelling typo in comments and printk within
rtl8188eu/core
Signed-off-by: Masanari Iida
---
drivers/staging/rtl8188eu/core/rtw_ap.c| 14 +-
drivers/staging/rtl8188eu/core/rtw_br_ext.c| 6 ++---
drivers/staging/rtl8188eu/core/rtw_debug.c | 2 +-
drivers/staging/rtl81
On 25/02/14 16:23, Philipp Zabel wrote:
> +Freescale i.MX DRM master device
> +
> +
> +The freescale i.MX DRM master device is a virtual device needed to list all
> +IPU or other display interface nodes that comprise the graphics subsystem.
> +
> +Required propertie
clean up checkpatch errors and bClassificationSucceed is set to "TRUE"
proper location.
If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.
Signed-off-by: Daeseok Youn
---
d
bClassificationSucceed is initialized with "false",
do not need to set "false" again.
Signed-off-by: Daeseok Youn
---
drivers/staging/bcm/Qos.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 0727599..ead57b4 100644
--- a/driv
57 matches
Mail list logo
