Hi Prabhakar
On 02/25/2014 07:02 AM, Prabhakar Lad wrote:
> Hi Michael,
>
> On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
> wrote:
>> Hi Michael,
>>
>> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
>> wrote:
>>> Hi Laurent,
>>>
>>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
Hi
Hi Michael,
On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
wrote:
> Hi Michael,
>
> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
> wrote:
>> Hi Laurent,
>>
>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>>> Hi Michael,
>>>
>>> What's the status of this patch ? Do expect Prabhakar to
After spin_lock() is called, all of if-else conditions in this brace
should reach the end of else and spin_unlock() must be called.
So It doesn't need to call spin_unlock() without a return statement
for handling an error.
Also sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
con
Ok.
I will make a patch based on linux-next branch and send it again.
Thanks.
Daeseok Youn
2014-02-25 9:43 GMT+09:00 Greg KH :
> On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>>
>> After spin_lock() is called, all of if-else conditions in this brace
>> should reach the end of els
On Mon, Feb 24, 2014 at 10:35:09AM -0600, Chase Southwood wrote:
> There are a couple of cases where a comment being on the same line as a
> statement is causing the line to be over 80 characters long. This is an
> easy fix, move these comments to the previous line.
>
> Signed-off-by: Chase South
On Sat, Feb 22, 2014 at 12:33:36PM +0800, Zhao, Gang wrote:
> On Fri, 2014-02-21 at 20:35:50 +0800, Dan Carpenter wrote:
> > On Fri, Feb 21, 2014 at 08:22:21PM +0800, Zhao, Gang wrote:
> >> > If we add your patch and the reviewer does a search for fb[0] then it is
> >> > confusing what the right th
On Mon, Feb 24, 2014 at 12:21:51AM +0400, Alexey Khoroshilov wrote:
> dgap_driver_start and dgap_Major_Control_Registered are used
> to keep status of initialization of the driver as a whole and its "Major
> Control".
> But the code that checks them is executed once on module init/unload.
> That m
On Wed, Feb 19, 2014 at 01:12:14PM -0500, Mark Hounschell wrote:
> Renames driver file dgap_driver.c and dgap_driver.h to
> dgap.c and dgap.h because we are now single source and
> include file and better fits kernel naming conventions.
>
> Signed-off-by: Mark Hounschell
> ---
> drivers/staging
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>
> After spin_lock() is called, all of if-else conditions in this brace
> should reach the end of else and spin_unlock() must be called.
> So It doesn't need to call spin_unlock() without a return statement
> for handling an error.
>
On Wed, Feb 19, 2014 at 01:11:57PM -0500, Mark Hounschell wrote:
> This patch removes all the original CVS tags because they are in my way
>
> Signed-off-by: Mark Hounschell
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/dgap/dgap_conf.h | 1 -
> drivers/staging/dgap/dgap_downld.h | 1 -
>
On Mon, Feb 24, 2014 at 01:08:19PM -0700, Jon Mason wrote:
> Use PCI_VENDOR_ID_INTEL instead of creating its own vendor ID #define.
>
> Signed-off-by: Jon Mason
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/media/dt3155v4l/dt3155v4l.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
On Thu, Feb 20, 2014 at 01:05:31AM -0700, axel.rasmuss...@gmail.com wrote:
> From: Axel Rasmussen
> Date: Mon, 17 Feb 2014 23:50:05 -0700
> Subject: [PATCH] staging: rtl8187se: fix checkpatch.pl issues
Please just use 'git send-email' so I don't have to hand-edit the patch
and strip this out :(
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Monday, February 24, 2014 8:17 AM
> To: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; KY Srinivasan;
> Abhishek Gupta (LIS); Haiyang Zhang; jasow...@redhat.com;
> to
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Monday, February 24, 2014 8:17 AM
> To: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; KY Srinivasan;
> Abhishek Gupta (LIS); Haiyang Zhang; jasow...@redhat.com;
> to
On 24/02/14 21:14, Jonathan Cameron wrote:
On 24/02/14 16:48, Alexandre Belloni wrote:
On 24/02/2014 at 15:39:53 +0100, Juergen Beisert wrote :
Releasing the touchscreen lets the internal statemachine left in a wrong state.
Due to this the release coordinate will be reported again by accident w
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Monday, February 24, 2014 5:17 AM
> To: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; KY
> Srinivasan; Abhishek Gupta (LIS); Haiyang Zhang; jasow...@redhat.com;
> to
On 24/02/14 16:48, Alexandre Belloni wrote:
On 24/02/2014 at 15:39:53 +0100, Juergen Beisert wrote :
Releasing the touchscreen lets the internal statemachine left in a wrong state.
Due to this the release coordinate will be reported again by accident when the
next
touchscreen event happens. Thi
On Mon, Feb 24, 2014 at 12:41:41PM -0800, Greg KH wrote:
> On Mon, Feb 24, 2014 at 02:20:20PM +, Russell King wrote:
> > Greg,
> >
> > Please incorporate the latest imx-drm updates into staging, which can be
> > found at:
> >
> > git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging
On Mon, Feb 24, 2014 at 02:20:20PM +, Russell King wrote:
> Greg,
>
> Please incorporate the latest imx-drm updates into staging, which can be
> found at:
>
> git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging
>
> with SHA1 d94905e019acce960feeda1f92a9427fbe45ebbe.
>
> These ch
Use PCI_VENDOR_ID_INTEL instead of creating its own vendor ID #define.
Signed-off-by: Jon Mason
Cc: Greg Kroah-Hartman
---
drivers/staging/media/dt3155v4l/dt3155v4l.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c
b/drivers/sta
Remove unused #defines, structure, and inlined functions for the
rtl8192e driver. Compile tested only.
Signed-off-by: Jon Mason
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8192e/rtl8192e/rtl_pci.h | 52 -
1 file changed, 52 deletions(-)
diff --git a/drivers/stagi
From: Manu Gupta
The D-Link DWA-123 REV D1 with USB ID 2001:3310 uses this driver.
Signed-off-by: Manu Gupta
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/s
Am Montag, den 24.02.2014, 17:06 + schrieb Russell King - ARM Linux:
> On Mon, Feb 24, 2014 at 05:56:38PM +0100, Philipp Zabel wrote:
> > Am Montag, den 24.02.2014, 15:49 + schrieb Russell King - ARM Linux:
> > One issue was that the DT parsing code would try to add the imx-ldb
> > componen
Am Montag, den 24.02.2014, 15:52 + schrieb Russell King - ARM Linux:
> On Tue, Feb 18, 2014 at 12:36:03PM +0100, Philipp Zabel wrote:
> > From: Philipp Zabel
> >
> > The existing v4l2-of parser functions for the video interface bindings
> > described in Documentation/device-tree/bindings/medi
On February 24, 2014 2:26:58 PM GMT+00:00, Alexandre Belloni
wrote:
>Hi Juergen,
>
>On 24/02/2014 at 14:16:24 +0100, Juergen Beisert wrote :
>> Hi Alexandre,
>>
>> > While I don't have much experience with the TS part of the code but
>I
>> > can investigate if you don't have any idea.
>>
>> c
On Mon, Feb 24, 2014 at 05:56:38PM +0100, Philipp Zabel wrote:
> Am Montag, den 24.02.2014, 15:49 + schrieb Russell King - ARM Linux:
> One issue was that the DT parsing code would try to add the imx-ldb
> component right after the first crtc, and then its bind would fail
> in imx_drm_encoder_p
Am Montag, den 24.02.2014, 17:56 +0100 schrieb Philipp Zabel:
> Am Montag, den 24.02.2014, 15:49 + schrieb Russell King - ARM Linux:
> > On Tue, Feb 18, 2014 at 12:36:02PM +0100, Philipp Zabel wrote:
> > > From: Lucas Stach
> > >
> > > Since imx_drm_encoder_parse_of is called from the encoder
Am Montag, den 24.02.2014, 15:49 + schrieb Russell King - ARM Linux:
> On Tue, Feb 18, 2014 at 12:36:02PM +0100, Philipp Zabel wrote:
> > From: Lucas Stach
> >
> > Since imx_drm_encoder_parse_of is called from the encoder bind callbacks,
> > it is too late to request probe deferral. Rather th
Signed-off-by: Monam Agarwal
---
drivers/staging/comedi/comedi_fops.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index ac1edd9..7da8566 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++
On 24/02/2014 at 15:39:53 +0100, Juergen Beisert wrote :
> Releasing the touchscreen lets the internal statemachine left in a wrong
> state.
> Due to this the release coordinate will be reported again by accident when
> the next
> touchscreen event happens. This change sets up the correct state w
On 2014-02-24 16:35, Chase Southwood wrote:
There are a couple of cases where a comment being on the same line as a
statement is causing the line to be over 80 characters long. This is an
easy fix, move these comments to the previous line.
Signed-off-by: Chase Southwood
---
2: Some changes to
On 2014-02-24 16:34, Chase Southwood wrote:
There were some conditional blocks that had an unnecessary level of
indentation in them. We can remove this to improve code clarity.
Signed-off-by: Chase Southwood
---
2: Moved "else if" up to the same line as closing brace of "if". Left
braces on s
There are a couple of cases where a comment being on the same line as a
statement is causing the line to be over 80 characters long. This is an
easy fix, move these comments to the previous line.
Signed-off-by: Chase Southwood
---
2: Some changes to PATCH 2/3 v2 occurred in the immediate context
There were some conditional blocks that had an unnecessary level of
indentation in them. We can remove this to improve code clarity.
Signed-off-by: Chase Southwood
---
2: Moved "else if" up to the same line as closing brace of "if". Left
braces on single line "else if" matched to an "if" requir
>On Monday, February 24, 2014 8:13 AM, Ian Abbott wrote:
>>On 2014-02-22 03:21, Chase Southwood wrote:
>> There were some conditional blocks that had an unneccesary level of
>> indentation in them. We can remove this to improve code clarity.
>>
>> Signed-off-by: Chase Southwood
>> ---
>> .../
On Tue, Feb 18, 2014 at 12:36:03PM +0100, Philipp Zabel wrote:
> From: Philipp Zabel
>
> The existing v4l2-of parser functions for the video interface bindings
> described in Documentation/device-tree/bindings/media/video-interfaces.txt
> are useful for DRM drivers, too. They will be moved to dri
On Tue, Feb 18, 2014 at 12:36:02PM +0100, Philipp Zabel wrote:
> From: Lucas Stach
>
> Since imx_drm_encoder_parse_of is called from the encoder bind callbacks,
> it is too late to request probe deferral. Rather the core should make sure
> that the crtcs are bound before the encoders, after all n
Am Dienstag, den 18.02.2014, 12:36 +0100 schrieb Philipp Zabel:
> Hi,
>
> here is an updated and more complete version of the imx-drm DT binding
> series. These patches apply on top of Russell's second preview of the
> imx-drm cleanup series on v3.14-rc2. I have added device tree bindings
> betwee
On Mon, Feb 24, 2014 at 03:38:26PM +0100, Juergen Beisert wrote:
> Hi Dan,
>
> On Monday 24 February 2014 14:33:16 Dan Carpenter wrote:
> > On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote:
> > > > While I don't have much experience with the TS part of the code but I
> > > > can inv
Releasing the touchscreen lets the internal statemachine left in a wrong state.
Due to this the release coordinate will be reported again by accident when the
next
touchscreen event happens. This change sets up the correct state when waiting
for the next touchscreen event.
Signed-off-by: Juer
Hi Dan,
On Monday 24 February 2014 14:33:16 Dan Carpenter wrote:
> On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote:
> > > While I don't have much experience with the TS part of the code but I
> > > can investigate if you don't have any idea.
> >
> > can you please test the followin
Hi Juergen,
On 24/02/2014 at 14:16:24 +0100, Juergen Beisert wrote :
> Hi Alexandre,
>
> > While I don't have much experience with the TS part of the code but I
> > can investigate if you don't have any idea.
>
> can you please test the following patch?
> After releasing the touchscreen the inte
Greg,
Please incorporate the latest imx-drm updates into staging, which can be
found at:
git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging
with SHA1 d94905e019acce960feeda1f92a9427fbe45ebbe.
These changes, which convert imx-drm to use the recently merged component
infrastructure,
On 2014-02-22 03:21, Chase Southwood wrote:
There are a couple of cases where a comment being on the same line as a
statement is causing the line to be over 80 characters long. This is an
easy fix; move these comments to the previous line.
Signed-off-by: Chase Southwood
Reviewed-by: Ian Abbo
On 2014-02-22 03:21, Chase Southwood wrote:
There were some conditional blocks that had an unneccesary level of
indentation in them. We can remove this to improve code clarity.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data/hwdrv_apci035.c | 31 ++
On 2014-02-22 03:20, Chase Southwood wrote:
This patch further cleans up the comments in hwdrv_apci035.c, converting
them to kernel style and removing some commented conditional statements
that are unused.
Signed-off-by: Chase Southwood
---
I decided to return to the first driver I touched. I
On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote:
> Hi Alexandre,
>
> > While I don't have much experience with the TS part of the code but I
> > can investigate if you don't have any idea.
>
> can you please test the following patch?
> After releasing the touchscreen the internal
UEFI-based generation 2 virtual machines support vmbus devices only.
There is no pci bus. Thus they use a different mechanism for the
graphics framebuffer: Instead of using the vga pci bar a chunk of
memory muct be allocated from the hyperv mmio region declared using
APCI. This patch implements
Remove firmware framebuffer before initializing hyperv-fb. Needed
on gen2 virtual machines. Letting register_framebuffer handle the
switchover results in efifb still being active while hyperv graphics
are initialized, which in turn can make the linux kernel hang.
Signed-off-by: Gerd Hoffmann
-
Hi,
This patch series adds support for uefi-based gen2 virtual machines to
the hyperv-fb driver. It depends on -next commit
90f3453585479d5beb75058da46eb573ced0e6ac
Patch #1 is a bugfix for 90f3453585479d5beb75058da46eb573ced0e6ac.
Patch #2 changes vmbus to properly hook the hyperv mmio area
Signed-off-by: Gerd Hoffmann
---
drivers/hv/vmbus_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index b37c91b..2352ae48 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -899,10 +899,12 @@ static acpi_status vmbus_wal
Use a resource for the hyperv mmio region instead of start/size
variables. Register the region properly so it shows up in
/proc/iomem.
Signed-off-by: Gerd Hoffmann
---
drivers/hv/vmbus_drv.c | 16 ++--
include/linux/hyperv.h | 3 +--
2 files changed, 11 insertions(+), 8 deletions(-
Hi Alexandre,
> While I don't have much experience with the TS part of the code but I
> can investigate if you don't have any idea.
can you please test the following patch?
After releasing the touchscreen the internal state machine was left in a
wrong state.
diff --git a/drivers/staging/iio/adc/
On Mon, Feb 24, 2014 at 11:55:43AM +0100, Gerd Hoffmann wrote:
> On Mo, 2014-02-24 at 13:42 +0300, Dan Carpenter wrote:
> > I'm sorry, I know it sucks to not get credit for fixes, but please just
> > fold this into [patch 1/5]. We really should have a tag for this kind
> > of thing.
>
> It's not
On Mo, 2014-02-24 at 13:42 +0300, Dan Carpenter wrote:
> I'm sorry, I know it sucks to not get credit for fixes, but please just
> fold this into [patch 1/5]. We really should have a tag for this kind
> of thing.
It's not because of the credits, but because Greg picked up #1 into one
of his branc
I'm sorry, I know it sucks to not get credit for fixes, but please just
fold this into [patch 1/5]. We really should have a tag for this kind
of thing.
Would something like this work?
Additional-Fixes: Gerd Hoffmann
regards,
dan carpenter
___
devel
On Mon, Feb 24, 2014 at 11:25:12AM +0100, Gerd Hoffmann wrote:
> -static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *irq)
> +static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *ctx)
> {
> + switch (res->type) {
> + case ACPI_RESOURCE_TYPE_IRQ:
> +
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>
> After spin_lock() is called, all of if-else conditions in this brace
> should reach the end of else and spin_unlock() must be called.
> So It doesn't need to call spin_unlock() without a return statement
> for handling an error.
>
UEFI-based generation 2 virtual machines support vmbus devices only.
There is no pci bus. Thus they use a different mechanism for the
graphics framebuffer: Instead of using the vga pci bar a chunk of
memory muct be allocated from the hyperv mmio region declared using
APCI. This patch implements
Remove firmware framebuffer before initializing hyperv-fb. Needed
on gen2 virtual machines. Letting register_framebuffer handle the
switchover results in efifb still being active while hyperv graphics
are initialized, which in turn can make the linux kernel hang.
Signed-off-by: Gerd Hoffmann
-
Use a resource for the hyperv mmio region instead of start/size
variables. Register the region properly so it shows up in
/proc/iomem.
Signed-off-by: Gerd Hoffmann
---
drivers/hv/vmbus_drv.c | 16 ++--
include/linux/hyperv.h | 3 +--
2 files changed, 11 insertions(+), 8 deletions(-
From: "K. Y. Srinivasan"
On Gen2 firmware, Hyper-V does not emulate the PCI bus. However, the MMIO
information is packaged up in DSDT. Extract this information and export it
for use by the synthetic framebuffer driver. This is the only driver that
needs this currently.
In this version of the pat
Signed-off-by: Gerd Hoffmann
---
drivers/hv/vmbus_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index b37c91b..2352ae48 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -899,10 +899,12 @@ static acpi_status vmbus_wal
After spin_lock() is called, all of if-else conditions in this brace
should reach the end of else and spin_unlock() must be called.
So It doesn't need to call spin_unlock() without a return statement
for handling an error.
Also sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
con
You have not understood what Joe said.
On Mon, Feb 24, 2014 at 08:48:47PM +1100, David Roddick wrote:
> Removed unnecessary spaces after function pointer names and corrected
> multi-line wrap alignment
>
This should be line wrapped at 72 characters (same rule as email). In
other words it shoul
Removed unnecessary spaces after function pointer names and corrected
multi-line wrap alignment
Signed-off-by: David Roddick
---
drivers/staging/comedi/drivers/poc.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/driver
2014-02-24 17:06 GMT+09:00 Dan Carpenter :
> On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
>> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn
>> Date: Mon, 24 Feb 2014 09:17:41 +0900
>> Subject: [PATCH] staging: ced401: remove redundant
Dear Webmail User,
You are receiving this e-mail because your inbox capacity is currently inactive
in our database.
Your incoming mails were placed on pending status due to the recent upgrade in
our database.
Your incoming mails has been migrated to the Exchange server with Error code:
EXCH2K10
On Mon, 2014-02-24 at 19:39 +1100, David Roddick wrote:
> This is a patch to remove unneccessary space after function pointer name
> found with checkpatch.pl
A few comments:
Please wrap your commit message to 70 columns or so.
There is 1 c in unnecessary.
The "This is a patch to " bit isn't p
This is a patch to remove unneccessary space after function pointer name found
with checkpatch.pl
Signed-off-by: David Roddick
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/drivers/st
Subject is still messed up. Send the email to yourself first and then
to the list until you figure it out. (hint add a blank line).
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mail
On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn
> Date: Mon, 24 Feb 2014 09:17:41 +0900
> Subject: [PATCH] staging: ced401: remove redundant spin_unlock
Don't send this header. We get eve
72 matches
Mail list logo
