On Fri, 2014-02-21 at 20:35:50 +0800, Dan Carpenter wrote:
> On Fri, Feb 21, 2014 at 08:22:21PM +0800, Zhao, Gang wrote:
>> > If we add your patch and the reviewer does a search for fb[0] then it is
>> > confusing what the right thing to do is.
>>
>> My fault. I should remove that two lines of cod
There were some conditional blocks that had an unneccesary level of
indentation in them. We can remove this to improve code clarity.
Signed-off-by: Chase Southwood
---
.../comedi/drivers/addi-data/hwdrv_apci035.c | 31 ++
1 file changed, 14 insertions(+), 17 deletions(
There are a couple of cases where a comment being on the same line as a
statement is causing the line to be over 80 characters long. This is an
easy fix; move these comments to the previous line.
Signed-off-by: Chase Southwood
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 11 ++
This patch further cleans up the comments in hwdrv_apci035.c, converting
them to kernel style and removing some commented conditional statements
that are unused.
Signed-off-by: Chase Southwood
---
I decided to return to the first driver I touched. I found some more
things that could be cleaned
On Thu, Feb 20, 2014 at 02:22:53PM +0100, Compostella, Jeremy wrote:
> From: "Compostella, Jeremy"
>
> This bug can manifest itself in several situations, here is the one that made
> me
> hunt it last week:
>
> When an Android device is encrypted, Android starts all the init services of
> core
Hi,
Denis Carikli wrote:
> If de-active and/or pixelclk-active properties were set in the
> display-timings DT node, they were not used.
>
> Instead the data-enable and the pixel data clock polarity
> were hardcoded.
>
> This change is needed for making the eukrea-cpuimx51
> QVGA display work.
On Fri, Feb 21, 2014 at 10:37:26AM -0500, Mark Hounschell wrote:
> When a kernel subsystem undergoes a global change such as the serial
> subsystem has been since 3.5 or so, if a driver is in staging, does it
> automatically get those changes if they are applicable to it?
Yes. If you change an AP
On Fri, Feb 21, 2014 at 10:37:26AM -0500, Mark Hounschell wrote:
> When a kernel subsystem undergoes a global change such as the serial
> subsystem has been since 3.5 or so, if a driver is in staging, does it
> automatically get those changes if they are applicable to it?
Yes it does.
When a kernel subsystem undergoes a global change such as the serial
subsystem has been since 3.5 or so, if a driver is in staging, does it
automatically get those changes if they are applicable to it?
Thanks
Mark
___
devel mailing list
de...@linuxdriver
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Friday, February 21, 2014 12:57 AM
> To: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; KY Srinivasan;
> Haiyang Zhang; jasow...@redhat.com; Gerd Hoffmann; Jean-Chris
Remove firmware framebuffer before initializing hyperv-fb. Needed
on gen2 virtual machines. Letting register_framebuffer handle the
switchover results in efifb still being active while hyperv graphics
are initialized, which in turn can make the linux kernel hang.
Signed-off-by: Gerd Hoffmann
-
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Cc: Greg Kroah-Hartman
Cc: Eric Bénard
Cc: Marek Vasut
Cc: Sascha Hauer
Cc: de...@driverdev.osuosl.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Denis
Cc: Greg Kroah-Hartman
Cc: Eric Bénard
Cc: Marek Vasut
Cc: Sascha Hauer
Cc: de...@driverdev.osuosl.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Denis Carikli
---
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Remove people not concerned by this patch fr
Cc: Alexander Shiyan
Cc: Eric Bénard
Cc: Greg Kroah-Hartman
Cc: Marek Vasut
Cc: Sascha Hauer
Cc: driverdev-devel@linuxdriverproject.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Denis Carikli
---
ChangeLog v6->v7:
- Shrinked even more the Cc list.
- Rebased the patch and include
If de-active and/or pixelclk-active properties were set in the
display-timings DT node, they were not used.
Instead the data-enable and the pixel data clock polarity
were hardcoded.
This change is needed for making the eukrea-cpuimx51
QVGA display work.
Cc: Eric Bénard
Cc: Greg Kroah-Hartman
On Fri, Feb 21, 2014 at 08:22:21PM +0800, Zhao, Gang wrote:
> > If we add your patch and the reviewer does a search for fb[0] then it is
> > confusing what the right thing to do is.
>
> My fault. I should remove that two lines of code in
> et131x_rx_dma_memory_free(), although they don't break the
Come on... :/
Don't randomly add a pointless kfree() to one error path when there are
four later error paths in this function that don't have a kfree(). It
just makes the code more difficult to understand for no reason.
And we're not going to add a comment to every single error path
either.
re
On Fri, 2014-02-21 at 15:38:56 +0800, Dan Carpenter wrote:
> I don't think this is the right thing because it is needless code.
> Overall it doesn't really simplify anything.
>
> You are worried that reviewers will be confused and think there is a
> leak in et131x_rx_dma_memory_alloc() and then add
From: Micky Ching
Add support for realtek rts5250 pci card reader. The card reader have
some problem with DDR50 mode, so add a new quirks2 for broken ddr50.
Signed-off-by: Micky Ching
---
drivers/mmc/host/sdhci-pci.c | 20
drivers/mmc/host/sdhci.c |3 ++-
include
UEFI-based generation 2 virtual machines support vmbus devices only.
There is no pci bus. Thus they use a different mechanism for the
graphics framebuffer: Instead of using the vga pci bar a chunk of
memory muct be allocated from the hyperv mmio region declared using
APCI. This patch implements
Signed-off-by: Gerd Hoffmann
---
drivers/hv/vmbus_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index b37c91b..2352ae48 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -899,10 +899,12 @@ static acpi_status vmbus_wal
Use a resource for the hyperv mmio region instead of start/size
variables. Register the region properly so it shows up in
/proc/iomem.
Signed-off-by: Gerd Hoffmann
---
drivers/hv/vmbus_drv.c | 16 ++--
include/linux/hyperv.h | 3 +--
2 files changed, 11 insertions(+), 8 deletions(-
From: "K. Y. Srinivasan"
On Gen2 firmware, Hyper-V does not emulate the PCI bus. However, the MMIO
information is packaged up in DSDT. Extract this information and export it
for use by the synthetic framebuffer driver. This is the only driver that
needs this currently.
In this version of the pat
23 matches
Mail list logo
