[PATCH 4/4] Staging: comedi: addi-data: don't initialize a static variable to 0

2014-02-18 Thread Chase Southwood
In hwdrv_apci1564.c, one static variable is zero initialized. This is unneeded and redundant, so we remove the initialization. Signed-off-by: Chase Southwood --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 3/4] Staging: comedi: addi-data: replace printk() with dev_err() in hwdrv_apci1564.c

2014-02-18 Thread Chase Southwood
There were a small handful of printk() calls in hwdrv_apci1564.c. It is generally better to use dev_err() for error messages instead, so I switched all the printk() calls out, as well as cleaned up the error strings. Signed-off-by: Chase Southwood --- drivers/staging/comedi/drivers/addi-data/hw

[PATCH 2/4] Staging: comedi: addi-data: cleanup brace usage in hwdrv_apci1564.c

2014-02-18 Thread Chase Southwood
hwdrv_apci1564.c had many single statments wrapped in braces, so we can delete these. Also, some else statements were improperly placed, fix these too. Signed-off-by: Chase Southwood --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 58 -- 1 file changed, 22 insertion

[PATCH 1/4] Staging: comedi: addi-data: cleanup comments in hwdrv_apci1564.c

2014-02-18 Thread Chase Southwood
hwdrv_apci1564.c had a lot of commented out conditional statements that were often identical to other un-commented out statements nearby, so it should be safe to just delete all of these commented out lines. This patch also converts the remaining comments to the preferred kernel style for comments

Re: [PATCH] staging: android: binder: convert commented messages to pr_debug

2014-02-18 Thread SeongJae Park
Add de...@driverdev.osuosl.org as CC. Sorry if this duplicated mail bothered your inbox. On Wed, Feb 19, 2014 at 12:49 PM, SeongJae Park wrote: > 2 debugging messages were just commented out for normal case. Let them > be activated on debug mode without explicit code modification. > > Signed-off-

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread SeongJae Park
On Wed, Feb 19, 2014 at 12:04 PM, Sachin Kamat wrote: > On 19 February 2014 05:58, SeongJae Park wrote: >> On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: >>> On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: Signed-off-by: SeongJae Park --- drivers/staging/android/

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread Sachin Kamat
On 19 February 2014 05:58, SeongJae Park wrote: > On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: >> On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: >>> Signed-off-by: SeongJae Park >>> --- >>> drivers/staging/android/binder.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> di

Re: [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues in hwdrv_apci035.c

2014-02-18 Thread Chase Southwood
>On Tuesday, February 18, 2014 5:00 AM, Dan Carpenter > wrote: >>On Mon, Feb 17, 2014 at 12:45:07PM -0800, Chase Southwood wrote: >>>On Monday, February 17, 2014 7:16 AM, Ian Abbott wrote: On 2014-02-16 08:40, Chase Southwood wrote: This patch for hwdrv_apci035 removes some unnee

Re: [PATCH] et131x: fix allocation failures

2014-02-18 Thread Zhao, Gang
Alan, thanks for resending this patch. But it seems you overlooked something we discussed earlier. On Mon, 2014-02-17 at 22:13:08 +0800, Alan wrote: > We should check the ring allocations don't fail. > If we get a fail we need to clean up properly. The allocator assumes the > deallocator will be u

Re: [PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread SeongJae Park
Hello, On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: > On Tue, Feb 18, 2014 at 08:23:26PM +0900, SeongJae Park wrote: >> The variable `binder_debugfs_dir_entry_root` is declared as static >> global variable although it is accessed from init function only. Declare >> it as init function's local

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread SeongJae Park
On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: > On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: >> Signed-off-by: SeongJae Park >> --- >> drivers/staging/android/binder.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/staging/android/binder.c >> b/drivers/

Re: Still waiting for your response

2014-02-18 Thread Mrs. Supini Thrunkul
Hello, I am Mrs. Supini Thrunkul from Tai Yau Bank Hong Kong, I need your cooperation to transfer $ 47.3 million US Dollars to any trusted account within your control. Contact me for more details. Mrs. Supini Thrunkul Tel: +85 2580 848 65 ___ de

Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table.

2014-02-18 Thread Belisko Marek
Hi Jonathan, On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron wrote: > On 14/02/14 14:25, Marek Belisko wrote: >> >> Signed-off-by: Marek Belisko > > I wonder how this got missed. However, for those data elements to be > useful, you will > need to read them somewhere in the driver I think

RE: [PATCH 00/87] staging: comedi: cleanup pcl812/816/818 drivers

2014-02-18 Thread Hartley Sweeten
On Tuesday, February 18, 2014 12:59 PM, Greg KH wrote: > On Tue, Feb 18, 2014 at 12:06:51PM +, Ian Abbott wrote: >> On 2014-02-17 21:26, H Hartley Sweeten wrote: > >These comedi drivers are all very similar so it made sense to clean them >>>up together. >>> >>>This series removes a bunch of the

[PATCH 2/2] hyperv_fb: Add support for Gen2 VM

2014-02-18 Thread Haiyang Zhang
This patch enables Hyper-V FB driver to run on Gen2 VM. The Gen2 VM provides MMIO area for synthetic video from ACPI module, which is exported by vmbus. The generic video is provided by UEFI. PCI video in Gen1 is no longer available. To support synthetic video on Hyper-V Gen2 VM, this patch updat

[PATCH 1/2] hyperv_fb: Add screen refresh after pause/resume operation

2014-02-18 Thread Haiyang Zhang
This is necessary because after VM is pause/resumed, some portion of the screen may need refresh. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/video/hyperv_fb.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/video/hyperv_fb.c

[PATCH 0/2] Re-sending two patches for hyperv_fb

2014-02-18 Thread Haiyang Zhang
They were sent out during tree closing, I'm re-sending them now. Haiyang Zhang (2): hyperv_fb: Add screen refresh after pause/resume operation hyperv_fb: Add support for Gen2 VM drivers/video/hyperv_fb.c | 70 - 1 files changed, 50 insertions(+),

Re: [PATCH 00/87] staging: comedi: cleanup pcl812/816/818 drivers

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 12:06:51PM +, Ian Abbott wrote: > On 2014-02-17 21:26, H Hartley Sweeten wrote: > >These comedi drivers are all very similar so it made sense to clean them > >up together. > > > >This series removes a bunch of the cruft in the drivers and reduces the > >boardinfo and pri

Re: [PATCH 01/16] Staging: rtl8821ae: Remove version specific code from base.c

2014-02-18 Thread Greg Kroah-Hartman
On Mon, Feb 17, 2014 at 08:25:03PM +0530, Sachin Kamat wrote: > On 17 February 2014 18:04, Dan Carpenter wrote: > > On Mon, Feb 17, 2014 at 05:21:56PM +0530, Sachin Kamat wrote: > >> The code should be for the current kernel version. Remove > >> conditional version based code. > >> > >> Signed-off

[PATCH net-next] hyperv: Add latest NetVSP versions to auto negotiation

2014-02-18 Thread Haiyang Zhang
It auto negotiates the highest NetVSP version supported by both guest and host. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h | 53 +++ drivers/net/hyperv/netvsc.c | 26 -- drivers/net/h

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: > Signed-off-by: SeongJae Park > --- > drivers/staging/android/binder.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/android/binder.c > b/drivers/staging/android/binder.c > index eaec1da..b23cbc9 100644

Re: [PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 08:23:26PM +0900, SeongJae Park wrote: > The variable `binder_debugfs_dir_entry_root` is declared as static > global variable although it is accessed from init function only. Declare > it as init function's local variable because it would be better to read > and memory effic

RE: [PATCH 31/87] staging: comedi: pcl816: remove incorrect 'ai_chanlist' from boardinfo

2014-02-18 Thread Hartley Sweeten
On Tuesday, February 18, 2014 4:36 AM, Ian Abbott wrote: > On 2014-02-17 21:27, H Hartley Sweeten wrote: >> The maximum chanlist that this hardware can handle is 16 (the number of >> input channels). >> >> Remove this incorrect data from the boardinfo and just initialize the >> subdevice 'len_chanl

[PATCH] staging: wlan-ng: replace function ieee80211_dsss_chan_to_freq()

2014-02-18 Thread Zhao, Gang
Replace ieee80211_dsss_chan_to_freq() with more generic ieee80211_channel_to_frequency(), and add a variable to deal with 80 characters problem. File cfg80211.c is included by p80211netdev.c, p80211netdev.c includes , both ieee80211_channel_to_frequency() and IEEE80211_BAND_2GHZ is defined / decla

Re: [PATCH RFC 01/17 v2] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-18 Thread Dan Carpenter
On Tue, Feb 18, 2014 at 08:27:17AM -0500, Mark Hounschell wrote: > On 02/18/2014 08:14 AM, Dan Carpenter wrote: > > On Tue, Feb 18, 2014 at 08:00:57AM -0500, Mark Hounschell wrote: > >> That's odd. I just installed vanilla 3.14-rc3 yesterday from kernel.org. > >> It boots up fine but does not appea

Re: [PATCH RFC 01/17 v2] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-18 Thread Mark Hounschell
On 02/18/2014 08:14 AM, Dan Carpenter wrote: > On Tue, Feb 18, 2014 at 08:00:57AM -0500, Mark Hounschell wrote: >> That's odd. I just installed vanilla 3.14-rc3 yesterday from kernel.org. >> It boots up fine but does not appear to have the same dgap driver as >> staging-next. Clearly staging-next i

Re: [PATCH RFC 01/17 v2] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-18 Thread Dan Carpenter
On Tue, Feb 18, 2014 at 08:00:57AM -0500, Mark Hounschell wrote: > That's odd. I just installed vanilla 3.14-rc3 yesterday from kernel.org. > It boots up fine but does not appear to have the same dgap driver as > staging-next. Clearly staging-next is more up to date. I assume that > means I just ha

[PATCH] staging: ion: ion_cma_heap: Remove '0x' when using %pa format

2014-02-18 Thread Fabio Estevam
%pa format already prints in hexadecimal format, so remove the '0x' annotation to avoid a double '0x0x' pattern. Signed-off-by: Fabio Estevam --- drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_hea

Re: [PATCH RFC 01/17 v2] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-18 Thread Mark Hounschell
On 02/17/2014 05:50 PM, Greg Kroah-Hartman wrote: > On Mon, Feb 17, 2014 at 02:32:28PM -0500, Mark Hounschell wrote: >> On 02/14/2014 01:18 PM, Greg Kroah-Hartman wrote: >>> On Fri, Feb 14, 2014 at 12:45:30PM -0500, Mark Hounschell wrote: On 02/14/2014 12:38 PM, Greg Kroah-Hartman wrote: >

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-18 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 12:45:09PM +0100, Philipp Zabel wrote: > Thanks for your comments there. I have just updated and resent this > series ([RFC PATCH v3 0/9] imx-drm dt bindings), still with a temporary > local copy of the v4l2_of functions, as long as the final resting place > of the v4l2_of/o

[patch] staging: gdm724x: cleanup alloc_tx_sdu_struct()

2014-02-18 Thread Dan Carpenter
The kfree(t_sdu->buf) sets off a private static checker warning because "t_sdu->buf" is always NULL. This function just allocates two pointers so we can re-write it to be simpler. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c in

Re: [PATCH 00/87] staging: comedi: cleanup pcl812/816/818 drivers

2014-02-18 Thread Ian Abbott
On 2014-02-17 21:26, H Hartley Sweeten wrote: These comedi drivers are all very similar so it made sense to clean them up together. This series removes a bunch of the cruft in the drivers and reduces the boardinfo and private data. H Hartley Sweeten (87): staging: comedi: pcl812: convert boa

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-18 Thread Philipp Zabel
Hi Russell, Am Montag, den 10.02.2014, 17:56 + schrieb Russell King - ARM Linux: > On Mon, Feb 10, 2014 at 06:37:26PM +0100, Philipp Zabel wrote: > > I'd like all of them to go through, too. If you don't want to have the DT > > changes integrated, I'd appreciate if you could have a look at my

[RFC PATCH v3 9/9] staging: imx-drm: Update TODO

2014-02-18 Thread Philipp Zabel
The device tree bindings are updated regardless of the common display framework and in the meantime the HDMI driver was included. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/imx-drm/TODO b/drivers/staging/i

[RFC PATCH v3 8/9] ARM: dts: imx6qdl: Add IPU DI ports and endpoints, move imx-drm node to dtsi

2014-02-18 Thread Philipp Zabel
This patch connects IPU and display encoder (HDMI, LVDS, MIPI) device tree nodes, as well as parallel displays on the DISP0 and DISP1 outputs, using the OF graph bindings described in Documentation/devicetree/bindings/media/video-interfaces.txt The IPU ports correspond to the two display interface

[RFC PATCH v3 0/9] imx-drm dt bindings

2014-02-18 Thread Philipp Zabel
Hi, here is an updated and more complete version of the imx-drm DT binding series. These patches apply on top of Russell's second preview of the imx-drm cleanup series on v3.14-rc2. I have added device tree bindings between IPU and the encoders as documented in Documentation/devicetree/bindings/me

[RFC PATCH v3 7/9] ARM: dts: imx53: Add IPU DI ports and endpoints, move imx-drm node to dtsi

2014-02-18 Thread Philipp Zabel
This patch connects IPU and display encoder (VGA, LVDS) device tree nodes, as well as parallel displays on the DISP0 and DISP1 outputs, using the OF graph bindings described in Documentation/devicetree/bindings/media/video-interfaces.txt The IPU ports correspond to the two display interfaces. The

[RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of

2014-02-18 Thread Philipp Zabel
From: Lucas Stach Since imx_drm_encoder_parse_of is called from the encoder bind callbacks, it is too late to request probe deferral. Rather the core should make sure that the crtcs are bound before the encoders, after all needed components are probed. This fixes probe failure when using the LDB

[RFC PATCH v3 4/9] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-18 Thread Philipp Zabel
This patch updates the device tree binding documentation for i.MX IPU/display nodes using the OF graph bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Philipp Zabel --- .../bindings/staging/imx-drm/fsl-imx-drm.txt | 48 +++

[RFC PATCH v3 5/9] staging: imx-drm: Document imx-hdmi device tree bindings

2014-02-18 Thread Philipp Zabel
This patch adds device tree binding documentation for the HDMI transmitter on i.MX6. Signed-off-by: Philipp Zabel --- .../devicetree/bindings/staging/imx-drm/hdmi.txt | 53 ++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/staging/imx

[RFC PATCH v3 3/9] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-02-18 Thread Philipp Zabel
This patch adds support to find the involved components connected to the IPU display interface ports using the OF graph bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt Each display interface needs to have an associated port node in the device tree. We can associ

[RFC PATCH v3 6/9] ARM: dts: imx51: Add IPU ports and endpoints, move imx-drm node to dtsi

2014-02-18 Thread Philipp Zabel
This patch connects IPU and and parallel display device tree nodes using the OF graph bindings described in Documentation/devicetree/bindings/media/video-interfaces.txt The IPU ports correspond to the two display interfaces. The order of endpoints in the ports is arbitrary. Since the imx-drm node

[RFC PATCH v3 2/9] staging: imx-drm: Add temporary copies of v4l2-of parsing functions

2014-02-18 Thread Philipp Zabel
From: Philipp Zabel The existing v4l2-of parser functions for the video interface bindings described in Documentation/device-tree/bindings/media/video-interfaces.txt are useful for DRM drivers, too. They will be moved to drivers/media so they can be used by drm drivers, too. Until then, duplicate

Re: [PATCH 31/87] staging: comedi: pcl816: remove incorrect 'ai_chanlist' from boardinfo

2014-02-18 Thread Ian Abbott
On 2014-02-17 21:27, H Hartley Sweeten wrote: The maximum chanlist that this hardware can handle is 16 (the number of input channels). Remove this incorrect data from the boardinfo and just initialize the subdevice 'len_chanlist' to subdevice 'n_chan'. The driver used to allow repeated channel

[PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/android/binder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index eaec1da..b23cbc9 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@

[PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread SeongJae Park
The variable `binder_debugfs_dir_entry_root` is declared as static global variable although it is accessed from init function only. Declare it as init function's local variable because it would be better to read and memory efficiency. Signed-off-by: SeongJae Park --- drivers/staging/android/bind

Re: [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues in hwdrv_apci035.c

2014-02-18 Thread Dan Carpenter
On Mon, Feb 17, 2014 at 12:45:07PM -0800, Chase Southwood wrote: > >On Monday, February 17, 2014 7:16 AM, Ian Abbott wrote: > > >>On 2014-02-16 08:40, Chase Southwood wrote: > >> This patch for hwdrv_apci035 removes some unneeded braces, and moves some > >> improperly placed braces to the correct

Re: [PATCH 3/4 v2] Staging: comedi: addi-data: convert printk() to dev_err()

2014-02-18 Thread Ian Abbott
On 2014-02-18 06:34, Chase Southwood wrote: This patch for hwdrv_apci035.c changes a printk() call to a dev_err() call since this is generally preferred. It also removes a newline from the start of the error message. Signed-off-by: Chase Southwood --- 2: Removed leading newline, per Ian's requ

Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table.

2014-02-18 Thread Jonathan Cameron
On 14/02/14 14:25, Marek Belisko wrote: Signed-off-by: Marek Belisko I wonder how this got missed. However, for those data elements to be useful, you will need to read them somewhere in the driver I think (if there is any magic that puts this in the relevant i2c locations then point it ou