checkpatch displays below errors for bypasslib/bp_ioctl.h file
ERROR: Macros with complex values should be enclosed in parenthesis
Hence added parenthesis for macros with complex values.
Signed-off-by: Surendra Patil
---
drivers/staging/silicom/bypasslib/bp_ioctl.h | 4 ++--
1 file cha
1) Deleted bp_proc_create() declaration from bp_mod.h,
because it is declared as static in bpctl_mod.c and not used anywhere.
2) checkpatch warns about
WARNING: externs should be avoided in .c files
because we have function declarations in bptcl_mod.c,These
functions are not used anywhere e
On 02/11/2014 05:50 PM, Ulf Hansson wrote:
On 11 February 2014 10:27, Roger wrote:
On 02/10/2014 10:58 PM, Ulf Hansson wrote:
On 6 February 2014 15:35, wrote:
From: Roger Tseng
Realtek USB SD/MMC host driver provides mmc host support based on the
Realtek
USB card reader MFD driver.
Sig
On Wed, Feb 12, 2014 at 5:22 AM, Greg KH wrote:
> On Sat, Feb 08, 2014 at 11:59:41AM +0900, SeongJae Park wrote:
>> Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
>> anywhere.
>
>>
>> Signed-off-by: SeongJae Park
>> ---
>> drivers/staging/android/binder.h | 7 +++
>> 1
On Wed, 2014-02-12 at 01:25 +0100, Paul Bolle wrote:
> (Greg, is it too late to add this tag in your queue?)
Greg already did! It was "USB: ELAN: Remove useless "default M" lines"
that lacks a Reported-by: tag.
Paul Bolle
___
devel mailing list
de...@
On Wed, 2014-02-12 at 01:09 +0100, Martin Walch wrote:
> On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote:
> > This patch also deserves a
> > Reported-by: Martin Walch
> >
> > line, but that apparently requires Martin's permission.
>
> I would be happy.
It seems I interpreted the requi
On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote:
> This patch also deserves a
> Reported-by: Martin Walch
>
> line, but that apparently requires Martin's permission.
I would be happy. And I am sorry for not sending patches myself. As I expect
to find some more issues in Kconfig files s
irqsafe"
[drivers/staging/rtl8821ae/rtl8821ae.ko] undefined!
Signed-off-by: Randy Dunlap
---
drivers/staging/rtl8821ae/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20140211.orig/drivers/staging/rtl8821ae/Kconfig
+++ linux-next-20140211/drivers/staging/rtl8
On Sun, Feb 09, 2014 at 03:15:59PM -0600, Larry Finger wrote:
> These debugging macros are seldom used for debugging once the driver
> is working. If routine tracing is needed, it can be added on an
> individual basis.
No, you can use the in-kernel tracing functionality :)
nice job.
greg k-h
___
On Sun, Feb 09, 2014 at 03:15:54PM -0600, Larry Finger wrote:
> This wrapper is replaced with a simple memcmp(). As the wrapper inverts the
> logic of memcmp(), care needed to be taken.
That's just evil, ugh, nice job...
___
devel mailing list
de...@lin
On Tue, Feb 11, 2014 at 08:51:26AM -0500, Chris Harrer wrote:
> Hi Denis,
>
> I understand your frustration; it¹s not that we don¹t want to help, it¹s
> that we¹ve moved onto other products.
So should I just delete this driver if no one is going to care about
cleaning it up and getting it merged
On Sun, Feb 09, 2014 at 02:10:46PM +0530, navin patidar wrote:
> "ethernet.h" is included in three files but only "rtw_recv.c" using two macros
> defined in "ethernet.h", so move used macros in "rtw_recv.c" and
> remove "include/ethernet.h" header file and inclusion of this header file.
>
> Signed
On Sat, Feb 08, 2014 at 11:59:41AM +0900, SeongJae Park wrote:
> Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
> anywhere.
>
> Signed-off-by: SeongJae Park
> ---
> drivers/staging/android/binder.h | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --
On Sun, Feb 09, 2014 at 10:55:25AM -0600, Larry Finger wrote:
> On 02/09/2014 01:30 AM, Surendra Patil wrote:
> >Fixed multiple coding style errors and warnings
> >wifi.h:1077: WARNING: please, no space before tabs
> >wifi.h:762: WARNING: missing space after struct definition
> >wifi.h:972: WARNING
On Tue, Feb 11, 2014 at 10:14:52AM -0800, Randy Dunlap wrote:
> On 02/10/2014 10:21 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > This tree fails (more than usual) the powerpc allyesconfig build.
> >
> > Changes since 20140210:
> >
>
> on i386:
>
> ERROR: "ieee80211_rx_irqsafe" [drivers/stag
On Tue, Feb 11, 2014 at 01:02:39PM -0500, Mark Hounschell wrote:
> Hi Greg,
>
> As I've never done this before, I've got 17 patches that I don't really know
> what to do with. These 17 patches whittle down the drivers/staging/dgap
> directory to just 4 files (dgap.c, dgap.h, Makefile, and Kconfig)
On 02/10/2014 10:21 PM, Stephen Rothwell wrote:
> Hi all,
>
> This tree fails (more than usual) the powerpc allyesconfig build.
>
> Changes since 20140210:
>
on i386:
ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtl8821ae/rtl8821ae.ko]
undefined!
ERROR: "ieee80211_beacon_get_tim" [drivers/s
Hi Greg,
As I've never done this before, I've got 17 patches that I don't really
know what to do with. These 17 patches whittle down the
drivers/staging/dgap directory to just 4 files (dgap.c, dgap.h,
Makefile, and Kconfig) and also add the in kernel firmware loading code
so when the driver l
Hi Denis,
I understand your frustration; it¹s not that we don¹t want to help, it¹s
that we¹ve moved onto other products. As for getting H/W to people, I can
easily ship H/W within the United States; it¹s difficult for us to ship
internationally due to many different customs restrictions. If ther
On Tue, Feb 11, 2014 at 02:01:08PM +0100, Paul Bolle wrote:
> On Tue, 2014-02-11 at 15:53 +0300, Dan Carpenter wrote:
> > You've pretty much given Martin's secret assistance away already on a
> > public mailing list. Next time just add the Reported-by. :P
>
> I would have done, if I hadn't bothe
On Tue, 2014-02-11 at 15:53 +0300, Dan Carpenter wrote:
> You've pretty much given Martin's secret assistance away already on a
> public mailing list. Next time just add the Reported-by. :P
I would have done, if I hadn't bothered to check
Documentation/SubmittingPatches first. It contains:
Pl
On Tue, Feb 11, 2014 at 01:31:32PM +0100, Paul Bolle wrote:
> Two Kconfig entries for this driver default to (uppercase) "Y". But in
> Kconfig (lowercase) "y" is a magic symbol. "Y" is an ordinary symbol.
> As "Y" is never set these Kconfig symbols will also not be set by
> default.
>
> So use "de
Mauro,
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 02 Nov 2013 20:20:54 +0100
> Paul Bolle escreveu:
> > On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote:
> > > drivers/media/common/siano/Kconfig:21-26
> > > > config SMS_SIANO_DEBUGFS
> > > > bool "Enable debugf
Hi Paul,
Thank you for the patch.
On Tuesday 11 February 2014 12:17:01 Paul Bolle wrote:
> Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
> camera interface - Build system") added a Kconfig entry for
> VIDEO_OMAP4_DEBUG. But nothing uses that symbol.
>
> This entry was appare
Two Kconfig entries for this driver default to (uppercase) "Y". But in
Kconfig (lowercase) "y" is a magic symbol. "Y" is an ordinary symbol.
As "Y" is never set these Kconfig symbols will also not be set by
default.
So use "default y" here, as was clearly intended.
Signed-off-by: Paul Bolle
---
From: Philipp Zabel
The video interface bindings described in
Documentation/device-tree/bindings/media/video-interfaces.txt
are useful for DRM drivers, too. To decouple development,
duplicate the v4l2-of parser functions temporarily. Also modify
imx_drm_of_get_next_endpoint to decrement the refco
This patch adds support to find the connections between crtcs and encoder
using the OF graph bindings documented for video interfaces in
Documentation/devicetree/bindings/media/video-interfaces.txt
This patch uses temporary copies of the V4L2 OF graph parsers that can be
removed again once those a
This connects the IPU and display encoder (HDMI, LVDS, MIPI)
device tree nodes using the bindings described in
Documentation/devicetree/bindings/media/video-interfaces.txt
The IPU ports correspond to the two display interfaces. The
order of endpoints in the ports is arbitrary.
Each encoder with a
Hi,
these patches apply on top of Russell's second preview of the
imx-drm cleanup series. I have added device tree bindings between
IPU and the encoders as documented in
Documentation/devicetree/bindings/media/video-interfaces.txt
and used those to determine the possible_crtcs and mux_id.
The crt
To connect the graph in the device tree, each display interface
needs to have an associated port node in the device tree. We can
associate this node with the crtc device and use it to find the
crtc corresponding to a given node instead of using a combination
of parent device node and id.
Explicitly
Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
camera interface - Build system") added a Kconfig entry for
VIDEO_OMAP4_DEBUG. But nothing uses that symbol.
This entry was apparently copied from a similar entry for "OMAP 3
Camera debug messages". The OMAP 3 entry is used to set
On Tue, 11 Feb 2014, Roger wrote:
> On 02/10/2014 07:30 PM, Lee Jones wrote:
> >>From: Roger Tseng
> >>
> >>Realtek USB card reader provides a channel to transfer command or data to
> >>flash
> >>memory cards. This driver exports host instances for mmc and memstick
> >>subsystems
> >>and handle
On 11 February 2014 10:40, Roger wrote:
> On 02/10/2014 07:30 PM, Lee Jones wrote:
>>>
>>> From: Roger Tseng
>>>
>>> Realtek USB card reader provides a channel to transfer command or data to
>>> flash
>>> memory cards. This driver exports host instances for mmc and memstick
>>> subsystems
>>> and
On 02/11/2014 02:15 AM, Haiyang Zhang wrote:
> Without this patch, the "cat /sys/class/net/ethN/operstate" shows
> "unknown", and "ethtool ethN" shows "Link detected: yes", when VM
> boots up with or without vNIC connected.
>
> This patch fixed the problem.
>
> Signed-off-by: Haiyang Zhang
> Revie
On 11 February 2014 10:27, Roger wrote:
> On 02/10/2014 10:58 PM, Ulf Hansson wrote:
>>
>> On 6 February 2014 15:35, wrote:
>>>
>>> From: Roger Tseng
>>>
>>> Realtek USB SD/MMC host driver provides mmc host support based on the
>>> Realtek
>>> USB card reader MFD driver.
>>>
>>> Signed-off-by:
On 02/10/2014 07:30 PM, Lee Jones wrote:
From: Roger Tseng
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng
---
drivers/mfd/Kco
On 02/10/2014 10:58 PM, Ulf Hansson wrote:
On 6 February 2014 15:35, wrote:
From: Roger Tseng
Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
USB card reader MFD driver.
Signed-off-by: Roger Tseng
---
drivers/mmc/host/Kconfig |7 +
drivers/mmc/
Hi Dan,
Am Dienstag, den 11.02.2014, 11:38 +0300 schrieb Dan Carpenter:
> > Why is this loop soo complicated? Why do you need to mess around with
> > this "last_ep" stuff - you don't actually end up using it.
> >
> > The loop reduces down to this without comments:
> >
> > for (i = 0; !ret;
> Why is this loop soo complicated? Why do you need to mess around with
> this "last_ep" stuff - you don't actually end up using it.
>
> The loop reduces down to this without comments:
>
> for (i = 0; !ret; i++) {
Philipp, "ret" isn't set anymore in the new loop.
On 01/26/2014 12:42 PM, Jason Wang wrote:
> On 01/25/2014 05:20 AM, H. Peter Anvin wrote:
>> On 01/23/2014 10:02 PM, Jason Wang wrote:
>>> This patch bypass the timer_irq_works() check for hyperv guest since:
>>>
>>> - It was guaranteed to work.
>>> - timer_irq_works() may fail sometime due to the
On Mon, Feb 10, 2014 at 10:54:00PM -0800, Surendra Patil wrote:
> Fixed MACRO and Extern Coding style warnings and errors - listed only few
> bpctl_mod.c:120: WARNING: externs should be avoided in .c files
> bpctl_mod.c:121: WARNING: externs should be avoided in .c files
> bpctl_mod.c:122: WARNING:
41 matches
Mail list logo
