Re: [PATCH 1/1] staging: imx-drm: Fix build error

2014-01-28 Thread Fabio Estevam
On Tue, Jan 28, 2014 at 3:03 AM, Sachin Kamat wrote: > Instead of redefining the enums, use the standard ones already > available to avoid the following build errors: > > drivers/staging/imx-drm/imx-hdmi.c:56:13: error: nested redefinition of ‘enum > hdmi_colorimetry’ > drivers/staging/imx-drm/im

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-01-28 Thread Geert Uytterhoeven
On Sat, Jan 25, 2014 at 4:23 AM, Oleg Drokin wrote: > On Jan 24, 2014, at 3:55 AM, Geert Uytterhoeven wrote: >> On Fri, Jan 24, 2014 at 6:51 AM, Oleg Drokin wrote: +STAGING - LUSTRE +M: Andreas Dilger +M: Oleg Drokin +M: Peng Tao . +L: hpdd-discuss +S: O

Re: [patch] staging: r8821ae: a couple macro expansion bugs

2014-01-28 Thread Larry Finger
On 01/28/2014 09:01 AM, Greg Kroah-Hartman wrote: On Tue, Jan 28, 2014 at 05:46:30PM +0300, Dan Carpenter wrote: On Tue, Jan 28, 2014 at 03:14:21PM +0100, walter harms wrote: Am 28.01.2014 15:00, schrieb Dan Carpenter: These macros need parentheses, otherwise it causes a macro expansion bug

Re: [patch] staging: r8821ae: a couple macro expansion bugs

2014-01-28 Thread Greg Kroah-Hartman
On Tue, Jan 28, 2014 at 05:46:30PM +0300, Dan Carpenter wrote: > On Tue, Jan 28, 2014 at 03:14:21PM +0100, walter harms wrote: > > > > > > Am 28.01.2014 15:00, schrieb Dan Carpenter: > > > These macros need parentheses, otherwise it causes a macro expansion bug > > > when they are used like this:

Re: [patch] staging: r8821ae: a couple macro expansion bugs

2014-01-28 Thread Dan Carpenter
On Tue, Jan 28, 2014 at 03:14:21PM +0100, walter harms wrote: > > > Am 28.01.2014 15:00, schrieb Dan Carpenter: > > These macros need parentheses, otherwise it causes a macro expansion bug > > when they are used like this: > > > > ch->flags &= ~IEEE80211_CHAN_NO_IBSS; > > > > This was found

Re: [patch] staging: r8821ae: a couple macro expansion bugs

2014-01-28 Thread walter harms
Am 28.01.2014 15:00, schrieb Dan Carpenter: > These macros need parentheses, otherwise it causes a macro expansion bug > when they are used like this: > > ch->flags &= ~IEEE80211_CHAN_NO_IBSS; > > This was found using Smatch: > drivers/staging/rtl8821ae/regd.c:200 _rtl_reg_apply_beaconing

[patch] staging: r8821ae: a couple macro expansion bugs

2014-01-28 Thread Dan Carpenter
These macros need parentheses, otherwise it causes a macro expansion bug when they are used like this: ch->flags &= ~IEEE80211_CHAN_NO_IBSS; This was found using Smatch: drivers/staging/rtl8821ae/regd.c:200 _rtl_reg_apply_beaconing_flags() warn: the 'IEEE80211_CHAN_NO_IBSS' macro