Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-21 Thread Drokin, Oleg
Hello! On Jan 21, 2014, at 4:15 PM, Dave Hansen wrote: > On 01/21/2014 12:02 PM, Dilger, Andreas wrote: >> The Lustre allocation macros track the memory usage across the whole >> filesystem, >> not just of a single structure that a mempool/slab/whatever would do. >> This is >> useful to know for

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-21 Thread Drokin, Oleg
Hello! On Jan 21, 2014, at 3:16 PM, Dan Carpenter wrote: > We have a leak checker in the kernel but most people disable it. I > forget the config name. There are a bunch of useful debug configs. I actually use it at times too and it's useful (e.g. it works even if you did not wrap the allocat

[PATCH V4 1/1] Drivers: hv: Implement the file copy service

2014-01-21 Thread K. Y. Srinivasan
Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of "guest integration services" supported on the Windows platform. Here is a link that provides additional details on this functionality: http://tech

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-21 Thread Dave Hansen
On 01/21/2014 12:02 PM, Dilger, Andreas wrote: > The Lustre allocation macros track the memory usage across the whole > filesystem, > not just of a single structure that a mempool/slab/whatever would do. > This is > useful to know for debugging purposes (e.g. user complains about not having > enoug

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-21 Thread Dan Carpenter
Greg meant mempools not slab. You should look at it. It does what you need for debugging and solves a couple other problems as well. We have a leak checker in the kernel but most people disable it. I forget the config name. There are a bunch of useful debug configs. regards, dan carpenter ___

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-21 Thread Dilger, Andreas
On 2014/01/17, 8:17 AM, "Greg Kroah-Hartman" wrote: >On Fri, Jan 17, 2014 at 05:51:28PM +0300, Dan Carpenter wrote: >> We will want to get rid of lustre's custom allocator before this gets >> out of staging. >> >> But one feature that the lustre allocator has which is pretty neat is >> that it l

[PATCH] staging/usbip: remove vhci_hcd vhci_hub_status change message

2014-01-21 Thread Shuah Khan
When vhci_hcd is enabled, the following message floods the dmesg buffer. This message doesn't provide any useful information other than cluttering the dmesg buffer. Fix it by removing the message. There is another debug message in this routine that dumps detailed port status change information. [

Re: [PATCH V3 1/1] Drivers: hv: Implement the file copy service

2014-01-21 Thread Olaf Hering
On Tue, Jan 21, K. Y. Srinivasan wrote: Looks better. A few comments below: > +++ b/drivers/hv/hv_fcopy.c > +static bool daemon_died; This is a write only variable. > +static u32 daemon_version; This is a write only variable. > +static int fcopy_handle_handshake(u32 version) > +{ > + pr

RE: [PATCH V3 1/1] Drivers: hv: Implement the file copy service

2014-01-21 Thread KY Srinivasan
> -Original Message- > From: Levente Kurusa [mailto:ilevex.li...@gmail.com] On Behalf Of Levente > Kurusa > Sent: Tuesday, January 21, 2014 11:01 AM > To: KY Srinivasan; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonica

Re: [PATCH V3 1/1] Drivers: hv: Implement the file copy service

2014-01-21 Thread Levente Kurusa
Hello, On 01/21/2014 08:06 PM, K. Y. Srinivasan wrote: > Implement the file copy service for Linux guests on Hyper-V. This permits the > host to copy a file (over VMBUS) into the guest. This facility is part of > "guest integration services" supported on the Windows platform. > Here is a link that

[PATCH V3 1/1] Drivers: hv: Implement the file copy service

2014-01-21 Thread K. Y. Srinivasan
Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of "guest integration services" supported on the Windows platform. Here is a link that provides additional details on this functionality: http://tech

[PATCH v2] staging: comedi: usbduxsigma: fix unaligned dereferences

2014-01-21 Thread Ian Abbott
There are a couple of dereferences such as `*(uint32_t *)(devpriv->insn_buf + 1)` that are unaligned as `devpriv->insn_buf` is of type `uint8_t *`. This works on x86 architecture but may not be supported on other architectures. Call `get_unalign()` to perform the unaligned dereferences. Signed-o

[PATCH] staging: comedi: usbduxsigma: fix unaligned dereferences

2014-01-21 Thread Ian Abbott
There are a couple of dereferences such as `*(uint32_t *)devpriv->insn_buf + 1` that are unaligned as `devpriv->insn_buf` is of type `uint8_t *`. This works on x86 architecture but may not be supported on other architectures. Call `get_unalign()` to perform the unaligned dereferences. Signed-off-

[PATCH] staging: comedi: fix too early cleanup in comedi_auto_config()

2014-01-21 Thread Ian Abbott
`comedi_auto_config()` is usually called from the probe routine of a low-level comedi driver to allocate and auto-configure a comedi device. Part of this involves calling the low-level driver's `auto_attach()` handler, and if that is successful, `comedi_device_postconfig()` tries to complete the co

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-21 Thread Greg KH
On Tue, Jan 21, 2014 at 02:08:53AM -0800, Insop Song wrote: > On Mon, Jan 20, 2014 at 10:06 AM, Greg KH wrote: > > On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote: > >> >> > >> >> On the FPGA side, there are dedicated pins for programming, and > >> >> through these you cannot get meanin

Re: [PATCH-3.13.y] staging: comedi: fix result of memdup_user for user chanlist

2014-01-21 Thread Ian Abbott
On 2014-01-21 13:56, Ian Abbott wrote: From: Bernd Porr commit e56b1401056288a725d50942ef300dcbed5e519a upstream If the channel list is not set in userspace we get an error at PTR_ERR(async->cmd.chanlist). However, do_become_nonbusy(dev, s) cleans up this pointer which causes a kernel ooops. S

[PATCH-3.13.y] staging: comedi: fix result of memdup_user for user chanlist

2014-01-21 Thread Ian Abbott
From: Bernd Porr commit e56b1401056288a725d50942ef300dcbed5e519a upstream If the channel list is not set in userspace we get an error at PTR_ERR(async->cmd.chanlist). However, do_become_nonbusy(dev, s) cleans up this pointer which causes a kernel ooops. Setting the channel list in async to NULL

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-21 Thread James Hogan
Hi Dan, On 20/01/14 21:13, Dan Carpenter wrote: > I made a quick and dirty sparse patch to check for this. I don't think > I will bother trying to send it to sparse upstream, but you can if you > want to. > > It found 289 unions which might need a __packed added. The lustre > unions were not in

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-21 Thread Insop Song
On Mon, Jan 20, 2014 at 10:06 AM, Greg KH wrote: > On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote: >> >> >> >> On the FPGA side, there are dedicated pins for programming, and >> >> through these you cannot get meaningful information (again unless you >> >> are JTAG capable) >> >> Such