Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread Dan Carpenter
On Thu, Jan 16, 2014 at 10:42:01AM +0100, Olaf Hering wrote: > On Tue, Jan 14, K. Y. Srinivasan wrote: > > > +enum hv_fcopy_op { > > + START_FILE_COPY = 0, > > + WRITE_TO_FILE, > > + COMPLETE_FCOPY, > > + CANCEL_FCOPY, > > +}; > > + > > +struct hv_fcopy_hdr { > > + enum hv_fcopy_op opera

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-16 Thread Greg KH
On Thu, Jan 16, 2014 at 11:47:41AM -0800, Insop Song wrote: > >> There is no way to detect FPGA until it is programmed. > >> This is a reason and the only reason of this driver to download the > >> program to the FPGA so that it can function. > > > > So how do you get the memory locations of where

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-16 Thread Insop Song
On Thu, Jan 16, 2014 at 8:09 AM, Greg KH wrote: > On Thu, Jan 16, 2014 at 12:56:15AM -0800, Insop Song wrote: >> On Tue, Jan 14, 2014 at 10:00 AM, Greg KH wrote: >> > On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: >> >> On Tue, Jan 14, 2014 at 1:18 AM, Insop Song wrote: >> >> > On M

[PATCH 1/1] Drivers: hv: vmbus: Don't timeout during the initial connection with host

2014-01-16 Thread K. Y. Srinivasan
When the guest attempts to connect with the host when there may already be a connection with the host (as would be the case during the kdump/kexec path), it is difficult to guarantee timely response from the host. Starting with WS2012 R2, the host supports this ability to re-connect with the host (

[PATCH v8] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-16 Thread Chase Southwood
This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood --- Okay, back to v2, basically. I fixed the checkpatch warning from v2, and added the error checking that was from v3, but otherwise it is the same. Of note, I have used a

Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

2014-01-16 Thread Levente Kurusa
Hello, On 01/16/2014 12:32 AM, Michał Kwiatkowski wrote: > This is a patch to the alarm-dev.c file that removes parentheses which > should not appear in return statement. This error was found by the > checkpatch.pl tool. > > Signed-off-by: Michał Kwiatkowski > [...] > +++ b/drivers/staging/andro

Re: [PATCH v7] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-16 Thread Chase Southwood
>On Thursday, January 16, 2014 5:31 AM, Ian Abbott wrote: >On 2014-01-15 19:22, Chase Southwood wrote: >> This patch for ni_mio_common.c changes out a while loop for a timeout, >> which is preferred. >> >> Signed-off-by: Chase Southwood >> --- >> >> Hartley, >> I sincerely apologize for the obvi

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Thursday, January 16, 2014 3:27 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH V2

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Thursday, January 16, 2014 2:49 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH V2

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Thursday, January 16, 2014 1:42 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH V2

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-16 Thread Greg KH
On Thu, Jan 16, 2014 at 12:56:15AM -0800, Insop Song wrote: > On Tue, Jan 14, 2014 at 10:00 AM, Greg KH wrote: > > On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: > >> On Tue, Jan 14, 2014 at 1:18 AM, Insop Song wrote: > >> > On Mon, Jan 13, 2014 at 10:44 AM, Greg KH > >> > wrote: >

RE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Thursday, January 16, 2014 2:17 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH V2

Re: [PATCH v7] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-16 Thread Ian Abbott
On 2014-01-15 19:22, Chase Southwood wrote: This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood --- Hartley, I sincerely apologize for the obvious mistake, I thought I had built it but clearly I made a mistake somewhere, as

Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread Olaf Hering
On Tue, Jan 14, K. Y. Srinivasan wrote: This function should return valid numbers: > +static ssize_t fcopy_write(struct file *file, const char __user *buf, > + size_t count, loff_t *ppos) > +{ > + int error = 0; > + > + if (count != sizeof(int)) > + return

Re: [PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-16 Thread Ian Abbott
On 2014-01-16 02:30, Greg KH wrote: On Wed, Jan 15, 2014 at 06:29:21PM +, Hartley Sweeten wrote: On Tuesday, January 14, 2014 8:59 PM, Greg KH wrote: Sleep for at least 10, as I think that's the smallest time delay you can sleep for anyway (meaning it will be that long no matter what number

Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread Olaf Hering
On Tue, Jan 14, K. Y. Srinivasan wrote: > Implement the file copy service for Linux guests on Hyper-V. This permits the > host to copy a file (over VMBUS) into the guest. This facility is part of > "guest integration services" supported on the Windows platform. > Here is a link that provides addit

Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread Olaf Hering
On Tue, Jan 14, K. Y. Srinivasan wrote: > +++ b/include/linux/hyperv.h > @@ -26,6 +26,8 @@ > #define _HYPERV_H > > #include > +#include > +#include limits.h is not required. Olaf ___ devel mailing list de...@linuxdriverproject.org http://driverd

Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service

2014-01-16 Thread Olaf Hering
On Tue, Jan 14, K. Y. Srinivasan wrote: > +enum hv_fcopy_op { > + START_FILE_COPY = 0, > + WRITE_TO_FILE, > + COMPLETE_FCOPY, > + CANCEL_FCOPY, > +}; > + > +struct hv_fcopy_hdr { > + enum hv_fcopy_op operation; > + uuid_le service_id0; /* currently unused */ > + uuid_le

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-16 Thread Lee Jones
> >>+static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr, > >>+ unsigned int pipe, struct scatterlist *sg, int num_sg, > >>+ unsigned int length, unsigned int *act_len, int timeout) > >>+{ > >>+ int ret; > >>+ > >>+ dev_dbg(&ucr->pusb_intf->dev, "%s: xfer %

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-16 Thread Insop Song
On Tue, Jan 14, 2014 at 10:00 AM, Greg KH wrote: > On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: >> On Tue, Jan 14, 2014 at 1:18 AM, Insop Song wrote: >> > On Mon, Jan 13, 2014 at 10:44 AM, Greg KH >> > wrote: >> >> On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: >> >>

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-16 Thread Roger
On 01/14/2014 09:04 PM, Lee Jones wrote: From: Roger Tseng Realtek USB card reader provides a channel to transfer command or data to flash memory cards. This driver exports host instances for mmc and memstick subsystems and handles basic works. Signed-off-by: Roger Tseng [snip] +static in