RE: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-07 Thread Roger Tseng
Hi Dan, >> +int rtsx_usb_ep0_write_register(struct rtsx_ucr *ucr, u16 addr, >> + u8 mask, u8 data) >> +{ >> + u16 value = 0, index = 0; >> + >> + value |= (u16)(3 & 0x03) << 14; >> + value |= (u16)(addr & 0x3FFF); > >Don't do pointless things: > >value |= 0x03 << 14

Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-07 Thread Dan Carpenter
On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote: > This patch adds Comedi driver for Humusoft MF634 (PCIe) and > MF624 (PCI) data acquisition cards. The legacy card Humusoft > MF614 is not supported. More info about the cards may be found > at http://humusoft.cz/produkty/datacq/ >

[PATCH v3.6 08/19] ozwpan: slight optimization of addr compare

2014-01-07 Thread Ding Tianhong
Use possibly more efficient ether_addr_equal instead of memcmp. Cc: Rupesh Gujare Cc: Greg Kroah-Hartman Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tan Xiaojun Signed-off-by: Ding Tianhong --- drivers/staging/ozwpan/ozcdev.c | 2 +- drivers/staging/ozwpan/

[PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-07 Thread Rostislav Lisovy
This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/ The driver was tested with both cards. Everything seems to work properly. Ju

[PATCH v2] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-07 Thread Rostislav Lisovy
Changes since v1: * Implemented all the small and big remarks pointed out by Hartley Sweeten, Dan Carpenter and Ian Abbott Rostislav Lisovy (1): comedi: Humusoft MF634 and MF624 DAQ cards driver drivers/staging/comedi/Kconfig | 6 + drivers/staging/comedi/comedidev.h | 1 +

[PATCH 3/3] staging: comedi: usbduxsigma: removing unneccesay attached info

2014-01-07 Thread Bernd Porr
Comedi core now reports that a device has been attached so that the driver itself won't need to do it any longer. The driver now just outputs the offset of the ADC converter which is a soft indicator of the health of the board and also the user can grep this value from the kernel log easier for deb

[PATCH v2 1/3] staging: comedi: report success/failure of autoconfig

2014-01-07 Thread Bernd Porr
Added success message to the driver autoconfig and error message in case it fails. A success message is required so that the user can find out which comedi driver has been associated with which udev device. This also makes troubleshooting much easier when more than one card is in the computer or th

[PATCH 2/3] staging: comedi: usbduxsigma: return failure of auto attach

2014-01-07 Thread Bernd Porr
The function usbduxsigma_getstatusinfo() returns a negative value in case there has been a communication error with the board. This should always work and if this communication fails then there is something seriously wrong with the board. This is now returned to the caller so that it can terminte t

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-07 Thread Sean Paul
On Thu, Jan 2, 2014 at 4:27 PM, Russell King wrote: > Subsystems such as ALSA, DRM and others require a single card-level > device structure to represent a subsystem. However, firmware tends to > describe the individual devices and the connections between them. > > Therefore, we need a way to gat

[PATCH] staging: usbip: userspace: add support for viewing imported devices

2014-01-07 Thread Valentina Manea
As of Matt Mooney's major refactoring in 2011, usbip port option was left out. Add support for this option in a manner similar to the old implementation. Sample output: Imported USB devices Port 00: at Full Speed(12Mbps) unknown vendor : unknown product (1687:6211)

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-07 Thread Philipp Zabel
Am Dienstag, den 07.01.2014, 08:30 -0700 schrieb Eric Nelson: > Hi Philipp, > > On 01/07/2014 04:29 AM, Philipp Zabel wrote: > > Am Montag, den 06.01.2014, 19:31 -0700 schrieb Eric Nelson: > >> Hi Russell, > >> > >> On 01/06/2014 10:46 AM, Russell King - ARM Linux wrote: > >>> On Mon, Jan 06, 2014

Re: vme_tsi148 question

2014-01-07 Thread Michael Kenney
Hi Martyn, On Fri, Dec 27, 2013 at 4:34 PM, Michael Kenney wrote: > > Hi Martyn, > > On Fri, Dec 27, 2013 at 4:23 PM, Martyn Welch wrote: > > On 27/12/13 20:15, Michael Kenney wrote: > >> > >> We are using the vme_tsi148 bridge driver along with the vme_user > >> driver to access the VME boards.

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-07 Thread Eric Nelson
Hi Philipp, On 01/07/2014 04:29 AM, Philipp Zabel wrote: Am Montag, den 06.01.2014, 19:31 -0700 schrieb Eric Nelson: Hi Russell, On 01/06/2014 10:46 AM, Russell King - ARM Linux wrote: On Mon, Jan 06, 2014 at 06:41:28PM +0100, Philipp Zabel wrote: Hi Eric, Am Freitag, den 03.01.2014, 12:14

[PATCH] staging: comedi: fix bug destroying subdevice files after parent

2014-01-07 Thread Ian Abbott
`comedi_free_board_dev()` is called (via `comedi_auto_unconfig()` --> `comedi_release_hardware_device()`) when an auto-configured comedi device is removed. This destroys the main sysfs class device and then calls `comedi_device_cleanup()` to clean up the comedi device. For comedi devices that hav

Re: [PATCHv2 1/7] vt6655: balance faulty parentheses in 80211hdr.h

2014-01-07 Thread Dan Carpenter
On Tue, Jan 07, 2014 at 01:11:45PM +0100, Michael Gunselmann wrote: > From: Martin Hofmann > > The file 80211hdr.h contained the macro WLAN_GET_FC_PRVER(n). The big endian > fashion of this macro had unbalanced parentheses. This patch removes the > parentheses in question. > Good fix. Next tim

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-07 Thread Philipp Zabel
Am Montag, den 06.01.2014, 19:31 -0700 schrieb Eric Nelson: > Hi Russell, > > On 01/06/2014 10:46 AM, Russell King - ARM Linux wrote: > > On Mon, Jan 06, 2014 at 06:41:28PM +0100, Philipp Zabel wrote: > >> Hi Eric, > >> > >> Am Freitag, den 03.01.2014, 12:14 -0700 schrieb Eric Nelson: > >>> This i

Re: [PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

2014-01-07 Thread Ian Abbott
On 2014-01-07 10:50, Bernd Porr wrote: Ian Abbott wrote: On 2014-01-07 10:01, Bernd Porr wrote: Ian Abbott wrote: On 2013-12-28 21:31, Bernd Porr wrote: This doesn't apply to linux-next any more. (For example, cleanup_device() function was renamed amongst other stuff.) I've also fixed a load

Re: [PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

2014-01-07 Thread Bernd Porr
Ian Abbott wrote: On 2014-01-07 10:01, Bernd Porr wrote: Ian Abbott wrote: On 2013-12-28 21:31, Bernd Porr wrote: This doesn't apply to linux-next any more. (For example, cleanup_device() function was renamed amongst other stuff.) I've also fixed a load of stuff related to this bug since th

Re: [PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

2014-01-07 Thread Ian Abbott
On 2014-01-07 10:01, Bernd Porr wrote: Ian Abbott wrote: On 2013-12-28 21:31, Bernd Porr wrote: This doesn't apply to linux-next any more. (For example, cleanup_device() function was renamed amongst other stuff.) I've also fixed a load of stuff related to this bug since this patch was applicab

Re: [PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

2014-01-07 Thread Bernd Porr
Ian Abbott wrote: On 2013-12-28 21:31, Bernd Porr wrote: Merging the un-registering of both the subdevices and the main comedi device into one function and the module which actually associated with it. The kernel oops observed before was because the main device was un-registered first and then

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-07 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:28:03PM +, Russell King wrote: > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index e75e11b36dff..0e005f21d241 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @