Re: [PATCH RFC 30/46] imx-drm: remove separate imx-fbdev

2014-01-06 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:28:19PM +, Russell King wrote: > @@ -449,6 +458,24 @@ static int imx_drm_driver_load(struct drm_device *drm, > unsigned long flags) > } > } > > + /* > + * All components are now initialised, so setup the fb helper. > + * The fb hel

Re: [PATCH RFC 24/46] imx-drm: provide common connector mode validation function

2014-01-06 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:27:48PM +, Russell King wrote: > diff --git a/drivers/staging/imx-drm/imx-drm.h > b/drivers/staging/imx-drm/imx-drm.h > index 5649f180dc44..4eb594ce9cff 100644 > --- a/drivers/staging/imx-drm/imx-drm.h > +++ b/drivers/staging/imx-drm/imx-drm.h > @@ -68,4 +68,7 @@ int

Re: [PATCH RFC 00/46] Preview of imx-drm cleanup series

2014-01-06 Thread Shawn Guo
On Thu, Jan 02, 2014 at 09:25:28PM +, Russell King - ARM Linux wrote: > Here is my large patch series which cleans up imx-drm, and gets it ready > to move out of drivers/staging. This is a preview only. When moving to non-RFC patches, you may want to run checkpatch.pl on the patches. There a

[PATCH v2] Staging: comedi: drivers:

2014-01-06 Thread Aruna-Hewapathirane
Fixed a coding style issue in ke_counter.c Signed-off-by: Aruna Hewapathirane --- drivers/staging/comedi/drivers/ke_counter.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c ind

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-06 Thread Eric Nelson
Hi Russell, On 01/06/2014 10:46 AM, Russell King - ARM Linux wrote: On Mon, Jan 06, 2014 at 06:41:28PM +0100, Philipp Zabel wrote: Hi Eric, Am Freitag, den 03.01.2014, 12:14 -0700 schrieb Eric Nelson: This is an issue we've seen before. The SABRE Lite board has a voltage divider on the HPD pi

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-06 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 06:41:28PM +0100, Philipp Zabel wrote: > Hi Eric, > > Am Freitag, den 03.01.2014, 12:14 -0700 schrieb Eric Nelson: > > This is an issue we've seen before. The SABRE Lite board has > > a voltage divider on the HPD pins and some monitors (esp. DVI > > monitors) either don't d

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-06 Thread Philipp Zabel
Hi Eric, Am Freitag, den 03.01.2014, 12:14 -0700 schrieb Eric Nelson: > This is an issue we've seen before. The SABRE Lite board has > a voltage divider on the HPD pins and some monitors (esp. DVI > monitors) either don't drive things high enough to assert HPD or > bounce with connect/disconnect.

[RFC PATCH 3/3] staging: imx-drm-core: associate crtc devices with di port nodes

2014-01-06 Thread Philipp Zabel
To connect the graph in the device tree, each display interface needs to have an associated port node in the device tree. We can associate this node with the crtc device and use it to find the crtc corresponding to a given node instead of using a combination of parent device node and id. Explicitly

[RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-01-06 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 44 -- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index 2490dc3..2c20434 100644 --- a/dri

[RFC PATCH 1/3] ARM: dts: imx6qdl: Add ports and endpoints to IPU DIs

2014-01-06 Thread Philipp Zabel
This connects the IPU and display encoder (HDMI, LVDS, MIPI) device tree nodes using the bindings described in Documentation/devicetree/bindings/media/video-interfaces.txt The IPU ports correspond to the two display interfaces. Port numbering begins at 2 to leave space for the two CSI input ports.

[RFC PATCH 0/3] imx-drm dt bindings

2014-01-06 Thread Philipp Zabel
Hi, these patches apply on top of Russell's imx-drm cleanup preview series. I have added device tree bindings between IPU and the encoders as documented in Documentation/devicetree/bindings/media/video-interfaces.txt and used those to determine the possible_crtcs and mux_id. The crtc cookie is re

[PATCH] Staging: rts5139: Fixed style issues

2014-01-06 Thread Morgan Creekmore
Fixed style issues for lines over 80 chars Signed-off-by: Morgan Creekmore --- drivers/staging/rts5139/rts51x_card.c | 10 +- drivers/staging/rts5139/rts51x_card.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5139/rts51x_card.c b/drive

Re: [PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

2014-01-06 Thread Bernd Porr
Hi Ian, will test later and fix the patches / rebase them to the latest version. For future patches: shall I in general submit my patches against the latest linux next or against linux next + Greg's remote staging tree? I'm a bit confused because I thought linux next plus Gregs remote would b

Re: [PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

2014-01-06 Thread Ian Abbott
On 2014-01-06 13:01, Bernd Porr wrote: Hi Ian, will test later and fix the patches / rebase them to the latest version. For future patches: shall I in general submit my patches against the latest linux next or against linux next + Greg's remote staging tree? I'm a bit confused because I thought

Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-06 Thread Ian Abbott
On 2014-01-02 18:38, Hartley Sweeten wrote: On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote: [snip] +static int mf6x4_dio_insn_bits(struct comedi_device *dev, +struct comedi_subdevice *s, +struct comedi_insn *insn, unsigned in

Re: [PATCH 2/3] staging: comedi: report success/failure of autoconfig

2014-01-06 Thread Dan Carpenter
On Mon, Jan 06, 2014 at 11:56:22AM +, Ian Abbott wrote: > > I know the checkpatch.pl script used to complain about concatenated > string literals, preferring a single string literal even if the code > went over 80 columns as a result. It doesn't seem to complain here, > but I think it's still

Re: [PATCH 3/3] staging: comedi: drivers: streamlined auto attach with main comedi

2014-01-06 Thread Ian Abbott
It would be better to put "usbduxsigma:" in the patch title instead of "drivers:" since it's only for a single driver. On 2013-12-28 21:32, Bernd Porr wrote: Removed the word "attached" from the "ADC_zero" output which is now reported by comedi itself at the end of the auto attach. A negative v

Re: [PATCH 2/3] staging: comedi: report success/failure of autoconfig

2014-01-06 Thread Ian Abbott
On 2013-12-28 21:32, Bernd Porr wrote: Added success message to the driver autoconfig and error message in case it fails. A success message is required so that the user can find out which comedi driver has been associated with which udev device. This also makes troubleshooting much easier when mo

Re: [PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

2014-01-06 Thread Ian Abbott
On 2013-12-28 21:31, Bernd Porr wrote: Merging the un-registering of both the subdevices and the main comedi device into one function and the module which actually associated with it. The kernel oops observed before was because the main device was un-registered first and then the subdevices which

Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane

2014-01-06 Thread Aruna Hewapathirane
To be honest I almost fell off the chair when your email pooped up in my in-box, that has to be the fastest anyone has ever responded and it is yet very much a learning process for me, have so much to learn.I am humbled and thankful you have not forgotten what it was like when you sent in that firs

Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane

2014-01-06 Thread Dan Carpenter
On Mon, Jan 06, 2014 at 04:18:05AM -0500, Aruna Hewapathirane wrote: > my apologies, it's my very first patch :-) > No worries. Take your time. We were all newbies once. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane

2014-01-06 Thread Aruna Hewapathirane
my apologies, it's my very first patch :-) On Mon, Jan 6, 2014 at 4:09 AM, Dan Carpenter wrote: > > Changelog mangled. You need a blank after the subject. > > On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote: >> --- >> drivers/staging/comedi/drivers/ke_counter.c |4 ++-- >

Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane

2014-01-06 Thread Dan Carpenter
Changelog mangled. You need a blank after the subject. On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote: > --- > drivers/staging/comedi/drivers/ke_counter.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ke_cou

[PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane

2014-01-06 Thread Aruna-Hewapathirane
--- drivers/staging/comedi/drivers/ke_counter.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c index 15589f6..cebf818 100644 --- a/drivers/staging/comedi/drivers/ke_counter.c +++

Re: [PATCH V2] Staging: rtl8187se: fix styling issues in r8180_wx.c

2014-01-06 Thread Dan Carpenter
On Mon, Jan 06, 2014 at 12:38:51AM -0500, Dan LaManna wrote: > This is a patch to the r8180_wx.c which fixes various whitespace issues, > brace issues, casting/declaration syntax issues, and increases > clarity in multi-line return statement. > Looks good. Reviewed-by: Dan Carpenter regards, d

Re: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib_debug.h

2014-01-06 Thread Dan Carpenter
On Sun, Jan 05, 2014 at 01:25:36PM +0100, Andreas Frembs wrote: > In rtllib_debug.h we fixed the following checkpatch error: > ERROR: Macros with complex values should be enclosed in parenthesis > > We fixed this with a do {} while (0), because otherwise the compiler > complained. > > Sign