On Sun, Jan 05, 2014 at 02:49:20PM -0800, Joe Perches wrote:
>
> Needs parentheses
>
> if ((src->capability & WLAN_CAPABILITY_IBSS) !=
> (dst->capability & WLAN_CAPABILITY_IBSS))
>
Yeah. You are right.
regards,
dan carpenter
___
dev
This is a patch to the r8180_wx.c which fixes various whitespace issues,
brace issues, casting/declaration syntax issues, and increases
clarity in multi-line return statement.
Signed-off-by: Dan LaManna
---
drivers/staging/rtl8187se/r8180_wx.c | 53 +-
1 file ch
This patch fixes a style issue regarding asterisk placement in
das1800.c and das6402.c found by checkpatch.pl.
Signed-off-by: Chase Southwood
---
2: Added fix for identical style problem in das6402.c, previous version only
changed das1800.c.
drivers/staging/comedi/drivers/das1800.c | 2 +-
dr
On Mon, 2014-01-06 at 01:41 +0530, MonamAgarwal wrote:
> This patch fixes the following checkpatch.pl warning in
> lustre/ldlm/interval_tree.c
> WARNING: line over 80 characters in the file
[]
> diff --git a/drivers/staging/lustre/lustre/ldlm/interval_tree.c
> b/drivers/staging/lustre/lustre/ldlm/
From: Ivaylo Dimitrov
Use upstream hashtable implementation instead of generic code
Signed-off-by: Ivaylo Dimitrov
---
drivers/staging/tidspbridge/gen/gh.c | 148
drivers/staging/tidspbridge/include/dspbridge/gh.h | 12 +-
drivers/staging/tidspbridge/pmgr/
On 05.01.2014 21:47, Dan Carpenter wrote:
Looks much nicer. I had a few tiny comments, but those could be
addressed in later patches. (There is a lot of work to be done on this
driver).
On Sun, Jan 05, 2014 at 08:58:12PM +0200, Ivaylo Dimitrov wrote:
-static u16 name_hash(void *key, u16 max_
On Mon, 2014-01-06 at 00:45 +0300, Dan Carpenter wrote:
> On Sun, Jan 05, 2014 at 04:17:36PM -0500, Dan LaManna wrote:
> > @@ -1358,22 +1358,22 @@ static inline int is_same_network(struct
> > ieee80211_network *src,
> > * We treat all with the same BSSID and channel
> >
On Mon, Jan 06, 2014 at 12:45:55AM +0300, Dan Carpenter wrote:
> On Sun, Jan 05, 2014 at 04:17:36PM -0500, Dan LaManna wrote:
> > @@ -1358,22 +1358,22 @@ static inline int is_same_network(struct
> > ieee80211_network *src,
> > * We treat all with the same BSSID and channel
> >
On Sun, Jan 05, 2014 at 04:17:36PM -0500, Dan LaManna wrote:
> @@ -1358,22 +1358,22 @@ static inline int is_same_network(struct
> ieee80211_network *src,
>* We treat all with the same BSSID and channel
>* as one network
>*/
> - return ((
This is not really an issue with this patch, it's something from the
original code so it doesn't affect merging the patch.
On Sun, Jan 05, 2014 at 08:55:47PM +0200, Ivaylo Dimitrov wrote:
> >Again, reverse the IS_ERR() check and return directly. Use the struct
> >pointer instead of the address of
This is a patch to the r8180_wx.c which fixes various whitespace issues,
brace issues, and casting/declaration syntax issues.
Signed-off-by: Dan LaManna
---
drivers/staging/rtl8187se/r8180_wx.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/d
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/interval_tree.c
ERROR: return is not a function, parentheses are not required
Signed-off-by: MonamAgarwal
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/interval_tree.c
WARNING: line over 80 characters in the file
Signed-off-by: MonamAgarwal
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/driv
Looks much nicer. I had a few tiny comments, but those could be
addressed in later patches. (There is a lot of work to be done on this
driver).
On Sun, Jan 05, 2014 at 08:58:12PM +0200, Ivaylo Dimitrov wrote:
> -static u16 name_hash(void *key, u16 max_bucket)
> +static u32 name_hash(const void *
From: Ivaylo Dimitrov
Use upstream hashtable implementation instead of generic code
Signed-off-by: Ivaylo Dimitrov
---
drivers/staging/tidspbridge/gen/gh.c | 148
drivers/staging/tidspbridge/include/dspbridge/gh.h | 12 +-
drivers/staging/tidspbridge/pmgr/
On Sun, Jan 05, 2014 at 04:04:04PM +0100, Rostislav Lisovy wrote:
> Hello Hartley (and Dan);
> Thank you for the review. I do agree with most of the things, however I
> would like to explain/discuss a few of them...
>
> On Thu, 2014-01-02 at 18:38 +, Hartley Sweeten wrote:
> > On Monday, Dece
Hello Hartley (and Dan);
Thank you for the review. I do agree with most of the things, however I
would like to explain/discuss a few of them...
On Thu, 2014-01-02 at 18:38 +, Hartley Sweeten wrote:
> On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote:
> >
> > create mode 100644 dri
In rtllib_crypt_tkip.c we fixed the checkpatch error: space required after that
','.
In rtllib_debug.h we fixed the checkpatch error: Macros with complex values
should be enclosed in parenthesis.
We also fixed in rtllib_debug.h the warning, do {} while (0) macros should not
be semicolon termina
We fixed in rtllib_debug.h the following checkpatch warning:
WARNING: do {} while (0) macros should not be semicolon terminated.
After deleting this semicolon we also had to fix the wrong use of this macro in
rtl8192e/r8192E_phy.c
Signed-off-by: Andreas Frembs
Signed-off-by: Matthias Sc
In rtllib_crypt_tkip.c we fixed the following checkpatch error:
ERROR: space required after that ','
Signed-off-by: Andreas Frembs
Signed-off-by: Matthias Schoepe
---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
In rtllib_debug.h we fixed the following checkpatch error:
ERROR: Macros with complex values should be enclosed in parenthesis
We fixed this with a do {} while (0), because otherwise the compiler complained.
Signed-off-by: Andreas Frembs
Signed-off-by: Matthias Schoepe
---
drivers/stag
21 matches
Mail list logo
