Re: [PATCH v3 0/2] fix sd power bug and modify phase-searching method

Hi, Is there anything wrong with this patch? It seems a long time, but I didn't got any reply. On 12/03/2013 10:34 AM, micky_ch...@realsil.com.cn wrote: From: Micky Ching If the driver removed while sd card still in the slot, the card power will not power down correctly, if we insert the dr

[PATCH 08/21] ozwpan: slight optimization of addr compare

Use the recently added and possibly more efficient ether_addr_equal_unaligned to instead of memcmp. Cc: Rupesh Gujare Cc: Greg Kroah-Hartman Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Tan Xiaojun Signed-off-by: Ding Tianhong --- drivers/staging/ozwpan/ozcde

[PATCH 2/3] staging: lustre: Fix brace {} are not necessary for single statement blocks

This patch fixed "WARNING: braces {} are not necessary for single statement blocks" in lustre/lustre/mgc_request.c Signed-off-by: Masanari Iida --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/l

[PATCH 3/3] staging: lustre: Fix do not use C99 // comments in mgc_request.c

This patch fixed "ERROR: do not use C99 // comments" found by checkpatch.pl in lustre/lustre/mgc_request.c Signed-off-by: Masanari Iida --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/mgc/mg

[PATCH 1/3] [staging] lustre: Fix space required before the open parenthesis in mgc_required.c

This patch fixed "ERROR: space required before the open parenthesis'('" found by checkpatch.pl in lustre/lustre/mgc/mgc_request.c Signed-off-by: Masanari Iida --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH 24/31] staging: r8188eu: Additional cleanup of include/odm.h

This driver only works with the USB bus. Accordingly, enum odm_interface_def can be removed along with all code that uses ODM_ITRF_XXX, where XXX is not USB. In enum odm_ic_type, only ODM_RTL8188E is used. Remove the enum, all references to the others, and define the needed value. Signed-off-by:

[PATCH 10/31] staging: r8188eu: Remove wrappers _rtw_free_sema, _rtw_up_sema, and _rtw_mutex_init

Any routines that are empty as a result of these changes are also removed. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 11 --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 7 --- drivers/staging/rtl8188eu/core/rtw_sreset.c | 2 +-

[PATCH 22/31] staging: r8188eu: Simplify code related to SupportICType

This member of struct odm_dm_struct is always set to ODM_RTL8188E for this driver. Accordingly, the code can be simplified. A number of routines now are no longer needed and are deleted. Signed-off-by: Larry Finger --- .../staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +- drivers/staging/

[PATCH 23/31] staging: r8188eu: Remove unneeded prototypes from include/odm.h

This header contains a number of routines that do not to be available globally. Once this change was made, a number of the routines were not used, and could be removed. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/odm.c | 67 - drivers/staging

[PATCH 25/31] staging: r8188eu: Cleanup of include/hal_intf.h

This driver only handles RTL8188EU with USB interface, thus several hardware defines and macros can be removed. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 -- drivers/staging/rtl8188eu/hal/rtl8188e_mp.c | 18 +++-- drivers/staging/rtl8188eu/h

[PATCH 06/31] staging: r8188eu: Remove unused atomic_xxx wrappers

Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/include/osdep_service.h | 7 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 35 --- 2 files changed, 42 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188

[PATCH 16/31] staging: r8188eu: Remove macro ODM_SetMACReg

This is the same as macro PHY_SetBBReg. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 14 +++--- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 3 --- 3 files changed, 7 insertions(

[PATCH 26/31] staging: r8188eu: Eliminate enum ODM_RADIO_PATH in favor of rf_radio_path

There are two different enum statements that have been combined. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 4 +-- drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 32 +++--- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 6 ++

[PATCH 09/31] staging: r8188eu: Replace wrapper around sema_init

Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++--- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++--- drivers/staging/rtl8188eu/include/osdep_service.h | 1 - drivers/staging/rtl8188eu/

[PATCH 30/31] staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c

Sparse lists the following: CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8188eu/core/rtw_br_ext.c:700:101:expected unsigned int *ipxNetAddr drivers/st

[PATCH 31/31] staging: r8188eu: Fix smatch error

Smatch shows the following: CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer overflow 'pstapriv->sta_aid' 32 <= 32 Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +- 1 file changed

[PATCH 17/31] staging: r8188eu: Remove macro ODM_GetMACReg

This is equivalent to PHY_GetBBReg. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 8 drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 3 files changed, 4 insertions(+), 12 deletio

[PATCH 29/31] staging: r8188eu: Fix sparse warning in core/rtw_xmit.c

Sparse reports the following warning: CHECK drivers/staging/rtl8188eu/core/rtw_xmit.c drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23: warning: incorrect type in initializer (different base types) drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23:expected unsigned short [usertype] *fctrl

[PATCH 13/31] staging: r8188eu: Remove macro ODM_GetBBReg

This one is a duplicate of PHY_QueryBBReg. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 68 +++ drivers/staging/rtl8188eu/hal/odm.c | 49 drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/s

[PATCH 28/31] staging: r8188eu: Fix sparse warning in core/rtw_pwrctrl.c

Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_pwrctrl.c drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol 'rtw_free_pwrctrl_priv' was not declared. Should it be static? That routine is not used and has been deleted. Signed-off-by: Larry Finger ---

[PATCH 18/31] staging: r8188eu: Remove - number of dummy and unused routines

These routines include: ODM_StartWorkItem() ODM_StopWorkItem() ODM_FreeWorkItem() ODM_ScheduleWorkItem() ODM_IsWorkItemScheduled() Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/odm_interface.c | 20 drivers/staging/rtl8188eu/include/odm_interface.h | 10 -

[PATCH 19/31] staging: r8188eu: Remove more empty routines

This batch includes ODM_StartWorkItem ODM_StopWorkItem ODM_FreeWorkItem ODM_AcquireSpinLoc ODM_ReleaseSpinLock ODM_ReleaseTimer ODM_ReleaseAllTimers Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/odm.c | 7 --- drivers/staging/rtl8188eu/hal/odm_interface.c

[PATCH 21/31] staging: r8188eu: Simplify code concerning SupportPlatform

This member of struct odm_dm_struct is always set to ODM_CE in this driver. As a result, a number of switch and if statements can be simplified. In addition, a number of routines are no longer used and can be removed. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/odm.c |

[PATCH 14/31] staging: r8188eu: Remove macro ODM_SetRFReg

It is a duplicate of macro PHY_SetRFReg. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 32 +++--- drivers/staging/rtl8188eu/hal/odm.c| 8 +++--- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 6 ++-- drivers/staging/r

[PATCH 20/31] staging: r8188eu: Remove even more empty routines

This patch removes the following: odm_DynamicTxPowerAP odm_RSSIMonitorCheckMP odm_RSSIMonitorCheckAP odm_TXPowerTrackingCheckMP odm_TXPowerTrackingCheckAP odm_SwAntDivInit ODM_SwAntDivChkPerPktRssi odm_SwAntDivChkAntSwitch ODM_SwAntDivRestAfterLink dm_GlobalAdapterCheck odm_dtc Signed-off-by: Lar

[PATCH 15/31] staging: r8188eu: Remove macro ODM_GetRFReg

This one is a duplicate od macro PHY_QueryRFReg. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++-- drivers/staging/rtl8188eu/hal/odm.c | 4 ++-- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include

[PATCH 27/31] staging: r8188eu: Fix sparse warning in core/rtw_sta_mgt.c

Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_sta_mgt.c drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:152:6: warning: symbol 'rtw_mfree_all_stainfo' was not declared. Should it be static? Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |

[PATCH 11/31] staging: r8188eu: Remove wrapper around mutex_destroy

Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 1 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5 - drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 ++-- 4 files changed, 3 insertions

[PATCH 00/31] Staging: r8188eu: Various cleanups

This set of patches removes a number of wrappers around standard routines, cleans up some sparse warhings, and also removed a smatch warning. Signed-off-by: Larry Finger Larry Finger (31): staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os staging: r8188eu: Replace wrapper rt

[PATCH 03/31] staging: r8188eu: Remove wrapper code for rtw_suspend_lock_init, rtw_suspend_lock_uninit, rtw_lock_suspend, and rtw_unlock_suspend

All of these routines are empty. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/include/osdep_service.h | 5 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 16 drivers/staging/rtl8188eu/os_dep/rtw_android.c| 2 -- drivers/staging/rtl8188eu/os_dep/usb_

[PATCH 02/31] staging: r8188eu: Replace wrapper rtw_yield_os

a simple yield() is sufficient. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 2 -- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5

[PATCH 08/31] staging: r8188eu: Remove daemonize conditional

The current kernels do not include this entry point. Delete the call. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/include/osdep_service.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osd

[PATCH 05/31] staging: r8188eu: Replace wrapper around atomic_set()

Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 1 - drivers/staging/rtl8188eu/include/usb_ops.h | 2 +- drivers/staging/rtl8188eu/os_dep/o

[PATCH 04/31] staging: r8188eu: Replace ATOMIC_T with atomic_t

Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/include/drv_types.h | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 22 ++ drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +- drivers/s

[PATCH 07/31] staging: r8188eu: Replace wrappers for atomic_inc and atomic_inc_return

Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++-- drivers/staging/rtl8188eu/include/osdep_service.h | 4 drivers/staging/rtl8188eu/include/usb_ops.h | 2 +- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 10 -- 4 files c

[PATCH 01/31] staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os

Each of the uses in the code asks for a sleep of 100 usec or so. On Linux, these are converted to msleep(1). Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/hal/rtl

patch to add a success/failure message to comedi autoconfig

Hi all, I've added a success / fail message to comedi autoconfig. That's badly needed to see which driver has been associated with which comedi dev in udev. Also, as far as I know an error in the USB probe callback won't cause the kernel to print any errors so tracking down failures in autoco