Moving the register_netdev to the end of probe to prevent
possible open call happens before NetVSP is connected.
Signed-off-by: Haiyang Zhang
Reviewed-by: K. Y. Srinivasan
---
drivers/net/hyperv/netvsc_drv.c | 20
1 files changed, 8 insertions(+), 12 deletions(-)
diff --
Hi all,
here is another patch which fixes a kernel warning where a subdevice is
released which no longer exists. The subdevice was removed before the
main comedi device. The functions for the main dev removal and the
subdevice were in different files/modules, were called from different
subsys
A line in the P2P code had been removed in the process of converting the vendor
driver to a form suitable for the kernel. The output of this call was ignored,
and the initial analysis incorrectly determined that the call had no other
effect.
Signed-off-by: Larry Finger
---
drivers/staging/rtl818
On Fri, Dec 20, 2013 at 02:58:43PM -0600, Larry Finger wrote:
> A recent set of patches revealed that a line of code had been incorrectly
> removed in an earlier edit. That line is added back. In addition, a
> configuration
> problem resulted in a number of "unused variable" warnings.
Thanks for
A previous set of patches were test compiled with one of the configuration
variables not set. As a result, a number of unused variables were left in the
code.
In several instances, declaration of the unused variable was the only statement
inside ifdef .. endif pairs. In those cases, the entire blo
A recent set of patches revealed that a line of code had been incorrectly
removed in an earlier edit. That line is added back. In addition, a
configuration
problem resulted in a number of "unused variable" warnings.
Signed-off-by: Larry Finger
Larry Finger (2):
staging: r8188eu: Restore line
On 12/20/2013 02:34 PM, Greg KH wrote:
Nah, I just switched to 4.8 and rebuilt all of the different kernel
trees on this box with it, so I'll stay there for now.
The problem wasn't the fault of gcc 4.8. I only use the staging tree to base
patches to send to you, and my .config in that director
On Fri, Dec 20, 2013 at 02:30:39PM -0600, Larry Finger wrote:
> On 12/20/2013 01:18 PM, Greg KH wrote:
> > On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
> >> On 12/20/2013 10:58 AM, Greg KH wrote:
> >>> With this series applied, I get a ton of "unused variable" warnings, can
> >>> y
On 12/20/2013 01:18 PM, Greg KH wrote:
On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of "unused variable" warnings, can
you please fix them up now too?
Strange, but I don't get any. My compiler is gcc
There is usb_get_dev() in go7007_loader_probe(),
but there is no usb_put_dev() anywhere.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/staging/media/go7007/go7007-loader.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
di
On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
> On 12/20/2013 10:58 AM, Greg KH wrote:
> > With this series applied, I get a ton of "unused variable" warnings, can
> > you please fix them up now too?
>
> Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909
On Fri, Dec 20, 2013 at 06:52:41PM +0100, Philipp Zabel wrote:
> Hi,
>
> this is mostly about the first patch, which moves the IPUv3 core code
> (drivers/staging/imx-drm/ipu-v3) to drivers/gpu. host1x, which
> serves a similar purpose, already sits there.
> The other four patches add the necessary
Hi,
this is mostly about the first patch, which moves the IPUv3 core code
(drivers/staging/imx-drm/ipu-v3) to drivers/gpu. host1x, which
serves a similar purpose, already sits there.
The other four patches add the necessary code for CSI and SMFC handling,
which is used by the V4L2 CSI capture driv
Signed-off-by: Lucas Stach
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-common.c | 35 +++
include/video/imx-ipu-v3.h | 1 +
2 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-c
IPU_CONF_..._EN bits are implementation details, not to be made public.
Add wrappers around ipu_module_enable/disable, so the CSI V4L2 driver
can enable/disable the CSI and SMFC modules.
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-common.c | 24
include/video
The Sensor Multi Fifo Controller (SMFC) is used as a buffer between
the two CSIs (writing simultaneously) and up to four IDMAC channels.
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/Makefile | 2 +-
drivers/gpu/ipu-v3/ipu-common.c | 10 +
drivers/gpu/ipu-v3/ipu-prv.h| 6 +++
The i.MX Image Processing Unit (IPU) contains a number of image processing
blocks that sit right in the middle between DRM and V4L2. Some of the modules,
such as Display Controller, Processor, and Interface (DC, DP, DI) or CMOS
Sensor Interface (CSI) and their FIFOs could be assigned to either fram
This function returns the currently active buffer (0 or 1)
of a double buffered IDMAC channel. It is to be used by the
CSI driver.
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-common.c | 9 +
include/video/imx-ipu-v3.h | 1 +
2 files changed, 10 insertions(+)
diff --git
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of "unused variable" warnings, can
you please fix them up now too?
Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909
[gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you
On Fri, Dec 20, 2013 at 10:31 PM, Greg Kroah-Hartman
wrote:
> On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote:
>> Hello Michael,
>>
>> On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
>> wrote:
>> > This patch addresses several problems in bypass.c found by checkpatch.
>> > Furthermor
On 12/20/2013 01:14 AM, Dan Carpenter wrote:
On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger
@@ -1509,10 +1509,6 @@ _func_enter_;
rtw_p2p_set_state(pwdinfo, P2P_STATE_FIND_PHAS
On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote:
> Hello Michael,
>
> On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
> wrote:
> > This patch addresses several problems in bypass.c found by checkpatch.
> > Furthermore it removes/adds some empty lines to make the code more readable.
>
On Fri, Dec 20, 2013 at 10:36:09AM -0600, Larry Finger wrote:
> On 12/20/2013 01:14 AM, Dan Carpenter wrote:
> > On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
> >> Some comment lines that mentioned spin_lock_bh() are also removed.
> >>
> >> Signed-off-by: Larry Finger
> >> @@ -1509
With this series applied, I get a ton of "unused variable" warnings, can
you please fix them up now too?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: stalinsrinivasan.s
This is a patch to the dgnc_cls.c file that fixes up comparison with
jiffies usage warning found by the checkpatch.pl tool
Signed-off-by: S. Stalin Srinivasan
---
drivers/staging/dgnc/dgnc_cls.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/
On 2013-12-19 23:31, H Hartley Sweeten wrote:
The ni_tio module is used by the ni_atmio, ni_660x, ni_pcimio and ni_mio_cs
drivers to provide support functions for the NI General Purpose Counters.
The ni_tiocmd module is used by the ni_660x and ni_pcimio to support async
commands with the counter
From: stalinsrinivasan.s
This is a patch to the dgnc_cls.c file that fixes up volatile usage
warning found by the checkpatch.pl tool
Signed-off-by: S. Stalin Srinivasan
---
drivers/staging/dgnc/dgnc_cls.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/st
From: stalinsrinivasan.s
This is a patch to the dgnc_cls.c file that
fixes up 80 characters per line and code indent
warnings found by the checkpatch.pl tool.
Signed-off-by: S. Stalin Srinivasan
---
drivers/staging/dgnc/dgnc_cls.c | 244 ++-
1 files change
These patches fix the issue of frame buffer offsets being forgotten
during crtc pageflip. Also we set the second buffer address.
Lucas Stach (2):
staging: drm/imx: handle framebuffer offsets correctly
staging: drm/imx: don't drop crtc offsets when doing pageflip
Philipp Zabel (1):
staging:
From: Lucas Stach
Signed-off-by: Lucas Stach
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/ipuv3-crtc.c | 3 ++-
drivers/staging/imx-drm/ipuv3-plane.c | 4
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c
b/drivers/staging/imx
From: Lucas Stach
Signed-off-by: Lucas Stach
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/ipuv3-plane.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/ipuv3-plane.c
b/drivers/staging/imx-drm/ipuv3-plane.c
index 685411c..2ef9516 100644
Even though we do not enable the hardware double buffering feature
right now, set the second base address pointer (EBA1) as well to
increase robustness.
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/ipuv3-plane.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
From: Gokulnath Avanashilingam
Removed the developer debug prints BCM_DEBUG_PRINT()
as per the TODO list, also removed braces for the
if-statement to match coding style
Signed-off-by: Gokulnath Avanashilingam
---
drivers/staging/bcm/InterfaceIdleMode.c | 57 ++---
1
From: Gokulnath Avanashilingam
This patch fixes all the warning related to spacing issues
found by checkpatch.pl script in InterfaceIdleMode.c
Signed-off-by: Gokulnath Avanashilingam
---
drivers/staging/bcm/InterfaceIdleMode.c | 24
1 file changed, 12 insertions(+), 12
From: Gokulnath Avanashilingam
Fixed all the line over 80 characters warning found by
checkpatch.pl script.
Signed-off-by: Gokulnath Avanashilingam
---
drivers/staging/bcm/InterfaceIdleMode.c | 153 +---
1 file changed, 99 insertions(+), 54 deletions(-)
diff --git
From: Gokulnath Avanashilingam
Used the time_after and time_before insted of comparing
the jiffies directly.This will fix the warnings and errors
found by the checkpatch.pl script.
Signed-off-by: Gokulnath Avanashilingam
---
drivers/staging/bcm/InterfaceIdleMode.c | 6 +++---
1 file changed, 3
This patch series fix all the warning and errors found by
checkpatch.pl script, Additionally removed the developer
debug BCM_DEBUG_PRINT() prints as per TODO list.
Gokulnath Avanashilingam (4):
staging:bcm: Remove Developer Debug prints in InterfaceIdleMode.c
staging: bcm: line over 80 charact
Hello Michael,
On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
wrote:
> This patch addresses several problems in bypass.c found by checkpatch.
> Furthermore it removes/adds some empty lines to make the code more readable.
>
> The following problems are fixed:
> - line over 80 characters
> - sp
In this patch we fix some "logical" errors in bypass.c of the silicom bypass
driver (in staging).
Checkpatch complains about the following errors:
- unnecessary forward declarations in a source file
- assignment in if condition
In addition to that the __init and __exit macros were missing at th
This patch improves bypass.c (in staging) in terms of coding style. This
includes different issues some of them mentioned by checkpatch:
- a c++ one line comment
- parenthesis at return statementes
- multiple definitions in one line
- missing braces according to the style guide
Signed-off-by:
This patch addresses several problems in bypass.c found by checkpatch.
Furthermore it removes/adds some empty lines to make the code more readable.
The following problems are fixed:
- line over 80 characters
- space after logical operator !
- spaces instead of tabs
- missing empty line after l
This patch series fixes most issues discovered by checkpatch. That includes
whitespaces, indentation, the wrong use of parenthesis and some more. Please
refer to the specific patch description to get more details.
Besides some minor issues not discovered by checkpatch are fixed. E.g. i moved
some
Hi Hans,
On Fri, Dec 20, 2013 at 7:00 PM, Hans Verkuil wrote:
> Hi Prabhakar,
>
> On 12/20/2013 02:02 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil wrote:
>>> I just made a patch myself that I added to the pull request I just posted.
>>>
>>> You didn't
Hi Prabhakar,
On 12/20/2013 02:02 PM, Prabhakar Lad wrote:
> Hi Hans,
>
> On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil wrote:
>> I just made a patch myself that I added to the pull request I just posted.
>>
>> You didn't CC me or CC the linux-media list when you posted your patch, so I
>> never
Hi Hans,
On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil wrote:
> I just made a patch myself that I added to the pull request I just posted.
>
> You didn't CC me or CC the linux-media list when you posted your patch, so I
> never saw it.
>
I dont know why this patch didnt make up in linux-media but
I just made a patch myself that I added to the pull request I just posted.
You didn't CC me or CC the linux-media list when you posted your patch, so I
never saw it.
Regards,
Hans
On 12/20/2013 01:47 PM, Prabhakar Lad wrote:
> Hi Hans,
>
> On Tue, Dec 17, 2013 at 8:55 PM, Lad, Prabhaka
Hi Hans,
On Tue, Dec 17, 2013 at 8:55 PM, Lad, Prabhakar
wrote:
> From: "Lad, Prabhakar"
>
> This patch includes linux/delay.h required for msleep,
> which fixes following build error.
>
> dm365_isif.c: In function ‘isif_enable’:
> dm365_isif.c:129:2: error: implicit declaration of function ‘msl
On Fri, Dec 20, 2013 at 07:07:38PM +0800, Wenliang Fan wrote:
> The checking condition in 'validateFlash2xReadWrite()' is not
> sufficient. A large number invalid would cause an integer overflow and
> pass the condition, which could cause further integer overflows in
> 'Bcmchar.c:bcm_char_ioctl()'.
The checking condition in 'validateFlash2xReadWrite()' is not
sufficient. A large number invalid would cause an integer overflow and
pass the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
Signed-off-by: Wenliang Fan
---
drivers/staging/bcm/nvm.c | 9
On Fri, Dec 20, 2013 at 06:19:56PM +0800, Wenliang Fan wrote:
> The checking condition in 'validateFlash2xReadWrite()' is not
> sufficient. A large number invalid would cause an integer overflow and
> pass the condition, which could cause further integer overflows in
> 'Bcmchar.c:bcm_char_ioctl()'.
In rtl819x_Qos.h there were several macros defined but never used.
So we removed this macros.
Signed-off-by: Andreas Frembs
Signed-off-by: Matthias Schoepe
---
drivers/staging/rtl8192e/rtl819x_Qos.h | 37 --
1 file changed, 37 deletions(-)
diff --git a/drivers/
We fixed checkpatch errors in the rtl8192e driver and noticed that some
macros that produced errors in checkpatch are unused, so we removed them.
There are no functional changes in this patch.
___
devel mailing list
de...@linuxdriverproject.org
http://dr
This patch fixes the following checkpatch errors from rtllib_endianfree.h:
- ERROR: Macros with complex values should be enclosed in parenthesis
Signed-off-by: Andreas Frembs
Signed-off-by: Matthias Schoepe
---
drivers/staging/rtl8192e/rtllib_endianfree.h | 6 +++---
1 file changed, 3 insertio
Checkpatch mentioned that these macros should be defined with a 'do {...}
while(0)' statement.
So we used grep to find all files using these macros and we found out that
these macros were only used
in rtl819x_Qos.h, in the defines we removed before.
Since the macros are not used anywhere else we
The checking condition in 'validateFlash2xReadWrite()' is not
sufficient. A large number invalid would cause an integer overflow and
pass the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
Signed-off-by: Wenliang Fan
---
drivers/staging/bcm/nvm.c | 5
On Fri, Dec 20, 2013 at 04:51:45PM +0800, Wenliang Fan wrote:
> Thanks for your advice.
> But the variable 'psFlash2xReadWrite->offset' in '
> *drivers/staging/bcm/nvm.c*:validateFlash2xReadWrite()' is also comes from
> user space, which would cause an integer overflow in the following line:
>
> i
On Fri, Dec 20, 2013 at 03:13:16PM +0800, Wenliang Fan wrote:
> The checking condition in 'validateFlash2xReadWrite()' is not sufficient.
> A large number invalid would cause an integer overflow and pass
> the condition, which could cause further integer overflows in
> 'Bcmchar.c:bcm_char_ioctl()'.
57 matches
Mail list logo
