Re: [PATCH] Staging: bcm: DDRInit: fixed issues w/ commenting.

2013-12-17 Thread Dan Carpenter
On Tue, Dec 17, 2013 at 05:08:52PM -0500, Gary Rookard wrote: > -//DDR INIT-133Mhz > -#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12 //index for 0x0F007000 > -static struct bcm_ddr_setting asT3_DDRSetting133MHz[] = {// # DPLL > Clock Setting > +/* DDR INIT-133Mhz */ This is indented i

Re: [PATCH] staging: xillybus: Return -EIO if *_iomap fails, instead of 0

2013-12-17 Thread Dan Carpenter
On Tue, Dec 17, 2013 at 09:36:29PM +0200, Eli Billauer wrote: > This patch replicates the correction made by Wei Yongjun on a second > occurrence of the same bug. > > The first correction was in commit 8eec411bfa1f8a2e0a2de45c988fd30c3efb. Always put patch title as well as the hash. regards,

Re: [PATCH v4 0/2] mfd: rtsx: decrease driver size and add new device

2013-12-17 Thread Dan Carpenter
On Wed, Dec 18, 2013 at 10:03:11AM +0800, micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > we add a macro to simplify setting pull control, and use a common init > function to init the common params for 8411-like chips. at last we add > support for rtl8402 chip. > > Micky Ching (2): >

[PATCH v4 2/2] mfd: rtsx: add support for card reader rtl8402

2013-12-17 Thread micky_ching
From: Micky Ching rtl8402 is much like rtl8411, so just add it to rtl8411.c Signed-off-by: Micky Ching --- drivers/mfd/rtl8411.c | 44 drivers/mfd/rtsx_pcr.c |5 + drivers/mfd/rtsx_pcr.h |1 + 3 files changed, 46 insertions(+), 4 dele

[PATCH v4 1/2] mfd: rtsx: add set pull control macro and simplify rtl8411

2013-12-17 Thread micky_ching
From: Micky Ching add set pull control macro to reduce code for setting pull control, and use a common init function to reduce code for rtl8411.c. So this patch is used to just simplify code. Signed-off-by: Micky Ching --- drivers/mfd/rtl8411.c | 53 -

[PATCH v4 0/2] mfd: rtsx: decrease driver size and add new device

2013-12-17 Thread micky_ching
From: Micky Ching we add a macro to simplify setting pull control, and use a common init function to init the common params for 8411-like chips. at last we add support for rtl8402 chip. Micky Ching (2): mfd: rtsx: add set pull control macro and simplify rtl8411 mfd: rtsx: add support for car

Re: [PATCH 2/3] imx-drm: imx-drm-core: avoid going the long route round for drm_device

2013-12-17 Thread Shawn Guo
On Tue, Dec 17, 2013 at 07:10:47PM +, Russell King wrote: > We have the drm_device available, so rather than storing it and then > using the stored version, us the one we already have available to us. > > Signed-off-by: Russell King > --- > drivers/staging/imx-drm/imx-drm-core.c | 16 +

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Greg Kroah-Hartman
On Tue, Dec 17, 2013 at 07:09:56PM +, Russell King - ARM Linux wrote: > On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: > > On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > > > On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > > > > On M

Re: [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411

2013-12-17 Thread micky
On 12/17/2013 03:28 PM, Dan Carpenter wrote: On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote: diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h index 947e79b..26b52ec 100644 --- a/drivers/mfd/rtsx_pcr.h +++ b/drivers/mfd/rtsx_pcr.h @@ -63,4 +63,12 @@ static

Re: [PATCH v2] vme_user: Update API to work in mixed environments

2013-12-17 Thread Greg KH
On Mon, Dec 09, 2013 at 10:05:40AM -0600, Aaron Sierra wrote: > This patch updates the vme_master and vme_slave structures to use > types with well defined size and to prevent the compiler from > inserting padding (between enable and vme_addr for one). > > The original vme_master and vme_slave str

[PATCH] Staging: bcm: DDRInit: fixed issues w/ commenting.

2013-12-17 Thread Gary Rookard
removed C99 comments to follow the linux kernel coding style thus fixing checkpatch errors respectfully. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 271 +- 1 file changed, 136 insertions(+), 135 deletions(-

[PATCH 2/3] imx-drm: imx-drm-core: avoid going the long route round for drm_device

2013-12-17 Thread Russell King
We have the drm_device available, so rather than storing it and then using the stored version, us the one we already have available to us. Signed-off-by: Russell King --- drivers/staging/imx-drm/imx-drm-core.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

RE: [PATCH 09/48] staging: comedi: pcmmio: move ai shadow data to device private data

2013-12-17 Thread Hartley Sweeten
On Tuesday, December 17, 2013 10:58 AM, gre...@linuxfoundation.org wrote: > On Tue, Dec 10, 2013 at 10:58:59AM +, Ian Abbott wrote: >> On 2013-12-09 22:30, H Hartley Sweeten wrote: >>>There is only one ai subdevice in this driver so there is no reason >>>to hold the last sample written to each

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > > On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > > > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: > > > > Russ

[PATCH 1/3] imx-drm: imx-drm-core: use the crtc drm device for vblank

2013-12-17 Thread Russell King
There are a couple of ways to get at the drm_device for the vblank operations. One of them is via the private imxdrm structure, the other is via the DRM crtc structure, which also stores a pointer. Use the DRM method instead of our own method. Signed-off-by: Russell King --- drivers/staging/imx

[PATCH] staging: xillybus: Return -EIO if *_iomap fails, instead of 0

2013-12-17 Thread Eli Billauer
This patch replicates the correction made by Wei Yongjun on a second occurrence of the same bug. The first correction was in commit 8eec411bfa1f8a2e0a2de45c988fd30c3efb. Bug fixed: The error code was not set, so the error condition wasn't reflected in the return value. Reported-by: Wei Yongj

Re: [PATCH net] netvsc: don't flush peers notifying work during setting mtu

2013-12-17 Thread David Miller
From: Jason Wang Date: Fri, 13 Dec 2013 17:21:27 +0800 > There's a possible deadlock if we flush the peers notifying work during > setting > mtu: ... > Reported-by: Yaju Cao > Tested-by: Yaju Cao > Cc: K. Y. Srinivasan > Cc: Haiyang Zhang > Signed-off-by: Jason Wang > --- > The patch is ne

[PATCH 3/3] imx-drm: imx-drm-core: merge imx_drm_crtc_register() into imx_drm_add_crtc()

2013-12-17 Thread Russell King
There's no reason for this to be a separate function; merge the two together. Signed-off-by: Russell King --- drivers/staging/imx-drm/imx-drm-core.c | 33 --- 1 files changed, 9 insertions(+), 24 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/d

Re: [PATCH 09/48] staging: comedi: pcmmio: move ai shadow data to device private data

2013-12-17 Thread gre...@linuxfoundation.org
On Tue, Dec 10, 2013 at 10:58:59AM +, Ian Abbott wrote: > On 2013-12-09 22:30, H Hartley Sweeten wrote: > >There is only one ai subdevice in this driver so there is no reason > >to hold the last sample written to each channel in the subdevice > >private data. Move the data into the device priva

Re: [PATCH] Staging: bcm: DDRInit: fixed comment issues.

2013-12-17 Thread Greg KH
On Fri, Dec 13, 2013 at 10:02:11AM -0500, Gary Rookard wrote: > replaced C99 style with C89 standard style comments > to follow the linux kernel coding style thus fixing > checkpatch errors respectfully. > also, in some instances changed comments from inline > to side-bar style. Why did you do tha

Re: [PATCH V2] staging:bcm: Code cleanup for InterfaceDld.c

2013-12-17 Thread Greg KH
On Tue, Dec 17, 2013 at 10:38:47PM +0530, Gokulnath A wrote: > As per the TODO, > > 1. Removed the developer debug BCM_DEBUG_PRINT() messages. > 2. Fixed all the errors found by checkpatch.pl script. > 3. Fixed all the line over 80 characters warning >found by checkpatch.pl script. As you say

Re: [PATCH] Staging: bcm: DDRInit: fixed bracing issues.

2013-12-17 Thread Greg KH
On Mon, Dec 16, 2013 at 03:51:58AM -0500, Gary Rookard wrote: > removed braces from single statement conditonals. > if, else, while opening brace placement was moved to last > on first line of each, and closing brace moved to first on > new line to follow the linux kernel coding style thus removin

Re: [PATCH] staging: xillybus: Return -ENOMEM if *_iomap fails instead of 0

2013-12-17 Thread Greg KH
On Mon, Dec 16, 2013 at 03:50:39PM +0200, Eli Billauer wrote: > Bug fix: The error code was not set, so the error condition wasn't reflected > in the return value. > > Reported-by: Wei Yongjun > Signed-off-by: Eli Billauer Wei wrote half of this patch, and now that I've applied his patch, yours

Re: [PATCH 7/8] staging: dgap: Fixed trailing white space in dgap_sysfs.c

2013-12-17 Thread Greg KH
On Tue, Dec 17, 2013 at 12:48:45PM +0900, Masanari Iida wrote: > This patch fixes "ERROR: trailing whitespace" found by > checkpatch.pl, within dgap_sysfs.c > --- > drivers/staging/dgap/dgap_sysfs.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) You don't have a signed-off

Re: [PATCH 3/8] staging: dgap: Fixed trailing white space

2013-12-17 Thread Greg KH
On Tue, Dec 17, 2013 at 12:48:41PM +0900, Masanari Iida wrote: > This patch fixes "ERROR: trailing whitespace" found by > checkpatch.pl, within dgap_fep5.h > > Signed-off-by: Masanari Iida The first 3 patches in this series has the exact same Subject, so I can't apply them. Please make them uni

Re: [media] v4l: omap4iss: Restore irq flags correctly in omap4iss_video_buffer_next()

2013-12-17 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Monday 16 December 2013 18:06:12 Dan Carpenter wrote: > The spin_lock_irqsave() macro is not nestable. The second call will > overwrite the first record of "flags" so the IRQs will not be enabled > correctly at the end of the function. > > I haven't looked at

Re: [patch] [media] v4l: omap4iss: use snprintf() to make smatch happy

2013-12-17 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Monday 16 December 2013 23:19:50 Dan Carpenter wrote: > Smatch complains here because name is a 32 character buffer and we > adding the "OMAP4 ISS " prefix as well for a total of 42 characters. > The sd->name buffer can only hold 32 characters. I've changed it

[PATCH V2] staging:bcm: Code cleanup for InterfaceDld.c

2013-12-17 Thread Gokulnath A
As per the TODO, 1. Removed the developer debug BCM_DEBUG_PRINT() messages. 2. Fixed all the errors found by checkpatch.pl script. 3. Fixed all the line over 80 characters warning found by checkpatch.pl script. Signed-off-by: Gokulnath A --- drivers/staging/bcm/InterfaceDld.c | 122 +

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Greg Kroah-Hartman
On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: > > > Russell King (8): > > > imx-drm: imx-drm-core: fix error cleanup path for

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: > > Russell King (8): > > imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() > > imx-drm: imx-drm-core: fix DRM cleanup paths > >

Re: [PATCH 3/4] imx-drm: fix missing symbol exports

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 12:28:37PM +0800, Shawn Guo wrote: > On Mon, Dec 16, 2013 at 11:34:05AM +, Russell King wrote: > > Trying to build a modular imx-drm results in a number of missing symbol > > exports, caused by the recent changes to this driver. Add the necessary > > exports, and the mi

[PATCH] staging: dgrp: Fix space prohibited before semicolon

2013-12-17 Thread Masanari Iida
This patch fixed "WARNING: space prohibited before semicoloni" found by checkpatch.pl within dgrp_tty.c Signed-off-by: Masanari Iida --- drivers/staging/dgrp/dgrp_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/

Re: [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411

2013-12-17 Thread Dan Carpenter
On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote: > void rtl8411b_init_params(struct rtsx_pcr *pcr) > { > - pcr->extra_caps = EXTRA_CAPS_SD_SDR50 | EXTRA_CAPS_SD_SDR104; > - pcr->num_slots = 2; > - pcr->ops = &rtl8411b_pcr_ops; > - > - pcr->flags = 0; > -