On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote:
> diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h
> index 947e79b..26b52ec 100644
> --- a/drivers/mfd/rtsx_pcr.h
> +++ b/drivers/mfd/rtsx_pcr.h
> @@ -63,4 +63,12 @@ static inline u8 map_sd_drive(int idx)
> #de
On Mon, Dec 16, 2013 at 11:33:01AM +, Russell King - ARM Linux wrote:
> The following patch series fixes some bugs and races in the imx-drm
> code, which should probably be applied to an -rc kernel.
>
> drivers/staging/imx-drm/imx-drm-core.c | 21 -
> drivers/staging/im
On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote:
> Russell King (8):
> imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc()
> imx-drm: imx-drm-core: fix DRM cleanup paths
> imx-drm: fix missing symbol exports
Except the little doubt I repl
On Mon, Dec 16, 2013 at 11:34:05AM +, Russell King wrote:
> Trying to build a modular imx-drm results in a number of missing symbol
> exports, caused by the recent changes to this driver. Add the necessary
> exports, and the missing MODULE_LICENSE() tag.
Since commit 9c74360 (staging: imx-drm
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within digi.h
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/digi.h | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgap/digi.h b/drivers/staging/dgap/digi.
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within dgap_sysfs.c
---
drivers/staging/dgap/dgap_sysfs.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap_sysfs.c
b/drivers/staging/dgap/dgap_sysfs.c
index 7f4ec9a..a
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within dgap_downld.h and dgap_sysfs.h.
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/dgap_downld.h | 4 ++--
drivers/staging/dgap/dgap_sysfs.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/dri
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within dgap_fep5.h
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/dgap_fep5.h | 45
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/dgap/dgap_fep5
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within dgap_parse.c
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/dgap_parse.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgap/dgap_parse.c
b/drivers/staging/d
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within dgap_driver.c
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/dgap_driver.c | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/dgap/dgap_dr
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within dgap_fep5.c
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/dgap_fep5.c | 86
1 file changed, 43 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/dgap/dgap_fep5
This patch fixes "ERROR: trailing whitespace" found by
checkpatch.pl, within dgap_driver.h
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/dgap_driver.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap_driver.h
b/driver
From: Wei Yongjun
Fixes the following sparse warnings:
drivers/staging/android/ion/tegra/tegra_ion.c:23:19: warning:
symbol 'idev' was not declared. Should it be static?
drivers/staging/android/ion/tegra/tegra_ion.c:24:19: warning:
symbol 'tegra_user_mapper' was not declared. Should it be stat
From: Wei Yongjun
module_platform_driver() makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Wei Yongjun
---
drivers/staging/android/ion/tegra/tegra_ion.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/staging/android/ion/tegra/te
From: Micky Ching
in order to remove duplicated code in rtl8411, we make 8411 as the base
init params, and other like-8411 chips will just change the different
value with 8411, this can save some source code.
Signed-off-by: Lee Jones
Signed-off-by: Micky Ching
---
drivers/mfd/rtl8411.c | 6
From: Micky Ching
With the recent added support request of yet another device, the
burden of duplicated code was becoming a little messy. To rectify is,
we init rtl8411-like chips to 8411 param first, then modify the
different values according each chip. And rtl8402 is supported from
this patch.
From: Micky Ching
Add card reader rtl8042, rtl8402 is much like rtl8411, so just add it to
rtl8411.c
Signed-off-by: Micky Ching
---
drivers/mfd/rtl8411.c | 28
drivers/mfd/rtsx_pcr.c |5 +
drivers/mfd/rtsx_pcr.h |1 +
3 files changed, 30 insertions(+
Smatch complains here because name is a 32 character buffer and we
adding the "OMAP4 ISS " prefix as well for a total of 42 characters.
The sd->name buffer can only hold 32 characters. I've changed it to use
snprintf() to silence the overflow warning.
Also I have removed the call to strlcpy() whi
This patchset cleans up the 2 files having the most checkpatch warnings/errors
in the rtl8188eu driver. The intention is to improve the coding style according
to
guidelines.
The 2 remaining warnings in osdep_service.h are macros requiring structural
change accommpanied by modifying every use of t
Signed-off-by: Matthias Wirth
Signed-off-by: Lukas Senger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 50 ++-
drivers/staging/rtl8188eu/include/rtw_cmd.h | 103 +++---
2 files changed, 80 insertions(+), 73 deletions(-)
diff --git a/drivers/staging/rtl8
These two macros needed reformatting but as they are not used anywhere we
just removed them.
Signed-off-by: Matthias Wirth
Signed-off-by: Lukas Senger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/rtl8
Signed-off-by: Matthias Wirth
Signed-off-by: Lukas Senger
---
drivers/staging/rtl8188eu/include/osdep_service.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include/osdep_service.h
index eb8
The spin_lock_irqsave() macro is not nestable. The second call will
overwrite the first record of "flags" so the IRQs will not be enabled
correctly at the end of the function.
I haven't looked at all the callers but it could be that this function
is always called with interrupts disabled and the
Bug fix: The error code was not set, so the error condition wasn't reflected
in the return value.
Reported-by: Wei Yongjun
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_of.c |2 +-
drivers/staging/xillybus/xillybus_pcie.c |2 +-
2 files changed, 2 insertions(+), 2
On Fri, 27 Sep 2013, Joseph Salisbury wrote:
> >> commit b1a1442a23776756b254b69786848a94d92445ba
> >> Author: Jiri Kosina
> >> Date: Mon Jun 3 11:27:48 2013 +0200
> >>
> >> HID: core: fix reporting of raw events
> >>
> >> Reverting this commit in v3.12-rc2 prevents the system from locking up
Thanks for reporting this bug. The same bug exists in the driver for OF
(xillybus_of.c).
As for the choice of -EIO, I've surveyed several drivers calling
of_iomap() and pci_iomap(), and it turns out that some fail on -ENOMEM,
some on -EIO and some on -EBUSY.
Personally, I'm inclined towards
On Mon, Dec 16, 2013 at 11:33:01AM +, Russell King - ARM Linux wrote:
> The following patch series fixes some bugs and races in the imx-drm
> code, which should probably be applied to an -rc kernel.
>
> drivers/staging/imx-drm/imx-drm-core.c | 21 -
> drivers/staging/im
Enable lock claims that it is serializing tve_enable/disable calls.
However, DRM already serialises mode sets with a mutex, which prevents
encoder/connector functions being called concurrently. Secondly,
holding a spinlock while calling clk_prepare_enable() is wrong; it
will cause a might_sleep()
imx_drm_crtc_register() doesn't clean up the CRTC upon failure, which
leaves the CRTC attached to the DRM device. Also, it does setup after
attaching the CRTC to the DRM device.
Fix this by reordering the function such that we do the setup before
drm_crtc_init(): this fixes both issues.
Signed-o
We must not add more CRTCs than we have declared to the vblank
helpers, otherwise we overflow their arrays. Force failure if we
exceed the number of CRTCs.
Signed-off-by: Russell King
---
drivers/staging/imx-drm/imx-drm-core.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
We have this definition, there's no reason not to use it.
Signed-off-by: Russell King
---
drivers/staging/imx-drm/imx-drm-core.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
b/drivers/staging/imx-drm/imx-drm-core.c
index aff4
Trying to build a modular imx-drm results in a number of missing symbol
exports, caused by the recent changes to this driver. Add the necessary
exports, and the missing MODULE_LICENSE() tag.
Signed-off-by: Russell King
---
drivers/staging/imx-drm/ipuv3-plane.c | 10 ++
1 files changed
Clean up the IPUv3 CRTC device registration; we don't need a separate
function just to call platform_device_register_data(), and we don't
need the return value converted at all.
Update the IPU client id under a mutex, so that parallel probing
doesn't race.
Signed-off-by: Russell King
---
driver
We must call drm_vblank_cleanup() on the error cleanup and unload paths
after we've had a successful call to drm_vblank_init(). Ensure that
the calls are in the reverse order to the initialisation order.
Signed-off-by: Russell King
---
drivers/staging/imx-drm/imx-drm-core.c | 20 +
imx_drm_add_crtc() was kfree'ing the imx_drm_crtc structure while
leaving it on the list of CRTCs. Delete it from the list first.
Signed-off-by: Russell King
---
drivers/staging/imx-drm/imx-drm-core.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/imx-d
The following patch series fixes some bugs and races in the imx-drm
code, which should probably be applied to an -rc kernel.
drivers/staging/imx-drm/imx-drm-core.c | 21 -
drivers/staging/imx-drm/ipu-v3/ipu-common.c | 32 +-
drivers/staging/imx-drm
On Monday, December 16, 2013 2:51 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun
>
> Fix to return negative error code -EIO from the error handling
> case instead of 0.
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/staging/xillybus/xillybus_pcie.c | 2 +-
It looks good.
Reviewed-by: Jingoo Han
removed braces from single statement conditonals.
if, else, while opening brace placement was moved to last
on first line of each, and closing brace moved to first on
new line to follow the linux kernel coding style thus removing
checkpatch errors respectfully.
Signed-off-by: Gary Alan Rookard
-
38 matches
Mail list logo
