My other patch (the one that fixes the security issue) was already
applied, albeit it was sent after this one, see
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-linus&id=559c71fe5dc3bf2ecc55afb336145db7f0abf810
, that is why I think there is some problem with
On Fri, Dec 06, 2013 at 08:05:38AM +0200, Ivajlo Dimitrov wrote:
> Hi Greg,
>
> On 01.12.2013 19:07, Ivaylo DImitrov wrote:
> >From: Ivaylo Dimitrov
> >
> >Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
> >need to be exported. It can also be made way simpler by using sscan
On Fri, 2013-12-06 at 10:11 +0300, Dan Carpenter wrote:
> On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote:
> > On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote:
> > > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
> > > > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpen
On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote:
> On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote:
> > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
> > > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
> > > > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Wil
Hi Greg,
On 01.12.2013 19:07, Ivaylo DImitrov wrote:
From: Ivaylo Dimitrov
Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
need to be exported. It can also be made way simpler by using sscanf.
Signed-off-by: Ivaylo Dimitrov
---
drivers/staging/tidspbridge/Makefile
And use the normal is__ether_addr functions and ETH_ALEN too.
Signed-off-by: Joe Perches
---
drivers/staging/slicoss/README| 1 -
drivers/staging/slicoss/slicoss.c | 21 -
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/slicoss/README b/dr
The 'triggered' value is read directly from the three trigger id
registers and does not have any extra data that needs masked off.
Remove the 'mytrig' local variable and just use 'triggered' directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/co
The header is no longer needed by this driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcmuio.c
b/drivers/staging/comedi/drivers/pcmuio
On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman
wrote:
> On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote:
>> On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote:
>> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
>> > is not preferred.
>> >
>> > Signed-off-by: Jingoo Han
On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote:
> On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
> > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
> > > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote:
> > > > Fixes warnings regarding redundant parantheses
On Thursday, December 05, 2013 4:54 PM, H Hartley Sweeten wrote:
> Subject: [PATCH 10/13] staging: comedi: pcmuio: fix types of some private
> data variables
Oops.. This one got posted twice. Sorry about that.
Hartley
___
devel mailing list
de...@linux
The 'asic' associated with a subdevice can be easily calculated. The
functions that use this member in the subdevice private data can only
be called by the subdevices that support interrupts. Just calculate
the 'asic' when needed and remove the member variable and sanity checks.
Signed-off-by: H H
Legacy (ISA) interrupts are not sharable so this driver should not
be passing the IRQF_SHARED flag when requesting the interrupts.
This driver supports two board types:
PCM-UIO48 with one asic (one interrupt source)
PCM-UIO96 with two asics (two interrupt sources)
The PCM-UIO96 has a jumper t
The 'enabled_mask' is a bit mask of the channels that are enabled
for interrupt detection and should be an unsigned int.
The 'stop_count' is a >= 0 value that is set by the unsigned int
cmd->stop_arg. Make it an unsigned int.
The 'active' and 'continuous' members are flags. Make them unsigned
int
Add some comments about the two spinlock_t variables in the private
data. Also, add come comments for the functions that do not need to
lock/unlock the spinlock.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 6 --
1 fil
Currently only the pcmuio_handle_asic_interrupt() function uses the
spinlock in the private data to protect the read of the paged interrupt
id registers. All accesses to the paged registers should be protected
to ensure that the page is not changed until the access is complete.
Move the lock/unlock
I orignally posted this series on 07/24/2013. At that time Ian Abbott had
some comments on it. I finally got around to addressing them.
This series cleans up the interrupt support and private data usage. It
also does a bit of cleanup to clarify the driver.
H Hartley Sweeten (13):
staging: comed
Refactor this function a bit to remove the need for an extra indent
level and cleanup some of the odd line breaks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 44 ++---
1 file changed, 24 inser
To reduce the potential for bugs, and better document the code, introduce
some inline helper functions to consolidate the calculations needed to get
the 'iobase' for a given asic and the 'asic' and 'port' associated with a
given subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
Clean up the local variables, 'sdev_no' and 'asic' are both used in
simple for () loops. Use the local variable 'i' for both cases. The
'n_subdevs' variable is only used in one place, just remove it.
For aesthetics, add some whitespace to the subdevice init and reorder
it to follow the more typica
This dio subdevice (*insn_bits) function does not follow the "norm"
for comedi drivers. It also _appears_ to return the incorrect state
of the channels.
Use the comedi_dio_update_state() helper to handle the boilerplate
for updating the output channel state. Due to the hardware we then
need to inv
The subdevice private data is only needed for each 'asic' not for each
subdevice. Since the 'asic' can be calculated easily from the subdevice
we can merge the subdevice private data members directly into the
private data.
This removes the need to kcalloc/free the subdevice private data and
saves
The 'enabled_mask' is a bit mask of the channels that are enabled
for interrupt detection and should be an unsigned int.
The 'stop_count' is a >= 0 value that is set by the unsigned int
cmd->stop_arg. Make it an unsigned int.
The 'active' and 'continuous' members are flags. Make them unsigned
int
Unfortunatly, since there could be two asics, we can't use dev->read_subdev
to get the subdevice. But, the comedi_subdevice associated with the 'asic'
can easily be calculated. This allows removing the for () loop that searched
for the correct subdevice.
Tidy up the function.
---
drivers/staging/
On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
> On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
> > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote:
> > > Fixes warnings regarding redundant parantheses thrown by the checkpatch
> > > tool in bpctl_mod.c
> []
> >
On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
> On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote:
> > Fixes warnings regarding redundant parantheses thrown by the checkpatch
> > tool in bpctl_mod.c
[]
> if (ret < 0)
> return BP_NOT_CAP;
> if (ret == 0)
Signed-off-by: Mark Einon
---
I noticed the obvious typo just after sending. Now fixed.
drivers/staging/et131x/et131x.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 4d76d79..2f3c84a 100644
--- a/dri
Factor the code that resets the board and disables the interrupts out
of the attach.
Move the reset so it happens before the subdevices are initialized.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 24 +++--
Clean up the irq request in the attach of this driver and remove the
dev_{level} noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 43 +++-
1 file changed, 17 insertions(+), 26 deletions(-)
The comedi subsystem only requires the drivers to support interrupts if one
or more of the subdevices support async commands. Since this is optional:
1) don't fail the attach if the irq is not available
2) only hookup the async command support if the irq is available
3) remove any async command in
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
Do the request_irq() before setting up the subdevices. This removes an
indent level and makes the code a bit cleaner.
Also, remove the dev_warn() noise about the irq.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 29 ++
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Pass the subdevice pointer to encoder_reset() from the attach instead
of accessing the dev->subdevices array directly to get the pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 6 +++---
1 file changed, 3 insertions
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-
On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote:
> Fixes warnings regarding redundant parantheses thrown by the checkpatch tool
> in bpctl_mod.c
>
Fair enough, but if you wanted to go clean the returns up further then
you could. Remove all the "!= 0" bits.
> @@ -3125,11 +3125,11 @@
Get rid of some of the more unhelpful comments.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 204 ++-
1 file changed, 28 insertions(+), 176 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 9
Negate some 'if' checks to return early, allowing a large block of code
to be un-indented.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 160 ---
1 file changed, 81 insertions(+), 79 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c
Several checks for a valid adapter->phydev pointer are made where the
pointer has already been checked previously in the code path.
Remove these redundant checks.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
There are a large number of TRUEPHY defines in the driver, all of which
are unused or unnecessary. Remove / replace these.
As this results in et1310_phy_access_mii_bit() only being used for
reading bits, also change it's name to et1310_phy_read_mii_bit().
Signed-off-by: Mark Einon
---
drivers/s
Tweak some whitespace, also remove a few redundant lines and
characters (mainly of type 'if (status != 0)' -> 'if (status)').
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 32 ++--
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/dri
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 4d76d79..21132a0 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/e
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 4d5e238..95470e0 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -23
Fixes warnings regarding redundant parantheses thrown by the checkpatch tool in
bpctl_mod.c
Signed-off-by: Will Tange
---
drivers/staging/silicom/bpctl_mod.c | 122 ++--
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/silicom/bpctl
On Thursday, December 05, 2013 at 07:28:10 PM, Denis Carikli wrote:
> The CMO-QVGA, DVI-SVGA and DVI-VGA are added.
>
> Cc: Shawn Guo
> Cc: Sascha Hauer
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: Eric Bénard
> Signed-off-by: Denis Carikli
> ---
> ChangeLog v3->v5:
> - Updated to new GPIO
On Thursday, December 05, 2013 at 07:28:09 PM, Denis Carikli wrote:
> Cc: Dan Carpenter
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Cc: Stephen Warren
> Cc: Ian Campbell
> Cc: devicet...@vger.kernel.org
> Cc: Greg Kroah-Hartman
> Cc: driverdev-devel@linuxdriverproject.org
> Cc: D
On Thursday, December 05, 2013 at 07:28:08 PM, Denis Carikli wrote:
> If de-active and/or pixelclk-active properties were set in the
> display-timings DT node, they were not used.
>
> Instead the data-enable and the pixel data clock polarity
> were hardcoded.
>
> This change is needed for making
On Thursday, December 05, 2013 at 07:28:07 PM, Denis Carikli wrote:
[...]
Can you please explain the correction here ? Why is it needed ? What was the
problem ?
Thanks!
Best regards,
Marek Vasut
___
devel mailing list
de...@linuxdriverproject.org
http
The sanity check of the irq is not necessary. If it _is_ wrong we have
bigger problems in the kernel...
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/co
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
d
This driver only needs an irq in order to support async commands.
If the irq is not available the driver will still function for
single analog input reads.
Tidy up the code that does the irq requests so that the driver
will still attach if it is not avaliable.
Remove the noise about the irq durin
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt3000.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt2814.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
dif
This function can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16m1.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/
The irq is only needed to support async commands. Don't fail the attach
if it is not available.
Only hook up the command support if the request_irq() was successful.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt3000.c | 26 +++
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pc236.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Use the dev->write_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
The 'len_chanlist' and 'cancel' members of the comedi_subdevice are
only used with async command support. Only initialize them if the irq
was sucessfully requested.
Also, only init the dev->read_subdev if we have the irq.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
-
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c | 2 +-
1 file changed, 1 insertion(+), 1 d
Do the request_irq() before setting up the subdevices. Only hook up
the command support of the irq was sucessfully requested.
Note that, because of the IRQF_SHARED flag, nidio_interrupt() _may_
be called before the device is ready and the subdevices are setup.
This condition is handled by the (!de
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_atmio16d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 6 +++---
1 file changed, 3 insertions(+)
Use the dev->write_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The dev->irq passed to request_irq() will always be 0 when the auto_attach
function is called. The pcidev->irq should be used instead to get the correct
irq number.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 2 +-
1
This driver needs both an irq and dma in order to support async
commands. If the irq and dma are not available the driver will
still function for single analog input reads.
Tidy up the code that does the irq and dma requests so that the
driver will still attach if they are not avaliable. The attac
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
An irq is only needed for async command support, modify the attach of
the subdevices so that the command support is only hooked up if the irq
request was successful. Remove the then unnecessary sanity check in
pci9111_ai_do_cmd().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Ha
Clean up the irq request in the attach of this driver and remove the
dev_{level} noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
On Thu, Dec 05, 2013 at 06:31:25PM +, Serban Constantinescu wrote:
> Hi all,
>
> Thanks for your feedback! Sadly enough, being in a different
> time-zone, is not useful.
>
> Sorry for the confusion related to why is this patch needed or not. I
> should highlight a bit more what is the patch e
On 05/12/13 08:40, Dan Carpenter wrote:
On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote:
This patch modifies the functions that need to be passed the explicit
command to use a boolean flag. This way we can reuse the code for 64bit
compat commands.
I don't understand this
On 04/12/13 23:17, Greg KH wrote:
On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote:
This patch adds binder_copy_to_user() to be used for copying binder
commands to user address space. This way we can abstract away the
copy_to_user() calls and add separate handling for the co
On 05/12/13 08:18, Dan Carpenter wrote:
On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote:
+static void bc_increfs_done(struct binder_proc *proc,
+ struct binder_thread *thread, uint32_t cmd,
+ void __user *node_ptr, void __user *cookie)
+{
+
On 05/12/13 08:00, Dan Carpenter wrote:
On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote:
+static void bc_dead_binder_done(struct binder_proc *proc,
+ struct binder_thread *thread, void __user *cookie)
+{
+ struct binder_work *w;
+ struct binder
Hi all,
Thanks for your feedback! Sadly enough, being in a different time-zone,
is not useful.
Sorry for the confusion related to why is this patch needed or not. I
should highlight a bit more what is the patch enabling and what would be
the different alternatives, at least from my perspectiv
Cc: Shawn Guo
Cc: Sascha Hauer
Cc: linux-arm-ker...@lists.infradead.org
Cc: Eric Bénard
Signed-off-by: Denis Carikli
---
ChangeLog v3->v5:
- Updated to the new GPIO defines.
ChangeLog v2->v3:
- Splitted out from the patch that added support for the cpuimx51/mbimxsd51
boards.
- This patch now
The eukrea mbimxsd51 has a gpio backlight for its
LCD display, so we turn that driver on.
Cc: Sascha Hauer
Cc: linux-arm-ker...@lists.infradead.org
Cc: Fabio Estevam
Cc: Shawn Guo
Cc: Eric Bénard
Signed-off-by: Denis Carikli
---
ChangeLog v5:
- New patch in this serie.
---
arch/arm/configs
Cc: Dan Carpenter
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Stephen Warren
Cc: Ian Campbell
Cc: devicet...@vger.kernel.org
Cc: Greg Kroah-Hartman
Cc: driverdev-devel@linuxdriverproject.org
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: Sascha Hauer
Cc: Shawn Guo
Cc: li
The CMO-QVGA, DVI-SVGA and DVI-VGA are added.
Cc: Shawn Guo
Cc: Sascha Hauer
Cc: linux-arm-ker...@lists.infradead.org
Cc: Eric Bénard
Signed-off-by: Denis Carikli
---
ChangeLog v3->v5:
- Updated to new GPIO defines.
- Updated to new licenses checkpatch requirements.
- one whitespace cleanup.
If de-active and/or pixelclk-active properties were set in the
display-timings DT node, they were not used.
Instead the data-enable and the pixel data clock polarity
were hardcoded.
This change is needed for making the eukrea-cpuimx51
QVGA display work.
Greg Kroah-Hartman
Cc: driverdev-devel@
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Stephen Warren
Cc: Ian Campbell
Cc: devicet...@vger.kernel.org
Cc: Greg Kroah-Hartman
Cc: driverdev-devel@linuxdriverproject.org
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: Mauro Carvalho Chehab
Cc: Laurent Pinchart
Cc: linux
That new macro is needed by the imx_drm staging driver
for supporting the QVGA display of the eukrea-cpuimx51 board.
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Stephen Warren
Cc: Ian Campbell
Cc: devicet...@vger.kernel.org
Cc: Greg Kroah-Hartman
Cc: driverdev-devel@linuxdriverproj
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Stephen Warren
Cc: Ian Campbell
Cc: devicet...@vger.kernel.org
Cc: Greg Kroah-Hartman
Cc: driverdev-devel@linuxdriverproject.org
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: Mauro Carvalho Chehab
Cc: Laurent Pinchart
Cc: linux
On Wednesday, December 04, 2013 4:47 AM, Ian Abbott wrote:
> On 2013-12-03 19:07, H Hartley Sweeten wrote:
>> The comedi subsystem only requires the drivers to support interrupts if one
>> or more of the subdevices support async commands. Since this is optional:
>>
>> 1) don't fail the attach if th
On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote:
> On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote:
> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> > is not preferred.
> >
> > Signed-off-by: Jingoo Han
> >
>
> I think you misunderstood the checkpatch.pl warning, it t
On Thu, Dec 05, 2013 at 05:14:37PM +0800, ZHAO Gang wrote:
> On Tue, Dec 3, 2013 at 7:29 AM, Jingoo Han wrote:
> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> > is not preferred.
> >
> > Signed-off-by: Jingoo Han
> > ---
>
> Greg, this patch should be reverted. It do the opposi
On Thu, Dec 05, 2013 at 11:18:22AM +0300, Dan Carpenter wrote:
> On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote:
> > +static void bc_increfs_done(struct binder_proc *proc,
> > + struct binder_thread *thread, uint32_t cmd,
> > + void __user *node_ptr, void
On Wed, Dec 04, 2013 at 03:23:29PM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 04, 2013 at 03:24:14PM +0800, ZHAO Gang wrote:
> > As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
> > when tx failed.
>
> Really? That's ok to do? Seems like you are changing the logic of the
On Tue, Dec 3, 2013 at 7:29 AM, Jingoo Han wrote:
> Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> is not preferred.
>
> Signed-off-by: Jingoo Han
> ---
Greg, this patch should be reverted. It do the opposite things.
> drivers/vme/boards/vme_vmivme7805.c |2 +-
> drivers/vme
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote:
> Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> is not preferred.
>
> Signed-off-by: Jingoo Han
>
I think you misunderstood the checkpatch.pl warning, it tells you what
to do, not what not to do.
WARNING: Use DEFINE_PCI_DEVICE_TA
These five patches all do the same thing. It's ok to merge them into
one patch.
The subject lines are all the same and that's not ok. The subject lines
are too long as well.
On Wed, Dec 04, 2013 at 07:26:19PM -0500, Gary Rookard wrote:
> This is the first patch of a series.
Don't put this in t
On Wed, Dec 04, 2013 at 06:09:36PM +, Serban Constantinescu wrote:
> This patch adds align_helper() macro that will be used for enforcing
> the desired alignment on 64bit systems where the alignment will differ
> depending on the userspace used (32bit /64bit).
>
> This patch is a temporary pat
On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote:
> This patch modifies the functions that need to be passed the explicit
> command to use a boolean flag. This way we can reuse the code for 64bit
> compat commands.
>
I don't understand this at all. cmd seems like it should b
On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote:
> This patch adds binder_copy_to_user() to be used for copying binder
> commands to user address space. This way we can abstract away the
> copy_to_user() calls and add separate handling for the compat layer.
>
> Signed-off-by:
On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote:
> +static void bc_increfs_done(struct binder_proc *proc,
> + struct binder_thread *thread, uint32_t cmd,
> + void __user *node_ptr, void __user *cookie)
> +{
> + struct binder_node *node;
> +
> +
On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote:
> +static void bc_dead_binder_done(struct binder_proc *proc,
> + struct binder_thread *thread, void __user *cookie)
> +{
> + struct binder_work *w;
> + struct binder_ref_death *death = NULL;
> +
> + l
99 matches
Mail list logo
