Oh, another member has already fixed it (found earlier than me), and
integrated it into next-20131203 tree, so this patch is obsoleted.
The related git commit is "8aced95 staging: ft1000: fix use of
potentially uninitialized variable"
Thanks.
On 11/27/2013 05:27 PM, Chen Gang wrote:
stop read and return error when hit max delay time.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 6441e25..0fe7b17 100644
--- a/drivers/staging/et131x/et13
adapter->lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev->addr_list_lock hold, to protect from
concurrent access. So adapter->lock is redundant.
Signed-off-by: ZHAO Gang
--
On Wed, Dec 04, 2013 at 06:35:15AM +0200, Aldo Iljazi wrote:
> Samuel Thibault wrote:
>
> > Err, I'd rather make it really visible that the for loop doesn't have
> > its first statement?
>
> Wouldn't it be better if you add a comment there? So it would follow the
> coding style?
No. Adding obv
remove items that have been done
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/README | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 8da96a6..00a34ea 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/stagin
Variable u32 numrfd is not necessary in this function.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 263a478..f4ab56a 100644
--- a/drivers
fix make -W1 warning:
drivers/staging/et131x//et131x.c: In function
‘et1310_setup_device_for_multicast’:
drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
drivers/staging/et131x//et131x.c: In function ‘et1310_set
Also use the __packed macro.
struc vme_master {
...
} __packed;
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 65fa0ed..772d299 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/stagi
The original code allocate rx dma memory in several dma_alloc_coherent calls,
which causes some problems:
1. since dma_alloc_coherent allocate at least one page memory, it wastes some
memory when allocation size is smaller than one page.
2. it causes et131x_rx_dma_memory_free as complex as et131
1. As TODO list suggested, do this sort of things to reduce split lines:
struct fbr_lookup *fbr;
fbr = rx_local->fbr[id];
Then replace all the instances of "rx_local->fbr[id]" with fbr.
2. Some code style change
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang
---
drivers/staging/et1
combine two dma_alloc_coherent to one
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 70 +++--
1 file changed, 19 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index a3d1b53..3fa1
Change function name from et1310_phy_power_down to et1310_phy_power_switch
to better describe its functionality.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/stagin
fix make -W1 warning:
drivers/staging/et131x//et131x.c: In function
‘et1310_setup_device_for_multicast’:
drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
drivers/staging/et131x//et131x.c: In function ‘et1310_set
On Wed, Dec 4, 2013 at 3:09 PM, Greg Kroah-Hartman
wrote:
> On Wed, Dec 04, 2013 at 01:51:41PM +0800, ZHAO Gang wrote:
>> On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman
>> wrote:
>> > On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote:
>> >> 1. As TODO list suggested, do this sort of
On Wed, Dec 04, 2013 at 01:51:41PM +0800, ZHAO Gang wrote:
> On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman
> wrote:
> > On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote:
> >> 1. As TODO list suggested, do this sort of things to reduce split lines:
> >> struct fbr_lookup *fbr;
On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman
wrote:
> On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote:
>> 1. As TODO list suggested, do this sort of things to reduce split lines:
>> struct fbr_lookup *fbr;
>> fbr = rx_local->fbr[id];
>> Then replace all the insta
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Tuesday, December 03, 2013 7:56 PM
>
> While Paul said that .uframe_sched should be enabled on the BCM2835,
> and doing so works fine with the built-in wired Ethernet, it prevents
> my WiFi dongle from operating correctly. Hence, disabl
adapter->lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev->addr_list_lock hold, to protect from
concurrent access. So adapter->lock is redundant.
Signed-off-by: ZHAO Gang
--
Samuel Thibault wrote:
> Err, I'd rather make it really visible that the for loop doesn't have
> its first statement?
Wouldn't it be better if you add a comment there? So it would follow the
coding style?
--
Aldo Iljazi
___
devel mailing list
de...@li
While Paul said that .uframe_sched should be enabled on the BCM2835,
and doing so works fine with the built-in wired Ethernet, it prevents
my WiFi dongle from operating correctly. Hence, disable the option so
that everything works.
Signed-off-by: Stephen Warren
---
drivers/staging/dwc2/platform.
Aldo Iljazi, le Tue 03 Dec 2013 22:08:03 +0200, a écrit :
> Line 468: Removed a space before a semicolon.
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Samuel
___
devel mailing list
de...@linuxdriverproject.o
- Original Message -
> From: "Greg Kroah-Hartman"
> Sent: Tuesday, December 3, 2013 1:07:51 PM
>
[snip]
> >
> > diff --git a/drivers/staging/vme/devices/vme_user.h
> > b/drivers/staging/vme/devices/vme_user.h
> > index 7d24cd6..6726a42 100644
> > --- a/drivers/staging/vme/devices/vme_
The subdevice 'len_chanlist' member is only used with async command
support. Remove the initialization of this member for the subdevices
that do not support commands. The core will then correctly initialize
it to the default value of '1'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
This member of the private data is not needed. We can check if
dev->irq is none zero instead. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --g
Clean up the irq request in the attach of this driver and remove the
dev_{level} noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 43 +++-
1 file changed, 17 insertions(+), 26 deletions(-)
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
Do the request_irq() before setting up the subdevices. This removes an
indent level and makes the code a bit cleaner.
Also, remove the dev_warn() noise about the irq.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 29 ++
Clean up the irq request in the attach of this driver and remove the
dev_{level} noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
The 'len_chanlist' and 'cancel' members of the comedi_subdevice are
only used with async command support. Only initialize them if the irq
was sucessfully requested.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 4 ++--
1 fi
Factor the code that resets the board and disables the interrupts out
of the attach.
Move the reset so it happens before the subdevices are initialized.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 24 +++--
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_atmio16d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
The irq is only needed to support async commands. Tidy up the
code that does the request_irq() and remove the noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcimio.c | 19 +++
1 file changed, 7 insertions(+),
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Use the dev->write_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This function can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16m1.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Line 468: Removed a space before a semicolon.
Signed-off-by: Aldo Iljazi
---
drivers/staging/speakup/synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index 0b3549b..2a4b348 100644
--- a/drivers/staging/s
This function can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/stag
Pass the subdevice pointer to encoder_reset() from the attach instead
of accessing the dev->subdevices array directly to get the pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 6 +++---
1 file changed, 3 insertions
The irq is only needed to support async commands. Tidy up the
code that does the request_irq() and remove the noise.
Only hookup the subdevice command support if the irq is available.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt3000.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
This member of the private data is a duplicate of the comedi_device
'read_subdev' member. Remove the private data member and use the
comedi_device member instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 4 +---
1 file
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
The sanity check of the irq is not necessary. If it _is_ wrong we have
bigger problems in the kernel...
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/co
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt2814.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
dif
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c | 2 +-
1 file changed, 1 insertion(+), 1 d
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pc236.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Do the request_irq() before setting up the subdevices. Only hook up
the command support of the irq was sucessfully requested.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 38 +++---
1 file change
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
d
The irq is only needed to support async commands. Don't fail the attach
if it is not available.
Only hook up the command support if the request_irq() was successful.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt3000.c | 26 +++
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 6 +++---
1 file changed, 3 insertions(+)
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Since the irq is only needed for async command support, modify the attach
of the subdevices so that the command support is only hooked up if the irq
request was successful.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c |
This function can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging
Use the dev->write_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
The 'len_chanlist' and 'cancel' members of the comedi_subdevice are
only used with async command support. Only initialize them if the irq
was sucessfully requested.
Also, only init the dev->read_subdev if we have the irq.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
-
Clean up the irq request in the attach of this driver and remove the
dev_{level} noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 64 ++--
1 file changed, 27 insertions(+), 37 deletions(-)
The dev->irq passed to request_irq() will always be 0 when the auto_attach
function is called. The pcidev->irq should be used instead to get the correct
irq number.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 2 +-
1
The async command support requires an irq. Only initialize the subdevice
command support if the request_irq was successfull.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 17 ++---
1 file changed, 10 insertions
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-
The irq is only needed to support async commands. Tidy up the
code that does the request_irq() and remove the noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 14 +++---
1 file changed, 7 insertions(+), 7 del
Only set the SDF_CMD_READ subdev_flag if the irq was sucessfully
requested.
Remove the unnecessary sanity check of dev->irq in s626_ai_cmd().
This callback is only hooked up if the irq is available.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
This member of the private data is not needed. We can check if
dev->irq is none zero instead. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --g
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
This member of the private data is a duplicate of the comedi_device
'read_subdev' member. Remove the private data member and use the
comedi_device member instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 4 +---
1 file
The subdevice 'len_chanlist' member is only used with async command
support. Remove the initialization of this member for the subdevices
that do not support commands. The core will then correctly initialize
it to the default value of '1'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-
These kernel messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/drivers/staging/comed
The comedi subsystem only requires the drivers to support interrupts if one
or more of the subdevices support async commands. Since this is optional:
1) don't fail the attach if the irq is not available
2) only hookup the async command support if the irq is available
3) remove any async command in
The 'len_chanlist' and 'cancel' members of the comedi_subdevice are
only used with async command support. Only initialize them if the irq
was sucessfully requested.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 4 ++--
1 fi
The async command support requires an irq. Only initialize the subdevice
command support if the request_irq was successfull.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 18 ++
1 file changed, 10 insertions
These functions can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
Use the dev->read_subdev that was setup in the device attach instead
of accessing the dev->subdevices array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
On Thu, Oct 31, 2013 at 06:47:54PM -0500, Aaron Sierra wrote:
> This patch updates the vme_master and vme_slave structures to use
> types with well defined size and to prevent the compiler from
> inserting padding (between enable and vme_addr for one).
>
> The original vme_master and vme_slave str
On Tuesday, December 03, 2013 10:18 AM, gre...@linuxfoundation.org wrote:
> On Wed, Nov 27, 2013 at 05:33:40PM +, Hartley Sweeten wrote:
>> Can I just fix this patch (51/60) and repost it or would you prefer to
>> take patches 1-50 and have me repost 51-60 after fixing this one?
>
> I'll just t
On Wed, Nov 27, 2013 at 05:33:40PM +, Hartley Sweeten wrote:
> On Tuesday, November 26, 2013 4:42 PM, H Hartley Sweeten wrote:
> > Tidy up the code that does the request_irq().
> >
> > Signed-off-by: H Hartley Sweeten
> > Cc: Ian Abbott
> > Cc: Greg Kroah-Hartman
> > ---
> > drivers/staging
On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote:
> 1. As TODO list suggested, do this sort of things to reduce split lines:
> struct fbr_lookup *fbr;
> fbr = rx_local->fbr[id];
> Then replace all the instances of "rx_local->fbr[id]" with fbr.
>
> 2. Some code style chan
On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
> Add DRM flags for the LCD display clock polarity so the pixelclk-active DT
> property can be properly handled by drivers using the DRM API.
>
> Signed-off-by: Marek Vasut
> Cc: Dave Airlie
> Cc: Greg Kroah-Hartman
> Cc: Philipp Zabe
On Tue, Dec 03, 2013 at 07:44:52PM +0800, Shawn Guo wrote:
> On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
> > Add DRM flags for the LCD display clock polarity so the pixelclk-active DT
> > property can be properly handled by drivers using the DRM API.
> >
> > Signed-off-by: Marek V
On Tue, 03 Dec 2013, micky wrote:
> On 12/03/2013 06:40 PM, Lee Jones wrote:
> >By the way, I'm going to apply this patch now.
> >
> So, in next patch-set, I will not include this patch.
Exactly.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM
On 12/03/2013 07:01 PM, Lee Jones wrote:
This should contain the author's name.
You should use:
`git rebase -i` /* Use edit option */
then
`git commit --amend --author="First Last "
To apply it.
Sorry Lee, I will modify it. Is the order important? or only your
name is need here?
drive
Signed-off-by is intended to have a legal meaning that you didn't steal
someone's code. You can't sign off for other people.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/list
> >This should contain the author's name.
> >
> >You should use:
> >`git rebase -i` /* Use edit option */
> >then
> > `git commit --amend --author="First Last "
> >
> >To apply it.
> >
> Sorry Lee, I will modify it. Is the order important? or only your
> name is need here?
> >>drivers/mfd/rtl
On 12/03/2013 06:40 PM, Lee Jones wrote:
By the way, I'm going to apply this patch now.
So, in next patch-set, I will not include this patch.
--
Best Regards
Micky.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
On 12/03/2013 06:45 PM, Lee Jones wrote:
From: Micky Ching
Add card reader rtl8042, rtl8402 is much like rtl8411, so just add it to
rtl8411.c
Signed-off-by: Lee Jones
I have never signed this patch off.
These tags actually 'mean' something. Please don't apply them willy-nilly!
ok, I will rem
> From: Micky Ching
>
> in order to remove duplicated code in rtl8411, we make 8411 as the base
> init params, and other like-8411 chips will just change the different
> value with 8411, this can save some source code.
>
> Signed-off-by: Lee Jones
I haven't signed this version off.
I'm still
On 12/03/2013 06:40 PM, Lee Jones wrote:
This should contain the author's name.
You should use:
`git rebase -i` /* Use edit option */
then
`git commit --amend --author="First Last "
To apply it.
Sorry Lee, I will modify it. Is the order important? or only your name
is need here?
drive
> From: Micky Ching
>
> Add card reader rtl8042, rtl8402 is much like rtl8411, so just add it to
> rtl8411.c
>
> Signed-off-by: Lee Jones
I have never signed this patch off.
These tags actually 'mean' something. Please don't apply them willy-nilly!
> Signed-off-by: Micky Ching
> ---
> driv
On Tue, 03 Dec 2013, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
This should contain the author's name.
You should use:
`git rebase -i` /* Use edit option */
then
`git commit --amend --author="First Last "
To apply it.
> drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor
By the way, I'm going to apply this patch now.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
devel mailing list
de...@linuxdriverproject.org
http://dr
Hello Russell,
> On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
> > Add DRM flags for the LCD display clock polarity so the pixelclk-active
> > DT property can be properly handled by drivers using the DRM API.
>
> I still say that not even this should be part of the DRM mode API to
From: Micky Ching
in order to remove duplicated code in rtl8411, we make 8411 as the base
init params, and other like-8411 chips will just change the different
value with 8411, this can save some source code.
Signed-off-by: Lee Jones
Signed-off-by: Micky Ching
---
drivers/mfd/rtl8411.c | 6
From: Micky Ching
With the recent added support request of yet another device, the
burden of duplicated code was becoming a little messy. To rectify is,
we init rtl8411-like chips to 8411 param first, then modify the
different values according each chip.
Micky Ching (3):
mfd: rtsx: reduce code
From: Micky Ching
drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
drivers/mfd/rtl8411.c:58:7: warning: 'reg1' is used uninitialized in this
function [-Wuninitialized]
drivers/mfd/rtl8411.c: In function 'rtl8411b_fetch_vendor_settings':
drivers/mfd/rtl8411.c:79:7: warning: 're
From: Micky Ching
Add card reader rtl8042, rtl8402 is much like rtl8411, so just add it to
rtl8411.c
Signed-off-by: Lee Jones
Signed-off-by: Micky Ching
---
drivers/mfd/rtl8411.c | 33 +
drivers/mfd/rtsx_pcr.c |5 +
drivers/mfd/rtsx_pcr.h |1 +
3
On Mon, Dec 02, 2013 at 03:32:30PM -0500, Rob Clark wrote:
> On Mon, Dec 2, 2013 at 3:01 PM, Russell King - ARM Linux
> wrote:
> > On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:
> >> Add DRM flags for the LCD display clock polarity so the pixelclk-active DT
> >> property can be prope
100 matches
Mail list logo
