[PATCH 3/3] staging: et131x: fix build warning

fix make -W1 warning: drivers/staging/et131x//et131x.c: In function ‘et1310_setup_device_for_multicast’: drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but not used [-Wunused-but-set-variable] u32 pm_csr; ^ drivers/staging/et131x//et131x.c: In function ‘et1310_set

[PATCH 2/3] staging: et131x: simplify tx dma code

combine two dma_alloc_coherent to one Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 72 - 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 409949f..45bb

[PATCH 1/3] staging: et131x: simplify rx dma code

The original code allocate rx dma memory in several dma_alloc_coherent calls, which causes some problems: 1. since dma_alloc_coherent allocate at least one page memory, it wastes some memory when allocation size is smaller than one page. 2. it causes et131x_rx_dma_memory_free as complex as et131

[PATCH 0/3] staging: et131x: patches for et131x

This patch set is based on previous sent v5 of 7 patches for et131x. ZHAO Gang (3): staging: et131x: simplify rx dma code staging: et131x: simplify tx dma code staging: et131x: fix build warning drivers/staging/et131x/et131x.c | 298 +--- 1 file changed,

Re: [PATCH] staging: dwc2: set up all module params

This looks like it is the same problem we saw in the dwc_otg driver with incorrect scheduling of split USB transactions to downstream ports behind single TT hubs (this just makes the problem worse rather than be the cause of anything) In general it should be possible to schedule multiple split tra

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

On 11/27/2013 12:03 PM, Greg KH wrote: > On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. Related warning (with allmodconfig under >> hexagon): >> >> CC [M] drivers/staging/media

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: > dev_*() assumes 'go' is already initialized, so need use pr_*() instead > of before 'go' initialized. Related warning (with allmodconfig under > hexagon): > > CC [M] drivers/staging/media/go7007/go7007-usb.o > drivers/staging/medi

[PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': drivers/stagin

Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

On 11/27/2013 11:21 AM, Joe Perches wrote: > On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. > [] >> diff --git a/drivers/staging/media/go7007/go7007-usb.c >> b/drivers/staging/media/go700

[PATCH] drivers: staging: ft1000: ft1000-usb: ft1000_debug.c: check return value of get_user() in ft1000_ioctl()

get_user() may fail and cause 'msgsz' uninitialized, so need give a check. The related warning (with allmodconfig under hexagon): CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_debug.o drivers/staging/ft1000/ft1000-usb/ft1000_debug.c: In function 'ft1000_ioctl': include/uapi/linux/swab.h

[PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': drivers/stagin

Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: > dev_*() assumes 'go' is already initialized, so need use pr_*() instead > of before 'go' initialized. [] > diff --git a/drivers/staging/media/go7007/go7007-usb.c > b/drivers/staging/media/go7007/go7007-usb.c [] > @@ -1057,7 +1057,7 @@ static in

[PATCH] drivers: staging: ft1000: ft1000-usb: initialize 'status' with STATUS_SUCCESS in request_code_segment()

If "!bool_case", it returns unexpected value instead of STATUS_SUCCESS, so need fix it, the related warning (with allmodconfig under hexagon): CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_download.o drivers/staging/ft1000/ft1000-usb/ft1000_download.c: In function 'request_code_segment':

Re: [PATCH] staging: dwc2: set up all module params

(trimming out the devicetree list and maintainers for this discussion) On 11/26/2013 12:52 PM, Paul Zimmerman wrote: >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] >> Sent: Tuesday, November 26, 2013 11:43 AM >> >> On 11/26/2013 12:27 PM, Paul Zimmerman wrote: From: Stephen Warren [ma

[PATCH V2] staging: dwc2: set up all module params

The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non- default parameters. Select these based on the compatible value from the DT node. For all other HW, fall back to the default parameters currently in use. The values in params_bcm2835[] were posted to the mailing list by Paul quit

[PATCH -next] staging: rts5208: fix error return code in rtsx_probe()

From: Wei Yongjun Fix to return -ENOMEM instead of 0 when the memory alloc fail in probe error handling path. Signed-off-by: Wei Yongjun --- drivers/staging/rts5208/rtsx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rt

[PATCH 34/60] staging: comedi: dt282x: convert dt282x_ai_dma_interrupt() messages

Convert the messages in this function to dev_{level}(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/

[PATCH 32/60] staging: comedi: dt282x: remove disable code that disables the irq

The code that would disable the irq after getting a number of D/A errors is disabled. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/com

[PATCH 56/60] staging: comedi: ni_tio: remove commented out printk message

This printk message is just added noise. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni

[PATCH 08/60] staging: comedi: c6xdigio: remove commented out subdevice code

The code to initialize subdevice[2] is commented out and incomplete. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/c6xdigio.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/

[PATCH 06/60] staging: comedi: pcl818: convert some printk's to dev_dbg()

Convert these messages to dev_dbg() and tidy them up a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/d

[PATCH 33/60] staging: comedi: dt282x: convert dt282x_ao_dma_interrupt() messages

Convert the messages in this function to dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/stag

[PATCH 54/60] staging: comedi: pcl812: tidy up the irq support in pcl812_attach()

Tidy up the code that does the request_irq(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/staging/comedi/drivers/p

[PATCH 59/60] staging: comedi: ni_atmio16d: tidy up the irq support in atmio16d_attach()

Tidy up the code that does the request_irq(). Only hookup the commad support if the irq was sucessfully requested. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_atmio16d.c | 34 1 file changed, 14 inse

[PATCH 12/60] staging: comedi: das16m1: tidy up the irq support in das16m1_attach()

An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if an invalid irq is selected by the user, or the request_irq() fails, the attach does not fail. Remove all the printk noise about the irq. Only hookup the async command suppor

[PATCH 31/60] staging: comedi: dt282x: remove unnecessary blank line message

This blank line message is not needed. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi/drivers/dt

[PATCH 30/60] staging: comedi: dt282x: convert printk() in dt282x_attach to a dev_err()

Convert this printk message into a dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi

[PATCH 05/60] staging: comedi: pcl816: convert some printk's to dev_dbg()

Convert these warning messages to dev_dbg() to minimize the noise. Also, tidy them up a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 28 1 file changed, 12 insertions(+), 16 deletions(-)

[PATCH 04/60] staging: comedi: pcl812: convert some printk's to dev_dbg()

Convert these debug messages to dev_dbg() and tidy them up a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 55/60] staging: comedi: pcl812: convert printk messages in pcl812_attach()

Convert the printk messages in this function to dev_{level} mesages. Remove the ones that are just added noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 27 --- 1 file changed, 8 insertions(+),

[PATCH 23/60] staging: comedi: dt2814: remove bad printk noise

This printk could spew a lot of noise while waiting for the ai conversion to complete. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2814.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/dr

[PATCH 49/60] staging: comedi: pcl816: remove commented out outb() macro

This macro is commented out, thankfully... Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/driver

[PATCH 50/60] staging: comedi: pcl816: remove TRIG_WAKE_EOS support stub

The support code for this command flag is commented out. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl816.c b/dri

[PATCH 40/60] staging: comedi: mpc624: convert printk messages in mpc624_ai_rinsn()

There's no reason for these messages to be KERN_INFO. Convert them to dev_dbg(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 44/60] staging: comedi: pcl818: remove commented out printk debug

These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/

[PATCH 37/60] staging: comedi: mpc624: remove commented out printk

This printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/mpc624.c b/drivers/staging/comedi/drivers/mpc624.c i

[PATCH 58/60] staging: comedi: ni_atmio16d: remove printk() noise in atmio16d_ai_insn_read()

These printk messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_atmio16d.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio16d.

[PATCH 53/60] staging: comedi: pcl816: convert printk messages in pcl816_attach()

Convert the printk messages in this function to dev_{level} mesages. Remove the ones that are just added noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 20 +--- 1 file changed, 9 insertions(+), 11 del

[PATCH 57/60] staging: comedi: ni_pcimio: convert printk() to dev_dbg()

Convert this printk messages to a dev_dbg(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_pcimio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c b/drivers/sta

[PATCH 22/60] staging: comedi: dt2814: remove unnecessary printk noise

The ai read timeout will return -ETIMEDOUT. The printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2814.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/comed

[PATCH 51/60] staging: comedi: pcl816: tidy up the irq support in pcl816_attach()

Tidy up the code that does the request_irq(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 33 ++--- 1 file changed, 6 insertions(+), 27 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 38/60] staging: comedi: mpc624: remove unnecessary test

It's not necessaary to vaidate insn->n passed to the (*insn_read) function. The for() loop following it will just be a NOP. Remove the test as well as the printk noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 4

[PATCH 45/60] staging: comedi: pcl818: remove printk function trace messages

These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/p

[PATCH 26/60] staging: comedi: dt2815: convert printk's in dt2815_ao_insn()

Convert the printk(KERN_WARNING messages in this function to dev_dbg(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2815.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drive

[PATCH 35/60] staging: comedi: dt282x: convert dt282x_ao_inttrig() messages

Convert the messages in this function to dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/stag

[PATCH 43/60] staging: comedi: pcm3724: remove commented out printk debug

These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcm3724.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcm3724.c b/drivers/staging/comedi/driv

[PATCH 39/60] staging: comedi: mpc624: remove unnecessary printk noise

The ai read timeout will return -ETIMEDOUT. The printk is just added noise. Remove it. It's also not necessary to set data[n[ = 0 when the read timesout. Remove that also. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mpc624.c | 6 ++

[PATCH 36/60] staging: comedi: dt282x: remove commented out printk

This printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi

[PATCH 24/60] staging: comedi: dt2814: convert a printk(KERN_ERR into a dev_err()

Convert this printk message into a dev_dev(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2814.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi

[PATCH 47/60] staging: comedi: pcl818: tidy up the irq support in pcl818_attach()

Tidy up the code that does the request_irq(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl8

[PATCH 27/60] staging: comedi: dt2815: convert printk's in dt2815_attach()

These messages don't appear to be important enough to warrent KERN_INFO and KERN_WARNING levels. Convert them dev_dbg(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2815.c | 9 + 1 file changed, 5 insertions(+), 4 deletion

[PATCH 52/60] staging: comedi: pcl816: remove commented out printk debug

These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pc

[PATCH 19/60] staging: comedi: dt2801: convert printk() messages to dev_dbg()

Convert all the printk() messages in this driver to dev_dbg(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2801.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi/dr

[PATCH 60/60] staging: comedi: ni_atmio16d: remove an unnecessary printk

This blank line printk is not necessary. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_atmio16d.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio16d.c b/drivers/staging/comedi/

[PATCH 46/60] staging: comedi: pcl818: remove board attach noise

These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/

[PATCH 48/60] staging: comedi: pcl818: convert printk() messages to dev_{level}

Convert the remaining printk messsages in this driver to dev_{level}. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/s

[PATCH 42/60] staging: comedi: plx9080.h: remove unnecessary printk noise

The timeouts will return -ETIMEDOUT. The printks are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/plx9080.h | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/sta

[PATCH 41/60] staging: comedi: rtd520: remove commented out printk debug

These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/r

[PATCH 02/60] staging: comedi: adv_pci1710: convert some printk's to dev_dbg()

Convert these debug messages to dev_dbg(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 15/60] staging: comedi: dmm32at: tidy up the irq support in dmm32at_attach()

An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if the request_irq() fails the attach does not fail. Remove the printk noise about the irq. Only hookup the async command support if the request_irq() was successful. Signed-o

[PATCH 00/60] staging: comedi: more printk debug cleanup

There are a lot of debugging messages in the comedi drivers that are just added noise. Some of them messages are worth keeping but they should be converted to the appropriate dev_{level} format. This series is a first pass at cleaning this up. H Hartley Sweeten (60): staging: comedi: pcmmio.c:

[PATCH 16/60] staging: comedi: dmm32at: convert a printk(KERN_ERR to a dev->err()

Convert this printk message to a dev_err() message. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/stagin

[PATCH 18/60] staging: comedi: dt2801: remove commented out printk()

This printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2801.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c i

[PATCH 25/60] staging: comedi: dt2814: tidy up the irq support in dt2814_attach()

An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if the request_irq() fails the attach does not fail. Remove the printk noise about the irq. Only hookup the async command support if the request_irq() was successful. Signed-o

[PATCH 20/60] staging: comedi: dt2811: remove disabled dt2811_adtrig() function

This function is not used by the driver. It's also suffering from bitrot since COMEDI_MDEMAND and COMEDI_MCONTS are not defined anywhere. Just remove the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2811.c | 29 --

[PATCH 14/60] staging: comedi: dmm32at: remove commented out printk debug

These printk messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comed

[PATCH 01/60] staging: comedi: pcmmio.c: remove kcalloc() failure message

An allocation failure will have already displayed a message. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/dri

[PATCH 28/60] staging: comedi: dt282x: tidy up the irq support in dt282x_attach()

An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if the request_irq() fails the attach does not fail. Remove the printk noise about the irq. Only hookup the async command support if the request_irq() was successful. Also, on

[PATCH 21/60] staging: comedi: dt2811: remove disabled interrupt support code

The interrupt support in this driver is incomplete due to the missing comedi functions to support async commands. Since the interrupt code is already disable just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2811.c | 72

[PATCH 11/60] staging: comedi: cb_pcimdas: remove unnecessary printk noise

The ai read timeout will return -ETIMEDOUT. The printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 29/60] staging: comedi: dt282x: remove attach noise in dt282x_grab_dma()

These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers

[PATCH 13/60] staging: comedi: dmm32at: remove unnecessary printk noise

A timeout will return -ETIMEDOUT. The printks are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/st

[PATCH 03/60] staging: comedi: dmm32at: remove final attach noise and fix return value

The "success" message after an attach is just added noise. Remove it. The normal return value for "success" is 0. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) dif

[PATCH 17/60] staging: comedi: dt2801: remove disabled code in dt2801_writedata

The code that checks the DT_S_READY status is disabled. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2801.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2801.c b/driver

[PATCH 09/60] staging: comedi: c6xdigio: remove commented out function trace messages

These commented out messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/c6xdigio.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/d

[PATCH 10/60] staging: comedi: cb_pcimdas: remove commented out irq init code

This driver does not have interrupt support. Remove the commented out code that requests the irq. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/c

[PATCH 07/60] staging: comedi: adq12b: remove commented out debug message

Remove the commented out message, it would just be added noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adq12b.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adq12b.c b/drivers/staging/com

RE: [PATCH] staging: dwc2: set up all module params

> From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Tuesday, November 26, 2013 11:43 AM > > On 11/26/2013 12:27 PM, Paul Zimmerman wrote: > >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] > >> Sent: Monday, November 25, 2013 9:03 PM > >> > >> The DWC2 USB controller in the BCM2835

Re: [PATCH] staging: dwc2: set up all module params

On 11/26/2013 12:27 PM, Paul Zimmerman wrote: >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] >> Sent: Monday, November 25, 2013 9:03 PM >> >> The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non- >> default parameters. Select these based on the compatible value from the >> D

RE: [PATCH] staging: dwc2: set up all module params

> From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Monday, November 25, 2013 9:03 PM > > The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non- > default parameters. Select these based on the compatible value from the > DT node. For all other HW, fall back to the default

[PATCH v2 13/26] staging: comedi: pcmmio: remove DAMMIT_ITS_BROKEN debug

These debug messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcmmio.c

[PATCH v2 24/26] staging: comedi: ni_mio_common: remove DEBUG_STATUS_A messages

Defining DEBUG_STATUS_A enables dumping of a status register during the interrupt. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 31 -

[PATCH v2 18/26] staging: comedi: dt2814: remove disabled irq probe code

The irq probe code in dt2814_attach() is disabled by an #if 0 block. Just remove it. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2814.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/driver

[PATCH v2 26/26] staging: comedi: unionxx5: tidy up some dev_{level} messages

Remove the "comedi%d:" prefix from the dev_{level} messages. This previx will already be displayed. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/unioxx5.c | 32 1 file changed, 16 insertions(+), 16 de

[PATCH v2 08/26] staging: comedi: cb_pcidas64: remove DEBUG_PRINT

The DEBUG_PRINT macro in this driver is used to output development debug tracing messages. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 126 +-

[PATCH v2 25/26] staging: comedi: ni_mio_common: remove DEBUG_INTERRUPT messages

Defining DEBUG_INTERRUPT enables some function trace messages during the interrupt. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 24 ---

[PATCH v2 16/26] staging: comedi: pcmmio: convert a KERN_DEBUG message to dev_dbg()

Convert a printk(KERN_DEBUG ... message to dev_dbg(). Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcmmio.c b

[PATCH v2 22/26] staging: comedi: ni_mio_common: remove DEBUG_DIO messages

Defining DEBUG_DIO simply enables some function trace messages. These are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 22 ++ 1 file changed, 2 insertions(

[PATCH v2 23/26] staging: comedi: ni_mio_common: remove DEBUG_STATUS_B messages

Defining DEBUG_STATUS_B enables dumping of a status register during the interrupt. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 29 -

[PATCH v2 20/26] staging: comedi: dmm32at: remove some unnecessary printk(KERN_DEBUG ...

These debug messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/stag

[PATCH v2 06/26] staging: comedi: mite: remove MDPRINTK macro

This macro is used by the comedi drivers that usee the mite module to output development function trace messages. These are just added noise. Remove the messages as well as the macro. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/dri

[PATCH v2 00/26] cleanup debugging support

Currently the COMEDI_DEBUG option enables the comedi_debug module parameter as well as a DPRINTK() macro. To actually get debug messages to display the kernel still needs to be built with the -DDEBUG flag. Cleanup all the custom uses of DEBUG in comedi and use the COMEDI_DEBUG option to enable th

[PATCH v2 10/26] staging: comedi: ni_at_a2150: remove A2150_DEBUG

The A2150_DEBUG define enables some development messages, specifically the ni_dum_regs() function. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 25 ---

[PATCH v2 21/26] staging: comedi: ni_mio_common: remove unused NI_CS5529_DEBUG code

The code blocked by #ifdef NI_CS5529_DEBUG is not used by the driver. Just remove it. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 30 -- 1 file changed, 30 deletions(-) diff --git

[PATCH v2 17/26] staging: comedi: c6xdigio: remove unnecessary c6xdigio_pwmo_insn_read()

The pwm subdevice in this driver sets the subdev_flags to SDF_WRITEABLE so the s->insn_read callback is not needed. Since this callback simply outputs a printk(KERN_DEBUG ... message jsut remove it. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/sta

[PATCH v2 15/26] staging: comedi: dyna_pci10xx: convert a KERN_DEBUG message to dev_dbg()

Convert a printk(KERN_DEBUG ... message to dev_dbg(). Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/dyna_pci1

[PATCH v2 11/26] staging: comedi: cb_pcimdas: remove CBPCIMDAS_DEBUG

This define is not used in the driver. Remove it. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcimdas.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b/drivers/staging

[PATCH v2 19/26] staging: comedi: pcl818: remove an unnecessary printk(KERN_DEBUG ...

This debug message is just added noise. Remove it. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/

[PATCH v2 09/26] staging: comedi: gsc_hpdi: remove DEBUG_PRINT

The DEBUG_PRINT macro in this driver is used to output development debug tracing messages. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 78 --

[PATCH v2 01/26] staging: comedi: comedi_fops: remove use of DPRINTK

Use dev_dbg(), or pr_debug() when dev is not valid, instead of the DPRINTK macro to output the comedi debugging information. Remove the debug messages for allocation failures. The failure will have already generated a message. Reword the messages that include the dev->minor number. This number wi

  1   2   >