Remove unnecessary variable ioctl from do_cmd().
As a consequence, this patch removes an assignment to ioctl in an if condition,
reported by checkpatch.pl.
Signed-off-by: Rupert Muchembled
---
drivers/staging/silicom/bypasslib/bypass.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Remove unnecessary variable ioctl from get_bypass_info().
As a consequence, this patch removes an assignment to ioctl in an if condition,
reported by checkpatch.pl.
Signed-off-by: Rupert Muchembled
---
drivers/staging/silicom/bypasslib/bypass.c | 8
1 file changed, 4 insertions(+), 4 d
On 07/11/13 15:25, Aaron Sierra wrote:
>> From: "Martyn Welch"
>>> This patch removes the bus parameter since its primary function in
>>> practice is to prevent the driver from registering itself with the VME
>>> subsystem entirely unless some (any) value is passed via the parameter.
>>>
>>> The b
On 11/06/2013 12:55 AM, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
Applied, thanks.
--
Jens Axboe
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linux
On 11/06/2013 12:56 AM, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
Applied, thanks.
--
Jens Axboe
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linux
> From: "Martyn Welch"
> > This patch removes the bus parameter since its primary function in
> > practice is to prevent the driver from registering itself with the VME
> > subsystem entirely unless some (any) value is passed via the parameter.
> >
> > The bus module parameter seems to be provide
On 05/11/13 20:58, Aaron Sierra wrote:
> - Original Message -
>> From: "Martyn Welch"
>> Subject: Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges
>>
>> On 05/11/13 17:53, Aaron Sierra wrote:
>>> Martyn,
>>> Can you please elaborate on why you feel it is not a fix? For in
On Wed, Nov 06, 2013 at 09:22:36AM +0800, Gu Zheng wrote:
> Hi Dan,
> On 11/05/2013 07:02 PM, Dan Carpenter wrote:
>
> > On Tue, Nov 05, 2013 at 06:01:00PM +0800, Gu Zheng wrote:
> >> The lock sequence of dcon_blank_fb(fb_info->lock ---> console_lock) is
> >> against
> >> with the one of console_
We assume nvec->rx can be NULL earlier so I have added a check here as
well.
Signed-off-by: Dan Carpenter
---
v2: print 0 instead of -1.
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 3066ee2..c64e069 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nv
On Thu, Nov 07, 2013 at 12:10:14PM +0100, Julian Andres Klode wrote:
> (Replying to all now)
>
> On Thu, Nov 7, 2013 at 8:54 AM, Dan Carpenter
> wrote:
> > We assume nvec->rx can be NULL earlier so I have added a check here as
> > well.
> >
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a/
(Replying to all now)
On Thu, Nov 7, 2013 at 8:54 AM, Dan Carpenter wrote:
> We assume nvec->rx can be NULL earlier so I have added a check here as
> well.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 3066ee2..c64e069 100644
On 2013-11-07 08:13, Dan Carpenter wrote:
These conditions are never true because they use bitwise AND instead of
logical ands.
Fixes: b3ff824a81e8 ('staging: comedi: drivers: use comedi_dio_update_state()
for complex cases')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/comedi/dr
On 31/10/13 23:47, Aaron Sierra wrote:
> This patch removes the bus parameter since its primary function in
> practice is to prevent the driver from registering itself with the VME
> subsystem entirely unless some (any) value is passed via the parameter.
>
> The bus module parameter seems to be pr
On Thu, 2013-11-07 at 10:55 +0300, Dan Carpenter wrote:
> We fixed this to use free_netdev() instead of kfree() but unfortunately
> free_netdev() doesn't accept NULL pointers. Smatch complains about
> this, it's not something I discovered through testing.
Wouldn't a better approach be to change f
These conditions are never true because they use bitwise AND instead of
logical ands.
Fixes: b3ff824a81e8 ('staging: comedi: drivers: use comedi_dio_update_state()
for complex cases')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/comedi/drivers/pcl730.c
b/drivers/staging/comedi/dri
From: Duan Jiong
Date: Wed, 6 Nov 2013 15:57:17 +0800
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
>
> Signed-off-by: Duan Jiong
Applied.
___
devel mailing list
de...@linuxdriverproject.org
h
From: Duan Jiong
Date: Wed, 6 Nov 2013 15:58:13 +0800
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
>
> Signed-off-by: Duan Jiong
Applied.
___
devel mailing list
de...@linuxdriverproject.org
h
17 matches
Mail list logo
