Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-04 Thread Laurent Pinchart
Hi Hans, On Monday 04 November 2013 09:34:49 Hans Verkuil wrote: > On 11/04/2013 12:28 AM, Laurent Pinchart wrote: > > On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote: > >> On 10/03/2013 01:55 AM, Laurent Pinchart wrote: > >>> From: Sergio Aguirre > >>> > >>> This adds a very simplistic

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-04 Thread Fabio Estevam
On Mon, Nov 4, 2013 at 9:20 PM, Matt Sealey wrote: > Fabio, Shawn, could you go so far as to bring this up with the i.MX > guys responsible for documentation or find the original transmitter IP > specs, or find the two pages missing from the manual? This is a really The multiple writes comes fro

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-11-04 Thread Matt Sealey
On Thu, Oct 31, 2013 at 4:48 PM, Matt Sealey wrote: > On Thu, Oct 31, 2013 at 4:08 PM, Fabio Estevam wrote: >> On Thu, Oct 31, 2013 at 7:00 PM, Russell King - ARM Linux >> wrote: >> Interesting. With the monitor I have tested I am not able to see this magenta line. >>> >>> Monitor or T

Re: [patch] Staging: sb105x: info leak in mp_get_count()

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 12:08:50PM -0500, Steven Rostedt wrote: > On Mon, 4 Nov 2013 02:11:50 +0300 > Dan Carpenter wrote: > > > On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > > > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > > > > The icount.reserved[] array

Re: [patch] Staging: sb105x: info leak in mp_get_count()

2013-11-04 Thread Steven Rostedt
On Mon, 4 Nov 2013 02:11:50 +0300 Dan Carpenter wrote: > On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > > > The icount.reserved[] array isn't initialized so it leaks stack > > > information to userspace. > > > >

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 01:32:20PM +0100, Ondrej Zary wrote: > > Shouldn't this be removed from the code, converted to a binary file and > loaded > by the kernel firmware loader instead? I have no idea. We may as well apply this and do that later unless someone wants to jump on it before 3.13-

[PATCH] Staging: dgnc: dgnc_cls.c: fixed a brace coding style issue

2013-11-04 Thread Simon Crequer
Fixed a coding style issue. Signed-off-by: Simon Crequer --- drivers/staging/dgnc/dgnc_cls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 117e158..357d000 100644 --- a/drivers/staging/dgnc/dgnc_cls

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Ondrej Zary
On Monday 04 November 2013, Aldo Iljazi wrote: > Fixed the following styling issues: > > Line 30: > Removed space before open square bracket '[' > > Lines 31 to 155: > Moved the commas that were in the start of the lines, to the end of the > lines. Inserted spaces after the commas. > Inserted a one

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 02:15:22PM +0200, Aldo Iljazi wrote: > > Fixed the following styling issues: > > > > Line 30: > > Removed space before open square bracket '[' > > > > Lines 31 to 155: > > Moved the commas that were in the start of the lines, to the end of the > >

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 02:15:22PM +0200, Aldo Iljazi wrote: > Fixed the following styling issues: > > Line 30: > Removed space before open square bracket '[' > > Lines 31 to 155: > Moved the commas that were in the start of the lines, to the end of the lines. > Inserted spaces after the commas.

[PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Fixed the following styling issues: Line 30: Removed space before open square bracket '[' Lines 31 to 155: Moved the commas that were in the start of the lines, to the end of the lines. Inserted spaces after the commas. Inserted a one tab indentation to each line. Signed-off-by: Aldo Iljazi ---

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 10:40:36AM +0200, Aldo Iljazi wrote: > Dan Carpenter wrote: > > > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > > Dan Carpenter wrote: > > > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > > > Fixed a few styling issues, spec

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 10:40:36AM +0200, Aldo Iljazi wrote: > > Dan Carpenter wrote: > > > > > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > > > Dan Carpenter wrote: > > > > > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > >

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > Dan Carpenter wrote: > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > > Fixed a few styling issues, specifically: > > > > > > > > > > Gar... No one wants to read that changelog

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-04 Thread Hans Verkuil
On 11/04/2013 12:28 AM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the review. > > On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote: >> On 10/03/2013 01:55 AM, Laurent Pinchart wrote: >>> From: Sergio Aguirre >>> >>> This adds a very simplistic driver to utilize the CSI2A interf

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > Dan Carpenter wrote: > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > Fixed a few styling issues, specifically: > > > > > > > Gar... No one wants to read that changelog. That was over 700 lines > > of repea

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > Fixed a few styling issues, specifically: > > > > Gar... No one wants to read that changelog. That was over 700 lines > of repeated text. > > regards, > dan carpenter > > > You are right. I'll be care

Re: [patch] Staging: sb105x: info leak in mp_get_count()

2013-11-04 Thread Josh Triplett
On Mon, Nov 04, 2013 at 10:01:00AM +0300, Dan Carpenter wrote: > I've dropped most of the people from the CC list. > > On Sun, Nov 03, 2013 at 08:31:50PM -0800, Josh Triplett wrote: > > On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote: > > > On Sun, Nov 03, 2013 at 10:28:02AM -0800, J