Re: [PATCH] arc: include: asm: define empty SERIAL_PORT_DFNS in serial.h

2013-10-30 Thread Vineet Gupta
On 10/31/2013 07:15 AM, Chen Gang wrote: > For some architectures (e.g. arc, openrisc), BASE_BAUD isn't constant > And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use > SERIAL_PORT_DFNS to initialize static variables, statically. > > So need define SERIAL_PORT_DFNS as empty to tell

Re: [PATCH] drivers: staging: speakup: serialio: delay initializing 'old_serial_port.baud_base'

2013-10-30 Thread Vineet Gupta
On 10/31/2013 06:57 AM, Chen Gang wrote: > On 10/26/2013 09:18 PM, Chen Gang wrote: >> On 10/25/2013 01:29 PM, Greg KH wrote: >>> No, just use the platform-specific SERIAL_PORT_DNFS, instead of having a >>> copy of it here in this driver, which is just wrong. So please remove >>> this, and just re

[PATCH] staging: android: Fix typo in android/sync.h

2013-10-30 Thread Masanari Iida
Correct spelling typo in android/sync.h Signed-off-by: Masanari Iida --- drivers/staging/android/sync.h | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h index 38ea986..

[PATCH] arc: include: asm: define empty SERIAL_PORT_DFNS in serial.h

2013-10-30 Thread Chen Gang
For some architectures (e.g. arc, openrisc), BASE_BAUD isn't constant And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use SERIAL_PORT_DFNS to initialize static variables, statically. So need define SERIAL_PORT_DFNS as empty to tell drivers they don't support SERIAL_PORT_DFNS (most

Re: [PATCH] drivers: staging: speakup: serialio: delay initializing 'old_serial_port.baud_base'

2013-10-30 Thread Chen Gang
On 10/26/2013 09:18 PM, Chen Gang wrote: > On 10/25/2013 01:29 PM, Greg KH wrote: >> No, just use the platform-specific SERIAL_PORT_DNFS, instead of having a >> copy of it here in this driver, which is just wrong. So please remove >> this, and just rely on the system version of this, defining it t

Re: [PATCH v2 0/8] staging: bcm: Clean up user defined data types

2013-10-30 Thread Kevin McKinney
On Wed, Oct 30, 2013 at 09:40:10AM -0700, Greg KH wrote: > Lisa and Kevin, you both keep stomping on each others patches, making my > merges a pain :( Sorry about this. I will make sure this does not happen again. > My tree is now closed for 3.13 stuff like this, so I recommend doing > something

Re: [PATCH v2 0/8] staging: bcm: Clean up user defined data types

2013-10-30 Thread Kevin McKinney
On Wed, Oct 30, 2013 at 02:46:27AM -0700, Lisa Nguyen wrote: > On Wed, Oct 30, 2013 at 1:55 AM, Dan Carpenter > wrote: > > You and Kevin are treading on each other's patches. CC each other for > > bcm work. > > > > regards, > > dan carpenter > > > > Ah, I wasn't aware of this. Huge part of the

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-30 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: > + /*Wait for PHY PLL lock */ > + msec = 4; > + val = hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_TX_PHY_LOCK; > + while (!val) { > + udelay(1000); > + if (msec-- == 0) { > +

Re: [PATCH 29/51] DMA-API: ata: pata_octeon_cf: convert to use dma_coerce_mask_and_coherent()

2013-10-30 Thread Geert Uytterhoeven
On Thu, Sep 19, 2013 at 11:54 PM, Russell King wrote: > diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c > index c51bbb9..6231d43 100644 > --- a/drivers/ata/pata_octeon_cf.c > +++ b/drivers/ata/pata_octeon_cf.c > @@ -1014,8 +1014,9 @@ static int octeon_cf_probe(struct platf

USB, TTY, char/misc, and Staging trees now closed for 3.13

2013-10-30 Thread Greg KH
Hi all, Given that 3.12 will be out in a few days, it's time to close my trees for new patches until 3.13-rc1 is out. The merge window for 3.13-rc1 is going to be a bit longer than normal as Linus has pointed out, due to travel and conferences. I'll also be traveling for 2 weeks, so my response

Re: [PATCH v2 0/8] staging: bcm: Clean up user defined data types

2013-10-30 Thread Greg KH
Lisa and Kevin, you both keep stomping on each others patches, making my merges a pain :( My tree is now closed for 3.13 stuff like this, so I recommend doing something else for a few weeks until 3.13-rc1 is out, as I can't take any more patches for this type of cleanups until that is released by

Re: [PATCH 01/12 V3] Staging: bcm: Fix WARNING: space prohibited before semicolon.

2013-10-30 Thread Greg KH
On Tue, Oct 29, 2013 at 10:16:49PM -0400, Kevin McKinney wrote: > This patch removes a space before semicolon as > specified by checkpatch.pl. > > Signed-off-by: Kevin McKinney > --- > drivers/staging/bcm/Adapter.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

Re: [PATCH v2 0/8] staging: bcm: Clean up user defined data types

2013-10-30 Thread Dan Carpenter
On Wed, Oct 30, 2013 at 02:46:27AM -0700, Lisa Nguyen wrote: > On Wed, Oct 30, 2013 at 1:55 AM, Dan Carpenter > wrote: > > You and Kevin are treading on each other's patches. CC each other for > > bcm work. > > > > regards, > > dan carpenter > > > > Ah, I wasn't aware of this. Huge part of the

Re: [PATCH v2 6/8] staging: bcm: Replace TRUE with true

2013-10-30 Thread Lisa Nguyen
On Wed, Oct 30, 2013 at 2:56 AM, Dan Carpenter wrote: > On Wed, Oct 30, 2013 at 02:51:45AM -0700, Lisa Nguyen wrote: >> On Wed, Oct 30, 2013 at 2:01 AM, Dan Carpenter >> wrote: >> > On Tue, Oct 29, 2013 at 10:06:34PM -0700, Lisa Nguyen wrote: >> >> --- a/drivers/staging/bcm/Bcmchar.c >> >> +++ b

Re: [PATCH v2 6/8] staging: bcm: Replace TRUE with true

2013-10-30 Thread Dan Carpenter
On Wed, Oct 30, 2013 at 02:51:45AM -0700, Lisa Nguyen wrote: > On Wed, Oct 30, 2013 at 2:01 AM, Dan Carpenter > wrote: > > On Tue, Oct 29, 2013 at 10:06:34PM -0700, Lisa Nguyen wrote: > >> --- a/drivers/staging/bcm/Bcmchar.c > >> +++ b/drivers/staging/bcm/Bcmchar.c > >> @@ -287,9 +287,9 @@ static

Re: [PATCH 1/2] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c

2013-10-30 Thread Dan Carpenter
On Mon, Oct 28, 2013 at 01:19:29PM -0700, Lisa Nguyen wrote: > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c > @@ -346,7 +346,10 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline > *pipe) > } > mutex_unlock(&mdev->g

Re: [PATCH v2 6/8] staging: bcm: Replace TRUE with true

2013-10-30 Thread Lisa Nguyen
On Wed, Oct 30, 2013 at 2:01 AM, Dan Carpenter wrote: > On Tue, Oct 29, 2013 at 10:06:34PM -0700, Lisa Nguyen wrote: >> --- a/drivers/staging/bcm/Bcmchar.c >> +++ b/drivers/staging/bcm/Bcmchar.c >> @@ -287,9 +287,9 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, >> ULONG arg) >>

Re: [PATCH v2 0/8] staging: bcm: Clean up user defined data types

2013-10-30 Thread Lisa Nguyen
On Wed, Oct 30, 2013 at 1:55 AM, Dan Carpenter wrote: > You and Kevin are treading on each other's patches. CC each other for > bcm work. > > regards, > dan carpenter > Ah, I wasn't aware of this. Huge part of the problem would probably be is that I'm not currently subscribed to the devel@driver

Re: [PATCH 1/1] staging: check return value of dev_alloc_skb() against NULL

2013-10-30 Thread Dan Carpenter
On Mon, Oct 28, 2013 at 01:08:19PM +0800, RUC_SoftSec wrote: > Function dev_alloc_skb() may return a NULL pointer if there is no enough > memory, it should be checked against NULL before used. > This bug is found by a static analysis tool developed by RUC_SoftSec, > supported by China.X.Orion. >

Re: [PATCH 1/1] staging: Add NULL checks to return value of skb_clone() and dev_alloc_skb()

2013-10-30 Thread Dan Carpenter
On Mon, Oct 28, 2013 at 12:37:26PM +0800, RUC_SoftSec wrote: > Function skb_clone() and dev_alloc_skb() may return NULL pointers if there is > no enough memroy, their return values should be checked against NULL before > used. > This bug is found by a static tool developed by RUC_SoftSec, support

Re: [PATCH v2 6/8] staging: bcm: Replace TRUE with true

2013-10-30 Thread Dan Carpenter
On Tue, Oct 29, 2013 at 10:06:34PM -0700, Lisa Nguyen wrote: > --- a/drivers/staging/bcm/Bcmchar.c > +++ b/drivers/staging/bcm/Bcmchar.c > @@ -287,9 +287,9 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, > ULONG arg) > struct bcm_rdm_buffer sRdmBuffer = {0}; >

Re: [PATCH v2 0/8] staging: bcm: Clean up user defined data types

2013-10-30 Thread Dan Carpenter
You and Kevin are treading on each other's patches. CC each other for bcm work. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] memstick: fix unreachable state in h_msb_read_page() in ms_block.c

2013-10-30 Thread rogerable
From: Roger Tseng In h_msb_read_page() in ms_block.c, flow never reaches case MSB_RP_RECIVE_STATUS_REG. This causes error when MEMSTICK_INT_ERR is encountered and status error bits are going to be examined, but the status will never be copied back. Fix it by transiting to MSB_RP_RECIVE_STATUS_RE