[PATCH] drivers: staging: bcm: removed a developer debug message per the TODO list.

2013-10-20 Thread Chuong Ngo
Removed a debug message as outlined in the TODO list. --- drivers/staging/bcm/Bcmchar.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index f91bc1f..526594b 100644 --- a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm/

[PATCH] staging: lustre: Remove typedef and update cfs_hash_bucket struct

2013-10-20 Thread Lisa Nguyen
Remove typedef keyword and rename the cfs_hash_bucket_t struct to cfs_hash_bucket in libcfs_hash.h. These changes resolve the "Do not add new typedefs" warning generated by checkpatch.pl and meet kernel coding style. The struct variables in hash.c are updated to reflect this change as well. Signe

[PATCH -next] staging: sep: add missing misc_deregister() on error in sep_register_driver_with_fs()

2013-10-20 Thread Wei Yongjun
From: Wei Yongjun Add the missing misc_deregister() before return from sep_register_driver_with_fs() in the error handling case. Signed-off-by: Wei Yongjun --- drivers/staging/sep/sep_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/se

[PATCH] staging: lustre: Remove typedef and update cfs_hash_lock union

2013-10-20 Thread Lisa Nguyen
Remove typedef keyword and rename the cfs_hash_lock_t union to cfs_hash_lock in libcfs_hash.h. These changes resolve the "Do not add new typedefs" warning generated by checkpatch.pl and meet kernel coding style. The union variables in hash.c are updated to reflect this change as well. Signed-off-

Re: [OPW kernel] Re: [PATCH v2] Staging: zram: Fix variable dereferenced before check

2013-10-20 Thread Greg KH
On Sun, Oct 20, 2013 at 01:33:39PM +0100, Josh Triplett wrote: > On Sat, Oct 19, 2013 at 01:59:05PM -0700, Greg KH wrote: > > On Sat, Oct 19, 2013 at 10:01:42PM +0530, Rashika Kheria wrote: > > > This patch fixes the following Smatch warning in zram_drv.c- > > > ~/git/kernels/linux/drivers/staging/

Re: [PATCH] staging: lustre: libcfs: Remove bitmap.h file

2013-10-20 Thread Greg KH
On Mon, Oct 21, 2013 at 06:18:04AM +0300, Dan Carpenter wrote: > On Sun, Oct 20, 2013 at 09:06:18AM -0700, Lisa Nguyen wrote: > > The functions in the bitmap.h header file are not being used by > > any source file in the lustre driver. > > > > Unless there are any objections, please remove the bit

Re: [PATCH 00/22] staging: lustre: Update structs

2013-10-20 Thread Lisa Nguyen
On Sun, Oct 20, 2013 at 8:07 PM, Peng, Tao wrote: > Hi Lisa, > > Thanks for the patch. I assume you were using coccinelle (or sed) to do the > conversion. Are there change done by hand other than scripting? Can you > please also put your scripts (such as in [PATCH 01/22]) in the commit message?

RE: [PATCH 00/22] staging: lustre: Update structs

2013-10-20 Thread Peng, Tao
Hi Lisa, Thanks for the patch. I assume you were using coccinelle (or sed) to do the conversion. Are there change done by hand other than scripting? Can you please also put your scripts (such as in [PATCH 01/22]) in the commit message? Thanks, Tao >-Original Message- >From: Lisa Nguyen

Re: [PATCH 01/22] staging: lustre: Remove all new typedefs in libcfs_hash.h

2013-10-20 Thread Lisa Nguyen
On Sun, Oct 20, 2013 at 8:23 PM, Greg KH wrote: > On Sun, Oct 20, 2013 at 03:45:46PM -0700, Lisa Nguyen wrote: >> Modified all structs in libcfs_hash header file to eliminate >> the "Do not add new typedefs" warning generated by checkpatch.pl >> and meet kernel coding style. >> >> Signed-off-by: L

RE: [PATCH 18/22] staging: lustre: Update struct variables in lprocfs_status.c

2013-10-20 Thread Peng, Tao
>-Original Message- >From: Prakash Prasad [mailto:prakash_pra...@yahoo.com] >Sent: Monday, October 21, 2013 9:59 AM >To: Lisa Nguyen; gre...@linuxfoundation.org >Cc: de...@driverdev.osuosl.org; Peng, Tao; andreas.dil...@intel.com >Subject: Re: [PATCH 18/22] staging: lustre: Update struct va

Re: [PATCH 01/22] staging: lustre: Remove all new typedefs in libcfs_hash.h

2013-10-20 Thread Lisa Nguyen
On Sun, Oct 20, 2013 at 8:22 PM, Dan Carpenter wrote: > On Sun, Oct 20, 2013 at 03:45:46PM -0700, Lisa Nguyen wrote: >> Modified all structs in libcfs_hash header file to eliminate >> the "Do not add new typedefs" warning generated by checkpatch.pl >> and meet kernel coding style. >> > > Can you r

Re: [PATCH 01/22] staging: lustre: Remove all new typedefs in libcfs_hash.h

2013-10-20 Thread Dan Carpenter
On Sun, Oct 20, 2013 at 03:45:46PM -0700, Lisa Nguyen wrote: > Modified all structs in libcfs_hash header file to eliminate > the "Do not add new typedefs" warning generated by checkpatch.pl > and meet kernel coding style. > Can you redo this whole series? The driver needs to be able to recompil

Re: [PATCH 01/22] staging: lustre: Remove all new typedefs in libcfs_hash.h

2013-10-20 Thread Greg KH
On Sun, Oct 20, 2013 at 03:45:46PM -0700, Lisa Nguyen wrote: > Modified all structs in libcfs_hash header file to eliminate > the "Do not add new typedefs" warning generated by checkpatch.pl > and meet kernel coding style. > > Signed-off-by: Lisa Nguyen This patch breaks the build so badly, I kn

Re: [PATCH] staging: lustre: libcfs: Remove bitmap.h file

2013-10-20 Thread Dan Carpenter
On Sun, Oct 20, 2013 at 09:06:18AM -0700, Lisa Nguyen wrote: > The functions in the bitmap.h header file are not being used by > any source file in the lustre driver. > > Unless there are any objections, please remove the bitmap.h > header file as it contains unused code in the kernel. > I'm in

Re: A review of dm-writeboost

2013-10-20 Thread Dave Chinner
On Sat, Oct 19, 2013 at 07:59:55PM +0900, Akira Hayakawa wrote: > Dave, > > # -EIO retuned corrupts XFS > I turned up > lockdep, frame pointer, xfs debug > and also changed to 3.12.0-rc5 from rc1. > > What's changed is that > the problem we discussed in previous mails > *never* reproduce. > > Ho

[PATCH 13/22] staging: lustre: Update struct variables in ldlm_lockd.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in ldlm_lockd.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 18/22] staging: lustre: Update struct variables in lprocfs_status.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in lprocfs_status.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 6 +++--- 1 file changed, 3 insert

[PATCH 08/22] staging: lustre: Update struct variables in hash.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in hash.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/libcfs/hash.c | 270 ++-- 1 file changed, 135 in

[PATCH 22/22] staging: lustre: Update struct variables in connection.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in connection.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/ptlrpc/connection.c | 14 +++--- 1 file changed, 7 inserti

[PATCH 21/22] staging: lustre: Update struct variables in osc_quota.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in osc_quota.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/osc/osc_quota.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 19/22] staging: lustre: Update struct variables in lu_object.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in lu_object.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/obdclass/lu_object.c | 42 +++--- 1 file changed, 2

[PATCH 20/22] staging: lustre: Update struct variables in obd_config.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in obd_config.c to avoid build errors. Signed-off-by: Lisa Nguyen --- .../staging/lustre/lustre/obdclass/obd_config.c| 28 +++--- 1 file changed,

[PATCH 16/22] staging: lustre: Update struct variables in cl_object.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in cl_object.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/obdclass/cl_object.c | 8 1 file changed, 4 insertions(+),

[PATCH 17/22] staging: lustre: Update struct variables in genops.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in genops.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/obdclass/genops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 delet

[PATCH 14/22] staging: lustre: Update struct variables in vvp_dev.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in vvp_dev.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/llite/vvp_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 15/22] staging: lustre: Update struct variables in lov_pool.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in lov_pool.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/lov/lov_pool.c | 8 1 file changed, 4 insertions(+), 4 dele

[PATCH 12/22] staging: lustre: Update struct variables in ldlm_resource.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in ldlm_resource.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 34 +++--- 1 file change

[PATCH 11/22] staging: lustre: Update struct variables in ldlm_request.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in ldlm_request.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 10/22] staging: lustre: Update struct variables in ldlm_lock.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in ldlm_lock.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH 09/22] staging: lustre: Update struct variables in ldlm_flock.c

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in ldlm_flock.c to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 07/22] staging: lustre: Update struct variables in lov_internal.h

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in lov_internal.h to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/lov/lov_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 05/22] staging: lustre: Update struct variables in lustre_net.h

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in lustre_net.h to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/include/lustre_net.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 04/22] staging: lustre: Update struct variables in lustre_export.h

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this will update the struct variables in lustre_export.h to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/include/lustre_export.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 06/22] staging: lustre: Update struct variables in obd.h

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in obd.h to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/include/obd.h | 10 +- 1 file changed, 5 insertions(+), 5 deletio

[PATCH 02/22] staging: lustre: Update struct variables in lu_object.h

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this will update the struct variables in lu_object.h to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/include/lu_object.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH 03/22] staging: lustre: Update struct variables in lustre_dlm.h

2013-10-20 Thread Lisa Nguyen
Assuming the patch to update the structs in libcfs_hash header file has been applied, this patch will update the struct variables in lustre_dlm.h to avoid build errors. Signed-off-by: Lisa Nguyen --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 01/22] staging: lustre: Remove all new typedefs in libcfs_hash.h

2013-10-20 Thread Lisa Nguyen
Modified all structs in libcfs_hash header file to eliminate the "Do not add new typedefs" warning generated by checkpatch.pl and meet kernel coding style. Signed-off-by: Lisa Nguyen --- .../lustre/include/linux/libcfs/libcfs_hash.h | 280 ++--- 1 file changed, 140 insertion

[PATCH 00/22] staging: lustre: Update structs

2013-10-20 Thread Lisa Nguyen
This patchset includes all the changes needed to update the structs defined in libcfs_hash.h. Doing this will eliminate the "Do not add new typedefs" warning generated by checkpatch.pl and the updated format of those structs will meet kernel coding style. Other header files and certain source fi

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
On Sun, Oct 20, 2013 at 05:31:56PM +0100, Russell King - ARM Linux wrote: > On Sun, Oct 20, 2013 at 02:00:57PM +0100, Russell King - ARM Linux wrote: > > As for imx-drm, there was a warning which preceded that oops. Here's the > > full log, below the "-" marker - this is from unbinding the

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
On Sun, Oct 20, 2013 at 02:00:57PM +0100, Russell King - ARM Linux wrote: > As for imx-drm, there was a warning which preceded that oops. Here's the > full log, below the "-" marker - this is from unbinding the imx-drm > module, and then trying to reboot. > > imx-drm is really very broken

[PATCH] staging: lustre: libcfs: Remove bitmap.h file

2013-10-20 Thread Lisa Nguyen
The functions in the bitmap.h header file are not being used by any source file in the lustre driver. Unless there are any objections, please remove the bitmap.h header file as it contains unused code in the kernel. Signed-off-by: Lisa Nguyen --- .../staging/lustre/include/linux/libcfs/bitmap.h

Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-20 Thread Lisa Nguyen
On Sun, Oct 20, 2013 at 12:43 AM, Greg KH wrote: > On Sat, Oct 19, 2013 at 04:15:25PM -0700, Lisa Nguyen wrote: >> On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter >> wrote: >> > Your patch is great, but actually, are any of the functions in this >> > header used? `grep cfs_bitmap drivers/staging

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
On Sun, Oct 20, 2013 at 01:04:34AM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 16, 2013 at 11:31:07AM -0700, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2013 at 07:07:35PM +0100, Russell King - ARM Linux wrote: > > > Sorry, but I don't think imx-drm is driving the hardware correctly, and

Re: [OPW kernel] Re: [PATCH v2] Staging: zram: Fix variable dereferenced before check

2013-10-20 Thread Josh Triplett
On Sat, Oct 19, 2013 at 01:59:05PM -0700, Greg KH wrote: > On Sat, Oct 19, 2013 at 10:01:42PM +0530, Rashika Kheria wrote: > > This patch fixes the following Smatch warning in zram_drv.c- > > ~/git/kernels/linux/drivers/staging/zram/zram_drv.c:663 > > reset_store() warn: variable dereferenced befor

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
Another problem. After performing several modesets, the IPU seems to lock up and produce no syncs or output data. I've seen this many times over the last week while testing out various aspects of imx-drm, and had put it down to problems with the clocking arrangement getting its settings wrong. N

Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-20 Thread Greg KH
On Sat, Oct 19, 2013 at 04:15:25PM -0700, Lisa Nguyen wrote: > On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter > wrote: > > Your patch is great, but actually, are any of the functions in this > > header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows > > this header file. > > > > P